gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #70604 from rhcs-dashboard/service-form-text-label-fix

Browse Source 
mgr/dashboard: fix cd-text-label-list string writeValue

Reviewed-by: Nizamudeen A <nia@redhat.com>
This commit is contained in:
Pedro Gonzalez Gomez 2026-07-29 14:11:46 +02:00 committed by GitHub
commit 0bb0d59a85
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/pybind/mgr/dashboard/frontend/src/app/shared/components/text-label-list/text-label-list.component.spec.ts
View File

@ -41,6 +41,34 @@ describe('TextLabelListComponent', () => {
expect(inputs[0].nativeElement.value).toBe('');
});
it('should treat a string value as a single item', () => {
component.writeValue('openid profile email');
fixture.detectChanges();
const inputs = fixture.debugElement.queryAll(By.css('cds-text-label input'));
expect(inputs.length).toBe(2);
expect(inputs[0].nativeElement.value).toBe('openid profile email');
expect(inputs[1].nativeElement.value).toBe('');
});
it('should not spread a string into individual characters', () => {
component.writeValue('openid');
fixture.detectChanges();
const inputs = fixture.debugElement.queryAll(By.css('cds-text-label input'));
expect(inputs.length).toBe(2);
expect(inputs[0].nativeElement.value).toBe('openid');
});
it('should treat null like an empty list', () => {
component.writeValue(null);
fixture.detectChanges();
const inputs = fixture.debugElement.queryAll(By.css('cds-text-label input'));
expect(inputs.length).toBe(1);
expect(inputs[0].nativeElement.value).toBe('');
});
it('should call onTouch on input changes', () => {
spyOn(component as any, 'onTouched');

10
src/pybind/mgr/dashboard/frontend/src/app/shared/components/text-label-list/text-label-list.component.ts
View File

@ -44,8 +44,14 @@ export class TextLabelListComponent implements ControlValueAccessor {
return originalValue.slice(0, -1) === value;
}
writeValue(value: string[]): void {
this.values = value?.length ? [...value, ''] : [''];
writeValue(value: string[] | string | null): void {
let items: string[] = [];
if (typeof value === 'string') {
items = value ? [value] : [];
} else if (Array.isArray(value)) {
items = [...value];
}
this.values = items.length ? [...items, ''] : [''];
}
registerOnChange(onChange: (value: string[]) => void): void {