gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-01 22:45:39 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

mds/Server: return after responding on error paths

Browse Source 
handle_client_symlink (-ENAMETOOLONG), reclaim_session (-EPERM) and
handle_client_readdir_snapdiff (-EINVAL) each sent an error reply on a
failure path but fell through, replying to the same MDRequest a second
time. reclaim_session additionally went on to bind reclaiming_from,
bypassing the auth_name check. Return right after sending the reply.

Fixes: https://tracker.ceph.com/issues/77862
Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
This commit is contained in:
Sun Yuechi 2026-06-30 19:37:00 +08:00 committed by Kefu Chai
parent cc3f8a69b3
commit 2601725fbf
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mds/Server.cc
View File

@ -501,6 +501,7 @@ void Server::reclaim_session(Session *session, const cref_t<MClientReclaim> &m)
<< " != target auth_name " << target->info.auth_name << dendl;
reply->set_result(-EPERM);
mds->send_message_client(reply, session);
return;
}
ceph_assert(!target->reclaiming_from);
@ -7700,6 +7701,7 @@ void Server::handle_client_symlink(const MDRequestRef& mdr)
if (req->get_alternate_name().size() > alternate_name_max) {
dout(10) << " alternate_name longer than " << alternate_name_max << dendl;
respond_to_request(mdr, -ENAMETOOLONG);
return;
}
dn->set_alternate_name(req->get_alternate_name());
@ -12111,6 +12113,7 @@ void Server::handle_client_readdir_snapdiff(const MDRequestRef& mdr)
mdr->snapid_diff_other == CEPH_NOSNAP) {
dout(10) << "reply to " << *req << " snapdiff -EINVAL" << dendl;
respond_to_request(mdr, -EINVAL);
return;
}
unsigned max = req->head.args.snapdiff.max_entries;