gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

qa/cephfs: increase number of files to cloned in test_clone_stats.py

Browse Source 
There's a race condition between cloning operation and clone progress
reporter thread to open the subvolume, former does so to copy/clone
files and latter to get details of the source and destination subvolume.

A low number of files in the snapshot gives clone progress reporter
thread less or no chance to fetch and process the details needed to
display the progress bar. This causes tests to fails when progress bar
isn't displayed in the output of "ceph status" output.

Increasing the number of files will give clone progress reporter more
time to display the progress bar and therefore these unnecessary test
failures wlll reduce/stop.

This failure wasn't seen earlier because Python code was being used to
copy files which was comparatively slow (compared to C++ code that was
merged to copy files as a part of fscrypt work) which allowed enough
time to clone progress reporter thread to process stats and display
clone progress bar.

Fixes: https://tracker.ceph.com/issues/74082
Signed-off-by: Rishabh Dave <ridave@redhat.com>
This commit is contained in:
Rishabh Dave 2025-12-08 18:07:09 +05:30
parent 2599fc10c5
commit 269e76bb13
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
qa/tasks/cephfs/volumes/test_clone_stats.py
View File

@ -332,7 +332,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
c = 'ss1clone1'
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -369,7 +369,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
c = 'ss1clone1'
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 10, 1024)
size = self._do_subvolume_io(sv, None, None, 100, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -417,7 +417,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
self.run_ceph_cmd(f'fs subvolumegroup create {v} {group}')
self.run_ceph_cmd(f'fs subvolume create {v} {sv} {group} --mode=777')
size = self._do_subvolume_io(sv, group, None, 10, 1024)
size = self._do_subvolume_io(sv, group, None, 100, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss} {group}')
self.wait_till_rbytes_is_right(v, sv, size, group)
@ -469,7 +469,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
self.config_set('mds', 'mds_snap_rstat', 'true')
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 10, 1024)
size = self._do_subvolume_io(sv, None, None, 100, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -513,7 +513,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
c = self._gen_subvol_clone_name(4)
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 10, 1024)
size = self._do_subvolume_io(sv, None, None, 100, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -563,7 +563,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
self.config_set('mgr', 'mgr/volumes/snapshot_clone_no_wait', 'false')
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -614,7 +614,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
self.config_set('mgr', 'mgr/volumes/snapshot_clone_no_wait', 'false')
self.run_ceph_cmd(f'fs subvolume create {v} {sv} --mode=777')
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -673,7 +673,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
sv_path = self.get_ceph_cmd_stdout(f'fs subvolume getpath {v} {sv}')
sv_path = sv_path[1:]
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -716,7 +716,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
sv_path = self.get_ceph_cmd_stdout(f'fs subvolume getpath {v} {sv}')
sv_path = sv_path[1:]
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -763,7 +763,7 @@ class TestCloneProgressReporter(CloneProgressReporterHelper):
sv_path = self.get_ceph_cmd_stdout(f'fs subvolume getpath {v} {sv}')
sv_path = sv_path[1:]
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)
@ -814,7 +814,7 @@ class TestOngoingClonesCounter(CloneProgressReporterHelper):
sv_path = self.get_ceph_cmd_stdout(f'fs subvolume getpath {v} {sv}')
sv_path = sv_path[1:]
size = self._do_subvolume_io(sv, None, None, 3, 1024)
size = self._do_subvolume_io(sv, None, None, 30, 100)
self.run_ceph_cmd(f'fs subvolume snapshot create {v} {sv} {ss}')
self.wait_till_rbytes_is_right(v, sv, size)