gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Revert "crimson/os/alienstore/alien_log: _flush concurrently"

Browse Source 
While submitting the log line asyncronously is reasonable,
with this implementation the EntryVector &q parameter does
not necessarily outlive the submission continuation.

This reverts commit 511af83e27.

Fixes: https://tracker.ceph.com/issues/64140
Signed-off-by: Samuel Just <sjust@redhat.com>
This commit is contained in:
Samuel Just 2024-01-23 21:47:27 +00:00
parent 18149a703b
commit 4d52d1d22b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/crimson/os/alienstore/alien_log.cc
View File

@ -17,7 +17,8 @@ CnLog::~CnLog() {
}
void CnLog::_flush(EntryVector& q, bool crash) {
std::ignore = seastar::alien::submit_to(inst, shard, [&q] {
// XXX: the waiting here will block the thread for an indeterministic peroid
seastar::alien::submit_to(inst, shard, [&q] {
for (auto& it : q) {
crimson::get_logger(it.m_subsys).log(
crimson::to_log_level(it.m_prio),
@ -25,7 +26,7 @@ void CnLog::_flush(EntryVector& q, bool crash) {
it.strv());
}
return seastar::make_ready_future<>();
});
}).wait();
q.clear();
return;
}