gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #70039 from VinayBhaskar-V/wip-group-snap-list

Browse Source 
pybind/rbd: handle non-existent groups properly in list_snaps()

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Ilya Dryomov 2026-07-15 21:37:12 +02:00 committed by GitHub
commit 54cd7760b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/pybind/rbd/rbd.pyx
View File

@ -6143,6 +6143,7 @@ cdef class GroupSnapIterator(object):
if ret >= 0:
break
elif ret != -errno.ERANGE:
self.num_group_snaps = 0
raise make_ex(ret, 'error listing snapshots for group %s' % group.name, group_errno_to_exception)
def __iter__(self):

2
src/test/pybind/test_rbd.py
View File

@ -3078,6 +3078,7 @@ class TestGroups(object):
create_group()
snap_name = get_temp_snap_name()
self.group = Group(ioctx, group_name)
self.dne_group = Group(ioctx, "group_does_not_exist")
def teardown_method(self, method):
remove_group()
@ -3191,6 +3192,7 @@ class TestGroups(object):
def test_group_snap(self):
global snap_name
assert_raises(ObjectNotFound, self.dne_group.list_snaps)
eq([], list(self.group.list_snaps()))
self.group.create_snap(snap_name)
eq([snap_name], [snap['name'] for snap in self.group.list_snaps()])