From 7538d13d373451d8d79ee19fcc24d138d564c44c Mon Sep 17 00:00:00 2001 From: Anurag Raut Date: Mon, 27 Jul 2026 11:56:33 +0530 Subject: [PATCH] mgr/dashboard: show Submit for initial telemetry configuration Display "Submit" instead of "Update" during the initial Telemetry configuration flow. Existing Telemetry configurations continue to display "Update". Fixes: https://tracker.ceph.com/issues/78694 Signed-off-by: Anurag Raut --- .../src/app/ceph/cluster/telemetry/telemetry.component.html | 2 +- .../src/app/ceph/cluster/telemetry/telemetry.component.spec.ts | 1 + .../src/app/ceph/cluster/telemetry/telemetry.component.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.html index 05f239d50a4..14a8ccf7717 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.html @@ -466,7 +466,7 @@ (submitActionEvent)="onSubmit()" (backActionEvent)="back()" [form]="previewForm" - [submitText]="actionLabels.UPDATE" + [submitText]="moduleEnabled ? actionLabels.UPDATE : actionLabels.SUBMIT" [cancelText]="actionLabels.BACK" > diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.spec.ts index bb3b8afd47e..2251057b220 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.spec.ts @@ -139,6 +139,7 @@ describe('TelemetryComponent', () => { req.flush({}); expect(router.navigate).toHaveBeenCalledWith(['']); }); + }); describe('previewForm', () => { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts index 2aa50ee920d..37dc8f54dc2 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts @@ -296,7 +296,7 @@ export class TelemetryComponent extends CdForm implements OnInit { $localize`An Error occurred while updating the Telemetry module configuration.\ Please Try again` ); - // Reset the 'Update' button. + // Reset the submit button. this.previewForm.setErrors({ cdSubmitButton: true }); }, () => {