gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

crimson/cmake: restrict -Wno-non-virtual-dtor to C++ sources

Browse Source 
The seastar target exports -Wno-non-virtual-dtor as a PUBLIC compile
option, so it leaks to every target that links seastar, including C
sources such as crimson-common's reverse.c, producing:

  cc1: warning: command-line option '-Wno-non-virtual-dtor' is valid for C++/ObjC++ but not for C

Guard the option with $<COMPILE_LANGUAGE:CXX> so that it only applies to
C++ compilations.

Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
This commit is contained in:
Sun Yuechi 2026-06-16 04:10:15 +08:00
parent 2286265c0a
commit 82ab9cc2e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/CMakeLists.txt
View File

@ -502,7 +502,7 @@ if(WITH_CRIMSON)
target_compile_options(seastar
PUBLIC
# required by any target that links to seastar
"-Wno-non-virtual-dtor"
"$<$<COMPILE_LANGUAGE:CXX>:-Wno-non-virtual-dtor>"
PRIVATE
"-DSEASTAR_NO_EXCEPTION_HACK"
"-Wno-error"