diff --git a/CMakeLists.txt b/CMakeLists.txt index e50c6ab0b89..40c8b634258 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -39,7 +39,15 @@ if(WIN32) # the targeted Windows version. The availability of certain functions and # structures will depend on it. set(WIN32_WINNT "0x0A00" CACHE STRING "Targeted Windows version.") - add_definitions(-D_WIN32_WINNT=${WIN32_WINNT}) + # In order to avoid known winpthread issues, we're using the boost + # shared mutex implementation. + # https://github.com/msys2/MINGW-packages/issues/3319 + add_definitions( + -D_WIN32_WINNT=${WIN32_WINNT} + -DBOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN + -DBOOST_THREAD_V2_SHARED_MUTEX + ) + set(Boost_THREADAPI "win32") endif() if(MINGW) diff --git a/src/common/ceph_mutex.h b/src/common/ceph_mutex.h index 4029a5a9f15..81777c7dbe2 100644 --- a/src/common/ceph_mutex.h +++ b/src/common/ceph_mutex.h @@ -69,6 +69,9 @@ namespace ceph { // ============================================================================ // debug (lockdep-capable, various sanity checks and asserts) // ============================================================================ +// +// Note: this is known to cause deadlocks on Windows because +// of the winpthreads shared mutex implementation. #include "common/condition_variable_debug.h" #include "common/mutex_debug.h" @@ -115,27 +118,39 @@ namespace ceph { #include #include -#include +// The winpthreads shared mutex implementation is broken. +// We'll use boost::shared_mutex instead. +// https://github.com/msys2/MINGW-packages/issues/3319 +#if __MINGW32__ +#include +#else +#include +#endif namespace ceph { typedef std::mutex mutex; typedef std::recursive_mutex recursive_mutex; typedef std::condition_variable condition_variable; + +#if __MINGW32__ + typedef boost::shared_mutex shared_mutex; +#else typedef std::shared_mutex shared_mutex; +#endif // discard arguments to make_mutex (they are for debugging only) template - std::mutex make_mutex(Args&& ...args) { + mutex make_mutex(Args&& ...args) { return {}; } template - std::recursive_mutex make_recursive_mutex(Args&& ...args) { + recursive_mutex make_recursive_mutex(Args&& ...args) { return {}; } template - std::shared_mutex make_shared_mutex(Args&& ...args) { + shared_mutex make_shared_mutex(Args&& ...args) { return {}; } diff --git a/win32_deps_build.sh b/win32_deps_build.sh index 87e5ab00fab..3fe8b656442 100755 --- a/win32_deps_build.sh +++ b/win32_deps_build.sh @@ -201,7 +201,7 @@ EOL ./b2 install --user-config=user-config.jam toolset=gcc-mingw32 \ target-os=windows release \ link=static,shared \ - threadapi=pthread --prefix=$boostDir \ + threadapi=win32 --prefix=$boostDir \ address-model=64 architecture=x86 \ binary-format=pe abi=ms -j $NUM_WORKERS \ -sZLIB_INCLUDE=$zlibDir/include -sZLIB_LIBRARY_PATH=$zlibDir/lib \