gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

test: Remove invalid unit test

Browse Source 
This test was talking about testing invalid ops, however with the inclusion of sync reads in EC (https://github.com/ceph/ceph/pull/67079), it is valid to perform class reads in EC. In addition, work was done around illegal ops here: https://github.com/ceph/ceph/pull/66258 and the existance of TEST(ClsHello, BadMethods) in test_cls_hello.cc covers illegal ops in that PR leading me to think this is unneccisairy. Because of these reasons, I think its better this test is removed as it is incorrect and also not working.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
This commit is contained in:
Jon Bailey 2026-06-04 11:27:07 +01:00
parent 44f1f41750
commit b05cfd1612
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/test/librados/split_op_cxx.cc
View File

@ -322,25 +322,6 @@ TEST_P(LibRadosSplitOpECPP, ReadSecondShardWithVersion) {
ASSERT_TRUE(AssertOperateWithSplitOp(0, 2, "foo", &read, &bl, balanced_read_flags));
}
TEST_P(LibRadosSplitOpECPP, ReadWithIllegalClsOp) {
SKIP_IF_CRIMSON();
bufferlist bl;
bl.append("ceph");
ObjectWriteOperation write1;
write1.write(0, bl);
ASSERT_TRUE(AssertOperateWithoutSplitOp(0, "foo", &write1));
bufferlist new_bl;
new_bl.append("CEPH");
ObjectWriteOperation write2;
bufferlist exec_inbl, exec_outbl;
int exec_rval;
rados::cls::fifo::op::init_part op;
encode(op, exec_inbl);
write2.exec(fifo::method::init_part, exec_inbl, &exec_outbl, &exec_rval);
ASSERT_TRUE(AssertOperateWithoutSplitOp(-EOPNOTSUPP, "foo", &write2));
}
TEST_P(LibRadosSplitOpECPP, XattrReads) {
SKIP_IF_CRIMSON();
bufferlist bl, attr_bl, attr_read_bl;