gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

crimson/osd: mark ThrottleReleaser [[nodiscard]]

Browse Source 
OperationThrottler::get_throttle() returns a ThrottleReleaser guard whose
destructor calls release_throttle(), the mClock RequestCompletion that
decrements in_progress.  The guard has to be held for the whole operation: a
caller that discards it at acquisition releases the slot in the same step, so
the operation never counts against max_in_progress and the throttle does
nothing.

Mark the type [[nodiscard]] so the compiler flags a discarded co_await of
get_throttle().

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
This commit is contained in:
Kefu Chai 2026-06-24 18:10:41 +08:00
parent a38b620ccd
commit d3df37a61b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/crimson/osd/osd_operation.h
View File

@ -376,7 +376,11 @@ public:
return !max_in_progress || in_progress < max_in_progress;
}
class ThrottleReleaser {
// The returned guard's destructor is the mClock RequestCompletion
// (release_throttle), so it must be held for the throttled operation's whole
// lifetime. Dropping it at acquisition frees the slot immediately and the
// operation never counts against max_in_progress.
class [[nodiscard("discarding the guard releases the throttle slot immediately")]] ThrottleReleaser {
OperationThrottler *parent = nullptr;
public:
ThrottleReleaser(OperationThrottler *parent) : parent(parent) {}