gian/ceph-mirror
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2026-08-02 07:03:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

common: Log when we leak and disallow inlining

Browse Source 
eaa2013 added a generic suppression that exposed the fact that the newer
compiler was inlining CephContext::do_command(). In order to avoid such
scenario in the future, and to keeo the behaviour constant between
daemons we'll disallow inlining.

Fixes: https://tracker.ceph.com/issues/76473

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
This commit is contained in:
Brad Hubbard 2026-05-29 13:59:41 +10:00
parent 44fa2a5d85
commit d6f1bcc890
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/ceph_context.cc
View File

@ -499,7 +499,7 @@ bool CephContext::check_experimental_feature_enabled(const std::string& feat,
return enabled;
}
int CephContext::do_command(std::string_view command, const cmdmap_t& cmdmap,
[[gnu::noinline]] int CephContext::do_command(std::string_view command, const cmdmap_t& cmdmap,
Formatter *f,
std::ostream& ss,
bufferlist *out)
@ -514,7 +514,8 @@ int CephContext::do_command(std::string_view command, const cmdmap_t& cmdmap,
#pragma GCC push_options
#pragma GCC optimize ("O0")
static void leak_some_memory() {
static void leak_some_memory(CephContext* cc) {
lgeneric_derr(cc) << "Leaking some memory" << dendl;
volatile char *foo = new char[1234];
(void)foo;
}
@ -538,7 +539,7 @@ int CephContext::_do_command(
}
}
if (command == "leak_some_memory") {
leak_some_memory();
leak_some_memory(this);
}
else if (command == "perfcounters_dump" || command == "1" ||
command == "perf dump") {