From d8054bd8b674b80cdd93a56d091fbafc8792f367 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Thu, 30 Jul 2026 11:02:11 -0400 Subject: [PATCH 1/2] tentacle: remove github workflows These workflows (with pull_request) are confusing the CI checks for release branches. Remove all of them and let `main` be the sole definition. Signed-off-by: Patrick Donnelly --- .github/workflows/check-license.yml | 14 ----- .../workflows/create-backport-trackers.yml | 54 ----------------- .github/workflows/needs-rebase.yml | 18 ------ .github/workflows/pr-check-deps.yml | 10 ---- .github/workflows/pr-checklist.yml | 19 ------ .github/workflows/pr-triage.yml | 28 --------- .github/workflows/qa-symlink.yml | 17 ------ .github/workflows/retrigger-rtd.yml | 25 -------- .github/workflows/stale.yml | 58 ------------------- 9 files changed, 243 deletions(-) delete mode 100644 .github/workflows/check-license.yml delete mode 100644 .github/workflows/create-backport-trackers.yml delete mode 100644 .github/workflows/needs-rebase.yml delete mode 100644 .github/workflows/pr-check-deps.yml delete mode 100644 .github/workflows/pr-checklist.yml delete mode 100644 .github/workflows/pr-triage.yml delete mode 100644 .github/workflows/qa-symlink.yml delete mode 100644 .github/workflows/retrigger-rtd.yml delete mode 100644 .github/workflows/stale.yml diff --git a/.github/workflows/check-license.yml b/.github/workflows/check-license.yml deleted file mode 100644 index 89dcfa292c3..00000000000 --- a/.github/workflows/check-license.yml +++ /dev/null @@ -1,14 +0,0 @@ ---- -name: "Check for Incompatible Licenses" -on: [pull_request] - -jobs: - pull_request: - name: "Check for Incompatible Licenses" - runs-on: ubuntu-latest - steps: - - name: Check Pull Request - uses: JJ/github-pr-contains-action@526dfe784d8604ea1c39b6c26609074de95b1ffd # releases/v14.1 - with: - github-token: ${{github.token}} - diffDoesNotContain: "GNU General Public License" diff --git a/.github/workflows/create-backport-trackers.yml b/.github/workflows/create-backport-trackers.yml deleted file mode 100644 index 4706311c59b..00000000000 --- a/.github/workflows/create-backport-trackers.yml +++ /dev/null @@ -1,54 +0,0 @@ ---- -name: Issue Backporting -on: - # To manually trigger this: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch - # View past runs and output: https://github.com/ceph/ceph/actions/workflows/create-backport-trackers.yml - workflow_dispatch: - inputs: - issues: - description: 'whitespace-separated list of issue numbers' - type: string - default: '' - debug: - description: '--debug: Show debug-level messages' - default: false - type: boolean - resolveParent: - description: '--resolve-parent: Resolve parent issue if all backports resolved/rejected' - default: false - type: boolean - force: - description: > - --force: When issue numbers provided, process them even if not in - 'Pending Backport' status. - Otherwise, process all issues in 'Pending Backport' status even if - already processed (tag 'backport_processed' added)' - default: false - type: boolean - dryRun: - description: '--dry-run: Do not write anything to Redmine' - default: false - type: boolean - schedule: - # Every 5 minutes: https://crontab.guru/every-5-minutes - - cron: '*/5 * * * *' -jobs: - create-backports: - runs-on: ubuntu-latest - if: github.ref == 'refs/heads/main' - steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - with: - sparse-checkout: | - src/script/backport-create-issue - src/script/requirements.backport-create-issue.txt - sparse-checkout-cone-mode: false - - uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 - with: - python-version: '>=3.6 <3.12' - cache: 'pip' - cache-dependency-path: src/script/requirements.backport-create-issue.txt - - run: pip install -r src/script/requirements.backport-create-issue.txt - - run: python3 src/script/backport-create-issue ${{ inputs.debug && '--debug' || '' }} ${{ inputs.resolveParent && '--resolve-parent' || '' }} ${{ inputs.force && '--force' || '' }} ${{ inputs.dryRun && '--dry-run' || '' }} ${{ inputs.issues }} - env: - REDMINE_API_KEY: ${{ secrets.REDMINE_API_KEY_BACKPORT_BOT }} diff --git a/.github/workflows/needs-rebase.yml b/.github/workflows/needs-rebase.yml deleted file mode 100644 index d9e2c706fad..00000000000 --- a/.github/workflows/needs-rebase.yml +++ /dev/null @@ -1,18 +0,0 @@ ---- -name: "Pull Request Needs Rebase?" -on: - pull_request_target: - types: [opened, synchronize, reopened] -jobs: - needs-rebase: - runs-on: ubuntu-latest - steps: - # eps1lon/actions-label-merge-conflict@v2.0.1 - # (NOTE: pinning the action to a given commit is a security best-practice: - # https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/security-hardening-for-github-actions) - - name: Check if PR needs rebase - uses: eps1lon/actions-label-merge-conflict@b8bf8341285ec9a4567d4318ba474fee998a6919 - with: - repoToken: "${{ secrets.GITHUB_TOKEN }}" - dirtyLabel: "needs-rebase" - commentOnDirty: "This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved" diff --git a/.github/workflows/pr-check-deps.yml b/.github/workflows/pr-check-deps.yml deleted file mode 100644 index a7258d187f1..00000000000 --- a/.github/workflows/pr-check-deps.yml +++ /dev/null @@ -1,10 +0,0 @@ -name: Check PR dependencies -on: [pull_request_target] -jobs: - check_dependencies: - runs-on: ubuntu-latest - name: Check PR Dependencies - steps: - - uses: gregsdennis/dependencies-action@f98d55eee1f66e7aaea4a60e71892736ae2548c7 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/pr-checklist.yml b/.github/workflows/pr-checklist.yml deleted file mode 100644 index 0b3f2d6e561..00000000000 --- a/.github/workflows/pr-checklist.yml +++ /dev/null @@ -1,19 +0,0 @@ ---- -name: "Pull Request Checklist" -on: - pull_request: - types: - - edited - - opened - - reopened -jobs: - pr_checklist: - runs-on: ubuntu-latest - name: Verify - steps: - - name: Sleep for 30 seconds - run: sleep 30s - shell: bash - - name: Action - id: checklist - uses: ceph/ceph-pr-checklist-action@32e92d1a2a7c9991ed51de5fccb2296551373d60 diff --git a/.github/workflows/pr-triage.yml b/.github/workflows/pr-triage.yml deleted file mode 100644 index 24b1c97db70..00000000000 --- a/.github/workflows/pr-triage.yml +++ /dev/null @@ -1,28 +0,0 @@ ---- -name: "Pull Request Triage" -on: pull_request_target -env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -jobs: - pr-triage: - runs-on: ubuntu-latest - steps: - - name: Assign labels based on modified files - # https://github.com/marketplace/actions/labeler?version=v4.0.2 - uses: actions/labeler@5c7539237e04b714afd8ad9b4aed733815b9fab4 - with: - sync-labels: '' - repo-token: "${{ secrets.GITHUB_TOKEN }}" - - name: Assign to Dashboard project - # https://github.com/marketplace/actions/add-to-github-projects?version=v0.5.0 - uses: actions/add-to-project@31b3f3ccdc584546fc445612dec3f38ff5edb41c - with: - project-url: https://github.com/orgs/ceph/projects/2 - github-token: ${{ secrets.ADD_TO_PROJECT_PAT }} - labeled: dashboard - - name: Assign milestone based on target brach name - # https://github.com/marketplace/actions/pull-request-milestone?version=v1.3.0 - uses: iyu/actions-milestone@e93115c90ff7bcddee71086e9253f1b6a5f4b48a - with: - configuration-path: .github/milestone.yml - repo-token: "${{ secrets.GITHUB_TOKEN }}" diff --git a/.github/workflows/qa-symlink.yml b/.github/workflows/qa-symlink.yml deleted file mode 100644 index d21167f1546..00000000000 --- a/.github/workflows/qa-symlink.yml +++ /dev/null @@ -1,17 +0,0 @@ ---- -name: "Check for missing .qa links" -on: [pull_request] - -jobs: - pull_request: - name: "Check for missing .qa links" - runs-on: ubuntu-latest - steps: - - name: checkout ceph.git - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4 - with: - path: ceph - - - name: verify .qa links - run: ./src/script/verify-qa - working-directory: ceph diff --git a/.github/workflows/retrigger-rtd.yml b/.github/workflows/retrigger-rtd.yml deleted file mode 100644 index daa4ae70f72..00000000000 --- a/.github/workflows/retrigger-rtd.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Retrigger RTD build on PR comment - -on: - issue_comment: - types: [created] - -permissions: - contents: read - pull-requests: read - -jobs: - retrigger-rtd: - if: github.event.issue.pull_request && - (contains(github.event.comment.body, 'jenkins test docs') || - contains(github.event.comment.body, 'jenkins rebuild docs') || - contains(github.event.comment.body, 'jenkins retrigger docs')) - runs-on: ubuntu-latest - - steps: - - name: Trigger Read the Docs build - run: | - curl -X POST \ - "https://readthedocs.org/api/v3/projects/ceph/versions/${{ github.event.issue.number }}/builds/" \ - -H "Authorization: Token ${{ secrets.READTHEDOCS_API_TOKEN }}" \ - -H "Content-Type: application/json" diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml deleted file mode 100644 index 1805ae36533..00000000000 --- a/.github/workflows/stale.yml +++ /dev/null @@ -1,58 +0,0 @@ -# Configuration for stale action workflow - https://github.com/actions/stale - -name: 'Close stale issues and PRs' -on: - schedule: - - cron: '0 * * * *' - -jobs: - stale: - runs-on: ubuntu-latest - steps: - - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0 - with: - # PAT for GitHub API authentication - repo-token: "${{ secrets.GITHUB_TOKEN }}" - - # Comment on the staled PRs - stale-pr-message: > - This pull request has been automatically marked as stale because it - has not had any activity for 60 days. It will be closed if no further - activity occurs for another 30 days. - - If you are a maintainer or core committer, please follow-up on this - pull request to identify what steps should be taken by the author to move this - proposed change forward. - - If you are the author of this pull request, thank you for your proposed - contribution. If you believe this change is still appropriate, please - ensure that any feedback has been addressed and ask for a code review. - - # Comment on the staled PRs while closed - close-pr-message: > - This pull request has been automatically closed because there has - been no activity for 90 days. Please feel free to reopen this pull - request (or open a new one) if the proposed change is still - appropriate. Thank you for your contribution! - - # Idle number of days before making PRs stale (exempts Issues) - days-before-pr-stale: 60 - - # Idle number of days before closing stale PRs (exempts Issues) - days-before-pr-close: 30 - - # Label to apply on staled PRs - stale-pr-label: 'stale' - - # Labels on PRs exempted from stale - exempt-pr-labels: 'pinned,security' - - # Exempt all PRs with milestones from stale (also exempts Issues) - exempt-all-pr-milestones: true - - # Max number of operations per run - operations-per-run: 100 - - # Change the order used to fetch the issues and pull requests from GitHub - # So we now start with the oldest PRs and work our way backwards - ascending: true From f531e122e3e908addab97b87b0528c94553480a9 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Thu, 30 Jul 2026 11:04:25 -0400 Subject: [PATCH 2/2] tentacle: remove pull_request_template It's not required for backports. Signed-off-by: Patrick Donnelly --- .github/pull_request_template.md | 65 -------------------------------- 1 file changed, 65 deletions(-) delete mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md deleted file mode 100644 index f6542d2af07..00000000000 --- a/.github/pull_request_template.md +++ /dev/null @@ -1,65 +0,0 @@ - - - - - - -## Contribution Guidelines -- To sign and title your commits, please refer to [Submitting Patches to Ceph](https://github.com/ceph/ceph/blob/main/SubmittingPatches.rst). - -- If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to [Submitting Patches to Ceph - Backports](https://github.com/ceph/ceph/blob/master/SubmittingPatches-backports.rst) for the proper workflow. - -- When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an `x` between the brackets: `[x]`. Spaces and capitalization matter when checking off items this way. - -## Checklist -- Tracker (select at least one) - - [ ] References tracker ticket - - [ ] Very recent bug; references commit where it was introduced - - [ ] New feature (ticket optional) - - [ ] Doc update (no ticket needed) - - [ ] Code cleanup (no ticket needed) -- Component impact - - [ ] Affects [Dashboard](https://tracker.ceph.com/projects/dashboard/issues/new), opened tracker ticket - - [ ] Affects [Orchestrator](https://tracker.ceph.com/projects/orchestrator/issues/new), opened tracker ticket - - [ ] No impact that needs to be tracked -- Documentation (select at least one) - - [ ] Updates relevant documentation - - [ ] No doc update is appropriate -- Tests (select at least one) - - [ ] Includes [unit test(s)](https://docs.ceph.com/en/latest/dev/developer_guide/tests-unit-tests/) - - [ ] Includes [integration test(s)](https://docs.ceph.com/en/latest/dev/developer_guide/testing_integration_tests/) - - [ ] Includes bug reproducer - - [ ] No tests - -
-Show available Jenkins commands - -- `jenkins test classic perf` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-perf-classic/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml) -- `jenkins test crimson perf` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-perf-crimson/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml) -- `jenkins test signed` [Jenkins Job](https://jenkins.ceph.com/job/ceph-pr-commits/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-pr-commits/config/definitions/ceph-pr-commits.yml) -- `jenkins test make check` [Jenkins Job](https://jenkins.ceph.com/job/ceph-pull-requests/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-pull-requests/config/definitions/ceph-pull-requests.yml) -- `jenkins test make check arm64` [Jenkins Job](https://jenkins.ceph.com/job/ceph-pull-requests-arm64/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-pull-requests-arm64/config/definitions/ceph-pull-requests-arm64.yml) -- `jenkins test submodules` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-pr-submodules/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-pr-submodules/config/definitions/ceph-pr-commits.yml) -- `jenkins test dashboard` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-dashboard-pull-requests/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-dashboard-pull-requests/config/definitions/ceph-dashboard-pull-requests.yml) -- `jenkins test dashboard cephadm` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-dashboard-cephadm-e2e/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-dashboard-cephadm-e2e/config/definitions/ceph-dashboard-cephadm-e2e.yml) -- `jenkins test api` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-api/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-pr-api/config/definitions/ceph-pr-api.yml) -- `jenkins test docs` [ReadTheDocs](https://readthedocs.org/projects/ceph/) | [Github Workflow Definition](https://github.com/ceph/ceph/blob/main/.readthedocs.yml) -- `jenkins test ceph-volume all` [Jenkins Jobs](https://jenkins.ceph.com/view/ceph-volume%20PR/) | [Jenkins Jobs Definition](https://github.com/ceph/ceph-build/blob/main/ceph-volume-cephadm-prs/config/definitions/ceph-volume-pr.yml) -- `jenkins test windows` [Jenkins Job](https://jenkins.ceph.com/job/ceph-windows-pull-requests/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-windows-pull-requests/config/definitions/ceph-windows-pull-requests.yml) -- `jenkins test rook e2e` [Jenkins Job](https://jenkins.ceph.com/view/all/job/ceph-orchestrator-rook-e2e/) | [Jenkins Job Definition](https://github.com/ceph/ceph-build/blob/main/ceph-rook-e2e/config/definitions/ceph-orchestrator-rook-e2e.yml) -