From ef0b9f339fe8b05abe14dccf2eae05942dddfcf7 Mon Sep 17 00:00:00 2001 From: Sun Yuechi Date: Wed, 1 Jul 2026 02:59:15 -0700 Subject: [PATCH] tools/rados: do not close stdin after put/append from '-' do_put()/do_append() set fd to STDIN_FILENO for '-', but cleanup guarded close() on STDOUT_FILENO (always true), closing stdin. Guard on STDIN_FILENO instead. Signed-off-by: Sun Yuechi --- src/tools/rados/rados.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/rados/rados.cc b/src/tools/rados/rados.cc index 42103648b6b..118359be582 100644 --- a/src/tools/rados/rados.cc +++ b/src/tools/rados/rados.cc @@ -649,7 +649,7 @@ static int do_put(IoCtx& io_ctx, } ret = 0; out: - if (fd != STDOUT_FILENO) + if (fd != STDIN_FILENO) VOID_TEMP_FAILURE_RETRY(close(fd)); return ret; } @@ -684,7 +684,7 @@ static int do_append(IoCtx& io_ctx, } ret = 0; out: - if (fd != STDOUT_FILENO) + if (fd != STDIN_FILENO) VOID_TEMP_FAILURE_RETRY(close(fd)); return ret; }