From 74293f77e06fcf02d461965cf559afed412f36c9 Mon Sep 17 00:00:00 2001 From: Likitha Shetty Date: Wed, 7 Aug 2013 13:21:57 +0530 Subject: [PATCH] CLOUDSTACK-4025. NPE observed during VM start. NPE was hit during VM start because the network it was to be deployed in didn't get implemented - Handling this failure. --- server/src/com/cloud/network/NetworkManagerImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java index ad79a2fb5b3..36e889d52fc 100755 --- a/server/src/com/cloud/network/NetworkManagerImpl.java +++ b/server/src/com/cloud/network/NetworkManagerImpl.java @@ -2080,6 +2080,10 @@ public class NetworkManagerImpl extends ManagerBase implements NetworkManager, L for (NicVO nic : nics) { Pair implemented = implementNetwork(nic.getNetworkId(), dest, context); + if (implemented.first() == null) { + s_logger.warn("Failed to implement network id=" + nic.getNetworkId() + " as a part of preparing nic id=" + nic.getId()); + throw new CloudRuntimeException("Failed to implement network id=" + nic.getNetworkId() + " as a part preparing nic id=" +nic.getId()); + } NetworkVO network = implemented.second(); NicProfile profile = prepareNic(vmProfile, dest, context, nic.getId(), network);