Commit Graph

1140 Commits

Author SHA1 Message Date
Rafael da Fonseca
d0a494b71b Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in DeployVMCmd.java Was creating Long to assign to long
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #417
2015-06-15 12:09:24 +03:00
Rafael da Fonseca
16baa1289b Remove unused imports to fix checkstyle warnings
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #414
2015-06-15 12:09:19 +03:00
Rafael da Fonseca
9c4162ac7f Fix 2 findbugs ClassCastExceptions getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map\<String, String\> and not a Map\<String, Map\<String,String\>\> If this piece of could would get run, it would just fail trying to cast String to HashMap\<String,String\> Removed nonsense comment about casting a Collection to a Map obviously giving exception
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:09:18 +03:00
Rafael da Fonseca
a7a39a608c Remove unused imports to fix checkstyle warnings
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #413
2015-06-15 12:09:17 +03:00
Rafael da Fonseca
96d6aaa293 Fix findbugs ClassCastException in UpgradeSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to HashMap<String,String> in line 83
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:09:16 +03:00
Rafael da Fonseca
8634fe5cf5 Remove unused imports to fix checkstyle warnings
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #412
2015-06-15 12:09:15 +03:00
Rafael da Fonseca
31a4f0ad6b Fix findbugs ClassCastException in ScaleSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to Map<String,String>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:09:14 +03:00
René Moser
666263e84d template, api: fix format desc, add OVA format
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #331
2015-05-29 21:02:03 +02:00
Milamber
87d4086a64 CLOUDSTACK-6181 Specify GB for the value of rootdisksize parameter. Add some Bytes/GB for log or exception messages. Fix Gb->GB. 2015-05-23 17:52:21 +01:00
Rohit Yadav
1c81b241e7 CLOUDSTACK-8505: Don't allow non-POST requests for default login API
We add a new contract to pass Http request to authentication plugin system. In
the default login API, we disallow non-POST requests.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 9e9b231672)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	api/src/org/apache/cloudstack/api/auth/APIAuthenticator.java
	plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/GetServiceProviderMetaDataCmd.java
	plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
	plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LogoutAPIAuthenticatorCmd.java
	plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/GetServiceProviderMetaDataCmdTest.java
	plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmdTest.java
	plugins/user-authenticators/saml2/test/org/apache/cloudstack/api/command/SAML2LogoutAPIAuthenticatorCmdTest.java
	server/src/com/cloud/api/ApiServlet.java
	server/src/com/cloud/api/auth/DefaultLoginAPIAuthenticatorCmd.java
	server/src/com/cloud/api/auth/DefaultLogoutAPIAuthenticatorCmd.java
	server/test/com/cloud/api/ApiServletTest.java
2015-05-22 11:44:34 +01:00
Rene Moser
84266b1c72 api: network: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #275
2015-05-21 17:49:19 +02:00
Rene Moser
c1fbb7821a api: loadbalancer: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
a1f58c48ec api: iso: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
897c73867d api: firewall: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
f17ab71bdf api: affinitygroup: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
4c65acfff7 api: address: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
68e867f0c6 api: account: fix and reformat descriptions
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:18 +02:00
Rene Moser
5cd35a2237 fix typos balacner -> balancer
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:17 +02:00
Rene Moser
23a44d6417 instanceGroupResponse: fix description
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:17 +02:00
Rene Moser
3824d997d6 queryService: fix style, remove public statement on interfaces
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-05-21 17:49:17 +02:00
Rene Moser
c43e4db4e0 ListFirewallEgressRulesCmd: add interfaces and minor cleanup
This commit does not implement new functionality:

* Fixes duplicate parameter in API docs.
* Fixes a bunch of typos.
* Add interfaces to make it easier for the FirewallService interface.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #249
2015-05-20 17:00:08 +01:00
Devdeep Singh
a99c9d0e68 Implementation for the ability to disable a storage pool for provisioning
... of new volumes. Following changes are implemented 1. Disable or enable a pool with the
updateStoragePool api. A new 'enabled' parameter added for the same. 2. When a
pool is disabled the state of the pool is updated to 'Disabled' in the db. On
enabling it is updated back to 'Up'. Alert is raised when a pool is disabled or
enabled. 3. Updated other storage providers to also honour the disabled state.
4. A disabled pool is skipped by allocators for provisioing of new volumes. 5.
Since the allocators skip a disabled pool for provisioning of volumes, the
volumes are also not listed as a destination for volume migration.

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Disabling+Storage+Pool+for+Provisioning

This closes #257

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-19 11:16:49 +01:00
Rene Moser
e8f8e0e3f2 listPortForwardingRules: fix typo in doc
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #248
2015-05-13 15:43:53 +02:00
Rajani Karuturi
0b8355920e Merge branch 'volume-upload' into master
This closes #206
2015-04-29 11:12:53 +05:30
Ilia Shakitko
fe29998938 GetUsageRecordsCmd - NewInputFormat for START_DATE and END_DATE (with time; backward capabile)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-24 11:34:51 +02:00
Rohit Yadav
79a46fe0b4 CLOUDSTACK-8399: Allow changing hvm flag in updateTemplate API
This allows changing the hvm flag for a template after the template has been
registered.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 3e8b12bbb1)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-23 15:28:22 +02:00
Rohit Yadav
d81e831214 RemoteAccessVpn: fix regression preshared key is not sent to UI/clients
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit c71339569d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-23 14:19:24 +02:00
Rene Moser
4a424500f3 CreateVMSnapshot: fix typo in API description
This closes #161
2015-04-13 20:26:26 +02:00
Rajani Karuturi
5c152e5f3a volume upload: disabled all zones during template upload 2015-04-13 14:43:12 +05:30
Rohit Yadav
0eec4ff977 CLOUDSTACK-6353: Fix list to have correct LB IP for each rule
(cherry picked from commit 0fe4acf525)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-26 18:24:19 +05:30
Pierre-Luc Dion
a86dbd3c20 remove 'double quotes' from description because it cause problem with integration tests 2015-03-21 21:04:09 -04:00
Rajani Karuturi
7d1ca8a55c Fixed NPE with getUploadParamsForTemplate API call
if isdynamicallyscalable optional parameter is not specified, its trying
to cast null to Boolean and throws NPE
2015-03-17 10:35:48 +05:30
wilderrodrigues
e350f1e76f Turn a single VPC into a redundant VPC
- when restarting a VPC, the user can check the option Make Redundant in order to change
    the VPC offering and make it redundant
2015-03-16 11:39:57 +01:00
wilderrodrigues
88129adac1 Implement the new VPC restart
- behaves just like network restart: if clean up is checked, all routers destroyed; if 1 router is gone and no
    clean up, only 1 new router created.
2015-03-16 11:39:52 +01:00
Antonio Fornie
09bd847040 Vpc redundancy enabled. Including Vpc & Vpc Offering creation. Marvin tests and UI. 2015-03-16 11:38:05 +01:00
Funs
c27c69438b hypervisors: add OVM3 plugin that supports OVM 3.2.1/3.3.x
This is a plugin that puts in ovm3 support ranging from 3.3.1 to 3.3.2. Basic
functionality is in here, advanced networking etc..

Snapshots only work when a VM is stopped now due to the semantics of OVM's raw
image implementation (so snapshots should work on a storage level underneath the
hypervisor shrug)

This closes #113

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 11:33:42 +05:30
Rohit Yadav
40f343ff4c api: avoid sending sensitive data in api response
- UI: use post when updating user
- S3: don't send s3 key in the response
- VPN: don't send preshared key in remoteaccessvpn api response
- Snapshot response should set zone id not volume's device id

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 02cadc3fb3)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-11 16:34:56 +05:30
Pierre-Luc Dion
d38b6f5f1e CLOUDSTACK-4719: update API description for details, example for xenserver tools 2015-03-08 22:17:45 -04:00
Pierre-Luc Dion
4c0ed3d85d CLOUDSTACK-1359: added (1GB = 1,073,741,824 bytes) 2015-03-07 15:24:04 -05:00
Phillip Kent
d4523c5778 modify description for name parameter in ListVMsCmd.java 2015-03-05 12:30:26 +00:00
René Moser
6fef3ed22b CreatePortForwardingRuleCmd: Fix typos and update descriptions.
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>

This closes #94
2015-03-05 11:03:00 +01:00
Rohit Yadav
43cf1da865 CLOUDSTACK-5238: password checks, NPE fixes and minor fixes
- insecure authenticators excluded in configuration
- snapshot response should have zone
- remove vmsnapshots when removing accounts

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 5481485a08)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	api/src/org/apache/cloudstack/api/response/VMSnapshotResponse.java
	server/src/com/cloud/api/ApiResponseHelper.java
	server/src/com/cloud/storage/download/DownloadActiveState.java
2015-02-27 18:24:46 +05:30
Rohit Yadav
2580edbcfb CLOUDSTACK-7908: UserVmResponse returns userid/username information of the creator
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 16:12:22 +05:30
Rohit Yadav
2b7073c73f CLOUDSTACK-7085, CLOUDSTACK-7084: disallow empty passwords
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e5cd75790a)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 15:34:06 +05:30
Rohit Yadav
1a6df6f978 CLOUDSTACK-7908: Add user_id column to vm_instance table
Design Document:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+VM+listing+by+User+ID

- Adds column to VMInstance DAO
- Adds column in vm_instance table
- Adds column in the UserVMJoinVO
- Adds default admin user which has UID = 2
- Adds migration path that sets user_id to first user of the accountId that
  owns the vm in vm_instance table
- Add arg on list VMs API to query by userId, add support in query layer
- Refactor VMInstanceVO and child classes to accept userId
- Add code to let service layer pass userId if loggedIn user belongs to same
  account as the owner executing an API call or use first user from owner account
- In case of CPVM and SSVM use system user ID
- Fix unit tests and spring injections

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 15:02:38 +05:30
Rohit Yadav
083a4950a9 Fix typos
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit af278fe1ab)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 15:54:01 +05:30
Rohit Yadav
1c616392db DeployVmCmd: Fix NPE case
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit d2bf21065e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 14:21:29 +05:30
Rohit Yadav
2f6691c6b9 CLOUDSTACK-8190: Fix xenserver traffic label for backward compatiblity
(cherry picked from commit 48ec9ac11b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	ui/scripts/system.js
2015-02-02 16:20:50 +05:30
Koushik Das
2fa4a475aa volume-upload: getUploadParamsForVolume/Template response differs from spec
Fixed the response parameters
2015-01-31 17:23:13 +05:30
Koushik Das
71873c8d41 volume-upload: GetUploadParamsForVolume/Template API response in XML format doesn't have POST URL
The URL response parameter didn't have the right name attribute set on it.
2015-01-31 17:16:58 +05:30