mirror of
https://github.com/apache/cloudstack
synced 2026-08-02 21:38:30 +00:00
beebeed5e2
- mTLS implementation for cluster service communication - Listen only on the specified cluster node IP address instead of all interfaces - Validate incoming cluster service requests are from peer management servers based on the server's certificate dns name which can be through global config - ca.framework.cert.management.custom.san - Hardening of KVM command wrapper script execution - Improve API server integration port check - cloudstack-management.default: don't have JMX configuration if not needed. JMX is used for instrumentation; users who need to use it should enable it explicitly Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: Wei Zhou <weizhou@apache.org> Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com> Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
74 lines
2.8 KiB
Java
74 lines
2.8 KiB
Java
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
package com.cloud.api;
|
|
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
|
|
import org.junit.Assert;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.InjectMocks;
|
|
import org.mockito.Mockito;
|
|
import org.powermock.api.mockito.PowerMockito;
|
|
import org.powermock.core.classloader.annotations.PrepareForTest;
|
|
import org.powermock.modules.junit4.PowerMockRunner;
|
|
|
|
@RunWith(PowerMockRunner.class)
|
|
@PrepareForTest(ApiServer.class)
|
|
public class ApiServerTest {
|
|
|
|
@InjectMocks
|
|
ApiServer apiServer = new ApiServer();
|
|
|
|
private List<ApiServer.ListenerThread> createdListeners;
|
|
|
|
private void runTestSetupIntegrationPortListenerInvalidPorts(Integer port) {
|
|
try {
|
|
ApiServer.ListenerThread mocked = Mockito.mock(ApiServer.ListenerThread.class);
|
|
PowerMockito.whenNew(ApiServer.ListenerThread.class).withAnyArguments().thenReturn(mocked);
|
|
apiServer.setupIntegrationPortListener(port);
|
|
Mockito.verify(mocked, Mockito.never()).start();
|
|
} catch (Exception e) {
|
|
Assert.fail(String.format("Exception occurred: %s", e.getMessage()));
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testSetupIntegrationPortListenerInvalidPorts() {
|
|
List<Integer> ports = new ArrayList<>(List.of(-1, -10, 0));
|
|
ports.add(null);
|
|
for (Integer port : ports) {
|
|
runTestSetupIntegrationPortListenerInvalidPorts(port);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testSetupIntegrationPortListenerValidPort() {
|
|
Integer validPort = 8080;
|
|
try {
|
|
ApiServer.ListenerThread mocked = Mockito.mock(ApiServer.ListenerThread.class);
|
|
PowerMockito.whenNew(ApiServer.ListenerThread.class).withAnyArguments().thenReturn(mocked);
|
|
apiServer.setupIntegrationPortListener(validPort);
|
|
PowerMockito.verifyNew(ApiServer.ListenerThread.class).withArguments(apiServer, validPort);
|
|
Mockito.verify(mocked).start();
|
|
} catch (Exception e) {
|
|
Assert.fail(String.format("Exception occurred: %s", e.getMessage()));
|
|
}
|
|
}
|
|
}
|
