From 3b1a70b140183a94e206d849efa1bcd679da8438 Mon Sep 17 00:00:00 2001 From: NaturalSelect <2145973003@qq.com> Date: Mon, 29 May 2023 20:24:09 +0800 Subject: [PATCH] test(datanode): fix limit.go unit test Signed-off-by: NaturalSelect <2145973003@qq.com> --- datanode/limit_test.go | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/datanode/limit_test.go b/datanode/limit_test.go index 5a8b9c809..37a3b96c6 100644 --- a/datanode/limit_test.go +++ b/datanode/limit_test.go @@ -12,7 +12,7 @@ import ( func TestInitRepairLimit(t *testing.T) { initRepairLimit() - assert.Equal(t, MaxExtentRepairLimit, cap(extentRepairLimitRater)) + assert.Equal(t, MaxExtentRepairLimit, len(extentRepairLimitRater)) } func TestRequestDoExtentRepair(t *testing.T) { @@ -25,11 +25,17 @@ func TestRequestDoExtentRepair(t *testing.T) { err := requestDoExtentRepair() require.NoError(t, err) + stop := false for { + if stop { + break + } select { case <-extentRepairLimitRater: + // do nothing default: - return + stop = true + break } } @@ -46,19 +52,28 @@ func TestFininshDoExtentRepair(t *testing.T) { err := requestDoExtentRepair() require.NoError(t, err) + stop := false for { + if stop { + break + } select { case <-extentRepairLimitRater: + // do nothing default: - return + stop = true + break } } + // finishDoExtentRepair() will send a struct{} to extentRepairLimitRater fininshDoExtentRepair() select { case <-extentRepairLimitRater: - t.Fatalf("extentRepairLimitRater should be empty") + if len(extentRepairLimitRater) != 0 { + t.Fatalf("extentRepairLimitRater should be empty, but len(extentRepairLimitRater) is %v", len(extentRepairLimitRater)) + } default: } }