gian/cubefs
1
0
Fork 0
mirror of https://github.com/cubefs/cubefs.git synced 2026-08-02 10:06:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(client): Disable xattr security.capability to avoid useless request to backend #1000519910

Browse Source 
Signed-off-by: leonrayang <changliang@oppo.com>
This commit is contained in:
leonrayang 2025-12-12 16:15:10 +08:00 committed by 贺迟
parent 86030fe047
commit 8adaad9f90
2 changed files with 30 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
client/fs/dir.go
View File

@ -173,9 +173,7 @@ func (d *Dir) Release(ctx context.Context, req *fuse.ReleaseRequest) (err error)
if !d.super.metaCacheAcceleration {
d.dctx.Clear()
d.dcache.Clear()
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Clear()
}
d.dcacheNoEnt.Clear()
ino := d.info.Inode
d.super.ic.Delete(ino)
@ -202,10 +200,7 @@ func (d *Dir) Create(ctx context.Context, req *fuse.CreateRequest, resp *fuse.Cr
}()
// Delete from negative cache if file is being created
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Delete(req.Name)
}
d.dcacheNoEnt.Delete(req.Name)
info, err := d.super.mw.Create_ll(d.info.Inode, req.Name, proto.Mode(req.Mode.Perm()), req.Uid, req.Gid, nil,
fullPath, false, false)
if err != nil {
@ -251,9 +246,7 @@ func (d *Dir) Forget() {
d.dctx.Clear()
d.super.ic.Delete(ino)
d.dcache.Clear()
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Clear()
}
d.dcacheNoEnt.Clear()
d.super.fslock.Lock()
delete(d.super.nodeCache, ino)
d.super.fslock.Unlock()
@ -277,10 +270,9 @@ func (d *Dir) Mkdir(ctx context.Context, req *fuse.MkdirRequest) (fs.Node, error
d.super.runningMonitor.SubClientOp(runningStat, err)
}()
log.LogDebugf("TRACE Mkdir:enter")
// Delete from negative cache if directory is being created
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Delete(req.Name)
}
d.dcacheNoEnt.Delete(req.Name)
info, err := d.super.mw.Create_ll(d.info.Inode, req.Name, proto.Mode(os.ModeDir|req.Mode.Perm()), req.Uid,
req.Gid, nil, fullPath, false, false)
if err != nil {
@ -377,7 +369,7 @@ func (d *Dir) Lookup(ctx context.Context, req *fuse.LookupRequest, resp *fuse.Lo
}
if dcachev2 {
// First check negative cache (file doesn't exist)
if d.dcacheNoEnt != nil && d.dcacheNoEnt.Get(req.Name) {
if d.dcacheNoEnt.Get(req.Name) {
if log.EnableDebug() {
log.LogDebugf("Lookup %v from parent %v hit negative cache (dcachev2), return ENOENT", path.Join(d.getCwd(), req.Name), d.info.Inode)
}
@ -419,7 +411,7 @@ func (d *Dir) Lookup(ctx context.Context, req *fuse.LookupRequest, resp *fuse.Lo
}
} else {
// First check negative cache (file doesn't exist)
if d.dcacheNoEnt != nil && d.dcacheNoEnt.Get(req.Name) {
if d.dcacheNoEnt.Get(req.Name) {
if log.EnableDebug() {
log.LogDebugf("Lookup %v from parent %v hit negative cache, return ENOENT", path.Join(d.getCwd(), req.Name), d.info.Inode)
}
@ -915,10 +907,9 @@ func (d *Dir) Mknod(ctx context.Context, req *fuse.MknodRequest) (fs.Node, error
d.super.runningMonitor.SubClientOp(runningStat, err)
}()
fullPath := path.Join(d.getCwd(), req.Name)
// Delete from negative cache if file is being created
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Delete(req.Name)
}
d.dcacheNoEnt.Delete(req.Name)
info, err := d.super.mw.Create_ll(d.info.Inode, req.Name, proto.Mode(req.Mode), req.Uid, req.Gid,
nil, fullPath, false, false)
if err != nil {
@ -952,10 +943,9 @@ func (d *Dir) Symlink(ctx context.Context, req *fuse.SymlinkRequest) (fs.Node, e
d.super.runningMonitor.SubClientOp(runningStat, err)
}()
fullPath := path.Join(d.getCwd(), req.NewName)
// Delete from negative cache if symlink is being created
if d.dcacheNoEnt != nil {
d.dcacheNoEnt.Delete(req.NewName)
}
d.dcacheNoEnt.Delete(req.NewName)
info, err := d.super.mw.Create_ll(parentIno, req.NewName, proto.Mode(os.ModeSymlink|os.ModePerm), req.Uid,
req.Gid, []byte(req.Target), fullPath, false, false)
if err != nil {
@ -1043,6 +1033,16 @@ func (d *Dir) Getxattr(ctx context.Context, req *fuse.GetxattrRequest, resp *fus
d.super.runningMonitor.SubClientOp(runningStat, err)
}()
// Optimize: directly return empty value for security.capability to avoid frequent server queries
// This avoids backend service access for system xattr that is frequently queried during write operations
if name == "security.capability" {
resp.Xattr = []byte{}
if log.EnableDebug() {
log.LogDebugf("TRACE GetXattr: ino(%v) name(%v) (optimized, returning empty)", ino, name)
}
return nil
}
if name == meta.SummaryKey {
var summaryInfo meta.SummaryInfo
summaryInfo, err = d.super.mw.GetSummary_ll(ino, 20)

9
client/fs/file.go
View File

@ -801,6 +801,15 @@ func (f *File) Getxattr(ctx context.Context, req *fuse.GetxattrRequest, resp *fu
name := req.Name
size := req.Size
pos := req.Position
// Optimize: directly return empty value for security.capability to avoid frequent server queries
// This avoids backend service access for system xattr that is frequently queried during write operations
if name == "security.capability" {
resp.Xattr = []byte{}
log.LogDebugf("TRACE GetXattr: ino(%v) name(%v) (optimized, returning empty)", ino, name)
return nil
}
info, err := f.super.mw.XAttrGet_ll(ino, name, false)
if err != nil {
log.LogErrorf("GetXattr: ino(%v) name(%v) err(%v)", ino, name, err)