imapsync/W/perlcritic_3.out
Nick Bebout 4a1d71d8fd 1.644
2015-08-03 20:44:40 -05:00

88 lines
8.8 KiB
Plaintext

Main code has high complexity score (387) at line 1, column 1. Consider refactoring. (Severity: 3)
Literal line breaks in a string at line 918, column 1. See pages 60,61 of PBP. (Severity: 3)
Literal line breaks in a string at line 930, column 1. See pages 60,61 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 1112, column 33. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 1121, column 33. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 1138, column 18. See page 236 of PBP. (Severity: 3)
Literal line breaks in a string at line 1212, column 1. See pages 60,61 of PBP. (Severity: 3)
Literal line breaks in a string at line 1245, column 1. See pages 60,61 of PBP. (Severity: 3)
Code structure is deeply nested at line 1613, column 41. Consider refactoring. (Severity: 3)
Literal line breaks in a string at line 1761, column 1. See pages 60,61 of PBP. (Severity: 3)
Subroutine "errors_incr" does not end with "return" at line 1783, column 1. See page 197 of PBP. (Severity: 4)
Subroutine "tests_live_result" does not end with "return" at line 1808, column 1. See page 197 of PBP. (Severity: 4)
Reused variable name in lexical scope: $nb_errors at line 1809, column 2. Invent unique variable names. (Severity: 3)
Subroutine "foldersizesatend" does not end with "return" at line 1817, column 1. See page 197 of PBP. (Severity: 4)
Too many arguments at line 1843, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 1861, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 1871, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "modules_VERSION" with high complexity score (21) at line 1989, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 2121, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 2182, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "authenticate_imap" with high complexity score (21) at line 2243, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 2243, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 2347, column 1. See page 182 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 2420, column 51. See page 236 of PBP. (Severity: 3)
Backtick operator used at line 2428, column 12. Use IPC::Open3 instead. (Severity: 3)
Subroutine "is_valid_directory" does not end with "return" at line 2558, column 1. See page 197 of PBP. (Severity: 4)
Close filehandles as soon as possible after opening them at line 2578, column 2. See page 209 of PBP. (Severity: 4)
Subroutine "remove_tmp_files" does not end with "return" at line 2589, column 1. See page 197 of PBP. (Severity: 4)
"die" used instead of "croak" at line 2603, column 2. See page 283 of PBP. (Severity: 3)
Always unpack @_ first at line 2704, column 1. See page 178 of PBP. (Severity: 4)
Regular expression without "/x" flag at line 2711, column 15. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 2712, column 15. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 2713, column 15. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 2739, column 31. See page 236 of PBP. (Severity: 3)
Reused variable name in lexical scope: $imap2 at line 2799, column 9. Invent unique variable names. (Severity: 3)
Regular expression without "/x" flag at line 2818, column 25. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 2821, column 20. See page 236 of PBP. (Severity: 3)
Mixed high and low-precedence booleans at line 2822, column 13. See page 70 of PBP. (Severity: 4)
Expression form of "eval" at line 3263, column 13. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 3489, column 13. See page 161 of PBP. (Severity: 5)
Subroutine "select_msgs" does not end with "return" at line 3630, column 1. See page 197 of PBP. (Severity: 4)
Subroutine "tests_msgs_from_maxmin" does not end with "return" at line 3771, column 1. See page 197 of PBP. (Severity: 4)
Subroutine "copy_message" with high complexity score (25) at line 3848, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 3848, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 3926, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 3960, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "tests_subject" does not end with "return" at line 4087, column 1. See page 197 of PBP. (Severity: 4)
Too many arguments at line 4150, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "sleep_if_needed" does not end with "return" at line 4211, column 1. See page 197 of PBP. (Severity: 4)
Reused variable name in lexical scope: $total_bytes_transferred at line 4212, column 2. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $nb_msg_transferred at line 4212, column 2. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $nb_msg_transferred at line 4224, column 9. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $maxmessagespersecond at line 4224, column 9. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $total_bytes_transferred at line 4245, column 9. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $maxbytespersecond at line 4245, column 9. Invent unique variable names. (Severity: 3)
Hard tabs used at line 4830, column 10. See page 20 of PBP. (Severity: 3)
Expression form of "eval" at line 5434, column 13. See page 161 of PBP. (Severity: 5)
Regular expression without "/x" flag at line 5669, column 22. See page 236 of PBP. (Severity: 3)
Expression form of "eval" at line 5674, column 13. See page 161 of PBP. (Severity: 5)
Too many arguments at line 5838, column 1. See page 182 of PBP. (Severity: 3)
Always unpack @_ first at line 6000, column 1. See page 178 of PBP. (Severity: 4)
Backtick operator used at line 6007, column 4. Use IPC::Open3 instead. (Severity: 3)
Subroutine "tests_pipemess" does not end with "return" at line 6024, column 1. See page 197 of PBP. (Severity: 4)
Backtick operator used at line 6213, column 12. Use IPC::Open3 instead. (Severity: 3)
Backtick operator used at line 6233, column 11. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 6373, column 12. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 6399, column 12. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 6428, column 12. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 6440, column 12. See page 261 of PBP. (Severity: 3)
Expression form of "eval" at line 6546, column 43. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 6550, column 45. See page 161 of PBP. (Severity: 5)
Split long regexps into smaller qr// chunks at line 6755, column 20. See page 261 of PBP. (Severity: 3)
"$i" is declared but not used at line 6814, column 9. Unused variables clutter code and make it harder to read. (Severity: 3)
Magic variable "$ENV" should be assigned as "local" at line 6861, column 12. See pages 81,82 of PBP. (Severity: 4)
Magic variable "$ENV" should be assigned as "local" at line 6869, column 12. See pages 81,82 of PBP. (Severity: 4)
Test without a label at line 6876, column 2. Add a label argument to all Test::More functions. (Severity: 3)
Test without a label at line 6877, column 2. Add a label argument to all Test::More functions. (Severity: 3)
Reused variable name in lexical scope: $logfile at line 6882, column 2. Invent unique variable names. (Severity: 3)
Subroutine "teelaunch" does not end with "return" at line 6889, column 1. See page 197 of PBP. (Severity: 4)
Reused variable name in lexical scope: $logfile at line 6890, column 2. Invent unique variable names. (Severity: 3)
Close filehandles as soon as possible after opening them at line 6893, column 2. See page 209 of PBP. (Severity: 4)
"die" used instead of "croak" at line 6894, column 7. See page 283 of PBP. (Severity: 3)
Magic variable "*STDERR" should be assigned as "local" at line 6896, column 10. See pages 81,82 of PBP. (Severity: 4)
One-argument "select" used at line 6897, column 2. See page 224 of PBP. (Severity: 4)
Subroutine "testslive" does not end with "return" at line 7387, column 1. See page 197 of PBP. (Severity: 4)
Return value of eval not tested at line 7409, column 17. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Return value of eval not tested at line 7448, column 17. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)