gian/incus-mirror
1
0
Fork 0
mirror of https://github.com/lxc/incus synced 2026-08-02 05:26:46 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

incusd/instances_post: Add extra validation during backup import

Browse Source 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
This commit is contained in:
Stéphane Graber 2026-03-25 21:22:17 -04:00
parent e61846207b
commit 15a5344774
No known key found for this signature in database
GPG Key ID: C638974D64792D67
1 changed files with 67 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
cmd/incusd/instances_post.go
View File

@ -718,7 +718,7 @@ func createFromBackup(s *state.State, r *http.Request, projectName string, data
return response.BadRequest(errors.New("Backup file is missing required information"))
}
// Check project permissions.
// Early project permissions check (pre-override and pre-backup.yaml).
var req api.InstancesPost
err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
req = api.InstancesPost{
@ -861,6 +861,7 @@ func createFromBackup(s *state.State, r *http.Request, projectName string, data
return fmt.Errorf("Failed importing backup: %w", err)
}
// Load the newly imported instance.
inst, err := instance.LoadByProjectAndName(s, bInfo.Project, bInfo.Name)
if err != nil {
return fmt.Errorf("Failed loading instance: %w", err)
@ -869,8 +870,32 @@ func createFromBackup(s *state.State, r *http.Request, projectName string, data
// Clean up created instance if the post hook fails below.
runReverter.Add(func() { _ = inst.Delete(true) })
// Run the storage post hook to perform any final actions now that the instance has been created
// in the database (this normally includes unmounting volumes that were mounted).
// Run a late project restriction check on the instance.
instState, _, err := inst.Render()
if err != nil {
return fmt.Errorf("Failed loading instance state: %w", err)
}
instStateAPI, ok := instState.(*api.Instance)
if !ok {
return fmt.Errorf("Unexpected instance state type %T", instStateAPI)
}
err = s.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
req = api.InstancesPost{
InstancePut: instStateAPI.Writable(),
Name: inst.Name(),
Source: api.InstanceSource{},
Type: inst.Type().ToAPI(),
}
return project.AllowInstanceCreation(tx, projectName, req)
})
if err != nil {
return err
}
// Run any post hook for the instance.
if postHook != nil {
err = postHook(inst)
if err != nil {
@ -878,6 +903,45 @@ func createFromBackup(s *state.State, r *http.Request, projectName string, data
}
}
// And wrap up validation by running a check on all snapshots too.
snaps, err := inst.Snapshots()
if err != nil {
return fmt.Errorf("Failed loading instance snapshots: %w", err)
}
for _, snap := range snaps {
snapState, _, err := snap.Render()
if err != nil {
return fmt.Errorf("Failed loading instance snapshot state: %w", err)
}
snapStateAPI, ok := snapState.(*api.InstanceSnapshot)
if !ok {
return fmt.Errorf("Unexpected snapshot type %T", snapStateAPI)
}
err = s.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
req = api.InstancesPost{
InstancePut: api.InstancePut{
Architecture: snapStateAPI.Architecture,
Config: snapStateAPI.Config,
Description: snapStateAPI.Description,
Devices: snapStateAPI.Devices,
Ephemeral: snapStateAPI.Ephemeral,
Profiles: snapStateAPI.Profiles,
},
Name: inst.Name(),
Source: api.InstanceSource{},
Type: inst.Type().ToAPI(),
}
return project.AllowInstanceCreation(tx, projectName, req)
})
if err != nil {
return err
}
}
runReverter.Success()
return instanceCreateFinish(s, &req, db.InstanceArgs{Name: bInfo.Name, Project: bInfo.Project}, op)