gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add error message to match the behaviour

Browse Source 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This commit is contained in:
Kamil Tekiela 2023-12-29 00:10:10 +01:00
parent 6e2d43bdd9
commit 0140716725
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Table/Indexes.php
View File

@ -162,6 +162,12 @@ final class Indexes
}
}
if ($index->getName() === 'PRIMARY') {
$this->error = Message::error(
__('Can\'t rename index to PRIMARY!'),
);
}
return QueryGenerator::getSqlQueryForIndexRename(
$db,
$table,

8
tests/classes/Table/IndexesTest.php
View File

@ -48,7 +48,13 @@ class IndexesTest extends AbstractTestCase
// Error message
$index->setName('NOT PRIMARY'); // Cannot rename primary so the operation should fail
$indexes->getSqlQueryForRename('PRIMARY', $index, Current::$database, Current::$table);
$this->assertInstanceOf(Message::class, $indexes->getError());
$error = $indexes->getError();
$this->assertInstanceOf(Message::class, $error);
$index->setName('PRIMARY'); // The new name cannot be PRIMARY so the operation should fail
$indexes->getSqlQueryForRename('NOT PRIMARY', $index, Current::$database, Current::$table);
$error = $indexes->getError();
$this->assertInstanceOf(Message::class, $error);
}
public function testGetSqlQueryForIndexCreateOrEdit(): void