From 01692acc7273c7ad34cd32b5dda2d681cdf6194f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CRijas?= <“Rijas.Ahammed@icfoss.in”>
Date: Tue, 10 Apr 2018 14:55:22 +0530
Subject: [PATCH] Remove Inline Styles from Ruotines.php

Signed-off-by: Rijas Ahammed PK <rijaspk5195@gmail.com>
---
 libraries/classes/Rte/Routines.php | 17 ++++++++---------
 themes/pmahomme/css/rte.css.php    | 14 +++++++++++++-
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/libraries/classes/Rte/Routines.php b/libraries/classes/Rte/Routines.php
index d7961c0284..962907373c 100644
--- a/libraries/classes/Rte/Routines.php
+++ b/libraries/classes/Rte/Routines.php
@@ -874,7 +874,7 @@ class Routines
         }
         $disableRemoveParam = '';
         if (! $routine['item_num_params']) {
-            $disableRemoveParam = " color: gray;' disabled='disabled";
+            $disableRemoveParam = " class='isdisableremoveparam_class' disabled=disabled";
         }
         $original_routine = '';
         if ($mode == 'edit') {
@@ -907,9 +907,9 @@ class Routines
         $retval .= Url::getHiddenInputs($db) . "\n";
         $retval .= "<fieldset>\n";
         $retval .= "<legend>" . __('Details') . "</legend>\n";
-        $retval .= "<table class='rte_table' style='width: 100%'>\n";
+        $retval .= "<table class='rte_table'>\n";
         $retval .= "<tr>\n";
-        $retval .= "    <td style='width: 20%;'>" . __('Routine name') . "</td>\n";
+        $retval .= "    <td>" . __('Routine name') . "</td>\n";
         $retval .= "    <td><input type='text' name='item_name' maxlength='64'\n";
         $retval .= "               value='{$routine['item_name']}' /></td>\n";
         $retval .= "</tr>\n";
@@ -924,11 +924,10 @@ class Routines
         } else {
             $retval .= "<input name='item_type' type='hidden'"
                 . " value='{$routine['item_type']}' />\n"
-                . "<div class='floatleft center' style='width: 49%;"
-                . " font-weight: bold;'>\n"
+                . "<div class='floatleft center'>\n"
                 . $routine['item_type'] . "\n"
                 . "</div>\n"
-                . "<input style='width: 49%;' type='submit' name='routine_changetype'\n"
+                . "<input type='submit' name='routine_changetype'\n"
                 . " value='" . sprintf(__('Change to %s'), $routine['item_type_toggle'])
                 . "' />\n";
         }
@@ -962,10 +961,10 @@ class Routines
         $retval .= "<tr>";
         $retval .= "    <td>&nbsp;</td>";
         $retval .= "    <td>";
-        $retval .= "        <input style='width: 49%;' type='button'";
+        $retval .= "        <input type='button'";
         $retval .= "               name='routine_addparameter'";
         $retval .= "               value='" . __('Add parameter') . "' />";
-        $retval .= "        <input style='width: 49%;" . $disableRemoveParam . "'";
+        $retval .= "        <input " . $disableRemoveParam . "";
         $retval .= "               type='submit' ";
         $retval .= "               name='routine_removeparameter'";
         $retval .= "               value='" . __('Remove last parameter') . "' />";
@@ -1620,7 +1619,7 @@ class Routines
             $retval .= "</caption>\n";
         } else {
             $retval .= "<legend>" . __('Routine parameters') . "</legend>\n";
-            $retval .= "<table class='rte_table' style='width: 100%;'>\n";
+            $retval .= "<table class='rte_table'>\n";
         }
         $retval .= "<tr>\n";
         $retval .= "<th>" . __('Name') . "</th>\n";
diff --git a/themes/pmahomme/css/rte.css.php b/themes/pmahomme/css/rte.css.php
index f70ffe2745..04e4f38161 100644
--- a/themes/pmahomme/css/rte.css.php
+++ b/themes/pmahomme/css/rte.css.php
@@ -15,12 +15,14 @@ if (! defined('PHPMYADMIN') && ! defined('TESTSUITE')) {
 ?>
 
 .rte_table {
-    table-layout: fixed;
+    table-layout: auto;
+    width: 100%;
 }
 
 .rte_table td {
     vertical-align: middle;
     padding: 0.2em;
+    width: 20%;
 }
 
 .rte_table tr td:nth-child(1) {
@@ -48,3 +50,13 @@ if (! defined('PHPMYADMIN') && ! defined('TESTSUITE')) {
 .rte_table .routine_params_table {
     width: 100%;
 }
+.rte_table .floatleft {
+    width: 49%;
+    font-weight: bold;
+}
+.rte_table input[type=submit] {
+    width: 49%;
+}
+.isdisableremoveparam_class {
+    color: gray;
+}