gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid calculating strlen twice

Browse Source 
Signed-off-by: Michal Čihař <michal@cihar.com>
This commit is contained in:
Michal Čihař 2016-07-22 14:12:45 +02:00
parent 9106b33933
commit 024a924b38
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libraries/plugins/auth/AuthenticationCookie.php
View File

@ -664,11 +664,12 @@ class AuthenticationCookie extends AuthenticationPlugin
{
// Grab first part, up to 16 chars
// The MAC and AES secrets can overlap if original secret is short
if (strlen($secret) > 16) {
$length = strlen($secret);
if ($length > 16) {
return substr($secret, 0, 16);
}
return $this->enlargeSecret(
strlen($secret) == 1 ? $secret : substr($secret, 0, -1)
$length == 1 ? $secret : substr($secret, 0, -1)
);
}
@ -683,11 +684,12 @@ class AuthenticationCookie extends AuthenticationPlugin
{
// Grab second part, up to 16 chars
// The MAC and AES secrets can overlap if original secret is short
if (strlen($secret) > 16) {
$length = strlen($secret);
if ($length > 16) {
return substr($secret, -16);
}
return $this->enlargeSecret(
strlen($secret) == 1 ? $secret : substr($secret, 1)
$length == 1 ? $secret : substr($secret, 1)
);
}