diff --git a/ChangeLog b/ChangeLog index 2c6e859d66..c895ddb6ec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -61,6 +61,8 @@ phpMyAdmin - ChangeLog + patch #3432835 [interface] Add useful intermediate pages to pageselector + [interface] Improved index editor +3.4.9.0 (not yet released) + 3.4.8.0 (not yet released) - bug #3425230 [interface] enum data split at space char (more space to edit) - bug #3426840 [interface] ENUM/SET editor can't handle commas in values @@ -81,6 +83,11 @@ phpMyAdmin - ChangeLog - [interface] Avoid showing the password in phpinfo()'s output - bug #3441572 [GUI] 'newer version of phpMyAdmin' message not shown in IE8 - bug #3407235 [interface] Entering the key through a lookup window does not reset NULL +- [security] Self-XSS on database names (Synchronize), see PMASA-2011-18 +- [security] Self-XSS on database names (Operations/rename), see PMASA-2011-18 +- [security] Self-XSS on column type (Create index), see PMASA-2011-18 +- [security] Self-XSS on column type (table Search), see PMASA-2011-18 +- [security] Self-XSS on invalid query (table overview), see PMASA-2011-18 3.4.7.1 (2011-11-10) - [security] Fixed possible local file inclusion in XML import diff --git a/js/db_operations.js b/js/db_operations.js index 9776cefe4c..bc61679680 100644 --- a/js/db_operations.js +++ b/js/db_operations.js @@ -32,7 +32,7 @@ $(document).ready(function() { var $form = $(this); - var question = 'CREATE DATABASE ' + $('#new_db_name').val() + ' / DROP DATABASE ' + window.parent.db; + var question = escapeHtml('CREATE DATABASE ' + $('#new_db_name').val() + ' / DROP DATABASE ' + window.parent.db); PMA_prepareForAjaxRequest($form); /** diff --git a/libraries/common.lib.php b/libraries/common.lib.php index bb5c6e18f5..767e2843f7 100644 --- a/libraries/common.lib.php +++ b/libraries/common.lib.php @@ -1066,13 +1066,10 @@ function PMA_showMessage($message, $sql_query = null, $type = 'notice', $is_view } else { // Parse SQL if needed $parsed_sql = PMA_SQP_parse($query_base); - if (PMA_SQP_isError()) { - unset($parsed_sql); - } } // Analyze it - if (isset($parsed_sql)) { + if (isset($parsed_sql) && ! PMA_SQP_isError()) { $analyzed_display_query = PMA_SQP_analyze($parsed_sql); // Same as below (append LIMIT), append the remembered ORDER BY diff --git a/scripts/create-release.sh b/scripts/create-release.sh index d411a67e0e..72c74959bd 100755 --- a/scripts/create-release.sh +++ b/scripts/create-release.sh @@ -282,7 +282,7 @@ Todo now: ./scripts/upload-release \$USER $version release 4. add SF news item to phpMyAdmin project - 5. announce release on freshmeat (http://freshmeat.net/projects/phpmyadmin/) + 5. announce release on freecode (http://freecode.com/projects/phpmyadmin/) 6. send a short mail (with list of major changes) to phpmyadmin-devel@lists.sourceforge.net phpmyadmin-news@lists.sourceforge.net diff --git a/tbl_indexes.php b/tbl_indexes.php index 195568b860..bcdc59cae0 100644 --- a/tbl_indexes.php +++ b/tbl_indexes.php @@ -233,7 +233,7 @@ foreach ($index->getColumns() as $column) { ) { echo '' . "\n"; } } // end foreach $fields @@ -256,7 +256,7 @@ for ($i = 0; $i < $add_fields; $i++) { $field_type) { echo '' . "\n"; } // end foreach $fields ?> diff --git a/tbl_select.php b/tbl_select.php index 71038143aa..c888291441 100644 --- a/tbl_select.php +++ b/tbl_select.php @@ -113,7 +113,7 @@ echo PMA_generate_html_tabs(PMA_tbl_getSubTabs(), $url_params, '', 'topmenu2'); } ?> - +