From 05892fb9239b68f19366cdec50a73d0baeb797fe Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Mon, 12 May 2025 20:52:18 +0100 Subject: [PATCH] Invert 
 and 

Signed-off-by: Kamil Tekiela 
---
 public/themes/bootstrap/scss/_common.scss     | 13 ++++--------
 public/themes/metro/scss/_common.scss         | 13 ++++--------
 public/themes/original/scss/_common.scss      | 13 ++++--------
 public/themes/pmahomme/scss/_common.scss      | 13 ++++--------
 resources/js/src/modules/sql-highlight.ts     |  8 ++++----
 resources/js/src/transformations/json.ts      |  8 ++++----
 resources/js/src/transformations/xml.ts       |  8 ++++----
 src/Html/Generator.php                        | 14 ++++++-------
 .../Output/Text_Plain_Json.php                |  4 +---
 .../Transformations/Output/Text_Plain_Xml.php |  4 +---
 .../Server/PrivilegesControllerTest.php       |  6 +++---
 .../Table/FindReplaceControllerTest.php       |  8 ++++----
 .../Table/IndexRenameControllerTest.php       | 12 +++++------
 tests/unit/Html/GeneratorTest.php             | 20 ++++++++-----------
 .../TransformationPluginsTest.php             |  6 +++---
 15 files changed, 61 insertions(+), 89 deletions(-)

diff --git a/public/themes/bootstrap/scss/_common.scss b/public/themes/bootstrap/scss/_common.scss
index 68dc6a7cce..59b371b8e3 100644
--- a/public/themes/bootstrap/scss/_common.scss
+++ b/public/themes/bootstrap/scss/_common.scss
@@ -1225,15 +1225,6 @@ input#auto_increment_opt {
     position: static;
   }
 
-  tbody td span {
-    display: block;
-    overflow: hidden;
-
-    code span {
-      display: inline;
-    }
-  }
-
   th.draggable {
     span {
       margin-right: 10px;
@@ -2400,3 +2391,7 @@ body .ui-dialog {
 .table-responsive-md .data {
   z-index: 9;
 }
+
+pre {
+  margin: 0;
+}
diff --git a/public/themes/metro/scss/_common.scss b/public/themes/metro/scss/_common.scss
index 61977561e0..5931e80b5c 100644
--- a/public/themes/metro/scss/_common.scss
+++ b/public/themes/metro/scss/_common.scss
@@ -1489,15 +1489,6 @@ input#auto_increment_opt {
   td {
     position: static;
   }
-
-  tbody td span {
-    display: block;
-    overflow: hidden;
-
-    code span {
-      display: inline;
-    }
-  }
 }
 
 .modal-copy input {
@@ -2577,3 +2568,7 @@ body {
 .table-responsive-md .data {
   z-index: 9;
 }
+
+pre {
+  margin: 0;
+}
diff --git a/public/themes/original/scss/_common.scss b/public/themes/original/scss/_common.scss
index 3be7de1598..7df89161dd 100644
--- a/public/themes/original/scss/_common.scss
+++ b/public/themes/original/scss/_common.scss
@@ -1229,15 +1229,6 @@ input#auto_increment_opt {
   td {
     position: static;
   }
-
-  tbody td span {
-    display: block;
-    overflow: hidden;
-
-    code span {
-      display: inline;
-    }
-  }
 }
 
 .modal-copy input {
@@ -2402,3 +2393,7 @@ body {
 .table-responsive-md .data {
   z-index: 9;
 }
+
+pre {
+  margin: 0;
+}
diff --git a/public/themes/pmahomme/scss/_common.scss b/public/themes/pmahomme/scss/_common.scss
index 65b2890cbe..f40decf86a 100644
--- a/public/themes/pmahomme/scss/_common.scss
+++ b/public/themes/pmahomme/scss/_common.scss
@@ -1432,15 +1432,6 @@ input#auto_increment_opt {
     position: static;
   }
 
-  tbody td span {
-    display: block;
-    overflow: hidden;
-
-    code span {
-      display: inline;
-    }
-  }
-
   th.draggable {
     span {
       margin-right: 10px;
@@ -2553,3 +2544,7 @@ body .ui-dialog {
 .bg-secondary {
   color: #333;
 }
+
+pre {
+  margin: 0;
+}
diff --git a/resources/js/src/modules/sql-highlight.ts b/resources/js/src/modules/sql-highlight.ts
index eb085e7da0..92cc0b21ad 100644
--- a/resources/js/src/modules/sql-highlight.ts
+++ b/resources/js/src/modules/sql-highlight.ts
@@ -459,15 +459,15 @@ export default function highlightSql ($base) {
     var $elm = $base.find('code.sql');
     $elm.each(function () {
         var $sql = $(this);
-        var $pre = $sql.find('pre');
+        var $pre = $sql.closest('pre');
         /* We only care about visible elements to avoid double processing */
-        if ($pre.is(':visible')) {
+        if ($sql.is(':visible')) {
             var $highlight = $('
');
-            $sql.append($highlight);
+            $pre.append($highlight);
             if (typeof window.CodeMirror !== 'undefined') {
                 // @ts-ignore
                 window.CodeMirror.runMode($sql.text(), 'text/x-mysql', $highlight[0]);
-                $pre.hide();
+                $sql.hide();
                 $highlight.find('.cm-keyword').each(documentationKeyword);
                 $highlight.find('.cm-builtin').each(documentationBuiltin);
             }
diff --git a/resources/js/src/transformations/json.ts b/resources/js/src/transformations/json.ts
index 8c18dbe56b..e2df1dbf59 100644
--- a/resources/js/src/transformations/json.ts
+++ b/resources/js/src/transformations/json.ts
@@ -8,14 +8,14 @@ AJAX.registerOnload('transformations/json.js', function () {
     var $elm = $('#page_content').find('code.json');
     $elm.each(function () {
         var $json = $(this);
-        var $pre = $json.find('pre');
+        var $pre = $json.closest('pre');
         /* We only care about visible elements to avoid double processing */
-        if ($pre.is(':visible')) {
+        if ($json.is(':visible')) {
             var $highlight = $('
');
-            $json.append($highlight);
+            $pre.append($highlight);
             // @ts-ignore
             window.CodeMirror.runMode($json.text(), 'application/json', $highlight[0]);
-            $pre.hide();
+            $json.hide();
         }
     });
 });
diff --git a/resources/js/src/transformations/xml.ts b/resources/js/src/transformations/xml.ts
index c19ab11205..627fd9deb0 100644
--- a/resources/js/src/transformations/xml.ts
+++ b/resources/js/src/transformations/xml.ts
@@ -8,14 +8,14 @@ AJAX.registerOnload('transformations/xml.js', function () {
     var $elm = $('#page_content').find('code.xml');
     $elm.each(function () {
         var $json = $(this);
-        var $pre = $json.find('pre');
+        var $pre = $json.closest('pre');
         /* We only care about visible elements to avoid double processing */
-        if ($pre.is(':visible')) {
+        if ($json.is(':visible')) {
             var $highlight = $('
');
-            $json.append($highlight);
+            $pre.append($highlight);
             // @ts-ignore
             window.CodeMirror.runMode($json.text(), 'application/xml', $highlight[0]);
-            $pre.hide();
+            $json.hide();
         }
     });
 });
diff --git a/src/Html/Generator.php b/src/Html/Generator.php
index e8a7a89be3..d4b1dc3a0c 100644
--- a/src/Html/Generator.php
+++ b/src/Html/Generator.php
@@ -450,12 +450,12 @@ class Generator
         /* SQL-Parser-Analyzer */
 
         if (Sql::$showAsPhp === true) {
-            $newLine = '\\n"
' . "\n" . '    . "';
+            $newLine = '\\n"' . "\n" . '    . "';
             $queryBase = htmlspecialchars(addslashes($sqlQuery));
             $queryBase = preg_replace('/((\015\012)|(\015)|(\012))/', $newLine, $queryBase);
-            $queryBase = '
' . "\n"
-                . '$sql = "' . $queryBase . '";' . "\n"
-                . '
';
+            $queryBase = '
'
+                . '$sql = "' . $queryBase . '";'
+                . '
';
         } else {
             $queryBase = self::formatSql($sqlQuery, true);
         }
@@ -1072,9 +1072,9 @@ class Generator
             $sqlQuery = mb_substr($sqlQuery, 0, $config->settings['MaxCharactersInDisplayedSQL']) . '[...]';
         }
 
-        return '
' . "\n"
-            . htmlspecialchars($sqlQuery, ENT_COMPAT) . "\n"
-            . '
';
+        return '
'
+            . htmlspecialchars($sqlQuery, ENT_COMPAT)
+            . '
';
     }
 
     /**
diff --git a/src/Plugins/Transformations/Output/Text_Plain_Json.php b/src/Plugins/Transformations/Output/Text_Plain_Json.php
index f0ac9af633..73506f2aa6 100644
--- a/src/Plugins/Transformations/Output/Text_Plain_Json.php
+++ b/src/Plugins/Transformations/Output/Text_Plain_Json.php
@@ -52,9 +52,7 @@ class Text_Plain_Json extends TransformationsPlugin
      */
     public function applyTransformation(string $buffer, array $options = [], FieldMetadata|null $meta = null): string
     {
-        return '
' . "\n"
-        . htmlspecialchars($buffer) . "\n"
-        . '
';
+        return '
' . htmlspecialchars($buffer) . '
';
     }
 
     /* ~~~~~~~~~~~~~~~~~~~~ Getters and Setters ~~~~~~~~~~~~~~~~~~~~ */
diff --git a/src/Plugins/Transformations/Output/Text_Plain_Xml.php b/src/Plugins/Transformations/Output/Text_Plain_Xml.php
index b44c917246..ac4b6d69e1 100644
--- a/src/Plugins/Transformations/Output/Text_Plain_Xml.php
+++ b/src/Plugins/Transformations/Output/Text_Plain_Xml.php
@@ -52,9 +52,7 @@ class Text_Plain_Xml extends TransformationsPlugin
      */
     public function applyTransformation(string $buffer, array $options = [], FieldMetadata|null $meta = null): string
     {
-        return '
' . "\n"
-        . htmlspecialchars($buffer) . "\n"
-        . '
';
+        return '
' . htmlspecialchars($buffer) . '
';
     }
 
     /* ~~~~~~~~~~~~~~~~~~~~ Getters and Setters ~~~~~~~~~~~~~~~~~~~~ */
diff --git a/tests/unit/Controllers/Server/PrivilegesControllerTest.php b/tests/unit/Controllers/Server/PrivilegesControllerTest.php
index 787dfdad77..c1884cb30c 100644
--- a/tests/unit/Controllers/Server/PrivilegesControllerTest.php
+++ b/tests/unit/Controllers/Server/PrivilegesControllerTest.php
@@ -148,10 +148,10 @@ class PrivilegesControllerTest extends AbstractTestCase
         self::assertStringContainsString("You have updated the privileges for 'pma_test'@'localhost'.", $output);
 
         // phpcs:disable Generic.Files.LineLength.TooLong
-        $expectedSql = '
' . "\n"
+        $expectedSql = '
'
             . "REVOKE ALL PRIVILEGES ON  `test_db_1`.* FROM 'pma_test'@'localhost'; REVOKE GRANT OPTION ON  `test_db_1`.* FROM 'pma_test'@'localhost'; GRANT SELECT ON  `test_db_1`.* TO 'pma_test'@'localhost'; \n"
-            . "REVOKE ALL PRIVILEGES ON  `test_db_2`.* FROM 'pma_test'@'localhost'; REVOKE GRANT OPTION ON  `test_db_2`.* FROM 'pma_test'@'localhost'; GRANT SELECT ON  `test_db_2`.* TO 'pma_test'@'localhost'; \n"
-            . '
';
+            . "REVOKE ALL PRIVILEGES ON  `test_db_2`.* FROM 'pma_test'@'localhost'; REVOKE GRANT OPTION ON  `test_db_2`.* FROM 'pma_test'@'localhost'; GRANT SELECT ON  `test_db_2`.* TO 'pma_test'@'localhost'; "
+            . '
';
         // phpcs:enable
         self::assertStringContainsString($expectedSql, $output);
 
diff --git a/tests/unit/Controllers/Table/FindReplaceControllerTest.php b/tests/unit/Controllers/Table/FindReplaceControllerTest.php
index 8ba1840dfa..ff55100254 100644
--- a/tests/unit/Controllers/Table/FindReplaceControllerTest.php
+++ b/tests/unit/Controllers/Table/FindReplaceControllerTest.php
@@ -54,10 +54,10 @@ final class FindReplaceControllerTest extends AbstractTestCase
         $controller($request);
 
         self::assertStringContainsString(
-            '
' . "\n"
+            '
'
             . 'UPDATE `test_table` SET `id` = REPLACE(`id`, \'Field\', \'Column\')'
             . ' WHERE `id` LIKE \'%Field%\' COLLATE utf8mb4_bin'
-            . "\n" . '
',
+            . '
',
             $responseRenderer->getHTMLResult(),
         );
         self::assertSame([], $responseRenderer->getJSONResult());
@@ -102,9 +102,9 @@ final class FindReplaceControllerTest extends AbstractTestCase
         $controller($request);
 
         self::assertStringContainsString(
-            '
' . "\n"
+            '
'
             . 'UPDATE `test_table` SET `id` = `id` WHERE `id` RLIKE \'Field\' COLLATE utf8mb4_bin'
-            . "\n" . '
',
+            . '
',
             $responseRenderer->getHTMLResult(),
         );
         self::assertSame([], $responseRenderer->getJSONResult());
diff --git a/tests/unit/Controllers/Table/IndexRenameControllerTest.php b/tests/unit/Controllers/Table/IndexRenameControllerTest.php
index 75979fa77c..eb11abe0e7 100644
--- a/tests/unit/Controllers/Table/IndexRenameControllerTest.php
+++ b/tests/unit/Controllers/Table/IndexRenameControllerTest.php
@@ -87,14 +87,14 @@ class IndexRenameControllerTest extends AbstractTestCase
         $dbi->setVersion(['@@version' => '5.5.0']);
         DatabaseInterface::$instance = $dbi;
 
+        // phpcs:disable Generic.Files.LineLength.TooLong
         $expected = <<<'HTML'
-

-            
-ALTER TABLE `test_db`.`test_table_index_rename` DROP INDEX `old_name`, ADD INDEX `new_name` (`name`) USING BTREE;
-

-    

+        

+                    
ALTER TABLE `test_db`.`test_table_index_rename` DROP INDEX `old_name`, ADD INDEX `new_name` (`name`) USING BTREE;

+            

 
-HTML;
+        HTML;
+        // phpcs:enable
 
         $request = ServerRequestFactory::create()->createServerRequest('GET', 'http://example.com/')
             ->withQueryParams(['db' => 'test_db', 'table' => 'test_table_index_rename'])
diff --git a/tests/unit/Html/GeneratorTest.php b/tests/unit/Html/GeneratorTest.php
index c111669a20..10bd74e4e2 100644
--- a/tests/unit/Html/GeneratorTest.php
+++ b/tests/unit/Html/GeneratorTest.php
@@ -277,18 +277,18 @@ class GeneratorTest extends AbstractTestCase
     public function testFormatSql(): void
     {
         self::assertSame(
-            '
' . "\n"
-            . 'SELECT 1 < 2' . "\n"
-            . '
',
+            '
'
+            . 'SELECT 1 < 2'
+            . '
',
             Generator::formatSql('SELECT 1 < 2'),
         );
 
         Config::getInstance()->settings['MaxCharactersInDisplayedSQL'] = 6;
 
         self::assertSame(
-            '
' . "\n"
-            . 'SELECT[...]' . "\n"
-            . '
',
+            '
'
+            . 'SELECT[...]'
+            . '
',
             Generator::formatSql('SELECT 1 < 2', true),
         );
     }
@@ -486,9 +486,7 @@ class GeneratorTest extends AbstractTestCase
 
-
-SELECT 1;
-

+
SELECT 1;

 

 

 

@@ -535,9 +533,7 @@ HTML;
 
-
-$sql = "EXPLAIN SELECT 1;";
-

+
$sql = "EXPLAIN SELECT 1;";

 

 

 

diff --git a/tests/unit/Plugins/Transformations/TransformationPluginsTest.php b/tests/unit/Plugins/Transformations/TransformationPluginsTest.php
index 161cb0ec6c..c0cc69a21a 100644
--- a/tests/unit/Plugins/Transformations/TransformationPluginsTest.php
+++ b/tests/unit/Plugins/Transformations/TransformationPluginsTest.php
@@ -564,9 +564,9 @@ class TransformationPluginsTest extends AbstractTestCase
             [
                 new Text_Plain_Sql(),
                 ['select *', ['option1', 'option2']],
-                '
' . "\n"
-                . 'select *' . "\n"
-                . '
',
+                '
'
+                . 'select *'
+                . '
',
             ],
             [new Text_Plain_Link(), ['PMA_TXT_LINK', ['./php/', 'text_name']], './php/PMA_TXT_LINK'],
             [new Text_Plain_Link(), ['PMA_TXT_LINK', []], 'PMA_TXT_LINK'],