diff --git a/ChangeLog b/ChangeLog index be0bb618b5..5cd6864a02 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ phpMyAdmin - ChangeLog ====================== 4.2.0.0 (not yet released) ++ rfe #1662 Add table comment tool tip in database structure page + rfe #1447 Single table for display Character Sets and Collations + rfe #1455 Display icons/text/both for the table row actions + rfe #1473 Transformation to convert Boolean value to text @@ -15,6 +16,8 @@ phpMyAdmin - ChangeLog 4.1.4.0 (not yet released) - bug #3840 (additional fix) When exporting to gzip format, the data is compressed 2 times +- bug #4209 Missing compression in one case +- bug #4208 Can't browse tables after sorting on columns with fieldnames that have a '-' 4.1.3.0 (2013-12-31) - bug #3938 PDFDefaultPageSize doc and easy configurability diff --git a/libraries/config/ServerConfigChecks.class.php b/libraries/config/ServerConfigChecks.class.php index 7d3486b0c1..2fc1240617 100644 --- a/libraries/config/ServerConfigChecks.class.php +++ b/libraries/config/ServerConfigChecks.class.php @@ -140,8 +140,10 @@ class ServerConfigChecks $cookieAuthUsed, $blowfishSecret, $sServerAuthCfgMsg, $sSecurityInfoMsg, $blowfishSecretSet ) { - for ($i = 1, $serverCnt = $this->cfg->getServerCount(); $i <= $serverCnt; $i++) { - $cookieAuthServer = ($this->cfg->getValue("Servers/$i/auth_type") == 'cookie'); + $serverCnt = $this->cfg->getServerCount(); + for ($i = 1; $i <= $serverCnt; $i++) { + $cookieAuthServer + = ($this->cfg->getValue("Servers/$i/auth_type") == 'cookie'); $cookieAuthUsed |= $cookieAuthServer; $serverName = $this->performConfigChecksServersGetServerName( $this->cfg->getServerName($i), $i @@ -472,7 +474,8 @@ class ServerConfigChecks // $cfg['LoginCookieValidity'] // value greater than session.gc_maxlifetime will cause // random session invalidation after that time - if ($this->cfg->getValue('LoginCookieValidity') > ini_get('session.gc_maxlifetime') + $loginCookieValidity = $this->cfg->getValue('LoginCookieValidity'); + if ($loginCookieValidity > ini_get('session.gc_maxlifetime') ) { PMA_messagesSet( 'error', @@ -486,7 +489,7 @@ class ServerConfigChecks // $cfg['LoginCookieValidity'] // should be at most 1800 (30 min) // - if ($this->cfg->getValue('LoginCookieValidity') > 1800) { + if ($loginCookieValidity > 1800) { PMA_messagesSet( 'notice', 'LoginCookieValidity', @@ -500,8 +503,8 @@ class ServerConfigChecks // $cfg['LoginCookieStore'] // LoginCookieValidity must be less or equal to LoginCookieStore // - if ($this->cfg->getValue('LoginCookieStore') != 0 - && $this->cfg->getValue('LoginCookieValidity') > $this->cfg->getValue('LoginCookieStore') + if (($this->cfg->getValue('LoginCookieStore') != 0) + && ($loginCookieValidity > $this->cfg->getValue('LoginCookieStore')) ) { PMA_messagesSet( 'error', diff --git a/libraries/export.lib.php b/libraries/export.lib.php index 9c6cf0502a..ad2765a0c6 100644 --- a/libraries/export.lib.php +++ b/libraries/export.lib.php @@ -45,9 +45,17 @@ function PMA_isGzHandlerEnabled() */ function PMA_gzencodeNeeded() { + /* + * We should gzencode only if the function exists + * but we don't want to compress twice, therefore + * gzencode only if transparent compression is not enabled + * and gz compression was not asked via $cfg['OBGzip'] + * but transparent compression does not apply when saving to server + */ if (@function_exists('gzencode') - && ! @ini_get('zlib.output_compression') - && ! PMA_isGzHandlerEnabled() + && ((! @ini_get('zlib.output_compression') + && ! PMA_isGzHandlerEnabled()) + || $GLOBALS['save_on_server']) ) { return true; } else { diff --git a/libraries/pmd_common.php b/libraries/pmd_common.php index 82b49c3bbc..8538fbb48c 100644 --- a/libraries/pmd_common.php +++ b/libraries/pmd_common.php @@ -180,9 +180,9 @@ function PMA_getScriptContr() * * @return array unique or primary indices */ -function get_pk_or_unique_keys() +function PMA_getPKOrUniqueKeys() { - return get_all_keys(true); + return PMA_getAllKeys(true); } /** @@ -192,7 +192,7 @@ function get_pk_or_unique_keys() * * @return array indices */ -function get_all_keys($unique_only = false) +function PMA_getAllKeys($unique_only = false) { include_once './libraries/Index.class.php'; @@ -219,7 +219,7 @@ function get_all_keys($unique_only = false) * * @return string */ -function get_script_tabs() +function PMA_getScriptTabs() { $retval = array( 'j_tabs' => array(), @@ -242,7 +242,7 @@ function get_script_tabs() * * @return array table positions and sizes */ -function get_tab_pos() +function PMA_getTabPos() { $cfgRelation = PMA_getRelationsParam(); @@ -276,7 +276,7 @@ function get_tab_pos() * * @return void */ -function PMD_Return_upd($b, $ret) +function PMA_returnUpd($b, $ret) { // not sure where this was defined... global $K; diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php index 94530e3f6b..fdfb23a357 100644 --- a/libraries/server_privileges.lib.php +++ b/libraries/server_privileges.lib.php @@ -411,7 +411,7 @@ function PMA_getGrantsArray() * * @return string $html_output html snippet */ -function PMA_getHtmlForDisplayColumnPrivileges($columns, $row, $name_for_select, +function PMA_getHtmlForColumnPrivileges($columns, $row, $name_for_select, $priv_for_header, $name, $name_for_dfn, $name_for_current ) { $html_output = '