From 0d88fe08d696c8680b86003b1537688d7c73b29e Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 14:51:19 +0200 Subject: [PATCH 1/2] Detect Chrome browser version --- libraries/Config.class.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/Config.class.php b/libraries/Config.class.php index 8d0275ac06..0242b2c41b 100644 --- a/libraries/Config.class.php +++ b/libraries/Config.class.php @@ -216,9 +216,9 @@ class PMA_Config '@Mozilla/([0-9].[0-9]{1,2})@', $HTTP_USER_AGENT, $log_version) - && preg_match('@Chrome/([0-9]*)@', $HTTP_USER_AGENT, $log_version2) + && preg_match('@Chrome/([0-9.]*)@', $HTTP_USER_AGENT, $log_version2) ) { - $this->set('PMA_USR_BROWSER_VER', $log_version[1] . '.' . $log_version2[1]); + $this->set('PMA_USR_BROWSER_VER', $log_version2[1]); $this->set('PMA_USR_BROWSER_AGENT', 'CHROME'); // newer Safari } elseif (preg_match( From c3e8a8cc44dc74ab323671a8185824cf462e8352 Mon Sep 17 00:00:00 2001 From: "J.M" Date: Mon, 8 Apr 2013 14:52:18 +0200 Subject: [PATCH 2/2] Add tests for IE9, IE10, IE11, Chrome --- test/classes/PMA_Config_test.php | 38 ++++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/test/classes/PMA_Config_test.php b/test/classes/PMA_Config_test.php index 0c84255038..c73343e678 100644 --- a/test/classes/PMA_Config_test.php +++ b/test/classes/PMA_Config_test.php @@ -127,6 +127,30 @@ class PMA_ConfigTest extends PHPUnit_Framework_TestCase 'IE', '8.0', ), + array( + 'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)', + 'Win', + 'IE', + '9.0', + ), + array( + 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Win64; x64; Trident/6.0)', + 'Win', + 'IE', + '10.0', + ), + array( + 'Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko', + 'Win', + 'IE', + '11.0', + ), + array( + 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.22 (KHTML, like Gecko) Chrome/25.0.1364.172 Safari/537.22', + 'Win', + 'CHROME', + '25.0.1364.172', + ), array( 'Mozilla/5.0 (Unknown; U; Unix BSD/SYSV system; C -) AppleWebKit/527+ (KHTML, like Gecko, Safari/419.3) Arora/0.10.2', 'Unix', @@ -147,18 +171,18 @@ class PMA_ConfigTest extends PHPUnit_Framework_TestCase array( 'Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0', 'Linux', - 'MOZILLA', + 'FIREFOX', '5.0', ), + array( + 'Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0', + 'Linux', + 'FIREFOX', + '12.0', + ), /** * @todo Is this version really expected? */ - array( - 'Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0', - 'Linux', - 'MOZILLA', - '5.0', - ), array( 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.4+ (KHTML, like Gecko) Version/5.0 Safari/535.4+ SUSE/12.1 (3.2.1) Epiphany/3.2.1', 'Linux',