gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tests by using mock objects of DatabaseInterface

Browse Source
This commit is contained in:
Madhura Jayaratne 2013-05-24 17:41:59 +05:30
parent 650a8cdda3
commit 098048627d
1 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
test/classes/navigation/PMA_Node_test.php
View File

@ -304,16 +304,18 @@ class Node_Test extends PHPUnit_Framework_TestCase
// It would have been better to mock _getWhereClause method
// but stangely, mocking private methods is not supported in PHPUnit
$node = PMA_NodeFactory::getInstance();
$origDbExt = $GLOBALS['extension'];
$origDbi = $GLOBALS['dbi'];
$dbExt = $this->getMock('PMA_DBI_Dummy');
$dbExt->expects($this->once())
->method('realQuery')
$dbi = $this->getMockBuilder('PMA_DatabaseInterface')
->disableOriginalConstructor()
->getMock();
$dbi->expects($this->once())
->method('fetchResult')
->with($expectedSql);
$GLOBALS['extension'] = $dbExt;
$GLOBALS['dbi'] = $dbi;
$node->getData('', $pos);
$GLOBALS['extension'] = $origDbExt;
$GLOBALS['dbi'] = $origDbi;
}
/**
@ -342,16 +344,18 @@ class Node_Test extends PHPUnit_Framework_TestCase
// It would have been better to mock _getWhereClause method
// but stangely, mocking private methods is not supported in PHPUnit
$node = PMA_NodeFactory::getInstance();
$origDbExt = $GLOBALS['extension'];
$origDbi = $GLOBALS['dbi'];
$dbExt = $this->getMock('PMA_DBI_Dummy');
$dbExt->expects($this->once())
->method('realQuery')
$dbi = $this->getMockBuilder('PMA_DatabaseInterface')
->disableOriginalConstructor()
->getMock();
$dbi->expects($this->once())
->method('fetchValue')
->with($query);
$GLOBALS['extension'] = $dbExt;
$GLOBALS['dbi'] = $dbi;
$node->getPresence();
$GLOBALS['extension'] = $origDbExt;
$GLOBALS['dbi'] = $origDbi;
}
/**
@ -374,25 +378,29 @@ class Node_Test extends PHPUnit_Framework_TestCase
$GLOBALS['cfg']['Servers'][0]['DisableIS'] = true;
$node = PMA_NodeFactory::getInstance();
$origDbExt = $GLOBALS['extension'];
$origDbi = $GLOBALS['dbi'];
// test with no search clause
$dbExt = $this->getMock('PMA_DBI_Dummy');
$dbExt->expects($this->once())
->method('realQuery')
$dbi = $this->getMockBuilder('PMA_DatabaseInterface')
->disableOriginalConstructor()
->getMock();
$dbi->expects($this->once())
->method('tryQuery')
->with("SHOW DATABASES ");
$GLOBALS['extension'] = $dbExt;
$GLOBALS['dbi'] = $dbi;
$node->getPresence();
// test with a search clause
$dbExt = $this->getMock('PMA_DBI_Dummy');
$dbExt->expects($this->once())
->method('realQuery')
$dbi = $this->getMockBuilder('PMA_DatabaseInterface')
->disableOriginalConstructor()
->getMock();
$dbi->expects($this->once())
->method('tryQuery')
->with("SHOW DATABASES LIKE '%dbname%' ");
$GLOBALS['extension'] = $dbExt;
$GLOBALS['dbi'] = $dbi;
$node->getPresence('', 'dbname');
$GLOBALS['extension'] = $origDbExt;
$GLOBALS['dbi'] = $origDbi;
}
public function testComment()