bug #4488 [security] XSS injection due to unescaped table name (triggers)

Signed-off-by: Marc Delisle <marc@infomarc.info>
This commit is contained in:
Madhura Jayaratne 2014-07-11 06:39:20 -04:00 committed by Marc Delisle
parent 57475371a5
commit 10014d4dc5
2 changed files with 4 additions and 3 deletions

View File

@ -12,6 +12,7 @@ phpMyAdmin - ChangeLog
- bug #4440 Javascript error when renaming table
- bug #4483 'New window' link (selflink) disappears, causing Javascript error
- bug #4486 [security] XSS injection due to unescaped table comment
- bug #4488 [security] XSS injection due to unescaped table name (triggers)
4.2.5.0 (2014-06-26)
- bug #4467 shell_exec() has been disabled for security reasons

View File

@ -259,9 +259,9 @@ function PMA_TRI_getRowForList($trigger, $rowclass = '')
$retval .= " </td>\n";
if (empty($table)) {
$retval .= " <td>\n";
$retval .= " <a href='db_triggers.php?{$url_query}"
. "&amp;table={$trigger['table']}'>"
. $trigger['table'] . "</a>\n";
$retval .= "<a href='db_triggers.php?{$url_query}"
. "&amp;table=" . urlencode($trigger['table']) . "'>"
. urlencode($trigger['table']) . "</a>";
$retval .= " </td>\n";
}
$retval .= " <td>\n";