From 40d9d82840490d06fcdbf5c594cd43ea7c32f5fc Mon Sep 17 00:00:00 2001 From: Sudheesh Singanamalla Date: Tue, 6 Sep 2016 15:28:38 +0530 Subject: [PATCH 1/2] Fixes #12470 Stores tab_id hash into a variable instead of location.hash Signed-off-by: Sudheesh Singanamalla --- js/config.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/config.js b/js/config.js index 6630dd6c7c..d3d0c5f840 100644 --- a/js/config.js +++ b/js/config.js @@ -588,8 +588,9 @@ function setTab(tab_id) } $this.find('li').removeClass('active').find('a[href=#' + tab_id + ']').parent().addClass('active'); $this.parent().find('div.tabs_contents fieldset').hide().filter('#' + tab_id).show(); - location.hash = 'tab_' + tab_id; - $this.parent().find('input[name=tab_hash]').val(location.hash); + var hashValue = 'tab_' + tab_id; + location.hash = hashValue; + $this.parent().find('input[name=tab_hash]').val(hashValue); }); } From f3cd949738c49cc58315452bb218d443fd96c535 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= Date: Tue, 6 Sep 2016 12:45:25 +0200 Subject: [PATCH 2/2] Changelog for issue #12470 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix possible race condition in setting URL hash Signed-off-by: Michal Čihař --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index d1b8e73d61..6703664aec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -23,6 +23,7 @@ phpMyAdmin - ChangeLog - issue #12405 Use single quotes in PHP code - issue #12534 Option for the dropped column is not removed from 'after_field' select, after the column is dropped - issue #12531 Properly detect DROP DATABASE queries +- issue #12470 Fix possible race condition in setting URL hash 4.6.4 (2016-08-16) - issue [security] Weaknesses with cookie encryption, see PMASA-2016-29