gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #13079 from manishbisht/remove-inline-javascript

Browse Source 
Removed inline onmousedown javascript
This commit is contained in:
Michal Čihař 2017-03-16 15:15:33 +01:00 committed by GitHub
commit 17335236cf
4 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/pmd/move.js
View File

@ -132,6 +132,20 @@ function MouseDown(e)
{
Glob_X = dx = isIE ? e.clientX + document.body.scrollLeft : e.pageX;
Glob_Y = dy = isIE ? e.clientY + document.body.scrollTop : e.pageY;
if (e.target.tagName == "SPAN") {
cur_click = e.target.parentNode.parentNode.parentNode.parentNode;
}
else if (e.target.className == "tab_zag_2") {
cur_click = e.target.parentNode.parentNode.parentNode;
}
else if (e.target.className == "icon") {
layer_menu_cur_click = 1;
}
else if (e.target.className == "M_butt") {
return false;
}
if (cur_click !== null) {
document.getElementById("canvas").style.display = 'none';
cur_click.style.zIndex = 2;

4
templates/database/designer/database_tables.phtml
View File

@ -38,7 +38,6 @@
</td>
<td id="id_zag_<?= htmlspecialchars($t_n_url); ?>"
class="tab_zag nowrap tab_zag_noquery"
onmousedown="cur_click=document.getElementById('<?= $t_n_url; ?>');"
table_name="<?= htmlspecialchars($t_n_url); ?>"
query_set="<?= isset($_REQUEST['query']) ? 1 : 0 ; ?>" >
<span class="owner">
@ -49,8 +48,7 @@
<?php if (isset($_REQUEST['query'])) : ?>
<td class="tab_zag tab_zag_query"
id="id_zag_<?= htmlspecialchars($t_n_url); ?>_2"
table_name="<?= htmlspecialchars($t_n_url); ?>"
onmousedown="cur_click=document.getElementById('<?= htmlspecialchars($t_n_url); ?>');">
table_name="<?= htmlspecialchars($t_n_url); ?>">
</td>
<?php endif; ?>
</tr>

1
templates/database/designer/side_menu.phtml
View File

@ -160,7 +160,6 @@ function getImg($path)
<a class="M_butt"
href="#"
onclick="build_query('SQL Query on Database', 0)"
onmousedown="return false;"
class="M_butt">
<img title="<?= __('Build Query'); ?>"
src="<?= getImg('pmd/query_builder.png'); ?>" />

2
templates/database/designer/table_list.phtml
View File

@ -54,7 +54,7 @@
<div class="center">
<?= __('Number of tables:'); ?> <?= $name_cnt; ?>
</div>
<div id="layer_menu_sizer" onmousedown="layer_menu_cur_click=1">
<div id="layer_menu_sizer">
<div class="floatleft">
<img class="icon"
data-right="<?= $_SESSION['PMA_Theme']->getImgPath('pmd/resizeright.png'); ?>"