diff --git a/db_tracking.php b/db_tracking.php index df1106e83b..29d8cc85b1 100644 --- a/db_tracking.php +++ b/db_tracking.php @@ -67,9 +67,9 @@ require_once './libraries/db_links.inc.php'; $all_tables_query = ' SELECT table_name, MAX(version) as version FROM ' . PMA_backquote($GLOBALS['cfg']['Server']['pmadb']) . '.' . PMA_backquote($GLOBALS['cfg']['Server']['tracking']) . - ' WHERE ' . PMA_backquote('db_name') . ' = \'' . PMA_sqlAddSlashes($_REQUEST['db']) . '\' ' . - ' GROUP BY '. PMA_backquote('table_name') . - ' ORDER BY '. PMA_backquote('table_name') .' ASC'; + ' WHERE db_name = \'' . PMA_sqlAddSlashes($_REQUEST['db']) . '\' ' . + ' GROUP BY table_name' . + ' ORDER BY table_name ASC'; $all_tables_result = PMA_query_as_controluser($all_tables_query); diff --git a/js/functions.js b/js/functions.js index ee83b8acfd..d1c554436c 100644 --- a/js/functions.js +++ b/js/functions.js @@ -902,26 +902,6 @@ function goToUrl(selObj, goToLocation) eval("document.location.href = '" + goToLocation + "pos=" + selObj.options[selObj.selectedIndex].value + "'"); } -/** - * getElement - */ -function getElement(e,f) -{ - if(document.layers){ - f=(f)?f:self; - if(f.document.layers[e]) { - return f.document.layers[e]; - } - for(W=0;W TableDragInit(); } function TableDragInit() { - myid = getElement('pdflayout'); + myid = $('#pdflayout')[0]; } @@ -683,9 +684,9 @@ class PMA_User_Schema */ $master_tables = 'SELECT COUNT(master_table), master_table' . ' FROM ' . PMA_backquote($GLOBALS['cfgRelation']['db']) . '.' . PMA_backquote($cfgRelation['relation']) - . ' WHERE master_db = \'' . $db . '\'' + . ' WHERE master_db = \'' . PMA_sqlAddSlashes($db) . '\'' . ' GROUP BY master_table' - . ' ORDER BY ' . PMA_backquote('COUNT(master_table)') . ' DESC '; + . ' ORDER BY COUNT(master_table) DESC'; $master_tables_rs = PMA_query_as_controluser($master_tables, false, PMA_DBI_QUERY_STORE); if ($master_tables_rs && PMA_DBI_num_rows($master_tables_rs) > 0) { /* first put all the master tables at beginning diff --git a/po/de.po b/po/de.po index 822ed74348..b1bd55893e 100644 --- a/po/de.po +++ b/po/de.po @@ -12907,18 +12907,6 @@ msgid "concurrent_insert is set to 0" msgstr "" #, fuzzy -#~| msgid "" -#~| "The Advisor system can provide recommendations on server variables by " -#~| "analyzing the server status variables. \n" -#~| " Do note however that this system provides recommendations based " -#~| "on fairly simple calculations and by rule of thumb and \n" -#~| " may not necessarily work for your system.\n" -#~| " Prior to changing any of the configuration, be sure to know what " -#~| "you are changing and how to undo the change. Wrong tuning\n" -#~| " can have a very negative effect on performance.\n" -#~| " The best way to tune the system would be to change only one " -#~| "setting at a time, observe or benchmark your database, and \n" -#~| " undo the change if there was no clearly measurable improvement." #~ msgid "" #~ "The Advisor system can provide recommendations on server variables by " #~ "analyzing the server status variables.

Do note however that this " diff --git a/po/es.po b/po/es.po index d45f9bd820..ba4b090bec 100644 --- a/po/es.po +++ b/po/es.po @@ -12960,18 +12960,6 @@ msgid "concurrent_insert is set to 0" msgstr "" #, fuzzy -#~| msgid "" -#~| "The Advisor system can provide recommendations on server variables by " -#~| "analyzing the server status variables.\n" -#~| " Do note however that this system provides recommendations based " -#~| "on fairly simple calculations and by rule of thumb and\n" -#~| " may not necessarily work for your system.\n" -#~| " Prior to changing any of the configuration, be sure to know what " -#~| "you are changing and how to undo the change. Wrong tuning\n" -#~| " can have a very negative effect on performance.\n" -#~| " The best way to tune the system would be to change only one " -#~| "setting at a time, observe or benchmark your database, and\n" -#~| " undo the change if there was no clearly measurable improvement." #~ msgid "" #~ "The Advisor system can provide recommendations on server variables by " #~ "analyzing the server status variables.

Do note however that this " diff --git a/po/zh_CN.po b/po/zh_CN.po index d8ee9f605f..4902bd6b5a 100644 --- a/po/zh_CN.po +++ b/po/zh_CN.po @@ -12325,18 +12325,6 @@ msgid "concurrent_insert is set to 0" msgstr "" #, fuzzy -#~| msgid "" -#~| "The Advisor system can provide recommendations on server variables by " -#~| "analyzing the server status variables.\n" -#~| " Do note however that this system provides recommendations based " -#~| "on fairly simple calculations and by rule of thumb and\n" -#~| " may not necessarily work for your system.\n" -#~| " Prior to changing any of the configuration, be sure to know what " -#~| "you are changing and how to undo the change. Wrong tuning\n" -#~| " can have a very negative effect on performance.\n" -#~| " The best way to tune the system would be to change only one " -#~| "setting at a time, observe or benchmark your database, and\n" -#~| " undo the change if there was no clearly measurable improvement." #~ msgid "" #~ "The Advisor system can provide recommendations on server variables by " #~ "analyzing the server status variables.

Do note however that this " diff --git a/tbl_tracking.php b/tbl_tracking.php index 76ed16ab33..b601348ea4 100644 --- a/tbl_tracking.php +++ b/tbl_tracking.php @@ -575,8 +575,8 @@ if (isset($_REQUEST['report']) || isset($_REQUEST['report_export'])) { $sql_query = " SELECT DISTINCT db_name, table_name FROM " . PMA_backquote($GLOBALS['cfg']['Server']['pmadb']) . "." . PMA_backquote($GLOBALS['cfg']['Server']['tracking']) . - " WHERE " . PMA_backquote('db_name') . " = '" . PMA_sqlAddSlashes($GLOBALS['db']) . "' " . - " ORDER BY ". PMA_backquote('db_name') . ", " . PMA_backquote('table_name'); + " WHERE db_name = '" . PMA_sqlAddSlashes($GLOBALS['db']) . "' " . + " ORDER BY db_name, table_name"; $sql_result = PMA_query_as_controluser($sql_query); @@ -615,9 +615,9 @@ if (PMA_DBI_num_rows($sql_result) > 0) { $sql_query = " SELECT * FROM " . PMA_backquote($GLOBALS['cfg']['Server']['pmadb']) . "." . PMA_backquote($GLOBALS['cfg']['Server']['tracking']) . - " WHERE " . PMA_backquote('db_name') . " = '" . PMA_sqlAddSlashes($_REQUEST['db']) . "' ". - " AND " . PMA_backquote('table_name') . " = '" . PMA_sqlAddSlashes($_REQUEST['table']) ."' ". - " ORDER BY ". PMA_backquote('version') . " DESC "; + " WHERE db_name = '" . PMA_sqlAddSlashes($_REQUEST['db']) . "' ". + " AND table_name = '" . PMA_sqlAddSlashes($_REQUEST['table']) ."' ". + " ORDER BY version DESC "; $sql_result = PMA_query_as_controluser($sql_query);