From 1de317993fc5ab7712a2eb90ac4c06d0624c740a Mon Sep 17 00:00:00 2001 From: William Desportes Date: Wed, 20 Nov 2019 00:46:38 +0100 Subject: [PATCH] Fix adding a table from list, do not crash the designer if impossible to add Signed-off-by: William Desportes --- js/designer/move.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/js/designer/move.js b/js/designer/move.js index 367ca4cfa3..8ab76b63cb 100644 --- a/js/designer/move.js +++ b/js/designer/move.js @@ -619,13 +619,15 @@ function Add_Other_db_tables () { }, function (data) { var $newTableDom = $(data.message); $newTableDom.find('a').first().remove(); - $('#container-form').append($newTableDom); - enableTableEvents(null, $newTableDom); - addTableToTablesList(null, $newTableDom); var dbEncoded = $($newTableDom).find('.small_tab_pref').attr('db_url'); var tableEncoded = $($newTableDom).find('.small_tab_pref').attr('table_name_url'); - j_tabs[dbEncoded + '.' + tableEncoded] = 1; - MarkUnsaved(); + if (typeof dbEncoded === 'string' && typeof tableEncoded === 'string' ) { // Do not try to add if attr not found ! + $('#container-form').append($newTableDom); + enableTableEvents(null, $newTableDom); + addTableToTablesList(null, $newTableDom); + j_tabs[dbEncoded + '.' + tableEncoded] = 1; + MarkUnsaved(); + } }); $(this).dialog('close'); };