diff --git a/libraries/export.lib.php b/libraries/export.lib.php index db3035cbf2..7dc5af7393 100644 --- a/libraries/export.lib.php +++ b/libraries/export.lib.php @@ -603,7 +603,7 @@ function PMA_exportDatabase( if (! $export_plugin->exportDBHeader($db, $db_alias)) { return; } - if (! $export_plugin->exportDBCreate($db, $db_alias)) { + if (! $export_plugin->exportDBCreate($db, $export_type, $db_alias)) { return; } if ($separate_files == 'database') { diff --git a/libraries/plugins/ExportPlugin.class.php b/libraries/plugins/ExportPlugin.class.php index 67500acca6..f959e39b1a 100644 --- a/libraries/plugins/ExportPlugin.class.php +++ b/libraries/plugins/ExportPlugin.class.php @@ -68,12 +68,13 @@ abstract class ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - abstract public function exportDBCreate($db, $db_alias = ''); + abstract public function exportDBCreate($db, $export_type, $db_alias = ''); /** * Outputs the content of a table diff --git a/libraries/plugins/export/ExportCodegen.class.php b/libraries/plugins/export/ExportCodegen.class.php index a45af94ec5..1abf3c6a57 100644 --- a/libraries/plugins/export/ExportCodegen.class.php +++ b/libraries/plugins/export/ExportCodegen.class.php @@ -163,12 +163,13 @@ class ExportCodegen extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportCsv.class.php b/libraries/plugins/export/ExportCsv.class.php index 5aec78c2a5..ef36f09225 100644 --- a/libraries/plugins/export/ExportCsv.class.php +++ b/libraries/plugins/export/ExportCsv.class.php @@ -184,12 +184,13 @@ class ExportCsv extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Alias of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportHtmlword.class.php b/libraries/plugins/export/ExportHtmlword.class.php index 7ac7d5595d..93210cf83a 100644 --- a/libraries/plugins/export/ExportHtmlword.class.php +++ b/libraries/plugins/export/ExportHtmlword.class.php @@ -165,12 +165,13 @@ class ExportHtmlword extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportJson.class.php b/libraries/plugins/export/ExportJson.class.php index b7faaa6488..7f5e954b69 100644 --- a/libraries/plugins/export/ExportJson.class.php +++ b/libraries/plugins/export/ExportJson.class.php @@ -141,12 +141,13 @@ class ExportJson extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportLatex.class.php b/libraries/plugins/export/ExportLatex.class.php index 0bb395c120..f83f094127 100644 --- a/libraries/plugins/export/ExportLatex.class.php +++ b/libraries/plugins/export/ExportLatex.class.php @@ -259,12 +259,13 @@ class ExportLatex extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportMediawiki.class.php b/libraries/plugins/export/ExportMediawiki.class.php index 4fed469347..a40a017c6f 100644 --- a/libraries/plugins/export/ExportMediawiki.class.php +++ b/libraries/plugins/export/ExportMediawiki.class.php @@ -145,12 +145,13 @@ class ExportMediawiki extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Alias of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportOds.class.php b/libraries/plugins/export/ExportOds.class.php index aafff32f54..df2b275915 100644 --- a/libraries/plugins/export/ExportOds.class.php +++ b/libraries/plugins/export/ExportOds.class.php @@ -189,12 +189,13 @@ class ExportOds extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportOdt.class.php b/libraries/plugins/export/ExportOdt.class.php index a2ba8a5942..70e82e6923 100644 --- a/libraries/plugins/export/ExportOdt.class.php +++ b/libraries/plugins/export/ExportOdt.class.php @@ -210,12 +210,13 @@ class ExportOdt extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportPdf.class.php b/libraries/plugins/export/ExportPdf.class.php index 693983a7ba..272004683d 100644 --- a/libraries/plugins/export/ExportPdf.class.php +++ b/libraries/plugins/export/ExportPdf.class.php @@ -193,12 +193,13 @@ class ExportPdf extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportPhparray.class.php b/libraries/plugins/export/ExportPhparray.class.php index f66c7e643f..8920da001b 100644 --- a/libraries/plugins/export/ExportPhparray.class.php +++ b/libraries/plugins/export/ExportPhparray.class.php @@ -132,12 +132,13 @@ class ExportPhparray extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportSql.class.php b/libraries/plugins/export/ExportSql.class.php index 9bd3fd8042..0993486e63 100644 --- a/libraries/plugins/export/ExportSql.class.php +++ b/libraries/plugins/export/ExportSql.class.php @@ -189,16 +189,6 @@ class ExportSql extends ExportPlugin unset($values); } - // server export options - if ($plugin_param['export_type'] == 'server') { - $leaf = new BoolPropertyItem(); - $leaf->setName("drop_database"); - $leaf->setText( - sprintf(__('Add %s statement'), 'DROP DATABASE') - ); - $generalOptions->addProperty($leaf); - } - // what to dump (structure/data/both) $subgroup = new OptionsPropertySubgroup(); $subgroup->setName("dump_table"); @@ -232,7 +222,17 @@ class ExportSql extends ExportPlugin $leaf->setText(__('Add statements:')); $subgroup->setSubgroupHeader($leaf); - if ($plugin_param['export_type'] != 'table') { + // server export options + if ($plugin_param['export_type'] == 'server') { + $leaf = new BoolPropertyItem(); + $leaf->setName("drop_database"); + $leaf->setText( + sprintf(__('Add %s statement'), 'DROP DATABASE') + ); + $subgroup->addProperty($leaf); + } + + if ($plugin_param['export_type'] == 'database') { $leaf = new BoolPropertyItem(); $leaf->setName('create_database'); $create_clause = 'CREATE DATABASE / USE'; @@ -768,12 +768,13 @@ class ExportSql extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { global $crlf; @@ -796,7 +797,7 @@ class ExportSql extends ExportPlugin return false; } } - if (!isset($GLOBALS['sql_create_database'])) { + if ($export_type == 'database' && !isset($GLOBALS['sql_create_database'])) { return true; } diff --git a/libraries/plugins/export/ExportTexytext.class.php b/libraries/plugins/export/ExportTexytext.class.php index c4578768ff..e9dc3c33a3 100644 --- a/libraries/plugins/export/ExportTexytext.class.php +++ b/libraries/plugins/export/ExportTexytext.class.php @@ -149,12 +149,13 @@ class ExportTexytext extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Alias of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportXml.class.php b/libraries/plugins/export/ExportXml.class.php index a388e67d69..62cb15806d 100644 --- a/libraries/plugins/export/ExportXml.class.php +++ b/libraries/plugins/export/ExportXml.class.php @@ -453,12 +453,13 @@ class ExportXml extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/libraries/plugins/export/ExportYaml.class.php b/libraries/plugins/export/ExportYaml.class.php index 9ddbb2bad5..ae8d4d6b12 100644 --- a/libraries/plugins/export/ExportYaml.class.php +++ b/libraries/plugins/export/ExportYaml.class.php @@ -122,12 +122,13 @@ class ExportYaml extends ExportPlugin /** * Outputs CREATE DATABASE statement * - * @param string $db Database name - * @param string $db_alias Aliases of db + * @param string $db Database name + * @param string $export_type 'server', 'database', 'table' + * @param string $db_alias Aliases of db * * @return bool Whether it succeeded */ - public function exportDBCreate($db, $db_alias = '') + public function exportDBCreate($db, $export_type, $db_alias = '') { return true; } diff --git a/test/classes/plugin/export/PMA_ExportCsv_test.php b/test/classes/plugin/export/PMA_ExportCsv_test.php index 3c85b22355..5ab98de441 100644 --- a/test/classes/plugin/export/PMA_ExportCsv_test.php +++ b/test/classes/plugin/export/PMA_ExportCsv_test.php @@ -467,7 +467,7 @@ class PMA_ExportCsv_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportHtmlword_test.php b/test/classes/plugin/export/PMA_ExportHtmlword_test.php index 9623ebca61..c8b96dd61a 100644 --- a/test/classes/plugin/export/PMA_ExportHtmlword_test.php +++ b/test/classes/plugin/export/PMA_ExportHtmlword_test.php @@ -327,7 +327,7 @@ class PMA_ExportHtmlword_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportJson_test.php b/test/classes/plugin/export/PMA_ExportJson_test.php index 0948dedbaf..ab689d3560 100644 --- a/test/classes/plugin/export/PMA_ExportJson_test.php +++ b/test/classes/plugin/export/PMA_ExportJson_test.php @@ -202,7 +202,7 @@ class PMA_ExportJson_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportLatex_test.php b/test/classes/plugin/export/PMA_ExportLatex_test.php index 8352c52410..e4715ca043 100644 --- a/test/classes/plugin/export/PMA_ExportLatex_test.php +++ b/test/classes/plugin/export/PMA_ExportLatex_test.php @@ -548,7 +548,7 @@ class PMA_ExportLatex_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportMediawiki_test.php b/test/classes/plugin/export/PMA_ExportMediawiki_test.php index 7b328208e7..925476f89e 100644 --- a/test/classes/plugin/export/PMA_ExportMediawiki_test.php +++ b/test/classes/plugin/export/PMA_ExportMediawiki_test.php @@ -251,7 +251,7 @@ class PMA_ExportMediawiki_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportOds_test.php b/test/classes/plugin/export/PMA_ExportOds_test.php index ac82df6af0..d787b6a97b 100644 --- a/test/classes/plugin/export/PMA_ExportOds_test.php +++ b/test/classes/plugin/export/PMA_ExportOds_test.php @@ -254,7 +254,7 @@ class PMA_ExportOds_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportOdt_test.php b/test/classes/plugin/export/PMA_ExportOdt_test.php index cf09558f6e..143925633f 100644 --- a/test/classes/plugin/export/PMA_ExportOdt_test.php +++ b/test/classes/plugin/export/PMA_ExportOdt_test.php @@ -402,7 +402,7 @@ class PMA_ExportOdt_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportPdf_test.php b/test/classes/plugin/export/PMA_ExportPdf_test.php index 7e28babcc7..c7197cd5f9 100644 --- a/test/classes/plugin/export/PMA_ExportPdf_test.php +++ b/test/classes/plugin/export/PMA_ExportPdf_test.php @@ -260,7 +260,7 @@ class PMA_ExportPdf_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportPhparray_test.php b/test/classes/plugin/export/PMA_ExportPhparray_test.php index 6c426e0226..470bc1cd0f 100644 --- a/test/classes/plugin/export/PMA_ExportPhparray_test.php +++ b/test/classes/plugin/export/PMA_ExportPhparray_test.php @@ -199,7 +199,7 @@ class PMA_ExportPhparray_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportSql_test.php b/test/classes/plugin/export/PMA_ExportSql_test.php index 4fd25ed07a..c7ea9ed93b 100644 --- a/test/classes/plugin/export/PMA_ExportSql_test.php +++ b/test/classes/plugin/export/PMA_ExportSql_test.php @@ -224,12 +224,6 @@ class PMA_ExportSql_Test extends PHPUnit_Framework_TestCase $property->getValues() ); - $property = array_shift($properties); - $this->assertInstanceOf( - 'BoolPropertyItem', - $property - ); - $property = array_shift($properties); $this->assertInstanceOf( 'OptionsPropertySubgroup', @@ -424,13 +418,13 @@ class PMA_ExportSql_Test extends PHPUnit_Framework_TestCase $properties = $properties[0]->getProperties(); $this->assertCount( - 5, + 4, $properties ); $this->assertNotcontains( ' / EVENT ', - $properties[1]->getText() + $properties[0]->getText() ); // dataOptions @@ -787,7 +781,7 @@ class PMA_ExportSql_Test extends PHPUnit_Framework_TestCase ob_start(); $this->assertTrue( - $this->object->exportDBCreate('db') + $this->object->exportDBCreate('db', 'database') ); $result = ob_get_clean(); @@ -825,7 +819,7 @@ class PMA_ExportSql_Test extends PHPUnit_Framework_TestCase ob_start(); $this->assertTrue( - $this->object->exportDBCreate('db') + $this->object->exportDBCreate('db', 'database') ); $result = ob_get_clean(); diff --git a/test/classes/plugin/export/PMA_ExportTexytext_test.php b/test/classes/plugin/export/PMA_ExportTexytext_test.php index 7bd6f9cf55..2b0a3cc830 100644 --- a/test/classes/plugin/export/PMA_ExportTexytext_test.php +++ b/test/classes/plugin/export/PMA_ExportTexytext_test.php @@ -232,7 +232,7 @@ class PMA_ExportTexytext_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportXml_test.php b/test/classes/plugin/export/PMA_ExportXml_test.php index 7908eeccec..a2b9fcef55 100644 --- a/test/classes/plugin/export/PMA_ExportXml_test.php +++ b/test/classes/plugin/export/PMA_ExportXml_test.php @@ -640,7 +640,7 @@ class PMA_ExportXml_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); } diff --git a/test/classes/plugin/export/PMA_ExportYaml_test.php b/test/classes/plugin/export/PMA_ExportYaml_test.php index 8f8b0ecd30..26073c387c 100644 --- a/test/classes/plugin/export/PMA_ExportYaml_test.php +++ b/test/classes/plugin/export/PMA_ExportYaml_test.php @@ -188,7 +188,7 @@ class PMA_ExportYaml_Test extends PHPUnit_Framework_TestCase public function testExportDBCreate() { $this->assertTrue( - $this->object->exportDBCreate('testDB') + $this->object->exportDBCreate('testDB', 'database') ); }