gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed displaying of SQL query on table operations

Browse Source 
- do not show message about executed SQL when none was executed
- always show the SQL

Signed-off-by: Michal Čihař <michal@cihar.com>
This commit is contained in:
Michal Čihař 2015-12-16 09:43:11 +01:00
parent a2a321eaf7
commit 2076b0203b
2 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -24,6 +24,7 @@ phpMyAdmin - ChangeLog
+ issue #11711 Clarify the meaning of "Stand-in structure for view" in SQL export
- issue HTML line break shown after a MySQL connection error message
- issue #11728 CSV import skip row count after
- issue Fixed displaying of SQL query on table operations
4.5.3.0 (not yet released)
- issue #11664 Online syntax verifier bug - "IF" on SELECT statement

40
tbl_operations.php
View File

@ -197,8 +197,6 @@ if (isset($_REQUEST['submitorderby']) && ! empty($_REQUEST['order_field'])) {
/**
* A partition operation has been requested by the user
*/
$sql_query = '';
if (isset($_REQUEST['submit_partition'])
&& ! empty($_REQUEST['partition_operation'])
) {
@ -216,9 +214,13 @@ unset($reread_info);
if (isset($result) && empty($message_to_show)) {
if (empty($_message)) {
$_message = $result
? PMA\libraries\Message::success()
: PMA\libraries\Message::error();
if (empty($sql_query)) {
$_message = PMA\libraries\Message::success(__('No change'));
} else {
$_message = $result
? PMA\libraries\Message::success()
: PMA\libraries\Message::error();
}
if (isset($GLOBALS['ajax_request'])
&& $GLOBALS['ajax_request'] == true
@ -226,9 +228,11 @@ if (isset($result) && empty($message_to_show)) {
$response = PMA\libraries\Response::getInstance();
$response->setRequestStatus($_message->isSuccess());
$response->addJSON('message', $_message);
$response->addJSON(
'sql_query', PMA\libraries\Util::getMessage(null, $sql_query)
);
if (!empty($sql_query)) {
$response->addJSON(
'sql_query', PMA\libraries\Util::getMessage(null, $sql_query)
);
}
exit;
}
}
@ -242,17 +246,25 @@ if (isset($result) && empty($message_to_show)) {
$response = PMA\libraries\Response::getInstance();
$response->setRequestStatus(false);
$response->addJSON('message', $_message);
$response->addJSON(
'sql_query', PMA\libraries\Util::getMessage(null, $sql_query)
);
if (!empty($sql_query)) {
$response->addJSON(
'sql_query', PMA\libraries\Util::getMessage(null, $sql_query)
);
}
exit;
}
unset($warning_messages);
}
$response->addHTML(
PMA\libraries\Util::getMessage($_message, $sql_query)
);
if (empty($sql_query)) {
$response->addHTML(
$_message->getDisplay()
);
} else {
$response->addHTML(
PMA\libraries\Util::getMessage($_message, $sql_query)
);
}
unset($_message);
}