Merge branch 'QA_5_2'

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

.github/workflows/test-selenium.yml

@@ -84,11 +84,8 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Refresh apt cache
-        run: sudo apt-get update
-
       - name: Install gettext
-        run: sudo apt-get install -y gettext
+        run: sudo apt-get update && sudo apt-get install -y gettext
 
       - name: Generate mo files
         run: ./bin/generate-mo --quiet
@@ -156,4 +153,4 @@ jobs:
         with:
           name: selenium-screenshots
           path: ${{ github.workspace }}/build/selenium/**/*
-          retention-days: 1
+          retention-days: 3

phpstan-baseline.neon

@@ -78,6 +78,126 @@ parameters:
 			count: 1
 			path: app/services_loader.php
 
+		-
+			message: '#^Access to constant FORMAT_HTTP on an unknown class OpenID_Message\.$#'
+			identifier: class.notFound
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Binary operation "\." between ''\://'' and mixed results in an error\.$#'
+			identifier: binaryOp.invalid
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Binary operation "\." between ''\<p class\="error"\>'' and mixed results in an error\.$#'
+			identifier: binaryOp.invalid
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Binary operation "\." between ''Location\: '' and mixed results in an error\.$#'
+			identifier: binaryOp.invalid
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Binary operation "\." between non\-falsy\-string and mixed results in an error\.$#'
+			identifier: binaryOp.invalid
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Cannot call method get\(\) on mixed\.$#'
+			identifier: method.nonObject
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Cannot call method getAuthorizeURL\(\) on mixed\.$#'
+			identifier: method.nonObject
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Cannot call method prepare\(\) on mixed\.$#'
+			identifier: method.nonObject
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
+			identifier: empty.notAllowed
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Instantiated class OpenID_Message not found\.$#'
+			identifier: class.notFound
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Instantiated class OpenID_RelyingParty not found\.$#'
+			identifier: class.notFound
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Only booleans are allowed in a negated boolean, int\<0, max\> given\.$#'
+			identifier: booleanNot.exprNotBoolean
+			count: 3
+			path: examples/openid.php
+
+		-
+			message: '#^Parameter \#1 \$e of function Die_error expects Exception, Throwable given\.$#'
+			identifier: argument.type
+			count: 3
+			path: examples/openid.php
+
+		-
+			message: '#^Parameter \#1 \$path of function dirname expects string, mixed given\.$#'
+			identifier: argument.type
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Parameter \#2 \$string of function explode expects string, mixed given\.$#'
+			identifier: argument.type
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Path in include_once\(\) "OpenID/RelyingParty\.php" is not a file or it does not exist\.$#'
+			identifier: includeOnce.fileNotFound
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Variable \$authRequest might not be defined\.$#'
+			identifier: variable.undefined
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Variable \$message might not be defined\.$#'
+			identifier: variable.undefined
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Variable \$o might not be defined\.$#'
+			identifier: variable.undefined
+			count: 1
+			path: examples/openid.php
+
+		-
+			message: '#^Parameter \#1 \(mixed\) of echo cannot be converted to string\.$#'
+			identifier: echo.nonString
+			count: 1
+			path: examples/signon.php
+
 		-
 			message: '#^Binary operation "\." between ''\<p\>File \<samp\>'' and mixed results in an error\.$#'
 			identifier: binaryOp.invalid

phpstan.neon.dist

@@ -4,18 +4,19 @@ parameters:
     level: max
     paths:
         - app
+        - examples
         - public
         - src
         - tests
     scanFiles:
         - app/constants.php
-        - examples/signon-script.php
     bootstrapFiles:
         - tests/phpstan-constants.php
     stubFiles:
         - tests/stubs/uploadprogress.stub
     excludePaths:
         - app/cache/*
+        - examples/config.manyhosts.inc.php
         - tests/doctum-config.php
     dynamicConstantNames:
         - ROOT_PATH

tests/end-to-end/TestBase.php

@@ -18,6 +18,7 @@ use Facebook\WebDriver\WebDriverElement;
 use Facebook\WebDriver\WebDriverExpectedCondition;
 use Facebook\WebDriver\WebDriverSelect;
 use InvalidArgumentException;
+use PHPUnit\Framework\SkippedTest;
 use PHPUnit\Framework\TestCase;
 use Throwable;
 
@@ -651,7 +652,7 @@ abstract class TestBase extends TestCase
             $this->waitAjax();
             $this->waitForElement('className', 'result_query');
             // If present then
-            $didSucceed = $this->isElementPresent('xpath', '//*[@class="result_query"]//*[contains(., "success")]');
+            $didSucceed = $this->isElementPresent('cssSelector', '.result_query .alert-success');
             $onResults?->call($this);
         }
 
@@ -1180,6 +1181,10 @@ JS;
      */
     protected function onNotSuccessfulTest(Throwable $t): never
     {
+        if ($t instanceof SkippedTest) {
+            parent::onNotSuccessfulTest($t);
+        }
+
         $this->markTestAs('failed', $t->getMessage());
         $this->takeScrenshot('test_failed');
         // End testing session