From 2181bfa8db68c9b671ea486440f18cb6d4f24cd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maximilian=20Kr=C3=B6g?= <maxi_kroeg@web.de>
Date: Sun, 5 Mar 2023 01:39:29 +0100
Subject: [PATCH] Remove modifiedSql property
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
---
 libraries/classes/Gis/GisVisualization.php | 23 ++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/libraries/classes/Gis/GisVisualization.php b/libraries/classes/Gis/GisVisualization.php
index 2d25c08efb..866c623d84 100644
--- a/libraries/classes/Gis/GisVisualization.php
+++ b/libraries/classes/Gis/GisVisualization.php
@@ -37,8 +37,6 @@ class GisVisualization
     /** @var array   Raw data for the visualization */
     private array $data;
 
-    private string $modifiedSql = '';
-
     /** @var array   Set of default settings values are here. */
     private array $settings = [
         // Array of colors to be used for GIS visualizations.
@@ -151,12 +149,17 @@ class GisVisualization
         $this->rows = $rows;
 
         $this->userSpecifiedSettings = $options;
-        if (isset($data)) {
-            $this->data = $data;
-        } else {
-            $this->modifiedSql = $this->modifySqlQuery($sql_query);
-            $this->data = $this->fetchRawData();
-        }
+        $this->data = is_string($sql_query)
+            ? $this->modifyQueryAndFetch($sql_query)
+            : $data;
+    }
+
+    /** @return array raw data */
+    private function modifyQueryAndFetch(string $sqlQuery): array
+    {
+        $modifiedSql = $this->modifySqlQuery($sqlQuery);
+
+        return $this->fetchRawData($modifiedSql);
     }
 
     /**
@@ -228,9 +231,9 @@ class GisVisualization
      *
      * @return array the raw data.
      */
-    private function fetchRawData(): array
+    private function fetchRawData(string $modifiedSql): array
     {
-        $modified_result = $GLOBALS['dbi']->tryQuery($this->modifiedSql);
+        $modified_result = $GLOBALS['dbi']->tryQuery($modifiedSql);
 
         if ($modified_result === false) {
             return [];