From 93453de996db6fc2333fd90c1add944f78721972 Mon Sep 17 00:00:00 2001 From: Pin-Yi Song <611077101@mail.nknu.edu.tw> Date: Mon, 28 Jul 2025 22:19:36 +0800 Subject: [PATCH 1/2] fix: set default value for the innodb. Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw> --- libraries/classes/Advisor.php | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libraries/classes/Advisor.php b/libraries/classes/Advisor.php index ea6bd95465..53f8ebd154 100644 --- a/libraries/classes/Advisor.php +++ b/libraries/classes/Advisor.php @@ -396,7 +396,20 @@ class Advisor */ private function evaluateRuleExpression(string $expression) { - return $this->expression->evaluate($expression, array_merge($this->variables, $this->globals)); + $variables = array_merge($this->variables, $this->globals); + + // Set default values for missing InnoDB variables when InnoDB is disabled + if (!isset($variables['innodb_buffer_pool_size'])) { + $variables['innodb_buffer_pool_size'] = 0; + } + if (!isset($variables['innodb_log_file_size'])) { + $variables['innodb_log_file_size'] = 0; + } + if (!isset($variables['innodb_log_files_in_group'])) { + $variables['innodb_log_files_in_group'] = 0; + } + + return $this->expression->evaluate($expression, $variables); } /** From 1a0e48debfdad3a07195bf77bae6158db928f8e7 Mon Sep 17 00:00:00 2001 From: Pin-Yi Song <611077101@mail.nknu.edu.tw> Date: Mon, 28 Jul 2025 22:27:45 +0800 Subject: [PATCH 2/2] style: cs fix. Signed-off-by: Pin-Yi Song <611077101@mail.nknu.edu.tw> --- libraries/classes/Advisor.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libraries/classes/Advisor.php b/libraries/classes/Advisor.php index 53f8ebd154..99bf7d4beb 100644 --- a/libraries/classes/Advisor.php +++ b/libraries/classes/Advisor.php @@ -399,13 +399,15 @@ class Advisor $variables = array_merge($this->variables, $this->globals); // Set default values for missing InnoDB variables when InnoDB is disabled - if (!isset($variables['innodb_buffer_pool_size'])) { + if (! isset($variables['innodb_buffer_pool_size'])) { $variables['innodb_buffer_pool_size'] = 0; } - if (!isset($variables['innodb_log_file_size'])) { + + if (! isset($variables['innodb_log_file_size'])) { $variables['innodb_log_file_size'] = 0; } - if (!isset($variables['innodb_log_files_in_group'])) { + + if (! isset($variables['innodb_log_files_in_group'])) { $variables['innodb_log_files_in_group'] = 0; }