From 0c56d0b9bb22fee65bcbd193f25fca61f164d1d7 Mon Sep 17 00:00:00 2001 From: ZhiFeng Hu Date: Tue, 4 Aug 2015 10:17:05 +0800 Subject: [PATCH] Strict check for create_addfield.lib.php Signed-off-by: ZhiFeng Hu --- libraries/create_addfield.lib.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/create_addfield.lib.php b/libraries/create_addfield.lib.php index afeaa29b76..89598e1c2d 100644 --- a/libraries/create_addfield.lib.php +++ b/libraries/create_addfield.lib.php @@ -101,18 +101,18 @@ function PMA_setColumnCreationStatementSuffix($current_field_num, $is_create_tbl = true ) { // no suffix is needed if request is a table creation - $sql_suffix = " "; + $sql_suffix = ' '; if ($is_create_tbl) { return $sql_suffix; } - if ($_REQUEST['field_where'] == 'last') { + if ((string) $_REQUEST['field_where'] === 'last') { return $sql_suffix; } // Only the first field can be added somewhere other than at the end - if ($current_field_num == 0) { - if ($_REQUEST['field_where'] == 'first') { + if ((int) $current_field_num === 0) { + if ((string) $_REQUEST['field_where'] === 'first') { $sql_suffix .= ' FIRST'; } else { $sql_suffix .= ' AFTER '