diff --git a/libraries/classes/Advisor.php b/libraries/classes/Advisor.php index 73e0070c86..4f6b2f53b8 100644 --- a/libraries/classes/Advisor.php +++ b/libraries/classes/Advisor.php @@ -122,7 +122,7 @@ class Advisor * * @return Advisor */ - public function setVariables($variables) + public function setVariables(array $variables) { $this->variables = $variables; @@ -161,7 +161,7 @@ class Advisor * * @return Advisor */ - public function setParseResult($parseResult) + public function setParseResult(array $parseResult) { $this->parseResult = $parseResult; @@ -185,7 +185,7 @@ class Advisor * * @return Advisor */ - public function setRunResult($runResult) + public function setRunResult(array $runResult) { $this->runResult = $runResult; @@ -357,7 +357,7 @@ class Advisor * * @return string[] */ - public static function splitJustification($rule) + public static function splitJustification(array $rule) { $jst = preg_split('/\s*\|\s*/', $rule['justification'], 2); if (count($jst) > 1) { @@ -374,7 +374,7 @@ class Advisor * * @return void */ - public function addRule($type, $rule) + public function addRule($type, array $rule) { switch ($type) { case 'notfired': @@ -430,7 +430,7 @@ class Advisor * * @return string Replacement value */ - private function replaceLinkURL($matches) + private function replaceLinkURL(array $matches) { return 'href="' . Core::linkURL($matches[2]) . '" target="_blank" rel="noopener noreferrer"'; } @@ -442,7 +442,7 @@ class Advisor * * @return string Replacement value */ - private function replaceVariable($matches) + private function replaceVariable(array $matches) { return '' . htmlspecialchars($matches[1]) . ''; diff --git a/libraries/classes/Bookmark.php b/libraries/classes/Bookmark.php index 01b0978d03..a38c4ddebe 100644 --- a/libraries/classes/Bookmark.php +++ b/libraries/classes/Bookmark.php @@ -166,11 +166,11 @@ class Bookmark /** * Replace the placeholders in the bookmark query with variables * - * @param array $variables array of variables + * @param array $variables array of variables * * @return string query with variables applied */ - public function applyVariables($variables) + public function applyVariables(array $variables) { // remove comments that encloses a variable placeholder $query = preg_replace( @@ -232,7 +232,7 @@ class Bookmark * * @return Bookmark|false */ - public static function createBookmark($bkm_fields, $all_users = false) + public static function createBookmark(array $bkm_fields, $all_users = false) { if (!(isset($bkm_fields['bkm_sql_query']) && strlen($bkm_fields['bkm_sql_query']) > 0 diff --git a/libraries/classes/BrowseForeigners.php b/libraries/classes/BrowseForeigners.php index a24dea96ec..c1f352fa57 100644 --- a/libraries/classes/BrowseForeigners.php +++ b/libraries/classes/BrowseForeigners.php @@ -30,8 +30,8 @@ class BrowseForeigners * * @return string $html the generated html */ - public static function getHtmlForOneKey($horizontal_count, $header, $keys, - $indexByKeyname, $descriptions, $indexByDescription, $current_value + public static function getHtmlForOneKey($horizontal_count, $header, array $keys, + $indexByKeyname, array $descriptions, $indexByDescription, $current_value ) { $horizontal_count++; $output = ''; @@ -114,7 +114,7 @@ class BrowseForeigners * * @return string */ - public static function getHtmlForRelationalFieldSelection($db, $table, $field, $foreignData, + public static function getHtmlForRelationalFieldSelection($db, $table, $field, array $foreignData, $fieldkey, $current_value ) { $gotopage = self::getHtmlForGotoPage($foreignData); @@ -277,7 +277,7 @@ class BrowseForeigners /** * Function to get html for show all case * - * @param array $foreignData foreign data + * @param array|null $foreignData foreign data * * @return string */ @@ -300,7 +300,7 @@ class BrowseForeigners /** * Function to get html for the goto page option * - * @param array $foreignData foreign data + * @param array|null $foreignData foreign data * * @return string */ diff --git a/libraries/classes/CentralColumns.php b/libraries/classes/CentralColumns.php index 23e201ef1f..3fbe903dcd 100644 --- a/libraries/classes/CentralColumns.php +++ b/libraries/classes/CentralColumns.php @@ -180,7 +180,7 @@ class CentralColumns * @return string query string to insert the given column * with definition into central list */ - public static function getInsertQuery($column, $def, $db, $central_list_table) + public static function getInsertQuery($column, array $def, $db, $central_list_table) { $type = ""; $length = 0; @@ -224,7 +224,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function syncUniqueColumns($field_select, $isTable=true, $table=null) + public static function syncUniqueColumns(array $field_select, $isTable=true, $table=null) { $cfgCentralColumns = self::getParams(); if (empty($cfgCentralColumns)) { @@ -329,7 +329,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function deleteColumnsFromList($field_select, $isTable=true) + public static function deleteColumnsFromList(array $field_select, $isTable=true) { $cfgCentralColumns = self::getParams(); if (empty($cfgCentralColumns)) { @@ -412,7 +412,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function makeConsistentWithList($db, $selected_tables) + public static function makeConsistentWithList($db, array $selected_tables) { $message = true; foreach ($selected_tables as $table) { @@ -731,7 +731,7 @@ class CentralColumns * * @return string html for table header in central columns multi edit page */ - public static function getEditTableHeader($header_cells) + public static function getEditTableHeader(array $header_cells) { $html = '
| '; $html_output .= ''; @@ -1308,8 +1308,8 @@ class DbQbe * * @return array having UNIQUE and INDEX columns */ - private function _getIndexes($search_tables, $search_columns, - $where_clause_columns + private function _getIndexes(array $search_tables, array $search_columns, + array $where_clause_columns ) { $unique_columns = array(); $index_columns = array(); @@ -1351,8 +1351,8 @@ class DbQbe * * @return array having UNIQUE and INDEX columns */ - private function _getLeftJoinColumnCandidates($search_tables, $search_columns, - $where_clause_columns + private function _getLeftJoinColumnCandidates(array $search_tables, array $search_columns, + array $where_clause_columns ) { $GLOBALS['dbi']->selectDb($this->_db); @@ -1411,8 +1411,8 @@ class DbQbe * * @return string table name */ - private function _getMasterTable($search_tables, $search_columns, - $where_clause_columns, $where_clause_tables + private function _getMasterTable(array $search_tables, array $search_columns, + array $where_clause_columns, array $where_clause_tables ) { if (count($where_clause_tables) == 1) { // If there is exactly one column that has a decent where-clause @@ -1532,7 +1532,7 @@ class DbQbe * * @return string FROM clause */ - private function _getFromClause($formColumns) + private function _getFromClause(array $formColumns) { $from_clause = ''; if (empty($formColumns)) { @@ -1579,7 +1579,7 @@ class DbQbe * * @return string table name */ - private function _getJoinForFromClause($searchTables, $searchColumns) + private function _getJoinForFromClause(array $searchTables, array $searchColumns) { // $relations[master_table][foreign_table] => clause $relations = array(); @@ -1702,7 +1702,7 @@ class DbQbe * * @return void */ - private function _loadRelationsForTable(&$relations, $oneTable) + private function _loadRelationsForTable(array &$relations, $oneTable) { $relations[$oneTable] = array(); @@ -1743,7 +1743,7 @@ class DbQbe * * @return void */ - private function _fillJoinClauses(&$finalized, $relations, $searchTables) + private function _fillJoinClauses(array &$finalized, array $relations, array $searchTables) { while (true) { $added = false; @@ -1784,7 +1784,7 @@ class DbQbe * * @return string SQL query */ - private function _getSQLQuery($formColumns) + private function _getSQLQuery(array $formColumns) { $sql_query = ''; // get SELECT clause @@ -1967,7 +1967,7 @@ class DbQbe * @return array */ private function _getLeftJoinColumnCandidatesBest( - $search_tables, $where_clause_columns, $unique_columns, $index_columns + array $search_tables, array $where_clause_columns, array $unique_columns, array $index_columns ) { // now we want to find the best. if (isset($unique_columns) && count($unique_columns) > 0) { diff --git a/libraries/classes/DbSearch.php b/libraries/classes/DbSearch.php index a5dbeea19a..e7c47425d9 100644 --- a/libraries/classes/DbSearch.php +++ b/libraries/classes/DbSearch.php @@ -312,7 +312,7 @@ class DbSearch * * @return string HTML row */ - private function _getResultsRow($each_table, $newsearchsqls, $res_cnt) + private function _getResultsRow($each_table, array $newsearchsqls, $res_cnt) { $this_url_params = array( 'db' => $GLOBALS['db'], diff --git a/libraries/classes/Dbi/DbiDummy.php b/libraries/classes/Dbi/DbiDummy.php index 8eb6cdcd62..35cd9a0e3c 100644 --- a/libraries/classes/Dbi/DbiDummy.php +++ b/libraries/classes/Dbi/DbiDummy.php @@ -41,7 +41,7 @@ class DbiDummy implements DbiExtension public function connect( $user, $password, - $server = null + array $server = [] ) { return true; } diff --git a/libraries/classes/Dbi/DbiExtension.php b/libraries/classes/Dbi/DbiExtension.php index a133f8082d..b1b9ffae6c 100644 --- a/libraries/classes/Dbi/DbiExtension.php +++ b/libraries/classes/Dbi/DbiExtension.php @@ -23,7 +23,7 @@ interface DbiExtension * @return mixed false on error or a connection object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ); /** diff --git a/libraries/classes/Dbi/DbiMysql.php b/libraries/classes/Dbi/DbiMysql.php index ecea5a8cfd..d3fedb3a2b 100644 --- a/libraries/classes/Dbi/DbiMysql.php +++ b/libraries/classes/Dbi/DbiMysql.php @@ -92,7 +92,7 @@ class DbiMysql implements DbiExtension * @return mixed false on error or a mysqli object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ) { if ($server['port'] === 0) { $server_port = ''; diff --git a/libraries/classes/Dbi/DbiMysqli.php b/libraries/classes/Dbi/DbiMysqli.php index 182878646f..0c1d332345 100644 --- a/libraries/classes/Dbi/DbiMysqli.php +++ b/libraries/classes/Dbi/DbiMysqli.php @@ -76,7 +76,7 @@ class DbiMysqli implements DbiExtension * @return mixed false on error or a mysqli object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ) { if ($server) { $server['host'] = (empty($server['host'])) diff --git a/libraries/classes/Di/AliasItem.php b/libraries/classes/Di/AliasItem.php index a0893bdfa5..3f461dd2fd 100644 --- a/libraries/classes/Di/AliasItem.php +++ b/libraries/classes/Di/AliasItem.php @@ -39,7 +39,7 @@ class AliasItem implements Item * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->container->get($this->target, $params); } diff --git a/libraries/classes/Di/Container.php b/libraries/classes/Di/Container.php index cba560a46e..bd633a44d1 100644 --- a/libraries/classes/Di/Container.php +++ b/libraries/classes/Di/Container.php @@ -52,7 +52,7 @@ class Container implements ContainerInterface * * @return mixed */ - public function get($name, $params = array()) + public function get($name, array $params = array()) { if (!$this->has($name)) { throw new NotFoundException("No entry was found for $name identifier."); diff --git a/libraries/classes/Di/FactoryItem.php b/libraries/classes/Di/FactoryItem.php index 21e6b948ed..16a096cd49 100644 --- a/libraries/classes/Di/FactoryItem.php +++ b/libraries/classes/Di/FactoryItem.php @@ -22,7 +22,7 @@ class FactoryItem extends ReflectorItem * * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->invoke($params); } diff --git a/libraries/classes/Di/Item.php b/libraries/classes/Di/Item.php index 882428d317..9ddd6a8f21 100644 --- a/libraries/classes/Di/Item.php +++ b/libraries/classes/Di/Item.php @@ -21,5 +21,5 @@ interface Item * @param array $params Parameters * @return mixed */ - public function get($params = array()); + public function get(array $params = array()); } diff --git a/libraries/classes/Di/ReflectorItem.php b/libraries/classes/Di/ReflectorItem.php index 72ab683c4a..228a1f7fe4 100644 --- a/libraries/classes/Di/ReflectorItem.php +++ b/libraries/classes/Di/ReflectorItem.php @@ -39,7 +39,7 @@ abstract class ReflectorItem implements Item * @param array $params Parameters * @return mixed */ - protected function invoke($params = array()) + protected function invoke(array $params = array()) { $args = array(); $reflector = $this->_reflector; @@ -74,7 +74,7 @@ abstract class ReflectorItem implements Item * *@return array */ - private function _resolveArgs($required, $params = array()) + private function _resolveArgs($required, array $params = array()) { $args = array(); foreach ($required as $param) { diff --git a/libraries/classes/Di/ServiceItem.php b/libraries/classes/Di/ServiceItem.php index 608e8a482d..25a4576f11 100644 --- a/libraries/classes/Di/ServiceItem.php +++ b/libraries/classes/Di/ServiceItem.php @@ -24,7 +24,7 @@ class ServiceItem extends ReflectorItem * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { if (!isset($this->instance)) { $this->instance = $this->invoke(); diff --git a/libraries/classes/Di/ValueItem.php b/libraries/classes/Di/ValueItem.php index 52f20509f9..2997a374de 100644 --- a/libraries/classes/Di/ValueItem.php +++ b/libraries/classes/Di/ValueItem.php @@ -34,7 +34,7 @@ class ValueItem implements Item * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->value; } diff --git a/libraries/classes/Display/Export.php b/libraries/classes/Display/Export.php index 6bef98947b..272557fdd5 100644 --- a/libraries/classes/Display/Export.php +++ b/libraries/classes/Display/Export.php @@ -1064,7 +1064,7 @@ class Export * * @return void */ - public static function handleExportTemplateActions($cfgRelation) + public static function handleExportTemplateActions(array $cfgRelation) { if (isset($_REQUEST['templateId'])) { $id = $GLOBALS['dbi']->escapeString($_REQUEST['templateId']); diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php index b7c4d49da3..e6d1a50c3b 100644 --- a/libraries/classes/Display/Results.php +++ b/libraries/classes/Display/Results.php @@ -437,7 +437,7 @@ class Results * @access private * */ - private function _setDisplayPartsForPrintView($displayParts) + private function _setDisplayPartsForPrintView(array $displayParts) { // set all elements to false! $displayParts['edit_lnk'] = self::NO_EDIT_OR_DELETE; // no edit link @@ -461,7 +461,7 @@ class Results * @access private * */ - private function _setDisplayPartsForShow($displayParts) + private function _setDisplayPartsForShow(array $displayParts) { preg_match( '@^SHOW[[:space:]]+(VARIABLES|(FULL[[:space:]]+)?' @@ -509,7 +509,7 @@ class Results * @access private * */ - private function _setDisplayPartsForNonData($displayParts) + private function _setDisplayPartsForNonData(array $displayParts) { // Statement is a "SELECT COUNT", a // "CHECK/ANALYZE/REPAIR/OPTIMIZE/CHECKSUM", an "EXPLAIN" one or @@ -540,7 +540,7 @@ class Results * @access private * */ - private function _setDisplayPartsForSelect($displayParts) + private function _setDisplayPartsForSelect(array $displayParts) { // Other statements (ie "SELECT" ones) -> updates // $displayParts['edit_lnk'], $displayParts['del_lnk'] and @@ -611,7 +611,7 @@ class Results * * @see getTable() */ - private function _setDisplayPartsAndTotal($displayParts) + private function _setDisplayPartsAndTotal(array $displayParts) { $the_total = 0; @@ -690,7 +690,7 @@ class Results * * @see _getTableHeaders(), _getColumnParams() */ - private function _isSelect($analyzed_sql_results) + private function _isSelect(array $analyzed_sql_results) { return ! ($this->__get('is_count') || $this->__get('is_export') @@ -1178,8 +1178,8 @@ class Results * @see getTableHeaders() */ private function _getTableHeadersForColumns( - $displayParts, $analyzed_sql_results, $sort_expression, - $sort_expression_nodirection, $sort_direction, $is_limited_display, + array $displayParts, array $analyzed_sql_results, array $sort_expression, + array $sort_expression_nodirection, array $sort_direction, $is_limited_display, $unsorted_sql_query ) { $html = ''; @@ -1268,15 +1268,15 @@ class Results /** * Get the headers of the results table * - * @param array &$displayParts which elements to display - * @param array $analyzed_sql_results analyzed sql results - * @param string $unsorted_sql_query the unsorted sql query - * @param array $sort_expression sort expression - * @param array $sort_expression_nodirection sort expression - * without direction - * @param array $sort_direction sort direction - * @param boolean $is_limited_display with limited operations - * or not + * @param array &$displayParts which elements to display + * @param array $analyzed_sql_results analyzed sql results + * @param string $unsorted_sql_query the unsorted sql query + * @param array $sort_expression sort expression + * @param array|string $sort_expression_nodirection sort expression + * without direction + * @param array $sort_direction sort direction + * @param boolean $is_limited_display with limited operations + * or not * * @return string html content * @@ -1285,9 +1285,9 @@ class Results * @see getTable() */ private function _getTableHeaders( - &$displayParts, $analyzed_sql_results, $unsorted_sql_query, - $sort_expression = array(), $sort_expression_nodirection = '', - $sort_direction = array(), $is_limited_display = false + array &$displayParts, array $analyzed_sql_results, $unsorted_sql_query, + array $sort_expression = array(), $sort_expression_nodirection = '', + array $sort_direction = array(), $is_limited_display = false ) { $table_headers_html = ''; @@ -1379,7 +1379,7 @@ class Results * @see _getTableHeaders() */ private function _getUnsortedSqlAndSortByKeyDropDown( - $analyzed_sql_results, $sort_expression + array $analyzed_sql_results, $sort_expression ) { $drop_down_html = ''; @@ -1517,7 +1517,7 @@ class Results * @see _getTableHeaders() */ private function _getFieldVisibilityParams( - &$displayParts, $full_or_partial_text_link + array &$displayParts, $full_or_partial_text_link ) { $button_html = ''; @@ -1592,7 +1592,7 @@ class Results * * @see _getTableHeaders() */ - private function _getTableCommentsArray($analyzed_sql_results) + private function _getTableCommentsArray(array $analyzed_sql_results) { if ((!$GLOBALS['cfg']['ShowBrowseComments']) || (empty($analyzed_sql_results['statement']->from)) @@ -1627,7 +1627,7 @@ class Results * * @see _getTableHeaders() */ - private function _setHighlightedColumnGlobalField($analyzed_sql_results) + private function _setHighlightedColumnGlobalField(array $analyzed_sql_results) { $highlight_columns = array(); @@ -1655,7 +1655,7 @@ class Results * * @see _getTableHeaders() */ - private function _getDataForResettingColumnOrder($analyzed_sql_results) + private function _getDataForResettingColumnOrder(array $analyzed_sql_results) { if (! $this->_isSelect($analyzed_sql_results)) { return ''; @@ -1922,7 +1922,7 @@ class Results * * @see _getTableHeaders() */ - private function _getCommentForRow($comments_map, $fields_meta) + private function _getCommentForRow(array $comments_map, $fields_meta) { $comments = ''; if (isset($comments_map[$fields_meta->table]) @@ -1969,9 +1969,9 @@ class Results * @see _getTableHeaders() */ private function _getOrderLinkAndSortedHeaderHtml( - $fields_meta, $sort_expression, $sort_expression_nodirection, + $fields_meta, array $sort_expression, array $sort_expression_nodirection, $column_index, $unsorted_sql_query, $session_max_rows, - $comments, $sort_direction, $col_visib, $col_visib_j + $comments, array $sort_direction, $col_visib, $col_visib_j ) { $sorted_header_html = ''; @@ -2065,8 +2065,8 @@ class Results * @see _getOrderLinkAndSortedHeaderHtml() */ private function _getSingleAndMultiSortUrls( - $sort_expression, $sort_expression_nodirection, $sort_tbl, - $name_to_use_in_sort, $sort_direction, $fields_meta, $column_index + array $sort_expression, array $sort_expression_nodirection, $sort_tbl, + $name_to_use_in_sort, array $sort_direction, $fields_meta, $column_index ) { $sort_order = ""; // Check if the current column is in the order by clause @@ -2195,7 +2195,7 @@ class Results * @see _getTableHeaders() */ private function _isInSorted( - $sort_expression, $sort_expression_nodirection, $sort_tbl, + array $sort_expression, array $sort_expression_nodirection, $sort_tbl, $name_to_use_in_sort ) { @@ -2271,7 +2271,7 @@ class Results * * @see _getSingleAndMultiSortUrls() */ - private function _getSortingUrlParams($sort_direction, $sort_order, $index) + private function _getSortingUrlParams(array $sort_direction, $sort_order, $index) { if (strtoupper(trim($sort_direction[$index])) == self::DESCENDING_SORT_DIR) { $sort_order .= ' ASC'; @@ -2341,7 +2341,7 @@ class Results * * @see _getDraggableClassForSortableColumns() */ - private function _getClassForNumericColumnType($fields_meta,&$th_class) + private function _getClassForNumericColumnType($fields_meta, array &$th_class) { if (preg_match( '@int|decimal|float|double|real|bit|boolean|serial@i', @@ -2460,7 +2460,7 @@ class Results * @see _getTableHeaders() */ private function _getColumnAtRightSide( - &$displayParts, $full_or_partial_text_link, $colspan + array &$displayParts, $full_or_partial_text_link, $colspan ) { $right_column_html = ''; @@ -2675,7 +2675,7 @@ class Results * @see getTable() */ private function _getTableBody( - &$dt_result, &$displayParts, $map, $analyzed_sql_results, + &$dt_result, array &$displayParts, array $map, array $analyzed_sql_results, $is_limited_display = false ) { @@ -2964,7 +2964,7 @@ class Results * displayed * @param array $row current row data * @param integer $row_no the index of current row - * @param array $col_order the column order false when + * @param array|boolean $col_order the column order false when * a property not found false * when a property not found * @param array $map the list of relations @@ -2983,9 +2983,9 @@ class Results * @see _getTableBody() */ private function _getRowValues( - &$dt_result, $row, $row_no, $col_order, $map, + &$dt_result, array $row, $row_no, $col_order, array $map, $grid_edit_class, $col_visib, - $url_sql_query, $analyzed_sql_results + $url_sql_query, array $analyzed_sql_results ) { $row_values_html = ''; @@ -3263,7 +3263,7 @@ class Results * * @return string generated link */ - private function _getSpecialLinkUrl($column_value, $row_info, $field_name) + private function _getSpecialLinkUrl($column_value, array $row_info, $field_name) { $linking_url_params = array(); @@ -3317,12 +3317,12 @@ class Results /** * Prepare row information for display special links * - * @param array $row current row data - * @param array $col_order the column order + * @param array $row current row data + * @param array|boolean $col_order the column order * * @return array $row_info associative array with column nama -> value */ - private function _getRowInfoForSpecialLinks($row, $col_order) + private function _getRowInfoForSpecialLinks(array $row, $col_order) { $row_info = array(); @@ -3349,7 +3349,7 @@ class Results * * @see _getTableBody() */ - private function _getUrlSqlQuery($analyzed_sql_results) + private function _getUrlSqlQuery(array $analyzed_sql_results) { if (($analyzed_sql_results['querytype'] != 'SELECT') || (mb_strlen($this->__get('sql_query')) < 200) @@ -3389,7 +3389,7 @@ class Results * * @see _getTableBody() */ - private function _getColumnParams($analyzed_sql_results) + private function _getColumnParams(array $analyzed_sql_results) { if ($this->_isSelect($analyzed_sql_results)) { $pmatable = new Table($this->__get('table'), $this->__get('db')); @@ -3426,7 +3426,7 @@ class Results * @see _getTableBody() */ private function _getRepeatingHeaders( - $display_params + array $display_params ) { $header_html = ' |