From 1d4125f15c911b7b3507ec483caa9f49c886b470 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Sun, 24 Sep 2017 15:08:14 -0300 Subject: [PATCH] Add array type declarations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: MaurĂ­cio Meneghini Fauth --- libraries/classes/Advisor.php | 14 +- libraries/classes/Bookmark.php | 6 +- libraries/classes/BrowseForeigners.php | 10 +- libraries/classes/CentralColumns.php | 18 +- libraries/classes/Config.php | 2 +- libraries/classes/Config/ConfigFile.php | 8 +- libraries/classes/Config/Form.php | 4 +- libraries/classes/Config/FormDisplay.php | 16 +- .../classes/Config/FormDisplayTemplate.php | 38 ++--- libraries/classes/Config/Validator.php | 22 +-- .../Database/DatabaseStructureController.php | 12 +- .../Server/ServerBinlogController.php | 6 +- .../Server/ServerCollationsController.php | 4 +- .../Server/ServerDatabasesController.php | 11 +- .../Server/ServerVariablesController.php | 4 +- .../Table/TableChartController.php | 2 +- .../Table/TableGisVisualizationController.php | 4 +- .../Table/TableRelationController.php | 12 +- .../Table/TableStructureController.php | 6 +- libraries/classes/Core.php | 10 +- libraries/classes/CreateAddField.php | 6 +- libraries/classes/Database/Designer.php | 10 +- libraries/classes/DatabaseInterface.php | 22 +-- libraries/classes/DbQbe.php | 34 ++-- libraries/classes/DbSearch.php | 2 +- libraries/classes/Dbi/DbiDummy.php | 2 +- libraries/classes/Dbi/DbiExtension.php | 2 +- libraries/classes/Dbi/DbiMysql.php | 2 +- libraries/classes/Dbi/DbiMysqli.php | 2 +- libraries/classes/Di/AliasItem.php | 2 +- libraries/classes/Di/Container.php | 2 +- libraries/classes/Di/FactoryItem.php | 2 +- libraries/classes/Di/Item.php | 2 +- libraries/classes/Di/ReflectorItem.php | 4 +- libraries/classes/Di/ServiceItem.php | 2 +- libraries/classes/Di/ValueItem.php | 2 +- libraries/classes/Display/Export.php | 2 +- libraries/classes/Display/Results.php | 141 ++++++++------- libraries/classes/Error.php | 8 +- libraries/classes/ErrorReport.php | 6 +- libraries/classes/Export.php | 14 +- libraries/classes/File.php | 2 +- libraries/classes/Font.php | 8 +- libraries/classes/Footer.php | 2 +- libraries/classes/Gis/GisGeometry.php | 32 ++-- .../classes/Gis/GisGeometryCollection.php | 10 +- libraries/classes/Gis/GisLineString.php | 10 +- libraries/classes/Gis/GisMultiLineString.php | 12 +- libraries/classes/Gis/GisMultiPoint.php | 14 +- libraries/classes/Gis/GisMultiPolygon.php | 14 +- libraries/classes/Gis/GisPoint.php | 12 +- libraries/classes/Gis/GisPolygon.php | 20 +-- libraries/classes/Gis/GisVisualization.php | 24 +-- libraries/classes/Import.php | 28 +-- libraries/classes/Index.php | 8 +- libraries/classes/IndexColumn.php | 4 +- libraries/classes/InsertEdit.php | 160 +++++++++--------- libraries/classes/Linter.php | 2 +- libraries/classes/ListAbstract.php | 2 +- libraries/classes/Message.php | 2 +- libraries/classes/MultSubmits.php | 48 +++--- .../classes/Navigation/NavigationTree.php | 4 +- libraries/classes/Normalization.php | 16 +- libraries/classes/Operations.php | 26 +-- libraries/classes/Partition.php | 2 +- libraries/classes/Plugins.php | 4 +- .../classes/Plugins/Export/ExportCodegen.php | 10 +- .../classes/Plugins/Export/ExportCsv.php | 2 +- .../classes/Plugins/Export/ExportHtmlword.php | 10 +- .../classes/Plugins/Export/ExportJson.php | 2 +- .../classes/Plugins/Export/ExportLatex.php | 4 +- .../Plugins/Export/ExportMediawiki.php | 4 +- .../classes/Plugins/Export/ExportOds.php | 2 +- .../classes/Plugins/Export/ExportOdt.php | 8 +- .../classes/Plugins/Export/ExportPdf.php | 4 +- .../classes/Plugins/Export/ExportPhparray.php | 2 +- .../classes/Plugins/Export/ExportSql.php | 20 +-- .../classes/Plugins/Export/ExportTexytext.php | 6 +- .../classes/Plugins/Export/ExportXml.php | 6 +- .../classes/Plugins/Export/ExportYaml.php | 2 +- .../classes/Plugins/Export/Helpers/Pdf.php | 4 +- .../Plugins/Export/Helpers/TableProperty.php | 2 +- libraries/classes/Plugins/ExportPlugin.php | 14 +- .../Plugins/IOTransformationsPlugin.php | 4 +- .../classes/Plugins/Import/ImportCsv.php | 2 +- .../classes/Plugins/Import/ImportLdi.php | 2 +- .../Plugins/Import/ImportMediawiki.php | 8 +- .../classes/Plugins/Import/ImportOds.php | 2 +- .../classes/Plugins/Import/ImportShp.php | 2 +- .../classes/Plugins/Import/ImportSql.php | 4 +- .../classes/Plugins/Import/ImportXml.php | 2 +- libraries/classes/Plugins/Schema/Pdf/Pdf.php | 4 +- .../Plugins/Schema/Pdf/PdfRelationSchema.php | 2 +- .../Abs/Bool2TextTransformationsPlugin.php | 2 +- .../CodeMirrorEditorTransformationPlugin.php | 6 +- .../Abs/DateFormatTransformationsPlugin.php | 2 +- .../Abs/DownloadTransformationsPlugin.php | 2 +- .../Abs/ExternalTransformationsPlugin.php | 4 +- .../Abs/FormattedTransformationsPlugin.php | 2 +- .../Abs/HexTransformationsPlugin.php | 2 +- .../Abs/ImageLinkTransformationsPlugin.php | 2 +- .../Abs/ImageUploadTransformationsPlugin.php | 6 +- .../Abs/InlineTransformationsPlugin.php | 2 +- .../Abs/LongToIPv4TransformationsPlugin.php | 2 +- .../Abs/PreApPendTransformationsPlugin.php | 2 +- .../RegexValidationTransformationsPlugin.php | 2 +- .../Abs/SQLTransformationsPlugin.php | 2 +- .../Abs/SubstringTransformationsPlugin.php | 2 +- .../TextFileUploadTransformationsPlugin.php | 6 +- .../TextImageLinkTransformationsPlugin.php | 2 +- .../Abs/TextLinkTransformationsPlugin.php | 2 +- .../Input/Text_Plain_Iptobinary.php | 6 +- .../Output/Text_Plain_Binarytoip.php | 2 +- .../Output/Text_Plain_Json.php | 2 +- .../Transformations/Output/Text_Plain_Xml.php | 2 +- .../classes/Plugins/TransformationsPlugin.php | 6 +- .../Options/OptionsPropertyOneItem.php | 4 +- libraries/classes/Relation.php | 24 +-- libraries/classes/Replication.php | 4 +- libraries/classes/ReplicationGui.php | 4 +- libraries/classes/Rte/Events.php | 2 +- libraries/classes/Rte/General.php | 4 +- libraries/classes/Rte/Routines.php | 12 +- libraries/classes/Rte/RteList.php | 8 +- libraries/classes/Rte/Triggers.php | 2 +- libraries/classes/Sanitize.php | 4 +- libraries/classes/SavedSearches.php | 4 +- libraries/classes/Scripts.php | 6 +- libraries/classes/Server/Privileges.php | 40 ++--- libraries/classes/Server/Status/Data.php | 10 +- libraries/classes/Server/Status/Monitor.php | 6 +- libraries/classes/Server/Status/Processes.php | 2 +- libraries/classes/Server/UserGroups.php | 4 +- libraries/classes/Sql.php | 42 ++--- libraries/classes/SubPartition.php | 6 +- libraries/classes/SysInfoWINNT.php | 2 +- libraries/classes/SystemDatabase.php | 2 +- libraries/classes/Table.php | 26 +-- libraries/classes/Template.php | 8 +- libraries/classes/Tracking.php | 64 +++---- libraries/classes/Url.php | 2 +- libraries/classes/UserPassword.php | 4 +- libraries/classes/UserPreferences.php | 6 +- libraries/classes/Util.php | 36 ++-- libraries/classes/VersionInformation.php | 2 +- setup/lib/ConfigGenerator.php | 2 +- test/classes/Config/FormTest.php | 4 +- .../Table/TableStructureControllerTest.php | 2 +- test/classes/CoreTest.php | 2 +- test/classes/Display/ResultsTest.php | 26 +-- 150 files changed, 759 insertions(+), 763 deletions(-) diff --git a/libraries/classes/Advisor.php b/libraries/classes/Advisor.php index 73e0070c86..4f6b2f53b8 100644 --- a/libraries/classes/Advisor.php +++ b/libraries/classes/Advisor.php @@ -122,7 +122,7 @@ class Advisor * * @return Advisor */ - public function setVariables($variables) + public function setVariables(array $variables) { $this->variables = $variables; @@ -161,7 +161,7 @@ class Advisor * * @return Advisor */ - public function setParseResult($parseResult) + public function setParseResult(array $parseResult) { $this->parseResult = $parseResult; @@ -185,7 +185,7 @@ class Advisor * * @return Advisor */ - public function setRunResult($runResult) + public function setRunResult(array $runResult) { $this->runResult = $runResult; @@ -357,7 +357,7 @@ class Advisor * * @return string[] */ - public static function splitJustification($rule) + public static function splitJustification(array $rule) { $jst = preg_split('/\s*\|\s*/', $rule['justification'], 2); if (count($jst) > 1) { @@ -374,7 +374,7 @@ class Advisor * * @return void */ - public function addRule($type, $rule) + public function addRule($type, array $rule) { switch ($type) { case 'notfired': @@ -430,7 +430,7 @@ class Advisor * * @return string Replacement value */ - private function replaceLinkURL($matches) + private function replaceLinkURL(array $matches) { return 'href="' . Core::linkURL($matches[2]) . '" target="_blank" rel="noopener noreferrer"'; } @@ -442,7 +442,7 @@ class Advisor * * @return string Replacement value */ - private function replaceVariable($matches) + private function replaceVariable(array $matches) { return '' . htmlspecialchars($matches[1]) . ''; diff --git a/libraries/classes/Bookmark.php b/libraries/classes/Bookmark.php index 01b0978d03..a38c4ddebe 100644 --- a/libraries/classes/Bookmark.php +++ b/libraries/classes/Bookmark.php @@ -166,11 +166,11 @@ class Bookmark /** * Replace the placeholders in the bookmark query with variables * - * @param array $variables array of variables + * @param array $variables array of variables * * @return string query with variables applied */ - public function applyVariables($variables) + public function applyVariables(array $variables) { // remove comments that encloses a variable placeholder $query = preg_replace( @@ -232,7 +232,7 @@ class Bookmark * * @return Bookmark|false */ - public static function createBookmark($bkm_fields, $all_users = false) + public static function createBookmark(array $bkm_fields, $all_users = false) { if (!(isset($bkm_fields['bkm_sql_query']) && strlen($bkm_fields['bkm_sql_query']) > 0 diff --git a/libraries/classes/BrowseForeigners.php b/libraries/classes/BrowseForeigners.php index a24dea96ec..c1f352fa57 100644 --- a/libraries/classes/BrowseForeigners.php +++ b/libraries/classes/BrowseForeigners.php @@ -30,8 +30,8 @@ class BrowseForeigners * * @return string $html the generated html */ - public static function getHtmlForOneKey($horizontal_count, $header, $keys, - $indexByKeyname, $descriptions, $indexByDescription, $current_value + public static function getHtmlForOneKey($horizontal_count, $header, array $keys, + $indexByKeyname, array $descriptions, $indexByDescription, $current_value ) { $horizontal_count++; $output = ''; @@ -114,7 +114,7 @@ class BrowseForeigners * * @return string */ - public static function getHtmlForRelationalFieldSelection($db, $table, $field, $foreignData, + public static function getHtmlForRelationalFieldSelection($db, $table, $field, array $foreignData, $fieldkey, $current_value ) { $gotopage = self::getHtmlForGotoPage($foreignData); @@ -277,7 +277,7 @@ class BrowseForeigners /** * Function to get html for show all case * - * @param array $foreignData foreign data + * @param array|null $foreignData foreign data * * @return string */ @@ -300,7 +300,7 @@ class BrowseForeigners /** * Function to get html for the goto page option * - * @param array $foreignData foreign data + * @param array|null $foreignData foreign data * * @return string */ diff --git a/libraries/classes/CentralColumns.php b/libraries/classes/CentralColumns.php index 23e201ef1f..3fbe903dcd 100644 --- a/libraries/classes/CentralColumns.php +++ b/libraries/classes/CentralColumns.php @@ -180,7 +180,7 @@ class CentralColumns * @return string query string to insert the given column * with definition into central list */ - public static function getInsertQuery($column, $def, $db, $central_list_table) + public static function getInsertQuery($column, array $def, $db, $central_list_table) { $type = ""; $length = 0; @@ -224,7 +224,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function syncUniqueColumns($field_select, $isTable=true, $table=null) + public static function syncUniqueColumns(array $field_select, $isTable=true, $table=null) { $cfgCentralColumns = self::getParams(); if (empty($cfgCentralColumns)) { @@ -329,7 +329,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function deleteColumnsFromList($field_select, $isTable=true) + public static function deleteColumnsFromList(array $field_select, $isTable=true) { $cfgCentralColumns = self::getParams(); if (empty($cfgCentralColumns)) { @@ -412,7 +412,7 @@ class CentralColumns * * @return true|PhpMyAdmin\Message */ - public static function makeConsistentWithList($db, $selected_tables) + public static function makeConsistentWithList($db, array $selected_tables) { $message = true; foreach ($selected_tables as $table) { @@ -731,7 +731,7 @@ class CentralColumns * * @return string html for table header in central columns multi edit page */ - public static function getEditTableHeader($header_cells) + public static function getEditTableHeader(array $header_cells) { $html = ''; @@ -842,7 +842,7 @@ class CentralColumns * * @return string html of a particular row in the central columns table. */ - public static function getHtmlForCentralColumnsTableRow($row, $row_num, $db) + public static function getHtmlForCentralColumnsTableRow(array $row, $row_num, $db) { $tableHtml = '' . Url::getHiddenInputs( @@ -1011,7 +1011,7 @@ class CentralColumns * * @return string html of a particular row in the central columns table. */ - public static function getHtmlForCentralColumnsEditTableRow($row, $row_num) + public static function getHtmlForCentralColumnsEditTableRow(array $row, $row_num) { $tableHtml = '' . '_defaultCfg; diff --git a/libraries/classes/Config/Form.php b/libraries/classes/Config/Form.php index f5ab1b7b7a..f7c670fa31 100644 --- a/libraries/classes/Config/Form.php +++ b/libraries/classes/Config/Form.php @@ -172,7 +172,7 @@ class Form * * @return void */ - protected function readFormPaths($form) + protected function readFormPaths(array $form) { // flatten form fields' paths and save them to $fields $this->fields = array(); @@ -224,7 +224,7 @@ class Form * * @return void */ - public function loadForm($form_name, $form) + public function loadForm($form_name, array $form) { $this->name = $form_name; $this->readFormPaths($form); diff --git a/libraries/classes/Config/FormDisplay.php b/libraries/classes/Config/FormDisplay.php index 78b0bf92d5..7d4c4577bf 100644 --- a/libraries/classes/Config/FormDisplay.php +++ b/libraries/classes/Config/FormDisplay.php @@ -268,13 +268,13 @@ class FormDisplay /** * Outputs HTML for forms * - * @param bool $tabbed_form if true, use a form with tabs - * @param bool $show_restore_default whether show "restore default" button - * besides the input field - * @param bool $show_buttons whether show submit and reset button - * @param string $form_action action attribute for the form - * @param array $hidden_fields array of form hidden fields (key: field - * name) + * @param bool $tabbed_form if true, use a form with tabs + * @param bool $show_restore_default whether show "restore default" button + * besides the input field + * @param bool $show_buttons whether show submit and reset button + * @param string $form_action action attribute for the form + * @param array|null $hidden_fields array of form hidden fields (key: field + * name) * * @return string HTML for forms */ @@ -867,7 +867,7 @@ class FormDisplay * * @return void */ - private function _fillPostArrayParameters($post_values, $key) + private function _fillPostArrayParameters(array $post_values, $key) { foreach ($post_values as $v) { $v = Util::requestString($v); diff --git a/libraries/classes/Config/FormDisplayTemplate.php b/libraries/classes/Config/FormDisplayTemplate.php index b1cc22710d..d4dff1997b 100644 --- a/libraries/classes/Config/FormDisplayTemplate.php +++ b/libraries/classes/Config/FormDisplayTemplate.php @@ -22,9 +22,9 @@ class FormDisplayTemplate /** * Displays top part of the form * - * @param string $action default: $_SERVER['REQUEST_URI'] - * @param string $method 'post' or 'get' - * @param array $hidden_fields array of form hidden fields (key: field name) + * @param string $action default: $_SERVER['REQUEST_URI'] + * @param string $method 'post' or 'get' + * @param array|null $hidden_fields array of form hidden fields (key: field name) * * @return string */ @@ -61,7 +61,7 @@ class FormDisplayTemplate * * @return string */ - public static function displayTabsTop($tabs) + public static function displayTabsTop(array $tabs) { $items = array(); foreach ($tabs as $tab_id => $tab_name) { @@ -87,15 +87,15 @@ class FormDisplayTemplate /** * Displays top part of a fieldset * - * @param string $title title of fieldset - * @param string $description description shown on top of fieldset - * @param array $errors error messages to display - * @param array $attributes optional extra attributes of fieldset + * @param string $title title of fieldset + * @param string $description description shown on top of fieldset + * @param array|null $errors error messages to display + * @param array $attributes optional extra attributes of fieldset * * @return string */ public static function displayFieldsetTop($title = '', $description = '', $errors = null, - $attributes = array() + array $attributes = array() ) { global $_FormDisplayGroup; @@ -141,13 +141,13 @@ class FormDisplayTemplate * o comment - (string) tooltip comment * o comment_warning - (bool) whether this comments warns about something * - * @param string $path config option path - * @param string $name config option name - * @param string $type type of config option - * @param mixed $value current value - * @param string $description verbose description - * @param bool $value_is_default whether value is default - * @param array $opts see above description + * @param string $path config option path + * @param string $name config option name + * @param string $type type of config option + * @param mixed $value current value + * @param string $description verbose description + * @param bool $value_is_default whether value is default + * @param array|null $opts see above description * * @return string */ @@ -482,7 +482,7 @@ class FormDisplayTemplate * * @return void */ - public static function addJsValidate($field_id, $validators, &$js_array) + public static function addJsValidate($field_id, $validators, array &$js_array) { foreach ((array)$validators as $validator) { $validator = (array)$validator; @@ -504,7 +504,7 @@ class FormDisplayTemplate * * @return string */ - public static function displayJavascript($js_array) + public static function displayJavascript(array $js_array) { if (empty($js_array)) { return null; @@ -523,7 +523,7 @@ class FormDisplayTemplate * * @return string HTML for errors */ - public static function displayErrors($name, $error_list) + public static function displayErrors($name, array $error_list) { $htmlOutput = '
'; $htmlOutput .= '
' . htmlspecialchars($name) . '
'; diff --git a/libraries/classes/Config/Validator.php b/libraries/classes/Config/Validator.php index 01c078c8d1..7b2ef2d9a0 100644 --- a/libraries/classes/Config/Validator.php +++ b/libraries/classes/Config/Validator.php @@ -93,7 +93,7 @@ class Validator * @return bool|array */ public static function validate( - ConfigFile $cf, $validator_id, &$values, $isPostSource + ConfigFile $cf, $validator_id, array &$values, $isPostSource ) { // find validators $validator_id = (array) $validator_id; @@ -235,7 +235,7 @@ class Validator * * @return array */ - public static function validateServer($path, $values) + public static function validateServer($path, array $values) { $result = array( 'Server' => '', @@ -307,7 +307,7 @@ class Validator * * @return array */ - public static function validatePMAStorage($path, $values) + public static function validatePMAStorage($path, array $values) { $result = array( 'Server_pmadb' => '', @@ -360,7 +360,7 @@ class Validator * * @return array */ - public static function validateRegex($path, $values) + public static function validateRegex($path, array $values) { $result = array($path => ''); @@ -402,7 +402,7 @@ class Validator * * @return array */ - public static function validateTrustedProxies($path, $values) + public static function validateTrustedProxies($path, array $values) { $result = array($path => array()); @@ -459,7 +459,7 @@ class Validator */ public static function validateNumber( $path, - $values, + array $values, $allow_neg, $allow_zero, $max_value, @@ -490,7 +490,7 @@ class Validator * * @return array */ - public static function validatePortNumber($path, $values) + public static function validatePortNumber($path, array $values) { return array( $path => static::validateNumber( @@ -512,7 +512,7 @@ class Validator * * @return array */ - public static function validatePositiveNumber($path, $values) + public static function validatePositiveNumber($path, array $values) { return array( $path => static::validateNumber( @@ -534,7 +534,7 @@ class Validator * * @return array */ - public static function validateNonNegativeNumber($path, $values) + public static function validateNonNegativeNumber($path, array $values) { return array( $path => static::validateNumber( @@ -558,7 +558,7 @@ class Validator * * @return array */ - public static function validateByRegex($path, $values, $regex) + public static function validateByRegex($path, array $values, $regex) { if (!isset($values[$path])) { return ''; @@ -576,7 +576,7 @@ class Validator * * @return array */ - public static function validateUpperBound($path, $values, $max_value) + public static function validateUpperBound($path, array $values, $max_value) { $result = $values[$path] <= $max_value; return array($path => ($result ? '' diff --git a/libraries/classes/Controllers/Database/DatabaseStructureController.php b/libraries/classes/Controllers/Database/DatabaseStructureController.php index 73a072b69d..bd80266e49 100644 --- a/libraries/classes/Controllers/Database/DatabaseStructureController.php +++ b/libraries/classes/Controllers/Database/DatabaseStructureController.php @@ -742,7 +742,7 @@ class DatabaseStructureController extends DatabaseController * * @return array */ - protected function isRowCountApproximated($current_table, $table_is_view) + protected function isRowCountApproximated(array $current_table, $table_is_view) { $approx_rows = false; $show_superscript = ''; @@ -846,7 +846,7 @@ class DatabaseStructureController extends DatabaseController protected function synchronizeFavoriteTables( $fav_instance, $user, - $favorite_tables + array $favorite_tables ) { $fav_instance_tables = $fav_instance->getTables(); @@ -899,7 +899,7 @@ class DatabaseStructureController extends DatabaseController * * @return bool */ - protected function hasTable($db, $truename) + protected function hasTable(array $db, $truename) { foreach ($db as $db_table) { if ($this->db == Replication::extractDbOrTable($db_table) @@ -926,7 +926,7 @@ class DatabaseStructureController extends DatabaseController * @internal param bool $table_is_view whether table is view or not */ protected function getStuffForEngineTypeTable( - $current_table, $sum_size, $overhead_size + array $current_table, $sum_size, $overhead_size ) { $formatted_size = '-'; $unit = ''; @@ -1018,7 +1018,7 @@ class DatabaseStructureController extends DatabaseController * @return array */ protected function getValuesForAriaTable( - $current_table, $sum_size, $overhead_size, $formatted_size, $unit, + array $current_table, $sum_size, $overhead_size, $formatted_size, $unit, $formatted_overhead, $overhead_unit ) { if ($this->_db_is_system_schema) { @@ -1059,7 +1059,7 @@ class DatabaseStructureController extends DatabaseController * @return array */ protected function getValuesForInnodbTable( - $current_table, $sum_size + array $current_table, $sum_size ) { $formatted_size = $unit = ''; diff --git a/libraries/classes/Controllers/Server/ServerBinlogController.php b/libraries/classes/Controllers/Server/ServerBinlogController.php index 31d5498c64..6d68e80c93 100644 --- a/libraries/classes/Controllers/Server/ServerBinlogController.php +++ b/libraries/classes/Controllers/Server/ServerBinlogController.php @@ -79,7 +79,7 @@ class ServerBinlogController extends Controller * * @return string */ - private function _getLogSelector($url_params) + private function _getLogSelector(array $url_params) { return Template::get('server/binlog/log_selector')->render( array( @@ -96,7 +96,7 @@ class ServerBinlogController extends Controller * * @return string */ - private function _getLogInfo($url_params) + private function _getLogInfo(array $url_params) { /** * Need to find the real end of rows? @@ -176,7 +176,7 @@ class ServerBinlogController extends Controller * * @return string */ - private function _getNavigationRow($url_params, $pos, $num_rows, $dontlimitchars) + private function _getNavigationRow(array $url_params, $pos, $num_rows, $dontlimitchars) { $html = ""; // we do not know how much rows are in the binlog diff --git a/libraries/classes/Controllers/Server/ServerCollationsController.php b/libraries/classes/Controllers/Server/ServerCollationsController.php index 90fd48b816..6b28dc958f 100644 --- a/libraries/classes/Controllers/Server/ServerCollationsController.php +++ b/libraries/classes/Controllers/Server/ServerCollationsController.php @@ -54,8 +54,8 @@ class ServerCollationsController extends Controller * * @return string */ - function _getHtmlForCharsets($mysqlCharsets, $mysqlCollations, - $mysqlCharsetsDesc, $mysqlDftCollations + function _getHtmlForCharsets(array $mysqlCharsets, array $mysqlCollations, + array $mysqlCharsetsDesc, array $mysqlDftCollations ) { return Template::get('server/collations/charsets')->render( array( diff --git a/libraries/classes/Controllers/Server/ServerDatabasesController.php b/libraries/classes/Controllers/Server/ServerDatabasesController.php index 97f6fd7ffd..063e71b136 100644 --- a/libraries/classes/Controllers/Server/ServerDatabasesController.php +++ b/libraries/classes/Controllers/Server/ServerDatabasesController.php @@ -262,9 +262,8 @@ class ServerDatabasesController extends Controller * * @return string */ - private function _getHtmlForDatabases($replication_types) + private function _getHtmlForDatabases(array $replication_types) { - $html = '
'; $first_database = reset($this->_databases); // table col order @@ -433,7 +432,7 @@ class ServerDatabasesController extends Controller * * @return string */ - private function _getHtmlForTableBody($column_order, $replication_types) + private function _getHtmlForTableBody(array $column_order, array $replication_types) { $html = '
' . "\n"; @@ -470,8 +469,8 @@ class ServerDatabasesController extends Controller * @return array $column_order, $out */ function _buildHtmlForDb( - $current, $column_order, - $replication_types, $replication_info, $tr_class = '' + array $current, array $column_order, + array $replication_types, array $replication_info, $tr_class = '' ) { $master_replication = $slave_replication = ''; foreach ($replication_types as $type) { @@ -535,7 +534,7 @@ class ServerDatabasesController extends Controller * @return string */ private function _getHtmlForTableHeader( - $_url_params, $column_order, $first_database + array $_url_params, array $column_order, array $first_database ) { return Template::get('server/databases/table_header')->render( array( diff --git a/libraries/classes/Controllers/Server/ServerVariablesController.php b/libraries/classes/Controllers/Server/ServerVariablesController.php index a57b6d819e..a3068c384e 100644 --- a/libraries/classes/Controllers/Server/ServerVariablesController.php +++ b/libraries/classes/Controllers/Server/ServerVariablesController.php @@ -289,7 +289,7 @@ class ServerVariablesController extends Controller * * @return string */ - private function _getHtmlForServerVariables($serverVars, $serverVarsSession) + private function _getHtmlForServerVariables(array $serverVars, array $serverVarsSession) { // filter $filterValue = ! empty($_REQUEST['filter']) ? $_REQUEST['filter'] : ''; @@ -322,7 +322,7 @@ class ServerVariablesController extends Controller * @return string */ private function _getHtmlForServerVariablesItems( - $serverVars, $serverVarsSession + array $serverVars, array $serverVarsSession ) { // list of static (i.e. non-editable) system variables $static_variables = $this->_getStaticSystemVariables(); diff --git a/libraries/classes/Controllers/Table/TableChartController.php b/libraries/classes/Controllers/Table/TableChartController.php index d23ee3f539..3f3e23d482 100644 --- a/libraries/classes/Controllers/Table/TableChartController.php +++ b/libraries/classes/Controllers/Table/TableChartController.php @@ -43,7 +43,7 @@ class TableChartController extends TableController * @param string $url_query Query URL * @param array $cfg Configuration */ - public function __construct($sql_query, $url_query, $cfg) + public function __construct($sql_query, $url_query, array $cfg) { parent::__construct(); diff --git a/libraries/classes/Controllers/Table/TableGisVisualizationController.php b/libraries/classes/Controllers/Table/TableGisVisualizationController.php index 775ad8775d..8ef0b7f063 100644 --- a/libraries/classes/Controllers/Table/TableGisVisualizationController.php +++ b/libraries/classes/Controllers/Table/TableGisVisualizationController.php @@ -56,10 +56,10 @@ class TableGisVisualizationController extends TableController */ public function __construct( $sql_query, - $url_params, + array $url_params, $goto, $back, - $visualizationSettings + array $visualizationSettings ) { parent::__construct(); diff --git a/libraries/classes/Controllers/Table/TableRelationController.php b/libraries/classes/Controllers/Table/TableRelationController.php index e85ab9d092..53ae952a9d 100644 --- a/libraries/classes/Controllers/Table/TableRelationController.php +++ b/libraries/classes/Controllers/Table/TableRelationController.php @@ -56,12 +56,12 @@ class TableRelationController extends TableController /** * Constructor * - * @param array $options_array Options - * @param array $cfgRelation Config relation - * @param string $tbl_storage_engine Table storage engine - * @param array $existrel Relations - * @param array $existrel_foreign External relations - * @param string $upd_query Update query + * @param array|null $options_array Options + * @param array|null $cfgRelation Config relation + * @param string $tbl_storage_engine Table storage engine + * @param array|null $existrel Relations + * @param array|null $existrel_foreign External relations + * @param string $upd_query Update query */ public function __construct($options_array, $cfgRelation, $tbl_storage_engine, $existrel, $existrel_foreign, $upd_query diff --git a/libraries/classes/Controllers/Table/TableStructureController.php b/libraries/classes/Controllers/Table/TableStructureController.php index 1a8fa69b75..2ad9849ba5 100644 --- a/libraries/classes/Controllers/Table/TableStructureController.php +++ b/libraries/classes/Controllers/Table/TableStructureController.php @@ -1067,7 +1067,7 @@ class TableStructureController extends TableController * @return boolean $changed boolean whether at least one column privileges * adjusted */ - protected function adjustColumnPrivileges($adjust_privileges) + protected function adjustColumnPrivileges(array $adjust_privileges) { $changed = false; @@ -1155,8 +1155,8 @@ class TableStructureController extends TableController * @return string */ protected function displayStructure( - $cfgRelation, $columns_with_unique_index, $url_params, - $primary_index, $fields, $columns_with_index + array $cfgRelation, array $columns_with_unique_index, $url_params, + $primary_index, array $fields, array $columns_with_index ) { /* TABLE INFORMATION */ $HideStructureActions = ''; diff --git a/libraries/classes/Core.php b/libraries/classes/Core.php index bbac3e353d..c0ef1589c4 100644 --- a/libraries/classes/Core.php +++ b/libraries/classes/Core.php @@ -388,7 +388,7 @@ class Core * * @return boolean whether $page is valid or not (in $whitelist or not) */ - public static function checkPageValidity(&$page, $whitelist) + public static function checkPageValidity(&$page, array $whitelist) { if (! isset($page) || !is_string($page)) { return false; @@ -592,7 +592,7 @@ class Core * * @return mixed array element or $default */ - public static function arrayRead($path, $array, $default = null) + public static function arrayRead($path, array $array, $default = null) { $keys = explode('/', $path); $value =& $array; @@ -614,7 +614,7 @@ class Core * * @return void */ - public static function arrayWrite($path, &$array, $value) + public static function arrayWrite($path, array &$array, $value) { $keys = explode('/', $path); $last_key = array_pop($keys); @@ -636,7 +636,7 @@ class Core * * @return void */ - public static function arrayRemove($path, &$array) + public static function arrayRemove($path, array &$array) { $keys = explode('/', $path); $keys_last = array_pop($keys); @@ -828,7 +828,7 @@ class Core * * @return void */ - public static function setPostAsGlobal($post_patterns) + public static function setPostAsGlobal(array $post_patterns) { foreach (array_keys($_POST) as $post_key) { foreach ($post_patterns as $one_post_pattern) { diff --git a/libraries/classes/CreateAddField.php b/libraries/classes/CreateAddField.php index e7a9424f09..b8b8bff319 100644 --- a/libraries/classes/CreateAddField.php +++ b/libraries/classes/CreateAddField.php @@ -148,7 +148,7 @@ class CreateAddField * * @return array an array of sql statements for indexes */ - public static function buildIndexStatements($index, $index_choice, + public static function buildIndexStatements(array $index, $index_choice, $is_create_tbl = true ) { $statement = array(); @@ -235,7 +235,7 @@ class CreateAddField * @return array $index_definitions */ public static function mergeIndexStatements( - $definitions, $is_create_tbl, $indexed_columns, $index_keyword + array $definitions, $is_create_tbl, array $indexed_columns, $index_keyword ) { foreach ($indexed_columns as $index) { $statements = self::buildIndexStatements( @@ -351,7 +351,7 @@ class CreateAddField * * @return string partition/subpartition definition */ - public static function getPartitionDefinition($partition, $isSubPartition = false) + public static function getPartitionDefinition(array $partition, $isSubPartition = false) { $sql_query = " " . ($isSubPartition ? "SUB" : "") . "PARTITION "; $sql_query .= $partition['name']; diff --git a/libraries/classes/Database/Designer.php b/libraries/classes/Database/Designer.php index 763ae5ae3c..4d1c6ab3d1 100644 --- a/libraries/classes/Database/Designer.php +++ b/libraries/classes/Database/Designer.php @@ -30,7 +30,7 @@ class Designer * * @return string html content */ - public static function getHtmlForPageSelector($cfgRelation, $db) + public static function getHtmlForPageSelector(array $cfgRelation, $db) { return Template::get('database/designer/page_selector') ->render( @@ -149,7 +149,7 @@ class Designer * @return string html */ public static function getHtmlForJsFields( - $script_tables, $script_contr, $script_display_field, $display_page + array $script_tables, array $script_contr, array $script_display_field, $display_page ) { return Template::get('database/designer/js_fields') ->render( @@ -172,7 +172,7 @@ class Designer * * @return string html */ - public static function getPageMenu($visualBuilder, $selected_page, $params_array) + public static function getPageMenu($visualBuilder, $selected_page, array $params_array) { return Template::get('database/designer/side_menu') ->render( @@ -290,7 +290,7 @@ class Designer * * @return string html */ - public static function getHtmlTableList($tab_pos, $display_page) + public static function getHtmlTableList(array $tab_pos, $display_page) { return Template::get('database/designer/table_list') ->render( @@ -313,7 +313,7 @@ class Designer * @return string html */ public static function getDatabaseTables( - $tab_pos, $display_page, $tab_column, $tables_all_keys, $tables_pk_or_unique_keys + array $tab_pos, $display_page, array $tab_column, array $tables_all_keys, array $tables_pk_or_unique_keys ) { return Template::get('database/designer/database_tables') ->render( diff --git a/libraries/classes/DatabaseInterface.php b/libraries/classes/DatabaseInterface.php index a37a860e6c..b3cd9b308d 100644 --- a/libraries/classes/DatabaseInterface.php +++ b/libraries/classes/DatabaseInterface.php @@ -155,7 +155,7 @@ class DatabaseInterface * * @return mixed cached value or default */ - public function getCachedTableContent($contentPath, $default = null) + public function getCachedTableContent(array $contentPath, $default = null) { return Util::getValueByKey($this->_table_cache, $contentPath, $default); } @@ -168,7 +168,7 @@ class DatabaseInterface * * @return void */ - public function cacheTableContent($contentPath, $value) + public function cacheTableContent(array $contentPath, $value) { $loc = &$this->_table_cache; @@ -212,7 +212,7 @@ class DatabaseInterface * * @return void */ - private function _cacheTableData($tables, $table) + private function _cacheTableData(array $tables, $table) { // Note: I don't see why we would need array_merge_recursive() here, // as it creates double entries for the same table (for example a double @@ -1000,7 +1000,7 @@ class DatabaseInterface * * @return array */ - public function getColumnMapFromSql($sql_query, $view_columns = array()) + public function getColumnMapFromSql($sql_query, array $view_columns = array()) { $result = $this->tryQuery($sql_query); @@ -1594,7 +1594,7 @@ class DatabaseInterface * * @return mixed */ - private function _fetchValue($row, $value) + private function _fetchValue(array $row, $value) { if (is_null($value)) { return $row; @@ -2276,9 +2276,9 @@ class DatabaseInterface /** * Return connection parameters for the database server * - * @param integer $mode Connection mode on of CONNECT_USER, CONNECT_CONTROL - * or CONNECT_AUXILIARY. - * @param array $server Server information like host/port/socket/persistent + * @param integer $mode Connection mode on of CONNECT_USER, CONNECT_CONTROL + * or CONNECT_AUXILIARY. + * @param array|null $server Server information like host/port/socket/persistent * * @return array user, host and server settings array */ @@ -2364,9 +2364,9 @@ class DatabaseInterface /** * connects to the database server * - * @param integer $mode Connection mode on of CONNECT_USER, CONNECT_CONTROL - * or CONNECT_AUXILIARY. - * @param array $server Server information like host/port/socket/persistent + * @param integer $mode Connection mode on of CONNECT_USER, CONNECT_CONTROL + * or CONNECT_AUXILIARY. + * @param array|null $server Server information like host/port/socket/persistent * * @return mixed false on error or a connection object on success */ diff --git a/libraries/classes/DbQbe.php b/libraries/classes/DbQbe.php index 7c4e859b9f..c8f5b1b980 100644 --- a/libraries/classes/DbQbe.php +++ b/libraries/classes/DbQbe.php @@ -248,7 +248,7 @@ class DbQbe * @param SavedSearches $currentSearch Current search id */ public function __construct( - $dbname, $savedSearchList = array(), $currentSearch = null + $dbname, array $savedSearchList = array(), $currentSearch = null ) { $this->_db = $dbname; $this->_savedSearchList = $savedSearchList; @@ -866,9 +866,9 @@ class DbQbe * Provides And/Or modification cell along with Insert/Delete options * (For modifying search form's table columns) * - * @param integer $column_number Column Number (0,1,2) or more - * @param array $selected Selected criteria column name - * @param bool $last_column Whether this is the last column + * @param integer $column_number Column Number (0,1,2) or more + * @param array|null $selected Selected criteria column name + * @param bool $last_column Whether this is the last column * * @return string HTML for modification cell */ @@ -961,7 +961,7 @@ class DbQbe * * @return string HTML */ - private function _getInsDelAndOrCell($row_index, $checked_options) + private function _getInsDelAndOrCell($row_index, array $checked_options) { $html_output = '' . "\n"; @@ -3529,7 +3529,7 @@ class Results * @see _getTableBody() */ private function _getDeleteAndKillLinks( - $where_clause, $clause_is_unique, $url_sql_query, $del_lnk, $row + $where_clause, $clause_is_unique, $url_sql_query, $del_lnk, array $row ) { $goto = $this->__get('goto'); @@ -3670,8 +3670,8 @@ class Results * @see _getTableBody() */ private function _getPlacedLinks( - $dir, $del_url, $displayParts, $row_no, $where_clause, $where_clause_html, - $condition_array, $edit_url, $copy_url, + $dir, $del_url, array $displayParts, $row_no, $where_clause, $where_clause_html, + array $condition_array, $edit_url, $copy_url, $edit_anchor_class, $edit_str, $copy_str, $del_str, $js_conf ) { @@ -3771,9 +3771,9 @@ class Results * @see _getTableBody() */ private function _getDataCellForNumericColumns( - $column, $class, $condition_field, $meta, $map, $is_field_truncated, - $analyzed_sql_results, $transformation_plugin, $default_function, - $transform_options + $column, $class, $condition_field, $meta, array $map, $is_field_truncated, + array $analyzed_sql_results, $transformation_plugin, $default_function, + array $transform_options ) { if (! isset($column) || is_null($column)) { @@ -3831,9 +3831,9 @@ class Results * @see _getTableBody() */ private function _getDataCellForGeometryColumns( - $column, $class, $meta, $map, $_url_params, $condition_field, + $column, $class, $meta, array $map, array $_url_params, $condition_field, $transformation_plugin, $default_function, $transform_options, - $analyzed_sql_results + array $analyzed_sql_results ) { if (! isset($column) || is_null($column)) { $cell = $this->_buildNullDisplay($class, $condition_field, $meta); @@ -3948,9 +3948,9 @@ class Results * @see _getTableBody() */ private function _getDataCellForNonNumericColumns( - $column, $class, $meta, $map, $_url_params, $condition_field, + $column, $class, $meta, array $map, array $_url_params, $condition_field, $transformation_plugin, $default_function, $transform_options, - $is_field_truncated, $analyzed_sql_results, &$dt_result, $col_index + $is_field_truncated, array $analyzed_sql_results, &$dt_result, $col_index ) { $original_length = 0; @@ -4246,7 +4246,7 @@ class Results * @see sql.php file */ public function getTable( - &$dt_result, &$displayParts, $analyzed_sql_results, + &$dt_result, array &$displayParts, array $analyzed_sql_results, $is_limited_display = false ) { @@ -4661,7 +4661,7 @@ class Results * @see getTable() */ private function _setMessageInformation( - $sorted_column_message, $analyzed_sql_results, $total, + $sorted_column_message, array $analyzed_sql_results, $total, $pos_next, $pre_count, $after_count ) { @@ -4753,10 +4753,8 @@ class Results } return $message; - } // end of the '_setMessageInformation()' function - /** * Set the value of $map array for linking foreign key related tables * @@ -4768,9 +4766,8 @@ class Results * * @see getTable() */ - private function _setParamForLinkForeignKeyRelatedTables(&$map) + private function _setParamForLinkForeignKeyRelatedTables(array &$map) { - // To be able to later display a link to the related table, // we verify both types of relations: either those that are // native foreign keys or those defined in the phpMyAdmin @@ -4836,7 +4833,7 @@ class Results * @see getTable() */ private function _getMultiRowOperationLinks( - &$dt_result, $analyzed_sql_results, $del_link + &$dt_result, array $analyzed_sql_results, $del_link ) { $links_html = '
'; $html_output .= ''; @@ -1308,8 +1308,8 @@ class DbQbe * * @return array having UNIQUE and INDEX columns */ - private function _getIndexes($search_tables, $search_columns, - $where_clause_columns + private function _getIndexes(array $search_tables, array $search_columns, + array $where_clause_columns ) { $unique_columns = array(); $index_columns = array(); @@ -1351,8 +1351,8 @@ class DbQbe * * @return array having UNIQUE and INDEX columns */ - private function _getLeftJoinColumnCandidates($search_tables, $search_columns, - $where_clause_columns + private function _getLeftJoinColumnCandidates(array $search_tables, array $search_columns, + array $where_clause_columns ) { $GLOBALS['dbi']->selectDb($this->_db); @@ -1411,8 +1411,8 @@ class DbQbe * * @return string table name */ - private function _getMasterTable($search_tables, $search_columns, - $where_clause_columns, $where_clause_tables + private function _getMasterTable(array $search_tables, array $search_columns, + array $where_clause_columns, array $where_clause_tables ) { if (count($where_clause_tables) == 1) { // If there is exactly one column that has a decent where-clause @@ -1532,7 +1532,7 @@ class DbQbe * * @return string FROM clause */ - private function _getFromClause($formColumns) + private function _getFromClause(array $formColumns) { $from_clause = ''; if (empty($formColumns)) { @@ -1579,7 +1579,7 @@ class DbQbe * * @return string table name */ - private function _getJoinForFromClause($searchTables, $searchColumns) + private function _getJoinForFromClause(array $searchTables, array $searchColumns) { // $relations[master_table][foreign_table] => clause $relations = array(); @@ -1702,7 +1702,7 @@ class DbQbe * * @return void */ - private function _loadRelationsForTable(&$relations, $oneTable) + private function _loadRelationsForTable(array &$relations, $oneTable) { $relations[$oneTable] = array(); @@ -1743,7 +1743,7 @@ class DbQbe * * @return void */ - private function _fillJoinClauses(&$finalized, $relations, $searchTables) + private function _fillJoinClauses(array &$finalized, array $relations, array $searchTables) { while (true) { $added = false; @@ -1784,7 +1784,7 @@ class DbQbe * * @return string SQL query */ - private function _getSQLQuery($formColumns) + private function _getSQLQuery(array $formColumns) { $sql_query = ''; // get SELECT clause @@ -1967,7 +1967,7 @@ class DbQbe * @return array */ private function _getLeftJoinColumnCandidatesBest( - $search_tables, $where_clause_columns, $unique_columns, $index_columns + array $search_tables, array $where_clause_columns, array $unique_columns, array $index_columns ) { // now we want to find the best. if (isset($unique_columns) && count($unique_columns) > 0) { diff --git a/libraries/classes/DbSearch.php b/libraries/classes/DbSearch.php index a5dbeea19a..e7c47425d9 100644 --- a/libraries/classes/DbSearch.php +++ b/libraries/classes/DbSearch.php @@ -312,7 +312,7 @@ class DbSearch * * @return string HTML row */ - private function _getResultsRow($each_table, $newsearchsqls, $res_cnt) + private function _getResultsRow($each_table, array $newsearchsqls, $res_cnt) { $this_url_params = array( 'db' => $GLOBALS['db'], diff --git a/libraries/classes/Dbi/DbiDummy.php b/libraries/classes/Dbi/DbiDummy.php index 8eb6cdcd62..35cd9a0e3c 100644 --- a/libraries/classes/Dbi/DbiDummy.php +++ b/libraries/classes/Dbi/DbiDummy.php @@ -41,7 +41,7 @@ class DbiDummy implements DbiExtension public function connect( $user, $password, - $server = null + array $server = [] ) { return true; } diff --git a/libraries/classes/Dbi/DbiExtension.php b/libraries/classes/Dbi/DbiExtension.php index a133f8082d..b1b9ffae6c 100644 --- a/libraries/classes/Dbi/DbiExtension.php +++ b/libraries/classes/Dbi/DbiExtension.php @@ -23,7 +23,7 @@ interface DbiExtension * @return mixed false on error or a connection object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ); /** diff --git a/libraries/classes/Dbi/DbiMysql.php b/libraries/classes/Dbi/DbiMysql.php index ecea5a8cfd..d3fedb3a2b 100644 --- a/libraries/classes/Dbi/DbiMysql.php +++ b/libraries/classes/Dbi/DbiMysql.php @@ -92,7 +92,7 @@ class DbiMysql implements DbiExtension * @return mixed false on error or a mysqli object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ) { if ($server['port'] === 0) { $server_port = ''; diff --git a/libraries/classes/Dbi/DbiMysqli.php b/libraries/classes/Dbi/DbiMysqli.php index 182878646f..0c1d332345 100644 --- a/libraries/classes/Dbi/DbiMysqli.php +++ b/libraries/classes/Dbi/DbiMysqli.php @@ -76,7 +76,7 @@ class DbiMysqli implements DbiExtension * @return mixed false on error or a mysqli object on success */ public function connect( - $user, $password, $server + $user, $password, array $server ) { if ($server) { $server['host'] = (empty($server['host'])) diff --git a/libraries/classes/Di/AliasItem.php b/libraries/classes/Di/AliasItem.php index a0893bdfa5..3f461dd2fd 100644 --- a/libraries/classes/Di/AliasItem.php +++ b/libraries/classes/Di/AliasItem.php @@ -39,7 +39,7 @@ class AliasItem implements Item * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->container->get($this->target, $params); } diff --git a/libraries/classes/Di/Container.php b/libraries/classes/Di/Container.php index cba560a46e..bd633a44d1 100644 --- a/libraries/classes/Di/Container.php +++ b/libraries/classes/Di/Container.php @@ -52,7 +52,7 @@ class Container implements ContainerInterface * * @return mixed */ - public function get($name, $params = array()) + public function get($name, array $params = array()) { if (!$this->has($name)) { throw new NotFoundException("No entry was found for $name identifier."); diff --git a/libraries/classes/Di/FactoryItem.php b/libraries/classes/Di/FactoryItem.php index 21e6b948ed..16a096cd49 100644 --- a/libraries/classes/Di/FactoryItem.php +++ b/libraries/classes/Di/FactoryItem.php @@ -22,7 +22,7 @@ class FactoryItem extends ReflectorItem * * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->invoke($params); } diff --git a/libraries/classes/Di/Item.php b/libraries/classes/Di/Item.php index 882428d317..9ddd6a8f21 100644 --- a/libraries/classes/Di/Item.php +++ b/libraries/classes/Di/Item.php @@ -21,5 +21,5 @@ interface Item * @param array $params Parameters * @return mixed */ - public function get($params = array()); + public function get(array $params = array()); } diff --git a/libraries/classes/Di/ReflectorItem.php b/libraries/classes/Di/ReflectorItem.php index 72ab683c4a..228a1f7fe4 100644 --- a/libraries/classes/Di/ReflectorItem.php +++ b/libraries/classes/Di/ReflectorItem.php @@ -39,7 +39,7 @@ abstract class ReflectorItem implements Item * @param array $params Parameters * @return mixed */ - protected function invoke($params = array()) + protected function invoke(array $params = array()) { $args = array(); $reflector = $this->_reflector; @@ -74,7 +74,7 @@ abstract class ReflectorItem implements Item * *@return array */ - private function _resolveArgs($required, $params = array()) + private function _resolveArgs($required, array $params = array()) { $args = array(); foreach ($required as $param) { diff --git a/libraries/classes/Di/ServiceItem.php b/libraries/classes/Di/ServiceItem.php index 608e8a482d..25a4576f11 100644 --- a/libraries/classes/Di/ServiceItem.php +++ b/libraries/classes/Di/ServiceItem.php @@ -24,7 +24,7 @@ class ServiceItem extends ReflectorItem * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { if (!isset($this->instance)) { $this->instance = $this->invoke(); diff --git a/libraries/classes/Di/ValueItem.php b/libraries/classes/Di/ValueItem.php index 52f20509f9..2997a374de 100644 --- a/libraries/classes/Di/ValueItem.php +++ b/libraries/classes/Di/ValueItem.php @@ -34,7 +34,7 @@ class ValueItem implements Item * @param array $params Parameters * @return mixed */ - public function get($params = array()) + public function get(array $params = array()) { return $this->value; } diff --git a/libraries/classes/Display/Export.php b/libraries/classes/Display/Export.php index 6bef98947b..272557fdd5 100644 --- a/libraries/classes/Display/Export.php +++ b/libraries/classes/Display/Export.php @@ -1064,7 +1064,7 @@ class Export * * @return void */ - public static function handleExportTemplateActions($cfgRelation) + public static function handleExportTemplateActions(array $cfgRelation) { if (isset($_REQUEST['templateId'])) { $id = $GLOBALS['dbi']->escapeString($_REQUEST['templateId']); diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php index b7c4d49da3..e6d1a50c3b 100644 --- a/libraries/classes/Display/Results.php +++ b/libraries/classes/Display/Results.php @@ -437,7 +437,7 @@ class Results * @access private * */ - private function _setDisplayPartsForPrintView($displayParts) + private function _setDisplayPartsForPrintView(array $displayParts) { // set all elements to false! $displayParts['edit_lnk'] = self::NO_EDIT_OR_DELETE; // no edit link @@ -461,7 +461,7 @@ class Results * @access private * */ - private function _setDisplayPartsForShow($displayParts) + private function _setDisplayPartsForShow(array $displayParts) { preg_match( '@^SHOW[[:space:]]+(VARIABLES|(FULL[[:space:]]+)?' @@ -509,7 +509,7 @@ class Results * @access private * */ - private function _setDisplayPartsForNonData($displayParts) + private function _setDisplayPartsForNonData(array $displayParts) { // Statement is a "SELECT COUNT", a // "CHECK/ANALYZE/REPAIR/OPTIMIZE/CHECKSUM", an "EXPLAIN" one or @@ -540,7 +540,7 @@ class Results * @access private * */ - private function _setDisplayPartsForSelect($displayParts) + private function _setDisplayPartsForSelect(array $displayParts) { // Other statements (ie "SELECT" ones) -> updates // $displayParts['edit_lnk'], $displayParts['del_lnk'] and @@ -611,7 +611,7 @@ class Results * * @see getTable() */ - private function _setDisplayPartsAndTotal($displayParts) + private function _setDisplayPartsAndTotal(array $displayParts) { $the_total = 0; @@ -690,7 +690,7 @@ class Results * * @see _getTableHeaders(), _getColumnParams() */ - private function _isSelect($analyzed_sql_results) + private function _isSelect(array $analyzed_sql_results) { return ! ($this->__get('is_count') || $this->__get('is_export') @@ -1178,8 +1178,8 @@ class Results * @see getTableHeaders() */ private function _getTableHeadersForColumns( - $displayParts, $analyzed_sql_results, $sort_expression, - $sort_expression_nodirection, $sort_direction, $is_limited_display, + array $displayParts, array $analyzed_sql_results, array $sort_expression, + array $sort_expression_nodirection, array $sort_direction, $is_limited_display, $unsorted_sql_query ) { $html = ''; @@ -1268,15 +1268,15 @@ class Results /** * Get the headers of the results table * - * @param array &$displayParts which elements to display - * @param array $analyzed_sql_results analyzed sql results - * @param string $unsorted_sql_query the unsorted sql query - * @param array $sort_expression sort expression - * @param array $sort_expression_nodirection sort expression - * without direction - * @param array $sort_direction sort direction - * @param boolean $is_limited_display with limited operations - * or not + * @param array &$displayParts which elements to display + * @param array $analyzed_sql_results analyzed sql results + * @param string $unsorted_sql_query the unsorted sql query + * @param array $sort_expression sort expression + * @param array|string $sort_expression_nodirection sort expression + * without direction + * @param array $sort_direction sort direction + * @param boolean $is_limited_display with limited operations + * or not * * @return string html content * @@ -1285,9 +1285,9 @@ class Results * @see getTable() */ private function _getTableHeaders( - &$displayParts, $analyzed_sql_results, $unsorted_sql_query, - $sort_expression = array(), $sort_expression_nodirection = '', - $sort_direction = array(), $is_limited_display = false + array &$displayParts, array $analyzed_sql_results, $unsorted_sql_query, + array $sort_expression = array(), $sort_expression_nodirection = '', + array $sort_direction = array(), $is_limited_display = false ) { $table_headers_html = ''; @@ -1379,7 +1379,7 @@ class Results * @see _getTableHeaders() */ private function _getUnsortedSqlAndSortByKeyDropDown( - $analyzed_sql_results, $sort_expression + array $analyzed_sql_results, $sort_expression ) { $drop_down_html = ''; @@ -1517,7 +1517,7 @@ class Results * @see _getTableHeaders() */ private function _getFieldVisibilityParams( - &$displayParts, $full_or_partial_text_link + array &$displayParts, $full_or_partial_text_link ) { $button_html = ''; @@ -1592,7 +1592,7 @@ class Results * * @see _getTableHeaders() */ - private function _getTableCommentsArray($analyzed_sql_results) + private function _getTableCommentsArray(array $analyzed_sql_results) { if ((!$GLOBALS['cfg']['ShowBrowseComments']) || (empty($analyzed_sql_results['statement']->from)) @@ -1627,7 +1627,7 @@ class Results * * @see _getTableHeaders() */ - private function _setHighlightedColumnGlobalField($analyzed_sql_results) + private function _setHighlightedColumnGlobalField(array $analyzed_sql_results) { $highlight_columns = array(); @@ -1655,7 +1655,7 @@ class Results * * @see _getTableHeaders() */ - private function _getDataForResettingColumnOrder($analyzed_sql_results) + private function _getDataForResettingColumnOrder(array $analyzed_sql_results) { if (! $this->_isSelect($analyzed_sql_results)) { return ''; @@ -1922,7 +1922,7 @@ class Results * * @see _getTableHeaders() */ - private function _getCommentForRow($comments_map, $fields_meta) + private function _getCommentForRow(array $comments_map, $fields_meta) { $comments = ''; if (isset($comments_map[$fields_meta->table]) @@ -1969,9 +1969,9 @@ class Results * @see _getTableHeaders() */ private function _getOrderLinkAndSortedHeaderHtml( - $fields_meta, $sort_expression, $sort_expression_nodirection, + $fields_meta, array $sort_expression, array $sort_expression_nodirection, $column_index, $unsorted_sql_query, $session_max_rows, - $comments, $sort_direction, $col_visib, $col_visib_j + $comments, array $sort_direction, $col_visib, $col_visib_j ) { $sorted_header_html = ''; @@ -2065,8 +2065,8 @@ class Results * @see _getOrderLinkAndSortedHeaderHtml() */ private function _getSingleAndMultiSortUrls( - $sort_expression, $sort_expression_nodirection, $sort_tbl, - $name_to_use_in_sort, $sort_direction, $fields_meta, $column_index + array $sort_expression, array $sort_expression_nodirection, $sort_tbl, + $name_to_use_in_sort, array $sort_direction, $fields_meta, $column_index ) { $sort_order = ""; // Check if the current column is in the order by clause @@ -2195,7 +2195,7 @@ class Results * @see _getTableHeaders() */ private function _isInSorted( - $sort_expression, $sort_expression_nodirection, $sort_tbl, + array $sort_expression, array $sort_expression_nodirection, $sort_tbl, $name_to_use_in_sort ) { @@ -2271,7 +2271,7 @@ class Results * * @see _getSingleAndMultiSortUrls() */ - private function _getSortingUrlParams($sort_direction, $sort_order, $index) + private function _getSortingUrlParams(array $sort_direction, $sort_order, $index) { if (strtoupper(trim($sort_direction[$index])) == self::DESCENDING_SORT_DIR) { $sort_order .= ' ASC'; @@ -2341,7 +2341,7 @@ class Results * * @see _getDraggableClassForSortableColumns() */ - private function _getClassForNumericColumnType($fields_meta,&$th_class) + private function _getClassForNumericColumnType($fields_meta, array &$th_class) { if (preg_match( '@int|decimal|float|double|real|bit|boolean|serial@i', @@ -2460,7 +2460,7 @@ class Results * @see _getTableHeaders() */ private function _getColumnAtRightSide( - &$displayParts, $full_or_partial_text_link, $colspan + array &$displayParts, $full_or_partial_text_link, $colspan ) { $right_column_html = ''; @@ -2675,7 +2675,7 @@ class Results * @see getTable() */ private function _getTableBody( - &$dt_result, &$displayParts, $map, $analyzed_sql_results, + &$dt_result, array &$displayParts, array $map, array $analyzed_sql_results, $is_limited_display = false ) { @@ -2964,7 +2964,7 @@ class Results * displayed * @param array $row current row data * @param integer $row_no the index of current row - * @param array $col_order the column order false when + * @param array|boolean $col_order the column order false when * a property not found false * when a property not found * @param array $map the list of relations @@ -2983,9 +2983,9 @@ class Results * @see _getTableBody() */ private function _getRowValues( - &$dt_result, $row, $row_no, $col_order, $map, + &$dt_result, array $row, $row_no, $col_order, array $map, $grid_edit_class, $col_visib, - $url_sql_query, $analyzed_sql_results + $url_sql_query, array $analyzed_sql_results ) { $row_values_html = ''; @@ -3263,7 +3263,7 @@ class Results * * @return string generated link */ - private function _getSpecialLinkUrl($column_value, $row_info, $field_name) + private function _getSpecialLinkUrl($column_value, array $row_info, $field_name) { $linking_url_params = array(); @@ -3317,12 +3317,12 @@ class Results /** * Prepare row information for display special links * - * @param array $row current row data - * @param array $col_order the column order + * @param array $row current row data + * @param array|boolean $col_order the column order * * @return array $row_info associative array with column nama -> value */ - private function _getRowInfoForSpecialLinks($row, $col_order) + private function _getRowInfoForSpecialLinks(array $row, $col_order) { $row_info = array(); @@ -3349,7 +3349,7 @@ class Results * * @see _getTableBody() */ - private function _getUrlSqlQuery($analyzed_sql_results) + private function _getUrlSqlQuery(array $analyzed_sql_results) { if (($analyzed_sql_results['querytype'] != 'SELECT') || (mb_strlen($this->__get('sql_query')) < 200) @@ -3389,7 +3389,7 @@ class Results * * @see _getTableBody() */ - private function _getColumnParams($analyzed_sql_results) + private function _getColumnParams(array $analyzed_sql_results) { if ($this->_isSelect($analyzed_sql_results)) { $pmatable = new Table($this->__get('table'), $this->__get('db')); @@ -3426,7 +3426,7 @@ class Results * @see _getTableBody() */ private function _getRepeatingHeaders( - $display_params + array $display_params ) { $header_html = '
' @@ -1688,8 +1688,8 @@ class InsertEdit * $special_chars_encoded */ public static function getSpecialCharsAndBackupFieldForExistingRow( - $current_row, $column, $extracted_columnspec, - $real_null_value, $gis_data_types, $column_name_appendix, $as_is + array $current_row, array $column, array $extracted_columnspec, + $real_null_value, array $gis_data_types, $column_name_appendix, $as_is ) { $special_chars_encoded = ''; $data = null; @@ -1784,7 +1784,7 @@ class InsertEdit * $backup_field, $special_chars_encoded */ public static function getSpecialCharsAndBackupFieldForInsertingMode( - $column, $real_null_value + array $column, $real_null_value ) { if (! isset($column['Default'])) { $column['Default'] = ''; @@ -1957,7 +1957,7 @@ class InsertEdit * * @return string error url for query failure */ - public static function getErrorUrl($url_params) + public static function getErrorUrl(array $url_params) { if (isset($_REQUEST['err_url'])) { return $_REQUEST['err_url']; @@ -1975,7 +1975,7 @@ class InsertEdit * * @return array of query */ - public static function buildSqlQuery($is_insertignore, $query_fields, $value_sets) + public static function buildSqlQuery($is_insertignore, array $query_fields, array $value_sets) { if ($is_insertignore) { $insert_command = 'INSERT IGNORE '; @@ -2001,7 +2001,7 @@ class InsertEdit * @return array $url_params, $total_affected_rows, $last_messages * $warning_messages, $error_messages, $return_to_sql_query */ - public static function executeSqlQuery($url_params, $query) + public static function executeSqlQuery(array $url_params, array $query) { $return_to_sql_query = ''; if (! empty($GLOBALS['sql_query'])) { @@ -2090,7 +2090,7 @@ class InsertEdit * @return string $dispval display value from the foreign table */ public static function getDisplayValueForForeignTableColumn($where_comparison, - $map, $relation_field + array $map, $relation_field ) { $foreigner = Relation::searchColumnInForeigners($map, $relation_field); $display_field = Relation::getDisplayField( @@ -2132,7 +2132,7 @@ class InsertEdit * * @return string $output HTML tag */ - public static function getLinkForRelationalDisplayField($map, $relation_field, + public static function getLinkForRelationalDisplayField(array $map, $relation_field, $where_comparison, $dispval, $relation_field_value ) { $foreigner = Relation::searchColumnInForeigners($map, $relation_field); @@ -2186,7 +2186,7 @@ class InsertEdit * @return array $extra_data */ public static function transformEditedValues($db, $table, - $transformation, &$edited_values, $file, $column_name, $extra_data, $type + array $transformation, array &$edited_values, $file, $column_name, array $extra_data, $type ) { $include_file = 'libraries/classes/Plugins/Transformations/' . $file; if (is_file($include_file)) { @@ -2236,7 +2236,7 @@ class InsertEdit * * @return array $cur_value */ - public static function getCurrentValueAsAnArrayForMultipleEdit( $multi_edit_funcs, + public static function getCurrentValueAsAnArrayForMultipleEdit($multi_edit_funcs, $multi_edit_salt, $gis_from_text_functions, $current_value, $gis_from_wkb_functions, $func_optional_param, $func_no_param, $key @@ -2300,7 +2300,7 @@ class InsertEdit */ public static function getQueryValuesForInsertAndUpdateInMultipleEdit($multi_edit_columns_name, $multi_edit_columns_null, $current_value, $multi_edit_columns_prev, - $multi_edit_funcs,$is_insert, $query_values, $query_fields, + $multi_edit_funcs, $is_insert, $query_values, $query_fields, $current_value_as_an_array, $value_sets, $key, $multi_edit_columns_null_prev ) { // i n s e r t @@ -2479,7 +2479,7 @@ class InsertEdit * @return void */ public static function verifyWhetherValueCanBeTruncatedAndAppendExtraData( - $db, $table, $column_name, &$extra_data + $db, $table, $column_name, array &$extra_data ) { $extra_data['isNeedToRecheck'] = false; @@ -2668,7 +2668,7 @@ class InsertEdit * * @return String */ - public static function getHtmlForFunctionOption($column, $column_name_appendix) + public static function getHtmlForFunctionOption(array $column, $column_name_appendix) { return '' . ''; @@ -3028,7 +3028,7 @@ class InsertEdit * * @return boolean whether user has necessary privileges */ - public static function userHasColumnPrivileges($table_column, $insert_mode) + public static function userHasColumnPrivileges(array $table_column, $insert_mode) { $privileges = $table_column['Privileges']; return ($insert_mode && strstr($privileges, 'insert') !== false) diff --git a/libraries/classes/Linter.php b/libraries/classes/Linter.php index bf433a7d7d..53dd207b1e 100644 --- a/libraries/classes/Linter.php +++ b/libraries/classes/Linter.php @@ -69,7 +69,7 @@ class Linter * * @return array */ - public static function findLineNumberAndColumn($lines, $pos) + public static function findLineNumberAndColumn(array $lines, $pos) { $line = 0; foreach ($lines as $lineNo => $lineStart) { diff --git a/libraries/classes/ListAbstract.php b/libraries/classes/ListAbstract.php index f46fa1ef7f..9e28490e34 100644 --- a/libraries/classes/ListAbstract.php +++ b/libraries/classes/ListAbstract.php @@ -36,7 +36,7 @@ abstract class ListAbstract extends ArrayObject * ArrayIterator is the default class used. */ public function __construct( - $array = array(), $flags = 0, $iterator_class = "ArrayIterator" + array $array = array(), $flags = 0, $iterator_class = "ArrayIterator" ) { parent::__construct($array, $flags, $iterator_class); } diff --git a/libraries/classes/Message.php b/libraries/classes/Message.php index 852b97877b..e850db365f 100644 --- a/libraries/classes/Message.php +++ b/libraries/classes/Message.php @@ -137,7 +137,7 @@ class Message * constant definitions above */ public function __construct($string = '', $number = Message::NOTICE, - $params = array(), $sanitize = Message::SANITIZE_NONE + array $params = array(), $sanitize = Message::SANITIZE_NONE ) { $this->setString($string, $sanitize & Message::SANITIZE_STRING); $this->setNumber($number); diff --git a/libraries/classes/MultSubmits.php b/libraries/classes/MultSubmits.php index 10ba65e940..02e7d9d9dd 100644 --- a/libraries/classes/MultSubmits.php +++ b/libraries/classes/MultSubmits.php @@ -27,20 +27,20 @@ class MultSubmits /** * Gets url params * - * @param string $what mult submit type - * @param bool $reload is reload - * @param string $action action type - * @param string $db database name - * @param string $table table name - * @param array $selected selected rows(table,db) - * @param array $views table views - * @param string $original_sql_query original sql query - * @param string $original_url_query original url query + * @param string $what mult submit type + * @param bool $reload is reload + * @param string $action action type + * @param string $db database name + * @param string $table table name + * @param array $selected selected rows(table,db) + * @param array|null $views table views + * @param string $original_sql_query original sql query + * @param string $original_url_query original url query * * @return array */ public static function getUrlParams( - $what, $reload, $action, $db, $table, $selected, $views, + $what, $reload, $action, $db, $table, array $selected, $views, $original_sql_query, $original_url_query ) { $_url_params = array( @@ -82,19 +82,19 @@ class MultSubmits /** * Builds or execute queries for multiple elements, depending on $query_type * - * @param string $query_type query type - * @param array $selected selected tables - * @param string $db db name - * @param string $table table name - * @param array $views table views - * @param string $primary table primary - * @param string $from_prefix from prefix original - * @param string $to_prefix to prefix original + * @param string $query_type query type + * @param array $selected selected tables + * @param string $db db name + * @param string $table table name + * @param array|null $views table views + * @param string $primary table primary + * @param string $from_prefix from prefix original + * @param string $to_prefix to prefix original * * @return array */ public static function buildOrExecuteQueryForMulti( - $query_type, $selected, $db, $table, $views, $primary, + $query_type, array $selected, $db, $table, $views, $primary, $from_prefix, $to_prefix ) { $rebuild_database_list = false; @@ -337,7 +337,7 @@ class MultSubmits * * @return string */ - public static function getHtmlForCopyMultipleTables($action, $_url_params) + public static function getHtmlForCopyMultipleTables($action, array $_url_params) { $html = ''; $html .= Url::getHiddenInputs($_url_params); @@ -382,7 +382,7 @@ class MultSubmits * * @return string */ - public static function getHtmlForReplacePrefixTable($action, $_url_params) + public static function getHtmlForReplacePrefixTable($action, array $_url_params) { $html = ''; $html .= Url::getHiddenInputs($_url_params); @@ -416,7 +416,7 @@ class MultSubmits * * @return string */ - public static function getHtmlForAddPrefixTable($action, $_url_params) + public static function getHtmlForAddPrefixTable($action, array $_url_params) { $html = ''; $html .= Url::getHiddenInputs($_url_params); @@ -447,7 +447,7 @@ class MultSubmits * * @return string */ - public static function getHtmlForOtherActions($what, $action, $_url_params, $full_query) + public static function getHtmlForOtherActions($what, $action, array $_url_params, $full_query) { $html = ''; $html .= Url::getHiddenInputs($_url_params); @@ -487,7 +487,7 @@ class MultSubmits * * @return array */ - public static function getQueryFromSelected($what, $table, $selected, $views) + public static function getQueryFromSelected($what, $table, array $selected, array $views) { $reload = false; $full_query_views = null; diff --git a/libraries/classes/Navigation/NavigationTree.php b/libraries/classes/Navigation/NavigationTree.php index 3bd55539af..8389ee7c7b 100644 --- a/libraries/classes/Navigation/NavigationTree.php +++ b/libraries/classes/Navigation/NavigationTree.php @@ -327,7 +327,7 @@ class NavigationTree * * @return Node|false The active node or false in case of failure */ - private function _buildPathPart($path, $type2, $pos2, $type3, $pos3) + private function _buildPathPart(array $path, $type2, $pos2, $type3, $pos3) { if (empty($pos2)) { $pos2 = 0; @@ -1002,7 +1002,7 @@ class NavigationTree * * @return boolean */ - private function _findTreeMatch($tree, $paths) + private function _findTreeMatch(array $tree, array $paths) { $match = false; foreach ($tree as $path) { diff --git a/libraries/classes/Normalization.php b/libraries/classes/Normalization.php index ee4131af18..08cbea5bc6 100644 --- a/libraries/classes/Normalization.php +++ b/libraries/classes/Normalization.php @@ -84,7 +84,7 @@ class Normalization * @return string HTML */ public static function getHtmlForCreateNewColumn( - $num_fields, $db, $table, $columnMeta=array() + $num_fields, $db, $table, array $columnMeta = array() ) { $cfgRelation = Relation::getRelationsParam(); $content_cells = array(); @@ -415,7 +415,7 @@ class Normalization * * @return string HTML */ - public static function getHtmlForNewTables2NF($partialDependencies,$table) + public static function getHtmlForNewTables2NF(array $partialDependencies, $table) { $html = '

' . sprintf( __( @@ -448,7 +448,7 @@ class Normalization * * @return array */ - public static function createNewTablesFor2NF($partialDependencies, $tablesName, $table, $db) + public static function createNewTablesFor2NF(array $partialDependencies, $tablesName, $table, $db) { $dropCols = false; $nonPKCols = array(); @@ -524,7 +524,7 @@ class Normalization * * @return array containing html and the list of new tables */ - public static function getHtmlForNewTables3NF($dependencies, $tables, $db) + public static function getHtmlForNewTables3NF($dependencies, array $tables, $db) { $html = ""; $i = 1; @@ -582,7 +582,7 @@ class Normalization * * @return array */ - public static function createNewTablesFor3NF($newTables, $db) + public static function createNewTablesFor3NF(array $newTables, $db) { $queries = array(); $dropCols = false; @@ -730,7 +730,7 @@ class Normalization * * @return string */ - public static function getHtmlFor3NFstep1($db, $tables) + public static function getHtmlFor3NFstep1($db, array $tables) { $legendText = __('Step 3.') . "1 " . __('Find transitive dependencies'); $extra = ""; @@ -952,7 +952,7 @@ class Normalization * * @return array associative array containing the count */ - public static function findDistinctValuesCount($columns, $table) + public static function findDistinctValuesCount(array $columns, $table) { $result = array(); $query = 'SELECT '; @@ -981,7 +981,7 @@ class Normalization * * @return array containing all the possible partial keys(subset of primary key) */ - public static function getAllCombinationPartialKeys($primaryKey) + public static function getAllCombinationPartialKeys(array $primaryKey) { $results = array(''); foreach ($primaryKey as $element) { diff --git a/libraries/classes/Operations.php b/libraries/classes/Operations.php index 15ac55378b..04feebf595 100644 --- a/libraries/classes/Operations.php +++ b/libraries/classes/Operations.php @@ -406,7 +406,7 @@ class Operations * @return array $views */ public static function getViewsAndCreateSqlViewStandIn( - $tables_full, $export_sql_plugin, $db + array $tables_full, $export_sql_plugin, $db ) { $views = array(); foreach ($tables_full as $each_table => $tmp) { @@ -450,7 +450,7 @@ class Operations * * @return array SQL queries for the constraints */ - public static function copyTables($tables_full, $move, $db) + public static function copyTables(array $tables_full, $move, $db) { $sqlContraints = array(); foreach ($tables_full as $each_table => $tmp) { @@ -546,7 +546,7 @@ class Operations * * @return void */ - public static function handleTheViews($views, $move, $db) + public static function handleTheViews(array $views, $move, $db) { // temporarily force to add DROP IF EXIST to CREATE VIEW query, // to remove stand-in VIEW that was created earlier @@ -735,7 +735,7 @@ class Operations * * @return void */ - public static function createAllAccumulatedConstraints($sqlConstratints) + public static function createAllAccumulatedConstraints(array $sqlConstratints) { $GLOBALS['dbi']->selectDb($_REQUEST['newname']); foreach ($sqlConstratints as $one_query) { @@ -773,7 +773,7 @@ class Operations * * @return string $html_out */ - public static function getHtmlForOrderTheTable($columns) + public static function getHtmlForOrderTheTable(array $columns) { $html_output = '

'; $html_output .= '' . '' @@ -1546,7 +1546,7 @@ class Operations * * @return String html output */ - public static function getDeleteDataOrTablelink($url_params, $syntax, $link, $htmlId) + public static function getDeleteDataOrTablelink(array $url_params, $syntax, $link, $htmlId) { return '
  • __('Analyze'), @@ -1652,7 +1652,7 @@ class Operations * * @return string $html_output */ - public static function getHtmlForReferentialIntegrityCheck($foreign, $url_params) + public static function getHtmlForReferentialIntegrityCheck(array $foreign, array $url_params) { $html_output = '
    ' . '
    ' diff --git a/libraries/classes/Partition.php b/libraries/classes/Partition.php index 2f0a2afe1e..8b99d962b5 100644 --- a/libraries/classes/Partition.php +++ b/libraries/classes/Partition.php @@ -32,7 +32,7 @@ class Partition extends SubPartition * * @return void */ - protected function loadData($row) + protected function loadData(array $row) { $this->name = $row['PARTITION_NAME']; $this->ordinal = $row['PARTITION_ORDINAL_POSITION']; diff --git a/libraries/classes/Plugins.php b/libraries/classes/Plugins.php index a9569ecd61..a91752b942 100644 --- a/libraries/classes/Plugins.php +++ b/libraries/classes/Plugins.php @@ -206,7 +206,7 @@ class Plugins * * @return string html select tag */ - public static function getChoice($section, $name, &$list, $cfgname = null) + public static function getChoice($section, $name, array &$list, $cfgname = null) { if (! isset($cfgname)) { $cfgname = $name; @@ -527,7 +527,7 @@ class Plugins * * @return string html fieldset with plugin options */ - public static function getOptions($section, &$list) + public static function getOptions($section, array &$list) { $ret = ''; // Options for plugins that support them diff --git a/libraries/classes/Plugins/Export/ExportCodegen.php b/libraries/classes/Plugins/Export/ExportCodegen.php index 085f189853..b2a2763fd4 100644 --- a/libraries/classes/Plugins/Export/ExportCodegen.php +++ b/libraries/classes/Plugins/Export/ExportCodegen.php @@ -187,7 +187,7 @@ class ExportCodegen extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $CG_FORMATS = $this->_getCgFormats(); $CG_HANDLERS = $this->_getCgHandlers(); @@ -237,7 +237,7 @@ class ExportCodegen extends ExportPlugin * * @return string containing C# code lines, separated by "\n" */ - private function _handleNHibernateCSBody($db, $table, $crlf, $aliases = array()) + private function _handleNHibernateCSBody($db, $table, $crlf, array $aliases = array()) { $db_alias = $db; $table_alias = $table; @@ -340,7 +340,7 @@ class ExportCodegen extends ExportPlugin $db, $table, $crlf, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -415,7 +415,7 @@ class ExportCodegen extends ExportPlugin * * @return void */ - private function _setCgFormats($CG_FORMATS) + private function _setCgFormats(array $CG_FORMATS) { $this->_cgFormats = $CG_FORMATS; } @@ -437,7 +437,7 @@ class ExportCodegen extends ExportPlugin * * @return void */ - private function _setCgHandlers($CG_HANDLERS) + private function _setCgHandlers(array $CG_HANDLERS) { $this->_cgHandlers = $CG_HANDLERS; } diff --git a/libraries/classes/Plugins/Export/ExportCsv.php b/libraries/classes/Plugins/Export/ExportCsv.php index f77b4bc81f..1f143483df 100644 --- a/libraries/classes/Plugins/Export/ExportCsv.php +++ b/libraries/classes/Plugins/Export/ExportCsv.php @@ -217,7 +217,7 @@ class ExportCsv extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $what, $csv_terminated, $csv_separator, $csv_enclosed, $csv_escaped; diff --git a/libraries/classes/Plugins/Export/ExportHtmlword.php b/libraries/classes/Plugins/Export/ExportHtmlword.php index e26b9ca9f9..65f7f03a5b 100644 --- a/libraries/classes/Plugins/Export/ExportHtmlword.php +++ b/libraries/classes/Plugins/Export/ExportHtmlword.php @@ -197,7 +197,7 @@ class ExportHtmlword extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $what; @@ -359,7 +359,7 @@ class ExportHtmlword extends ExportPlugin $do_comments, $do_mime, $view = false, - $aliases = array() + array $aliases = array() ) { // set $cfgRelation here, because there is a chance that it's modified // since the class initialization @@ -549,7 +549,7 @@ class ExportHtmlword extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -619,8 +619,8 @@ class ExportHtmlword extends ExportPlugin * @return string Formatted column definition */ protected function formatOneColumnDefinition( - $column, - $unique_keys, + array $column, + array $unique_keys, $col_alias = '' ) { if (empty($col_alias)) { diff --git a/libraries/classes/Plugins/Export/ExportJson.php b/libraries/classes/Plugins/Export/ExportJson.php index 00b5462c6b..278d5a621b 100644 --- a/libraries/classes/Plugins/Export/ExportJson.php +++ b/libraries/classes/Plugins/Export/ExportJson.php @@ -206,7 +206,7 @@ class ExportJson extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportLatex.php b/libraries/classes/Plugins/Export/ExportLatex.php index 549639e2d6..a00a0c9116 100644 --- a/libraries/classes/Plugins/Export/ExportLatex.php +++ b/libraries/classes/Plugins/Export/ExportLatex.php @@ -301,7 +301,7 @@ class ExportLatex extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -466,7 +466,7 @@ class ExportLatex extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportMediawiki.php b/libraries/classes/Plugins/Export/ExportMediawiki.php index 342e031312..b2f3fdd108 100644 --- a/libraries/classes/Plugins/Export/ExportMediawiki.php +++ b/libraries/classes/Plugins/Export/ExportMediawiki.php @@ -189,7 +189,7 @@ class ExportMediawiki extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -283,7 +283,7 @@ class ExportMediawiki extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportOds.php b/libraries/classes/Plugins/Export/ExportOds.php index 029c7cad3c..0dd84111e4 100644 --- a/libraries/classes/Plugins/Export/ExportOds.php +++ b/libraries/classes/Plugins/Export/ExportOds.php @@ -218,7 +218,7 @@ class ExportOds extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $what; diff --git a/libraries/classes/Plugins/Export/ExportOdt.php b/libraries/classes/Plugins/Export/ExportOdt.php index c6ba2fd2ba..758442ad17 100644 --- a/libraries/classes/Plugins/Export/ExportOdt.php +++ b/libraries/classes/Plugins/Export/ExportOdt.php @@ -246,7 +246,7 @@ class ExportOdt extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $what; @@ -441,7 +441,7 @@ class ExportOdt extends ExportPlugin $show_dates = false, $add_semicolon = true, $view = false, - $aliases = array() + array $aliases = array() ) { global $cfgRelation; @@ -590,7 +590,7 @@ class ExportOdt extends ExportPlugin * * @return bool true */ - protected function getTriggers($db, $table, $aliases = array()) + protected function getTriggers($db, $table, array $aliases = array()) { $db_alias = $db; $table_alias = $table; @@ -679,7 +679,7 @@ class ExportOdt extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportPdf.php b/libraries/classes/Plugins/Export/ExportPdf.php index ba6820ac7e..d6ec52fcf4 100644 --- a/libraries/classes/Plugins/Export/ExportPdf.php +++ b/libraries/classes/Plugins/Export/ExportPdf.php @@ -215,7 +215,7 @@ class ExportPdf extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -269,7 +269,7 @@ class ExportPdf extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportPhparray.php b/libraries/classes/Plugins/Export/ExportPhparray.php index c2a4e589aa..292e788acc 100644 --- a/libraries/classes/Plugins/Export/ExportPhparray.php +++ b/libraries/classes/Plugins/Export/ExportPhparray.php @@ -174,7 +174,7 @@ class ExportPhparray extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportSql.php b/libraries/classes/Plugins/Export/ExportSql.php index 4c0687abbc..2024da2ecd 100644 --- a/libraries/classes/Plugins/Export/ExportSql.php +++ b/libraries/classes/Plugins/Export/ExportSql.php @@ -484,7 +484,7 @@ class ExportSql extends ExportPlugin * @return string SQL query */ protected function _exportRoutineSQL( - $db, $aliases, $type, $name, $routines, $delimiter + $db, array $aliases, $type, $name, array $routines, $delimiter ) { global $crlf; @@ -536,7 +536,7 @@ class ExportSql extends ExportPlugin * * @return bool Whether it succeeded */ - public function exportRoutines($db, $aliases = array()) + public function exportRoutines($db, array $aliases = array()) { global $crlf; @@ -996,7 +996,7 @@ class ExportSql extends ExportPlugin public function exportMetadata( $db, $tables, - $metadataTypes + array $metadataTypes ) { $cfgRelation = Relation::getRelationsParam(); if (!isset($cfgRelation['db'])) { @@ -1048,7 +1048,7 @@ class ExportSql extends ExportPlugin private function _exportMetadata( $db, $table, - $metadataTypes + array $metadataTypes ) { $cfgRelation = Relation::getRelationsParam(); @@ -1274,7 +1274,7 @@ class ExportSql extends ExportPlugin $view, $crlf, $add_semicolon = true, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $view_alias = $view; @@ -1368,7 +1368,7 @@ class ExportSql extends ExportPlugin $add_semicolon = true, $view = false, $update_indexes_increments = true, - $aliases = array() + array $aliases = array() ) { global $sql_drop_table, $sql_backquotes, $sql_constraints, $sql_constraints_query, $sql_indexes, $sql_indexes_query, @@ -1828,7 +1828,7 @@ class ExportSql extends ExportPlugin $crlf, $do_relation = false, $do_mime = false, - $aliases = array() + array $aliases = array() ) { global $cfgRelation, $sql_backquotes; @@ -1978,7 +1978,7 @@ class ExportSql extends ExportPlugin $comments = false, $mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; @@ -2152,7 +2152,7 @@ class ExportSql extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $current_row, $sql_backquotes; @@ -2646,7 +2646,7 @@ class ExportSql extends ExportPlugin */ public function replaceWithAliases( $sql_query, - $aliases, + array $aliases, $db, $table = '', &$flag = null diff --git a/libraries/classes/Plugins/Export/ExportTexytext.php b/libraries/classes/Plugins/Export/ExportTexytext.php index f01860bccd..5072fc8c26 100644 --- a/libraries/classes/Plugins/Export/ExportTexytext.php +++ b/libraries/classes/Plugins/Export/ExportTexytext.php @@ -181,7 +181,7 @@ class ExportTexytext extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { global $what; @@ -341,7 +341,7 @@ class ExportTexytext extends ExportPlugin $show_dates = false, $add_semicolon = true, $view = false, - $aliases = array() + array $aliases = array() ) { global $cfgRelation; @@ -504,7 +504,7 @@ class ExportTexytext extends ExportPlugin $do_comments = false, $do_mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/ExportXml.php b/libraries/classes/Plugins/Export/ExportXml.php index 5c768006b0..b03749059f 100644 --- a/libraries/classes/Plugins/Export/ExportXml.php +++ b/libraries/classes/Plugins/Export/ExportXml.php @@ -177,7 +177,7 @@ class ExportXml extends ExportPlugin * * @return string XML with definitions */ - private function _exportDefinitions($db, $type, $dbitype, $names) + private function _exportDefinitions($db, $type, $dbitype, array $names) { global $crlf; @@ -465,7 +465,7 @@ class ExportXml extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { // Do not export data for merge tables if ($GLOBALS['dbi']->getTable($db, $table)->isMerge()) { @@ -571,7 +571,7 @@ class ExportXml extends ExportPlugin * * @return void */ - private function _setTables($tables) + private function _setTables(array $tables) { $this->_tables = $tables; } diff --git a/libraries/classes/Plugins/Export/ExportYaml.php b/libraries/classes/Plugins/Export/ExportYaml.php index 6ac9b5506f..48255c6bdd 100644 --- a/libraries/classes/Plugins/Export/ExportYaml.php +++ b/libraries/classes/Plugins/Export/ExportYaml.php @@ -150,7 +150,7 @@ class ExportYaml extends ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ) { $db_alias = $db; $table_alias = $table; diff --git a/libraries/classes/Plugins/Export/Helpers/Pdf.php b/libraries/classes/Plugins/Export/Helpers/Pdf.php index f308af5826..558502d61c 100644 --- a/libraries/classes/Plugins/Export/Helpers/Pdf.php +++ b/libraries/classes/Plugins/Export/Helpers/Pdf.php @@ -261,7 +261,7 @@ class Pdf extends PdfLib * * @return void */ - public function setAttributes($attr = array()) + public function setAttributes(array $attr = array()) { foreach ($attr as $key => $val) { $this->$key = $val; @@ -436,7 +436,7 @@ class Pdf extends PdfLib $do_comments, $do_mime, $view = false, - $aliases = array() + array $aliases = array() ) { // set $cfgRelation here, because there is a chance that it's modified // since the class initialization diff --git a/libraries/classes/Plugins/Export/Helpers/TableProperty.php b/libraries/classes/Plugins/Export/Helpers/TableProperty.php index e5bae76237..de8bff2047 100644 --- a/libraries/classes/Plugins/Export/Helpers/TableProperty.php +++ b/libraries/classes/Plugins/Export/Helpers/TableProperty.php @@ -65,7 +65,7 @@ class TableProperty * * @param array $row table row */ - public function __construct($row) + public function __construct(array $row) { $this->name = trim($row[0]); $this->type = trim($row[1]); diff --git a/libraries/classes/Plugins/ExportPlugin.php b/libraries/classes/Plugins/ExportPlugin.php index ff856f99a7..fcee065d87 100644 --- a/libraries/classes/Plugins/ExportPlugin.php +++ b/libraries/classes/Plugins/ExportPlugin.php @@ -94,7 +94,7 @@ abstract class ExportPlugin $crlf, $error_url, $sql_query, - $aliases = array() + array $aliases = array() ); /** @@ -110,7 +110,7 @@ abstract class ExportPlugin * * @return bool Whether it succeeded */ - public function exportRoutines($db, $aliases = array()) + public function exportRoutines($db, array $aliases = array()) { ; } @@ -160,7 +160,7 @@ abstract class ExportPlugin $comments = false, $mime = false, $dates = false, - $aliases = array() + array $aliases = array() ) { ; } @@ -177,7 +177,7 @@ abstract class ExportPlugin public function exportMetadata( $db, $tables, - $metadataTypes + array $metadataTypes ) { ; } @@ -278,7 +278,7 @@ abstract class ExportPlugin * * @return string alias of the identifier if found or '' */ - public function getAlias($aliases, $id, $type = 'dbtblcol', $db = '', $tbl = '') + public function getAlias(array $aliases, $id, $type = 'dbtblcol', $db = '', $tbl = '') { if (!empty($db) && isset($aliases[$db])) { $aliases = array( @@ -344,10 +344,10 @@ abstract class ExportPlugin * @return string the Relation string */ public function getRelationString( - $res_rel, + array $res_rel, $field_name, $db, - $aliases = array() + array $aliases = array() ) { $relation = ''; $foreigner = Relation::searchColumnInForeigners($res_rel, $field_name); diff --git a/libraries/classes/Plugins/IOTransformationsPlugin.php b/libraries/classes/Plugins/IOTransformationsPlugin.php index 4b098b2bf4..084923ddfc 100644 --- a/libraries/classes/Plugins/IOTransformationsPlugin.php +++ b/libraries/classes/Plugins/IOTransformationsPlugin.php @@ -39,10 +39,10 @@ abstract class IOTransformationsPlugin extends TransformationsPlugin * @return string the html for input field */ public function getInputHtml( - $column, + array $column, $row_id, $column_name_appendix, - $options, + array $options, $value, $text_dir, $tabindex, diff --git a/libraries/classes/Plugins/Import/ImportCsv.php b/libraries/classes/Plugins/Import/ImportCsv.php index 492b90190e..b68fcea06d 100644 --- a/libraries/classes/Plugins/Import/ImportCsv.php +++ b/libraries/classes/Plugins/Import/ImportCsv.php @@ -96,7 +96,7 @@ class ImportCsv extends AbstractImportCsv * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $db, $table, $csv_terminated, $csv_enclosed, $csv_escaped, $csv_new_line, $csv_columns, $err_url; diff --git a/libraries/classes/Plugins/Import/ImportLdi.php b/libraries/classes/Plugins/Import/ImportLdi.php index 157f7bde24..e41e6f02f8 100644 --- a/libraries/classes/Plugins/Import/ImportLdi.php +++ b/libraries/classes/Plugins/Import/ImportLdi.php @@ -96,7 +96,7 @@ class ImportLdi extends AbstractImportCsv * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $finished, $import_file, $charset_conversion, $table; global $ldi_local_option, $ldi_replace, $ldi_ignore, $ldi_terminated, diff --git a/libraries/classes/Plugins/Import/ImportMediawiki.php b/libraries/classes/Plugins/Import/ImportMediawiki.php index 943d0c1cdd..852110e42b 100644 --- a/libraries/classes/Plugins/Import/ImportMediawiki.php +++ b/libraries/classes/Plugins/Import/ImportMediawiki.php @@ -66,7 +66,7 @@ class ImportMediawiki extends ImportPlugin * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $error, $timeout_passed, $finished; @@ -298,7 +298,7 @@ class ImportMediawiki extends ImportPlugin * * @return void */ - private function _importDataOneTable($table, &$sql_data) + private function _importDataOneTable(array $table, array &$sql_data) { $analyze = $this->_getAnalyze(); if ($analyze) { @@ -348,7 +348,7 @@ class ImportMediawiki extends ImportPlugin * * @return void */ - private function _setTableHeaders(&$table_headers, $table_row) + private function _setTableHeaders(array &$table_headers, array $table_row) { if (empty($table_headers)) { // The first table row should contain the number of columns @@ -379,7 +379,7 @@ class ImportMediawiki extends ImportPlugin * * @return void */ - private function _executeImportTables(&$tables, &$analyses, &$sql_data) + private function _executeImportTables(array &$tables, array &$analyses, array &$sql_data) { global $db; diff --git a/libraries/classes/Plugins/Import/ImportOds.php b/libraries/classes/Plugins/Import/ImportOds.php index f0c627613e..3447a8cfa1 100644 --- a/libraries/classes/Plugins/Import/ImportOds.php +++ b/libraries/classes/Plugins/Import/ImportOds.php @@ -100,7 +100,7 @@ class ImportOds extends ImportPlugin * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $db, $error, $timeout_passed, $finished; diff --git a/libraries/classes/Plugins/Import/ImportShp.php b/libraries/classes/Plugins/Import/ImportShp.php index 9cfcee6345..4d87dd8cad 100644 --- a/libraries/classes/Plugins/Import/ImportShp.php +++ b/libraries/classes/Plugins/Import/ImportShp.php @@ -60,7 +60,7 @@ class ImportShp extends ImportPlugin * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $db, $error, $finished, $import_file, $local_import_file, $message; diff --git a/libraries/classes/Plugins/Import/ImportSql.php b/libraries/classes/Plugins/Import/ImportSql.php index 809edc3482..240b8ba36a 100644 --- a/libraries/classes/Plugins/Import/ImportSql.php +++ b/libraries/classes/Plugins/Import/ImportSql.php @@ -104,7 +104,7 @@ class ImportSql extends ImportPlugin * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $error, $timeout_passed; @@ -178,7 +178,7 @@ class ImportSql extends ImportPlugin * * @return void */ - private function _setSQLMode($dbi, $request) + private function _setSQLMode($dbi, array $request) { $sql_modes = array(); if (isset($request['sql_compatibility']) diff --git a/libraries/classes/Plugins/Import/ImportXml.php b/libraries/classes/Plugins/Import/ImportXml.php index 83a75b3b6f..b511582a7e 100644 --- a/libraries/classes/Plugins/Import/ImportXml.php +++ b/libraries/classes/Plugins/Import/ImportXml.php @@ -58,7 +58,7 @@ class ImportXml extends ImportPlugin * * @return void */ - public function doImport(&$sql_data = array()) + public function doImport(array &$sql_data = array()) { global $error, $timeout_passed, $finished, $db; diff --git a/libraries/classes/Plugins/Schema/Pdf/Pdf.php b/libraries/classes/Plugins/Schema/Pdf/Pdf.php index 98e080f619..1f70fc4b90 100644 --- a/libraries/classes/Plugins/Schema/Pdf/Pdf.php +++ b/libraries/classes/Plugins/Schema/Pdf/Pdf.php @@ -276,7 +276,7 @@ class Pdf extends PdfLib * * @return void */ - public function setWidths($w) + public function setWidths(array $w) { // column widths $this->widths = $w; @@ -290,7 +290,7 @@ class Pdf extends PdfLib * * @return void */ - public function row($data, $links) + public function row(array $data, array $links) { // line height $nb = 0; diff --git a/libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php b/libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php index 523936c3ba..45d02b6469 100644 --- a/libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php +++ b/libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php @@ -479,7 +479,7 @@ class PdfRelationSchema extends ExportRelationSchema * * @return void */ - public function dataDictionaryDoc($alltables) + public function dataDictionaryDoc(array $alltables) { // TOC $this->diagram->addpage($this->orientation); diff --git a/libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php index 584ef55598..49a1c099ca 100644 --- a/libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/Bool2TextTransformationsPlugin.php @@ -40,7 +40,7 @@ abstract class Bool2TextTransformationsPlugin extends TransformationsPlugin * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { $cfg = $GLOBALS['cfg']; $options = $this->getOptions($options, $cfg['DefaultTransformations']['Bool2Text']); diff --git a/libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php b/libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php index 4c8b6707d8..129da8ea23 100644 --- a/libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php @@ -25,7 +25,7 @@ abstract class CodeMirrorEditorTransformationPlugin extends IOTransformationsPlu * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { return $buffer; } @@ -47,10 +47,10 @@ abstract class CodeMirrorEditorTransformationPlugin extends IOTransformationsPlu * @return string the html for input field */ public function getInputHtml( - $column, + array $column, $row_id, $column_name_appendix, - $options, + array $options, $value, $text_dir, $tabindex, diff --git a/libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php index 4372f871d8..208dab2542 100644 --- a/libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/DateFormatTransformationsPlugin.php @@ -48,7 +48,7 @@ abstract class DateFormatTransformationsPlugin extends TransformationsPlugin * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { // possibly use a global transform and feed it with special options $cfg = $GLOBALS['cfg']; diff --git a/libraries/classes/Plugins/Transformations/Abs/DownloadTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/DownloadTransformationsPlugin.php index 5b46f07697..d205b9f0f7 100644 --- a/libraries/classes/Plugins/Transformations/Abs/DownloadTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/DownloadTransformationsPlugin.php @@ -42,7 +42,7 @@ abstract class DownloadTransformationsPlugin extends TransformationsPlugin * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { global $row, $fields_meta; diff --git a/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php index 92f4da1d59..d3286aa563 100644 --- a/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php @@ -47,7 +47,7 @@ abstract class ExternalTransformationsPlugin extends TransformationsPlugin * * @return bool */ - public function applyTransformationNoWrap($options = array()) + public function applyTransformationNoWrap(array $options = array()) { if (!isset($options[3]) || $options[3] == '') { $nowrap = true; @@ -69,7 +69,7 @@ abstract class ExternalTransformationsPlugin extends TransformationsPlugin * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { // possibly use a global transform and feed it with special options diff --git a/libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php index d502dc6716..c97f1268f2 100644 --- a/libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php @@ -40,7 +40,7 @@ abstract class FormattedTransformationsPlugin extends TransformationsPlugin * * @return string */ - public function applyTransformation($buffer, $options = array(), $meta = '') + public function applyTransformation($buffer, array $options = array(), $meta = '') { return '
  • ' . '' . $column['pma_type'] . '' @@ -2752,13 +2752,13 @@ class InsertEdit * * @return string */ - public static function getHtmlForInsertEditFormColumn($table_columns, $column_number, - $comments_map, $timestamp_seen, $current_result, $chg_evt_handler, - $jsvkey, $vkey, $insert_mode, $current_row, &$o_rows, + public static function getHtmlForInsertEditFormColumn(array $table_columns, $column_number, + array $comments_map, $timestamp_seen, $current_result, $chg_evt_handler, + $jsvkey, $vkey, $insert_mode, array $current_row, &$o_rows, &$tabindex, $columns_cnt, $is_upload, $tabindex_for_function, - $foreigners, $tabindex_for_null, $tabindex_for_value, $table, $db, - $row_id, $titles, $biggest_max_file_size, $default_char_editing, - $text_dir, $repopulate, $column_mime, $where_clause + array $foreigners, $tabindex_for_null, $tabindex_for_value, $table, $db, + $row_id, array $titles, $biggest_max_file_size, $default_char_editing, + $text_dir, array $repopulate, array $column_mime, $where_clause ) { $column = $table_columns[$column_number]; $readOnly = false; @@ -2979,12 +2979,12 @@ class InsertEdit * * @return string */ - public static function getHtmlForInsertEditRow($url_params, $table_columns, - $comments_map, $timestamp_seen, $current_result, $chg_evt_handler, - $jsvkey, $vkey, $insert_mode, $current_row, &$o_rows, &$tabindex, $columns_cnt, - $is_upload, $tabindex_for_function, $foreigners, $tabindex_for_null, - $tabindex_for_value, $table, $db, $row_id, $titles, - $biggest_max_file_size, $text_dir, $repopulate, $where_clause_array + public static function getHtmlForInsertEditRow(array $url_params, array $table_columns, + array $comments_map, $timestamp_seen, $current_result, $chg_evt_handler, + $jsvkey, $vkey, $insert_mode, array $current_row, &$o_rows, &$tabindex, $columns_cnt, + $is_upload, $tabindex_for_function, array $foreigners, $tabindex_for_null, + $tabindex_for_value, $table, $db, $row_id, array $titles, + $biggest_max_file_size, $text_dir, array $repopulate, array $where_clause_array ) { $html_output = self::getHeadAndFootOfInsertRowTable($url_params) . '