Upgrade Psalm to 3.13

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

composer.json

@@ -93,7 +93,7 @@
         "symfony/finder": "^4.4",
         "symfony/twig-bridge": "^4.4",
         "tecnickcom/tcpdf": "^6.3",
-        "vimeo/psalm": "^3.11"
+        "vimeo/psalm": "^3.13"
     },
     "extra": {
         "branch-alias": {

psalm-baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="3.12.2@7c7ebd068f8acaba211d4a2c707c4ba90874fa26">
+<files psalm-version="3.13.1@afd8874a9e4562eac42a02de90e42e430c3a1db1">
   <file src="libraries/classes/Advisor.php">
     <PossiblyNullArgument occurrences="1">
       <code>Util::formatByteDown($value, $limes, $comma)</code>
@@ -21,6 +21,9 @@
       <code>$this-&gt;dbi-&gt;getError()</code>
       <code>$this-&gt;dbi-&gt;getError(DatabaseInterface::CONNECT_CONTROL)</code>
     </PossiblyInvalidArgument>
+    <TypeDoesNotContainType occurrences="1">
+      <code>$table == ''</code>
+    </TypeDoesNotContainType>
   </file>
   <file src="libraries/classes/Charsets.php">
     <TypeDoesNotContainType occurrences="1">
@@ -28,6 +31,72 @@
     </TypeDoesNotContainType>
   </file>
   <file src="libraries/classes/Charsets/Collation.php">
+    <ImpureByReferenceAssignment occurrences="64">
+      <code>$name</code>
+      <code>$variant</code>
+      <code>$name</code>
+      <code>$unicode</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$unicode</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$unknown</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$level</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$level</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$name</code>
+      <code>$found</code>
+    </ImpureByReferenceAssignment>
     <PossiblyNullArgument occurrences="1">
       <code>$name</code>
     </PossiblyNullArgument>
@@ -401,6 +470,9 @@
     <PossiblyNullArgument occurrences="1">
       <code>$where_clause ?? null</code>
     </PossiblyNullArgument>
+    <TypeDoesNotContainType occurrences="1">
+      <code>$biggest_max_file_size &gt; 0</code>
+    </TypeDoesNotContainType>
   </file>
   <file src="libraries/classes/Controllers/Table/ChartController.php">
     <ImplicitToStringCast occurrences="1">
@@ -535,6 +607,11 @@
     <TypeDoesNotContainType occurrences="1">
       <code>is_string($data)</code>
     </TypeDoesNotContainType>
+    <UndefinedConstant occurrences="3">
+      <code>PMA_USR_BROWSER_AGENT</code>
+      <code>PMA_USR_BROWSER_AGENT</code>
+      <code>PMA_USR_BROWSER_VER</code>
+    </UndefinedConstant>
   </file>
   <file src="libraries/classes/CreateAddField.php">
     <PossiblyFalseArgument occurrences="1">
@@ -566,7 +643,8 @@
     <NullArgument occurrences="1">
       <code>null</code>
     </NullArgument>
-    <PossiblyNullArgument occurrences="1">
+    <PossiblyNullArgument occurrences="2">
+      <code>$table</code>
       <code>$sortOrder</code>
     </PossiblyNullArgument>
     <PossiblyNullArrayAccess occurrences="1">
@@ -579,6 +657,9 @@
     </PossiblyNullPropertyAssignmentValue>
   </file>
   <file src="libraries/classes/Database/Routines.php">
+    <InvalidScalarArgument occurrences="1">
+      <code>$affected</code>
+    </InvalidScalarArgument>
     <PossiblyInvalidArgument occurrences="2">
       <code>$routine['item_type_toggle']</code>
       <code>$routine['item_returntype']</code>
@@ -816,6 +897,13 @@
       <code>$errorNumber</code>
     </PossiblyNullArgument>
   </file>
+  <file src="libraries/classes/ErrorReport.php">
+    <UndefinedConstant occurrences="3">
+      <code>PMA_USR_BROWSER_AGENT</code>
+      <code>PMA_USR_BROWSER_VER</code>
+      <code>PMA_USR_OS</code>
+    </UndefinedConstant>
+  </file>
   <file src="libraries/classes/Export.php">
     <InvalidReturnStatement occurrences="1">
       <code>$memory_limit</code>
@@ -834,6 +922,10 @@
       <code>$line</code>
       <code>$line</code>
     </PossiblyNullArgument>
+    <UndefinedConstant occurrences="2">
+      <code>PMA_USR_BROWSER_AGENT</code>
+      <code>PMA_USR_BROWSER_VER</code>
+    </UndefinedConstant>
   </file>
   <file src="libraries/classes/File.php">
     <FalsableReturnStatement occurrences="1">
@@ -1029,6 +1121,9 @@
     <InvalidArgument occurrences="1">
       <code>$current_result</code>
     </InvalidArgument>
+    <NullableReturnStatement occurrences="1">
+      <code>$dispval</code>
+    </NullableReturnStatement>
     <PossiblyInvalidOperand occurrences="2">
       <code>$tmp</code>
       <code>$insert_id</code>
@@ -1100,12 +1195,6 @@
     <PossiblyFalseReference occurrences="1">
       <code>getPresence</code>
     </PossiblyFalseReference>
-    <PossiblyInvalidArgument occurrences="1">
-      <code>$icons</code>
-    </PossiblyInvalidArgument>
-    <PossiblyInvalidIterator occurrences="1">
-      <code>$icons</code>
-    </PossiblyInvalidIterator>
     <PossiblyNullArgument occurrences="3">
       <code>$table</code>
       <code>$container-&gt;realName</code>
@@ -1180,6 +1269,12 @@
       <code>$text</code>
       <code>$text</code>
     </PossiblyNullArgument>
+    <TypeDoesNotContainType occurrences="4">
+      <code>$property_class == BoolPropertyItem::class</code>
+      <code>$property_class == MessageOnlyPropertyItem::class</code>
+      <code>$property_class == SelectPropertyItem::class</code>
+      <code>$property_class == TextPropertyItem::class</code>
+    </TypeDoesNotContainType>
   </file>
   <file src="libraries/classes/Plugins/Auth/AuthenticationCookie.php">
     <ImplementedReturnTypeMismatch occurrences="2">
@@ -1335,11 +1430,6 @@
       <code>$mime_map</code>
     </PossiblyUndefinedVariable>
   </file>
-  <file src="libraries/classes/Plugins/Export/Helpers/TableProperty.php">
-    <PossiblyFalseArgument occurrences="1">
-      <code>$pos</code>
-    </PossiblyFalseArgument>
-  </file>
   <file src="libraries/classes/Plugins/Import/AbstractImportCsv.php">
     <ImplementedReturnTypeMismatch occurrences="1">
       <code>OptionsPropertyMainGroup|void</code>
@@ -2145,6 +2235,9 @@
       <code>$tmp_initial</code>
       <code>$result['password']</code>
     </PossiblyNullArrayAccess>
+    <PossiblyNullArrayOffset occurrences="1">
+      <code>$array_initials</code>
+    </PossiblyNullArrayOffset>
     <PossiblyUndefinedArrayOffset occurrences="1">
       <code>$_POST['pred_dbname']</code>
     </PossiblyUndefinedArrayOffset>
@@ -2392,14 +2485,19 @@
     <PossiblyInvalidArgument occurrences="1">
       <code>$ret[_pgettext('string types', 'String')]</code>
     </PossiblyInvalidArgument>
+    <PossiblyInvalidArrayOffset occurrences="2">
+      <code>'-'</code>
+      <code>'INET6'</code>
+    </PossiblyInvalidArrayOffset>
   </file>
   <file src="libraries/classes/Util.php">
     <EmptyArrayAccess occurrences="1">
       <code>$group[$group_name]['tab' . $sep . 'count']</code>
     </EmptyArrayAccess>
-    <InvalidArrayOffset occurrences="3">
+    <InvalidArrayOffset occurrences="4">
       <code>$group[$group_name]['is' . $sep . 'group']</code>
       <code>$group[$group_name]['tab' . $sep . 'count']</code>
+      <code>$byteUnits[$d]</code>
       <code>$units[$d]</code>
     </InvalidArrayOffset>
     <InvalidReturnStatement occurrences="1">
@@ -2442,6 +2540,10 @@
       <code>$value</code>
       <code>$value</code>
     </PossiblyInvalidOperand>
+    <PossiblyNullArgument occurrences="2">
+      <code>$max_size</code>
+      <code>$max_unit</code>
+    </PossiblyNullArgument>
     <PossiblyNullArrayAccess occurrences="2">
       <code>$max_size</code>
       <code>$max_unit</code>