diff --git a/libraries/classes/InsertEdit.php b/libraries/classes/InsertEdit.php index 78aeb8145c..a40bc1a11c 100644 --- a/libraries/classes/InsertEdit.php +++ b/libraries/classes/InsertEdit.php @@ -480,24 +480,6 @@ class InsertEdit . ''; } - /** - * Get column values - * - * @param string[] $enumSetValues - * - * @return mixed[] column values as an associative array - * @psalm-return list - */ - private function getColumnEnumValues(array $enumSetValues): array - { - $values = []; - foreach ($enumSetValues as $val) { - $values[] = ['plain' => $val, 'html' => htmlspecialchars($val)]; - } - - return $values; - } - /** * Retrieve column 'set' value and select size * @@ -2037,17 +2019,15 @@ class InsertEdit } if ($column['pma_type'] === 'enum') { - if (! isset($column['values'])) { - $column['values'] = $this->getColumnEnumValues($extractedColumnspec['enum_set_values']); - } + $column['values'] ??= $extractedColumnspec['enum_set_values']; foreach ($column['values'] as $enumValue) { if ( - $data == $enumValue['plain'] || ($data == '' + $data == $enumValue || ($data == '' && (! isset($_POST['where_clause']) || $column['Null'] !== 'YES') - && isset($column['Default']) && $enumValue['plain'] == $column['Default']) + && isset($column['Default']) && $enumValue == $column['Default']) ) { - $enumSelectedValue = $enumValue['plain']; + $enumSelectedValue = $enumValue; break; } } diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 47bac5f852..44bbd7ac80 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -4765,11 +4765,6 @@ parameters: count: 1 path: libraries/classes/InsertEdit.php - - - message: "#^Parameter \\#1 \\$enumSetValues of method PhpMyAdmin\\\\InsertEdit\\:\\:getColumnEnumValues\\(\\) expects array\\, mixed given\\.$#" - count: 1 - path: libraries/classes/InsertEdit.php - - message: "#^Parameter \\#1 \\$haystack of function mb_stripos expects string, mixed given\\.$#" count: 1 diff --git a/psalm-baseline.xml b/psalm-baseline.xml index 735ebbccc1..903d0a3c2a 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -7959,7 +7959,6 @@ $data $data - @@ -7996,9 +7995,6 @@ $currCellEditedValues[$columnName] - - - $editedValues[$cellIndex][$columnName] @@ -8034,6 +8030,7 @@ + $currCellEditedValues @@ -14896,7 +14893,6 @@ $result $result $result - $result diff --git a/templates/table/insert/column_row.twig b/templates/table/insert/column_row.twig index c5e4d761b5..73dd1963b9 100644 --- a/templates/table/insert/column_row.twig +++ b/templates/table/insert/column_row.twig @@ -71,13 +71,13 @@ {% else %} {% for enum_value in column.values %} - - + + {% endfor %} {% endif %} {% elseif column.pma_type == 'set' %} diff --git a/test/classes/InsertEditTest.php b/test/classes/InsertEditTest.php index 66bf95c010..af5cdc31b5 100644 --- a/test/classes/InsertEditTest.php +++ b/test/classes/InsertEditTest.php @@ -619,25 +619,6 @@ class InsertEditTest extends AbstractTestCase ); } - /** - * Test for getColumnEnumValues - */ - public function testGetColumnEnumValues(): void - { - $enumSetValues = ['', '"foo"']; - - $result = $this->callFunction( - $this->insertEdit, - InsertEdit::class, - 'getColumnEnumValues', - [$enumSetValues], - ); - $this->assertEquals( - [['plain' => '', 'html' => '<abc>'], ['plain' => '"foo"', 'html' => '"foo"']], - $result, - ); - } - /** * Test for getColumnSetValueAndSelectSize */