gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move spacer creating outside of loop

Browse Source
This commit is contained in:
Michal Čihař 2012-05-10 10:08:19 +02:00
parent 843fe3dced
commit 2dabdb8ea3
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/common.lib.php
View File

@ -3717,6 +3717,13 @@ function PMA_getFunctionsForField($field, $insert_mode)
$dropdown_built[$each_dropdown] = true;
$op_spacing_needed = true;
}
// Create separator before all functions list
if ($op_spacing_needed) {
$retval .= ' ';
$retval .= '<option value="">--------</option>' . "\n";
}
// For compatibility's sake, do not let out all other functions. Instead
// print a separator (blank) and then show ALL functions which weren't
// shown yet.
@ -3729,11 +3736,6 @@ function PMA_getFunctionsForField($field, $insert_mode)
|| (! $field['first_timestamp'] && $functions[$j] == $default_function)
? ' selected="selected"'
: '';
if ($op_spacing_needed == true) {
$retval .= ' ';
$retval .= '<option value="">--------</option>' . "\n";
$op_spacing_needed = false;
}
$retval .= ' ';
$retval .= '<option' . $selected . '>' . $functions[$j]