diff --git a/ChangeLog b/ChangeLog index 95e8fcd1af..62b40dfd09 100644 --- a/ChangeLog +++ b/ChangeLog @@ -15,6 +15,7 @@ phpMyAdmin - ChangeLog - bug #4615 SQL highlighting in process list breaks on auto refresh - bug #4616 Warning in db structure print view page - bug Undefined index navwork, savedsearcheswork, fields +- bug #4620 Undefined index while adding to the central columns list 4.3.0.0 (not yet released) + rfe #1502 Smart sorting for int keys diff --git a/libraries/central_columns.lib.php b/libraries/central_columns.lib.php index 8544300509..792f0c383c 100644 --- a/libraries/central_columns.lib.php +++ b/libraries/central_columns.lib.php @@ -201,7 +201,7 @@ function PMA_syncUniqueColumns($field_select, $isTable=true, $table=null) if (empty($cfgCentralColumns)) { return PMA_configErrorMessage(); } - $db = $_POST['db']; + $db = $_REQUEST['db']; $pmadb = $cfgCentralColumns['db']; $central_list_table = $cfgCentralColumns['table']; $GLOBALS['dbi']->selectDb($db, $GLOBALS['userlink']); @@ -235,7 +235,7 @@ function PMA_syncUniqueColumns($field_select, $isTable=true, $table=null) } } else { if ($table == null) { - $table = $_POST['table']; + $table = $_REQUEST['table']; } foreach ($field_select as $column) { $cols .= "'" . PMA_Util::sqlAddSlashes($column) . "',"; diff --git a/test/libraries/PMA_central_columns_test.php b/test/libraries/PMA_central_columns_test.php index 0acdc880e6..47c5547f1d 100644 --- a/test/libraries/PMA_central_columns_test.php +++ b/test/libraries/PMA_central_columns_test.php @@ -157,8 +157,8 @@ class PMA_Central_Columns_Test extends PHPUnit_Framework_TestCase public function testPMASyncUniqueColumns() { $field_select = array("col1"); - $_POST['db'] = 'PMA_db'; - $_POST['table'] = 'PMA_table'; + $_REQUEST['db'] = 'PMA_db'; + $_REQUEST['table'] = 'PMA_table'; $this->assertInstanceOf( 'PMA_Message', PMA_syncUniqueColumns($field_select, false) ); @@ -514,4 +514,4 @@ class PMA_Central_Columns_Test extends PHPUnit_Framework_TestCase $result ); } -} \ No newline at end of file +}