From 8e18a98440509d117253aed540dd6bbed7fc0873 Mon Sep 17 00:00:00 2001
From: Telma Gonzaga <novawebproject@gmail.com>
Date: Sat, 20 Jul 2013 08:18:29 +0200
Subject: [PATCH 01/33] Translated using Weblate (Portuguese)

Currently translated at 50.6% (1319 of 2607)
---
 po/pt.po | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/po/pt.po b/po/pt.po
index 355f165ddb..fd9ae6aa74 100644
--- a/po/pt.po
+++ b/po/pt.po
@@ -4,8 +4,8 @@ msgstr ""
 "Project-Id-Version: phpMyAdmin 4.0.5-dev\n"
 "Report-Msgid-Bugs-To: phpmyadmin-devel@lists.sourceforge.net\n"
 "POT-Creation-Date: 2013-06-24 10:43+0200\n"
-"PO-Revision-Date: 2013-07-20 08:17+0200\n"
-"Last-Translator: Telma Gonzaga <novawebproject@gmail.com>\n"
+"PO-Revision-Date: 2013-07-20 08:18+0200\n"
+"Last-Translator: Pedro Ribeiro <p.m42.ribeiro@gmail.com>\n"
 "Language-Team: Portuguese "
 "<http://l10n.cihar.com/projects/phpmyadmin/4-0/pt/>\n"
 "Language: pt\n"
@@ -3002,9 +3002,8 @@ msgid "Handler"
 msgstr "Manipulador (handler)"
 
 #: libraries/ServerStatusData.class.php:185
-#, fuzzy
 msgid "Query cache"
-msgstr "Query cache"
+msgstr "Cache de queries"
 
 #: libraries/ServerStatusData.class.php:186
 msgid "Threads"

From 6ff96fe06237d4b7905c0bb009dd845c7f71e930 Mon Sep 17 00:00:00 2001
From: ProUser <stefan@inkopsforum.se>
Date: Fri, 19 Jul 2013 18:16:01 +0200
Subject: [PATCH 02/33] Translated using Weblate (Swedish)

Currently translated at 100.0% (2607 of 2607)
---
 po/sv.po | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/po/sv.po b/po/sv.po
index 3bf71d04c4..78fba2e9e3 100644
--- a/po/sv.po
+++ b/po/sv.po
@@ -4,8 +4,8 @@ msgstr ""
 "Project-Id-Version: phpMyAdmin 4.0.5-dev\n"
 "Report-Msgid-Bugs-To: phpmyadmin-devel@lists.sourceforge.net\n"
 "POT-Creation-Date: 2013-06-24 10:43+0200\n"
-"PO-Revision-Date: 2013-06-24 16:12+0200\n"
-"Last-Translator: Anders Jonsson <anders.jonsson@norsjovallen.se>\n"
+"PO-Revision-Date: 2013-07-19 18:15+0200\n"
+"Last-Translator: ProUser <stefan@inkopsforum.se>\n"
 "Language-Team: Swedish <http://l10n.cihar.com/projects/phpmyadmin/4-0/sv/>\n"
 "Language: sv\n"
 "MIME-Version: 1.0\n"
@@ -5213,10 +5213,9 @@ msgid "Use only icons, only text or both"
 msgstr "Använd enbart ikoner, endast text eller både och"
 
 #: libraries/config/messages.inc.php:325
-#, fuzzy
 #| msgid "Iconic navigation bar"
 msgid "Table navigation bar"
-msgstr "Ikonbaserat navigeringsfält"
+msgstr "Tabellbaserat navigeringsfält"
 
 #: libraries/config/messages.inc.php:326
 msgid "use GZip output buffering for increased speed in HTTP transfers"
@@ -5285,14 +5284,13 @@ msgid "MySQL reserved word warning"
 msgstr "Varning för reserverat MySQL-ord"
 
 #: libraries/config/messages.inc.php:339
-#, fuzzy
 #| msgid "Allow to display all the rows"
 msgid "How to display the menu tabs"
-msgstr "Tillåt att visa alla rader"
+msgstr "Hur att visa menyflikarna"
 
 #: libraries/config/messages.inc.php:341
 msgid "How to display various action links"
-msgstr ""
+msgstr "Hur man visar olika åtgärdslänkar"
 
 #: libraries/config/messages.inc.php:342
 msgid "Disallow BLOB and BINARY columns from editing"
@@ -10691,20 +10689,18 @@ msgid "Instructions/Setup"
 msgstr "Instruktioner/Setup"
 
 #: server_status_monitor.php:483
-#, fuzzy
 #| msgid "Done rearranging/editing charts"
 msgid "Done dragging (rearranging) charts"
-msgstr "Klar med ändring/redigering av diagram"
+msgstr "Klar med ändring (omdisponering) av diagram"
 
 #: server_status_monitor.php:489 server_status_monitor.php:606
 msgid "Add chart"
 msgstr "Lägg till diagram"
 
 #: server_status_monitor.php:492
-#, fuzzy
 #| msgid "Enable highlighting"
 msgid "Enable charts dragging"
-msgstr "Aktivera framhävning"
+msgstr "Aktivera diagram"
 
 #: server_status_monitor.php:496
 msgid "Refresh rate"

From c9474ad521f81a12570f9514e10c49de80195e9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <michal@cihar.com>
Date: Mon, 22 Jul 2013 11:57:28 +0200
Subject: [PATCH 03/33] Translated using Weblate (West Flemish)

Currently translated at 0.1% (2 of 2680)
---
 po/vls.po | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/po/vls.po b/po/vls.po
index f4fe1c24b0..d81c6c08c1 100644
--- a/po/vls.po
+++ b/po/vls.po
@@ -8,14 +8,16 @@ msgstr ""
 "Project-Id-Version: phpMyAdmin 4.1-dev\n"
 "Report-Msgid-Bugs-To: phpmyadmin-devel@lists.sourceforge.net\n"
 "POT-Creation-Date: 2013-07-12 16:06+0200\n"
-"PO-Revision-Date: 2013-07-12 16:06+0200\n"
-"Last-Translator: Automatically generated\n"
-"Language-Team: none\n"
+"PO-Revision-Date: 2013-07-22 11:57+0200\n"
+"Last-Translator: Michal Čihař <michal@cihar.com>\n"
+"Language-Team: West Flemish "
+"<http://l10n.cihar.com/projects/phpmyadmin/master/vls/>\n"
 "Language: vls\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 1.6-dev\n"
 
 #: browse_foreigners.php:51 browse_foreigners.php:75 js/messages.php:339
 #: libraries/DisplayResults.class.php:813
@@ -2099,13 +2101,13 @@ msgstr ""
 #. l10n: Month-year order for calendar, use either "calendar-month-year" or "calendar-year-month".
 #: js/messages.php:509
 msgid "calendar-month-year"
-msgstr ""
+msgstr "calendar-month-year"
 
 #. l10n: Year suffix for calendar, "none" is empty.
 #: js/messages.php:511
 msgctxt "Year suffix"
 msgid "none"
-msgstr ""
+msgstr "none"
 
 #: js/messages.php:520
 msgid "Hour"

From e186cffe2dd12f158c8802ddc7cb1e1622446a59 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 22 Jul 2013 06:03:03 -0400
Subject: [PATCH 04/33] Clarify code path

---
 libraries/sql.lib.php | 4 ++++
 sql.php               | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/libraries/sql.lib.php b/libraries/sql.lib.php
index e2ea325f7b..ae21b53f52 100644
--- a/libraries/sql.lib.php
+++ b/libraries/sql.lib.php
@@ -1028,6 +1028,9 @@ function PMA_addBookmark($pmaAbsoluteUri, $goto)
         exit;
     } else {
         // go back to sql.php to redisplay query; do not use &amp; in this case:
+        /**
+         * @todo In which scenario does this happen? 
+         */
         PMA_sendHeaderLocation(
             $pmaAbsoluteUri . $goto
             . '&label=' . $_POST['bkm_fields']['bkm_label']
@@ -2013,6 +2016,7 @@ function PMA_sendQueryResponseForResultsReturned($result, $justBrowsing,
     // value of a transformed field, show it here
     if (isset($_REQUEST['grid_edit']) && $_REQUEST['grid_edit'] == true) {
         PMA_sendResponseForGridEdit($result);
+        // script has exited at this point
     }
 
     // Gets the list of fields properties
diff --git a/sql.php b/sql.php
index d64570a65e..336b7b1861 100644
--- a/sql.php
+++ b/sql.php
@@ -84,17 +84,20 @@ if (isset($_REQUEST['get_relational_values'])
     && $_REQUEST['get_relational_values'] == true
 ) {
     PMA_getRelationalValues($db, $table, $display_field);
+    // script has exited at this point 
 }
 
 // Just like above, find possible values for enum fields during grid edit.
 if (isset($_REQUEST['get_enum_values']) && $_REQUEST['get_enum_values'] == true) {
     PMA_getEnumOrSetValues($db, $table, "enum");
+    // script has exited at this point 
 }
 
 
 // Find possible values for set fields during grid edit.
 if (isset($_REQUEST['get_set_values']) && $_REQUEST['get_set_values'] == true) {
     PMA_getEnumOrSetValues($db, $table, "set");
+    // script has exited at this point 
 }
 
 /**
@@ -102,6 +105,7 @@ if (isset($_REQUEST['get_set_values']) && $_REQUEST['get_set_values'] == true) {
  */
 if (isset($_REQUEST['set_col_prefs']) && $_REQUEST['set_col_prefs'] == true) {
     PMA_setColumnOrderOrVisibility($table, $db);
+    // script has exited at this point 
 }
 
 // Default to browse if no query set and we have table
@@ -153,6 +157,7 @@ if (isset($find_real_end) && $find_real_end) {
  */
 if (isset($_POST['store_bkm'])) {
     PMA_addBookmark($cfg['PmaAbsoluteUri'], $goto);
+    // script has exited at this point 
 } // end if
 
 

From 24014834509f0259731dd4600af7969474130e97 Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Mon, 22 Jul 2013 21:34:41 +0800
Subject: [PATCH 05/33] UTs for PMA_display_export

---
 test/libraries/PMA_display_export_test.php | 239 +++++++++++++++++++++
 1 file changed, 239 insertions(+)
 create mode 100644 test/libraries/PMA_display_export_test.php

diff --git a/test/libraries/PMA_display_export_test.php b/test/libraries/PMA_display_export_test.php
new file mode 100644
index 0000000000..8475c27890
--- /dev/null
+++ b/test/libraries/PMA_display_export_test.php
@@ -0,0 +1,239 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * tests for display_export.lib.php
+ *
+ * @package PhpMyAdmin-test
+ */
+
+/*
+ * Include to test.
+ */
+require_once 'libraries/Util.class.php';
+require_once 'libraries/Table.class.php';
+require_once 'libraries/Advisor.class.php';
+require_once 'libraries/php-gettext/gettext.inc';
+require_once 'libraries/url_generating.lib.php';
+require_once 'libraries/ServerStatusData.class.php';
+require_once 'libraries/display_export.lib.php';
+require_once 'libraries/Theme.class.php';
+require_once 'libraries/database_interface.inc.php';
+require_once 'libraries/charset_conversion.lib.php';
+require_once 'libraries/Message.class.php';
+require_once 'libraries/plugin_interface.lib.php';
+require_once 'libraries/sanitizing.lib.php';
+require_once 'libraries/sqlparser.lib.php';
+require_once 'libraries/js_escape.lib.php';
+require_once 'libraries/relation.lib.php';
+
+/**
+ * class PMA_DisplayExport_Test
+ *
+ * this class is for testing display_export.lib.php functions
+ *
+ * @package PhpMyAdmin-test
+ */
+class PMA_DisplayExport_Test extends PHPUnit_Framework_TestCase
+{
+    /**
+     * Test for setUp
+     *
+     * @return void
+     */
+    public function setUp()
+    {    
+        //$GLOBALS
+        $GLOBALS['cfg']['MaxRows'] = 10;
+        $GLOBALS['cfg']['ServerDefault'] = "PMA_server";
+        $GLOBALS['cfg']['TableNavigationLinksMode'] = 'icons';
+        $GLOBALS['cfg']['LimitChars'] = 100;
+        $GLOBALS['cfg']['ActionLinksMode'] = 'icons';
+        $GLOBALS['cfg']['Server']['host'] = "localhost";   
+        $GLOBALS['cfg']['MySQLManualType'] = 'viewable';  
+        $GLOBALS['cfg']['Server']['user'] = "pma_user";
+        $GLOBALS['cfg']['ShowHint'] = true;
+        $GLOBALS['cfg']['ActionLinksMode'] = 'icons';
+        $GLOBALS['cfg']['ZipDump'] = true;
+        $GLOBALS['cfg']['GZipDump'] = false;
+        $GLOBALS['cfg']['BZipDump'] = false;
+        $GLOBALS['cfg']['Export']['asfile'] = true;
+        $GLOBALS['cfg']['Export']['file_template_server'] = "file_template_server";
+        $GLOBALS['PMA_PHP_SELF'] = PMA_getenv('PHP_SELF');
+        $GLOBALS['PMA_recoding_engine'] = "InnerDB";
+        $GLOBALS['server'] = 0;
+        
+        $GLOBALS['table'] = "table";
+        $GLOBALS['pmaThemeImage'] = 'image';
+        $GLOBALS['db'] = "PMA";
+        
+        //$_SESSION
+        $_SESSION['PMA_Theme'] = PMA_Theme::load('./themes/pmahomme');
+        $_SESSION['PMA_Theme'] = new PMA_Theme();
+        $_SESSION['relation'][$GLOBALS['server']] = "";
+      
+        $pmaconfig = $this->getMockBuilder('PMA_Config')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $pmaconfig->expects($this->any())
+            ->method('getUserValue')
+            ->will($this->returnValue('user value for test'));
+
+        $GLOBALS['PMA_Config'] = $pmaconfig;
+    }
+
+    /**
+     * Test for PMA_getHtmlForHiddenInput
+     *
+     * @return void
+     */
+    public function testPMAGetHtmlForHiddenInput()
+    {
+        $export_type = "server";
+        $db = "PMA";
+        $table = "PMA_test";
+        $single_table_str = "PMA_single_str";
+        $sql_query_str = "sql_query_str";
+
+        //Call the test function
+        $html = PMA_getHtmlForHiddenInput(
+            $export_type, 
+            $db, 
+            $table, 
+            $single_table_str,
+            $sql_query_str
+        );
+
+        //validate 1: PMA_generate_common_hidden_inputs
+        //$single_table
+        $this->assertContains(
+            '<input type="hidden" name="single_table" value="TRUE"',
+            $html
+        );
+        //$export_type
+        $this->assertContains(
+            '<input type="hidden" name="export_type" value="server"',
+            $html
+        );
+        $this->assertContains(
+            '<input type="hidden" name="export_method" value="quick"',
+            $html
+        );
+    }
+
+    /**
+     * Test for PMA_getHtmlForExportOptions
+     *
+     * @return vgetUserValue
+     */
+    public function testPMAGetHtmlForExportOptions()
+    {      
+        global $cfg;
+        $cfg['Export']['method'] = "XML";
+        $cfg['SaveDir'] = "/tmp";
+        
+        $export_type = "server";
+        $db = "PMA";
+        $table = "PMA_test";
+        $multi_values_str = "multi_values_str";
+        $num_tables_str = "10";
+        $export_list = null;
+        $unlim_num_rows_str = "unlim_num_rows_str";
+        $single_table = "single_table";
+        PMA_Table::$cache[$db][$table]['ENGINE'] = "MERGE";
+        
+        /* Scan for plugins */
+        $export_list = PMA_getPlugins(
+            "export",
+            'libraries/plugins/export/',
+            array(
+                'export_type' => $export_type,
+                'single_table' => isset($single_table)
+            )
+        );      
+
+        //Call the test function
+        $html = PMA_getHtmlForExportOptions(
+            $export_type, 
+            $db, 
+            $table, 
+            $multi_values_str, 
+            $num_tables_str, 
+            $export_list,
+            $unlim_num_rows_str
+        );
+
+        //validate 1: PMA_getHtmlForExportOptionHeader
+        $this->assertContains(
+            '<div class="exportoptions" id="header">',
+            $html
+        );
+        $this->assertContains(
+            __('Exporting databases from the current server'),
+            $html
+        );
+
+        //validate 2: PMA_getHtmlForExportOptionsMethod
+        $this->assertContains(
+            $cfg['Export']['method'],
+            $html
+        );
+        $this->assertContains(
+            '<div class="exportoptions" id="quick_or_custom">',
+            $html
+        );
+        $this->assertContains(
+            __('Export Method:'),
+            $html
+        );
+        $this->assertContains(
+            __('Custom - display all possible options'),
+            $html
+        );
+
+        //validate 3: PMA_getHtmlForExportOptionsSelection
+        $this->assertContains(
+            '<div class="exportoptions" id="databases_and_tables">',
+            $html
+        );
+        $this->assertContains(
+            '<h3>' . __('Database(s):') . '</h3>',
+            $html
+        );
+        $this->assertContains(
+            $multi_values_str,
+            $html
+        );
+
+        //validate 4: PMA_getHtmlForExportOptionsQuickExport
+        $this->assertContains(
+            '<input type="checkbox" name="onserver" value="saveit" ',
+            $html
+        );
+        $dir = htmlspecialchars(PMA_Util::userDir($cfg['SaveDir']));
+        $this->assertContains(
+            'Save on server in the directory <b>' . $dir . '</b>',
+            $html
+        );
+
+        //validate 5: PMA_getHtmlForExportOptionsOutput
+        $this->assertContains(
+            '<div class="exportoptions" id="output">',
+            $html
+        );
+        $this->assertContains(
+            'user value for test',
+            $html
+        );
+        
+        //validate 6: PMA_getHtmlForExportOptionsFormat
+        $this->assertContains(
+            '<div class="exportoptions" id="format">',
+            $html
+        );
+        $this->assertContains(
+            '<h3>' . __('Format:') . '</h3>',
+            $html
+        );
+    }
+}

From c1d7d986f40353c56247533a7ad7bcacaaf056fd Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 22 Jul 2013 09:46:13 -0400
Subject: [PATCH 06/33] Comparison does not work when the array element does
 not exist, leading to an incorrect sql query generated

---
 js/tbl_zoom_plot_jqplot.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/js/tbl_zoom_plot_jqplot.js b/js/tbl_zoom_plot_jqplot.js
index 17aba65970..fe7dcf35f3 100644
--- a/js/tbl_zoom_plot_jqplot.js
+++ b/js/tbl_zoom_plot_jqplot.js
@@ -362,7 +362,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () {
                 // other
                 } else {
                     // type explicitly identified
-                    if (sqlTypes[key] !== null) {
+                    if (sqlTypes[key] != null) {
                         if (sqlTypes[key] == 'bit') {
                             sql_query += "b'" + value + "', ";
                         }
@@ -376,6 +376,7 @@ AJAX.registerOnload('tbl_zoom_plot_jqplot.js', function () {
                     }
                 }
             }
+            // remove two extraneous characters ', '
             sql_query = sql_query.substring(0, sql_query.length - 2);
             sql_query += ' WHERE ' + PMA_urldecode(searchedData[searchedDataKey].where_clause);
 

From 5ca23f337dba05b57d952477793fd7f31e3a07ac Mon Sep 17 00:00:00 2001
From: adamgsoc2013 <adamgsoc2013@gmail.com>
Date: Mon, 22 Jul 2013 22:19:11 +0800
Subject: [PATCH 07/33] add test case for parse_analyze.inc.php

---
 libraries/sqlparser.lib.php                   | 13 ++++++
 test/libraries/PMA_SQL_parse_analyze_test.php | 42 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 test/libraries/PMA_SQL_parse_analyze_test.php

diff --git a/libraries/sqlparser.lib.php b/libraries/sqlparser.lib.php
index b99ba814be..c7fe15b7ce 100644
--- a/libraries/sqlparser.lib.php
+++ b/libraries/sqlparser.lib.php
@@ -3041,5 +3041,18 @@ function PMA_SQP_getParserDataMap()
         'PMA_SQPdata_column_type'    => $PMA_SQPdata_column_type,
     );
 }
+/**
+ * Get Parser analyze Map from parse_analyze_inc.php
+ *
+ * @param array $sql_query The SQL string
+ * @param array $db        Current DB
+ *
+ * @return Array analyze Map from parse_analyze_inc.php
+ */
+function PMA_SQP_getParserAnalyzeMap($sql_query, $db)
+{
+    include 'libraries/parse_analyze.inc.php';
+    return $analyzed_sql_results;
+}
 
 ?>
diff --git a/test/libraries/PMA_SQL_parse_analyze_test.php b/test/libraries/PMA_SQL_parse_analyze_test.php
new file mode 100644
index 0000000000..fc44bfc50c
--- /dev/null
+++ b/test/libraries/PMA_SQL_parse_analyze_test.php
@@ -0,0 +1,42 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * tests for correctness of SQL parser analyze data
+ *
+ * @package PhpMyAdmin-test
+ */
+
+/*
+ * Include to test.
+ */
+require_once 'libraries/sqlparser.lib.php';
+
+class PMA_SQLParserAnalyze_Test extends PHPUnit_Framework_TestCase
+{
+    public function testPMA_SQP_getParserAnalyzeMa()
+    {
+        $sql_query = "select * from PMA.PMAParse";
+        $db = "PMA";
+        $data = PMA_SQP_getParserAnalyzeMap($sql_query, $db);
+        
+        $this->assertEquals(
+            array(
+                'type' => 'alpha_reservedWord',
+                'data' => 'select',
+                'pos' => 6,
+                'forbidden' => true,
+            ),
+            $data['parsed_sql'][0]
+        );
+        $this->assertEquals(
+            'select * from PMA.PMAParse',
+            $data['analyzed_sql'][0]['unsorted_query']
+        );
+        $this->assertFalse($data['reload']);
+        $this->assertFalse($data['is_group']);
+        $this->assertFalse($data['is_show']);
+        $this->assertFalse($data['is_group']);
+    }
+}
+
+?>

From 1c0fd2fdfef304bc7b1d2eacbf321a7b1950db86 Mon Sep 17 00:00:00 2001
From: adamgsoc2013 <adamgsoc2013@gmail.com>
Date: Mon, 22 Jul 2013 23:12:36 +0800
Subject: [PATCH 08/33] add update sql statement for testing

---
 test/libraries/PMA_SQL_parse_analyze_test.php | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/test/libraries/PMA_SQL_parse_analyze_test.php b/test/libraries/PMA_SQL_parse_analyze_test.php
index fc44bfc50c..61a6723c38 100644
--- a/test/libraries/PMA_SQL_parse_analyze_test.php
+++ b/test/libraries/PMA_SQL_parse_analyze_test.php
@@ -9,12 +9,14 @@
 /*
  * Include to test.
  */
+require_once 'libraries/Util.class.php';
 require_once 'libraries/sqlparser.lib.php';
 
 class PMA_SQLParserAnalyze_Test extends PHPUnit_Framework_TestCase
 {
     public function testPMA_SQP_getParserAnalyzeMa()
     {
+        //select statement
         $sql_query = "select * from PMA.PMAParse";
         $db = "PMA";
         $data = PMA_SQP_getParserAnalyzeMap($sql_query, $db);
@@ -32,10 +34,33 @@ class PMA_SQLParserAnalyze_Test extends PHPUnit_Framework_TestCase
             'select * from PMA.PMAParse',
             $data['analyzed_sql'][0]['unsorted_query']
         );
-        $this->assertFalse($data['reload']);
+
+        $this->assertTrue($data['is_select']);
         $this->assertFalse($data['is_group']);
         $this->assertFalse($data['is_show']);
+        
+        //update statement
+        $sql_query = "UPDATE `11`.`pma_bookmark` SET `id` = '2' WHERE `pma_bookmark`.`id` = 1;";
+        $db = "PMA";
+        $data = PMA_SQP_getParserAnalyzeMap($sql_query, $db);
+        
+        $this->assertEquals(
+            array(
+                'type' => 'alpha_reservedWord',
+                'data' => 'UPDATE',
+                'pos' => 6,
+                'forbidden' => true,
+            ),
+            $data['parsed_sql'][0]
+        );
+        $this->assertEquals(
+            $sql_query,
+            $data['analyzed_sql'][0]['unsorted_query']
+        );
         $this->assertFalse($data['is_group']);
+        $this->assertFalse($data['is_show']);
+        $this->assertTrue($data['is_affected']);
+        $this->assertFalse($data['is_select']);        
     }
 }
 

From d80fa9452eff45d6b6dda4cfa67cd5fb8fe658a5 Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Mon, 22 Jul 2013 22:50:50 +0530
Subject: [PATCH 09/33] taken care by sql.js in client side

---
 js/sql.js          |  4 +++-
 tbl_row_action.php | 12 ------------
 2 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/js/sql.js b/js/sql.js
index e561ba5bf5..59a398814a 100644
--- a/js/sql.js
+++ b/js/sql.js
@@ -361,7 +361,9 @@ AJAX.registerOnload('sql.js', function () {
 /**
  * Ajax Event for table row change
  * */
-    $("#resultsForm.ajax .mult_submit[value=edit]").live('click', function (event) {
+    $("#resultsForm.ajax .mult_submit[value=edit]," +
+            "#resultsForm.ajax .mult_submit[value=delete],"  +
+            "#resultsForm.ajax .mult_submit[value=export]").live('click', function (event) {
         event.preventDefault();
 
         /*Check whether atleast one row is selected for change*/
diff --git a/tbl_row_action.php b/tbl_row_action.php
index b9ccaa4a3c..400f116e8c 100644
--- a/tbl_row_action.php
+++ b/tbl_row_action.php
@@ -12,18 +12,6 @@
 require_once 'libraries/common.inc.php';
 require_once 'libraries/mysql_charsets.inc.php';
 
-/**
- * No rows were selected => show again the query and tell that user.
- */
-if (! PMA_isValid($_REQUEST['rows_to_delete'], 'array')
-    && ! isset($_REQUEST['mult_btn'])
-) {
-    $disp_message = __('No rows selected');
-    $disp_query = '';
-    include 'sql.php';
-    exit;
-}
-
 if (isset($_REQUEST['submit_mult'])) {
     $submit_mult = $_REQUEST['submit_mult'];
     // workaround for IE problem:

From 6a053b562796929fb77adba454d7b971d24f6d4c Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Mon, 22 Jul 2013 22:52:57 +0530
Subject: [PATCH 10/33] replace include 'sql.php' with method calls to
 sql.lib.php

---
 tbl_row_action.php | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tbl_row_action.php b/tbl_row_action.php
index 400f116e8c..121f05a18b 100644
--- a/tbl_row_action.php
+++ b/tbl_row_action.php
@@ -11,6 +11,7 @@
  */
 require_once 'libraries/common.inc.php';
 require_once 'libraries/mysql_charsets.inc.php';
+require_once 'libraries/sql.lib.php';
 
 if (isset($_REQUEST['submit_mult'])) {
     $submit_mult = $_REQUEST['submit_mult'];
@@ -124,8 +125,16 @@ if (!empty($submit_mult)) {
         unset($submit_mult, $_REQUEST['mult_btn']);
 
         $active_page = 'sql.php';
-        include 'sql.php';
-        break;
+        /**
+         * Parse and analyze the query
+         */
+        require_once 'libraries/parse_analyze.inc.php';
+
+        PMA_executeQueryAndSendQueryResponse(
+            $analyzed_sql_results, false, $db, $table, null, null, null, false, null,
+            null, null, null, $goto, $pmaThemeImage, null, null, null, $sql_query,
+            null, null
+        );
     }
 }
 ?>

From 96836745c42f9040116c7f7f7ff5f777ad26ba96 Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Tue, 23 Jul 2013 00:17:52 +0530
Subject: [PATCH 11/33] error coorected

---
 js/sql.js | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/js/sql.js b/js/sql.js
index 59a398814a..81ad2cb638 100644
--- a/js/sql.js
+++ b/js/sql.js
@@ -361,9 +361,7 @@ AJAX.registerOnload('sql.js', function () {
 /**
  * Ajax Event for table row change
  * */
-    $("#resultsForm.ajax .mult_submit[value=edit]," +
-            "#resultsForm.ajax .mult_submit[value=delete],"  +
-            "#resultsForm.ajax .mult_submit[value=export]").live('click', function (event) {
+    $("#resultsForm.ajax .mult_submit[value=edit]").live('click', function (event) {
         event.preventDefault();
 
         /*Check whether atleast one row is selected for change*/
@@ -428,6 +426,17 @@ AJAX.registerOnload('sql.js', function () {
         }
     });
 
+    /**
+     * Checks whether atleast one row is selected for slected row editing and export
+     */
+    $("#resultsForm.ajax .mult_submit[value=delete]," +
+            "#resultsForm.ajax .mult_submit[value=export]").live('click', function (event) {
+        /*Check whether atleast one row is selected for change*/
+        if (!$("#table_results tbody tr, #table_results tbody tr td").hasClass("marked")) {
+            event.preventDefault();
+            PMA_ajaxShowMessage(PMA_messages.strNoRowSelected);
+        }
+    });
 /**
  * Click action for "Go" button in ajax dialog insertForm -> insertRowTable
  */

From a025fe1781cdeccfec79e5f83414748b6305b92a Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Tue, 23 Jul 2013 00:26:02 +0530
Subject: [PATCH 12/33] typo corrected

---
 js/sql.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/sql.js b/js/sql.js
index 81ad2cb638..a27c9c66b5 100644
--- a/js/sql.js
+++ b/js/sql.js
@@ -427,7 +427,7 @@ AJAX.registerOnload('sql.js', function () {
     });
 
     /**
-     * Checks whether atleast one row is selected for slected row editing and export
+     * Checks whether atleast one row is selected for selcted row editing and export
      */
     $("#resultsForm.ajax .mult_submit[value=delete]," +
             "#resultsForm.ajax .mult_submit[value=export]").live('click', function (event) {

From f5639ca63d18f5d9efbc4ad7a8d57a5df56bb813 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 22 Jul 2013 15:28:31 -0400
Subject: [PATCH 13/33] Clarify comments

---
 js/sql.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/js/sql.js b/js/sql.js
index a27c9c66b5..18c26d4296 100644
--- a/js/sql.js
+++ b/js/sql.js
@@ -364,7 +364,7 @@ AJAX.registerOnload('sql.js', function () {
     $("#resultsForm.ajax .mult_submit[value=edit]").live('click', function (event) {
         event.preventDefault();
 
-        /*Check whether atleast one row is selected for change*/
+        /*Check whether at least one row is selected*/
         if ($("#table_results tbody tr, #table_results tbody tr td").hasClass("marked")) {
             var $div = $('<div id="change_row_dialog"></div>');
 
@@ -427,11 +427,11 @@ AJAX.registerOnload('sql.js', function () {
     });
 
     /**
-     * Checks whether atleast one row is selected for selcted row editing and export
+     * Checks whether at least one row is selected for deletion or export
      */
     $("#resultsForm.ajax .mult_submit[value=delete]," +
             "#resultsForm.ajax .mult_submit[value=export]").live('click', function (event) {
-        /*Check whether atleast one row is selected for change*/
+        /*Check whether at least one row is selected*/
         if (!$("#table_results tbody tr, #table_results tbody tr td").hasClass("marked")) {
             event.preventDefault();
             PMA_ajaxShowMessage(PMA_messages.strNoRowSelected);

From 7c44c81b9e813da6673529cddbf6c4844f780094 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 22 Jul 2013 15:30:31 -0400
Subject: [PATCH 14/33] No longer needed

---
 tbl_row_action.php | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tbl_row_action.php b/tbl_row_action.php
index 121f05a18b..264ec36cb1 100644
--- a/tbl_row_action.php
+++ b/tbl_row_action.php
@@ -120,10 +120,6 @@ if (!empty($submit_mult)) {
             $url_query = $original_url_query;
         }
 
-        // this is because sql.php could call tbl_structure
-        // which would think it needs to call mult_submits.inc.php:
-        unset($submit_mult, $_REQUEST['mult_btn']);
-
         $active_page = 'sql.php';
         /**
          * Parse and analyze the query

From 76ba0b03cd56b1b4003ebb22d071e13b5a863859 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Mon, 22 Jul 2013 15:33:54 -0400
Subject: [PATCH 15/33] No longer needed

---
 sql.php | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sql.php b/sql.php
index 336b7b1861..2aeadebbb6 100644
--- a/sql.php
+++ b/sql.php
@@ -24,8 +24,6 @@ $header   = $response->getHeader();
 $scripts  = $header->getScripts();
 $scripts->addFile('jquery/jquery-ui-timepicker-addon.js');
 $scripts->addFile('tbl_change.js');
-// the next one needed because sql.php may do a "goto" to tbl_structure.php
-$scripts->addFile('tbl_structure.js');
 $scripts->addFile('indexes.js');
 $scripts->addFile('gis_data_editor.js');
 

From 81dba57b6a655997aa3584e34ac1003277970404 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Tue, 23 Jul 2013 11:20:56 +0200
Subject: [PATCH 16/33] Better injection of variables into eval'd code

---
 libraries/Advisor.class.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/libraries/Advisor.class.php b/libraries/Advisor.class.php
index 91c8bf2beb..bd85d8bc0a 100644
--- a/libraries/Advisor.class.php
+++ b/libraries/Advisor.class.php
@@ -300,11 +300,14 @@ class Advisor
      */
     private function _ruleExprEvaluateVariable($matches)
     {
-        return isset($this->variables[$matches[1]])
-            ? (is_numeric($this->variables[$matches[1]])
-                ? $this->variables[$matches[1]]
-                : '"'.$this->variables[$matches[1]].'"')
-            : $matches[1];
+        if (! isset($this->variables[$matches[1]])) {
+            return $matches[1];
+        }
+        if (is_numeric($this->variables[$matches[1]])) {
+            return $this->variables[$matches[1]];
+        } else {
+            return '\'' . addslashes($this->variables[$matches[1]]) . '\'';
+        }
     }
 
     /**

From 2f48cd69eb74f48565b7505e4dd3cb6ce8844683 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Tue, 23 Jul 2013 11:34:33 +0200
Subject: [PATCH 17/33] Fix rule definition (value and check were mixed)

---
 libraries/advisory_rules.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/advisory_rules.txt b/libraries/advisory_rules.txt
index 3ffa1d9faf..354791c12b 100644
--- a/libraries/advisory_rules.txt
+++ b/libraries/advisory_rules.txt
@@ -200,8 +200,8 @@ rule 'Query cache max size' [!fired('Query cache disabled')]
 	Current query cache size: %s | implode(' ',ADVISOR_formatByteDown(value, 2, 2))
 
 rule 'Query cache min result size' [!fired('Query cache disabled')]
-	value == 1024*1024
 	query_cache_limit
+	value == 1024*1024
 	The max size of the result set in the query cache is the default of 1 MiB.
 	Changing {query_cache_limit} (usually by increasing) may increase efficiency. This variable determines the maximum size a query result may have to be inserted into the query cache. If there are many query results above 1 MiB that are well cacheable (many reads, little writes) then increasing {query_cache_limit} will increase efficiency. Whereas in the case of many query results being above 1 MiB that are not very well cacheable (often invalidated due to table updates) increasing {query_cache_limit} might reduce efficiency.
 	query_cache_limit is set to 1 MiB

From 8a5e39a9f7e61aafea103f2bcbed35c21e7865a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Tue, 23 Jul 2013 11:43:39 +0200
Subject: [PATCH 18/33] Use variable variables instead of eval

---
 libraries/sysinfo.lib.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libraries/sysinfo.lib.php b/libraries/sysinfo.lib.php
index d2b2e982b3..46e253010d 100644
--- a/libraries/sysinfo.lib.php
+++ b/libraries/sysinfo.lib.php
@@ -176,12 +176,13 @@ class PMA_SysInfoWinnt extends PMA_SysInfo
             }
             $arrInstance = array();
             foreach ($arrProp as $propItem) {
+                $name = $propItem->Name;
                 if ( empty($strValue)) {
-                    eval("\$value = \$objItem->" . $propItem->Name . ";");
+                    $value = $objItem->$name;
                     $arrInstance[$propItem->Name] = trim($value);
                 } else {
                     if (in_array($propItem->Name, $strValue)) {
-                        eval("\$value = \$objItem->" . $propItem->Name . ";");
+                        $value = $objItem->$name;
                         $arrInstance[$propItem->Name] = trim($value);
                     }
                 }

From 5401211ac24bef3198539264d65a51f75bc951ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Tue, 23 Jul 2013 11:44:03 +0200
Subject: [PATCH 19/33] Avoid code duplication

---
 libraries/sysinfo.lib.php | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/libraries/sysinfo.lib.php b/libraries/sysinfo.lib.php
index 46e253010d..74fa7f127b 100644
--- a/libraries/sysinfo.lib.php
+++ b/libraries/sysinfo.lib.php
@@ -177,14 +177,9 @@ class PMA_SysInfoWinnt extends PMA_SysInfo
             $arrInstance = array();
             foreach ($arrProp as $propItem) {
                 $name = $propItem->Name;
-                if ( empty($strValue)) {
+                if ( empty($strValue) || in_array($propItem->Name, $strValue)) {
                     $value = $objItem->$name;
                     $arrInstance[$propItem->Name] = trim($value);
-                } else {
-                    if (in_array($propItem->Name, $strValue)) {
-                        $value = $objItem->$name;
-                        $arrInstance[$propItem->Name] = trim($value);
-                    }
                 }
             }
             $arrData[] = $arrInstance;

From 1e109f88b283fc6f826015f7554c5e891c14206c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Tue, 23 Jul 2013 11:44:34 +0200
Subject: [PATCH 20/33] Use local variable

---
 libraries/sysinfo.lib.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libraries/sysinfo.lib.php b/libraries/sysinfo.lib.php
index 74fa7f127b..ef33910626 100644
--- a/libraries/sysinfo.lib.php
+++ b/libraries/sysinfo.lib.php
@@ -177,9 +177,9 @@ class PMA_SysInfoWinnt extends PMA_SysInfo
             $arrInstance = array();
             foreach ($arrProp as $propItem) {
                 $name = $propItem->Name;
-                if ( empty($strValue) || in_array($propItem->Name, $strValue)) {
+                if ( empty($strValue) || in_array($name, $strValue)) {
                     $value = $objItem->$name;
-                    $arrInstance[$propItem->Name] = trim($value);
+                    $arrInstance[$name] = trim($value);
                 }
             }
             $arrData[] = $arrInstance;

From 957a204c5a8b68e303d27c97e694477bc97f8b58 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Tue, 23 Jul 2013 07:12:44 -0400
Subject: [PATCH 21/33] Fix typos

---
 js/chart.js                  | 2 +-
 libraries/core.lib.php       | 2 +-
 libraries/operations.lib.php | 2 +-
 libraries/sql.lib.php        | 2 +-
 tbl_row_action.php           | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/js/chart.js b/js/chart.js
index 895d051d9b..dcd08cc2ae 100644
--- a/js/chart.js
+++ b/js/chart.js
@@ -170,7 +170,7 @@ var ColumnType = {
 };
 
 /*******************************************************************************
- * JQPlot specifc code
+ * JQPlot specific code
  ******************************************************************************/
 
 /**
diff --git a/libraries/core.lib.php b/libraries/core.lib.php
index e5766e51e4..fe26d3f2f3 100644
--- a/libraries/core.lib.php
+++ b/libraries/core.lib.php
@@ -55,7 +55,7 @@ function PMA_ifSetOr(&$var, $default = null, $type = 'similar')
  * $type can be:
  * - false       : no type checking
  * - 'scalar'    : whether type of $var is integer, float, string or boolean
- * - 'numeric'   : whether type of $var is any number repesentation
+ * - 'numeric'   : whether type of $var is any number representation
  * - 'length'    : whether type of $var is scalar with a string length > 0
  * - 'similar'   : whether type of $var is similar to type of $compare
  * - 'equal'     : whether type of $var is identical to type of $compare
diff --git a/libraries/operations.lib.php b/libraries/operations.lib.php
index 9e25525437..46377f5106 100644
--- a/libraries/operations.lib.php
+++ b/libraries/operations.lib.php
@@ -428,7 +428,7 @@ function PMA_getSqlConstraintsQueryForFullDb(
  *
  * @param array  $tables_full       array of all tables in given db or dbs
  * @param object $export_sql_plugin export plugin instance
- * @param strin  $db                database name
+ * @param string $db                database name
  *
  * @return array $views
  */
diff --git a/libraries/sql.lib.php b/libraries/sql.lib.php
index ae21b53f52..bb50899c51 100644
--- a/libraries/sql.lib.php
+++ b/libraries/sql.lib.php
@@ -15,7 +15,7 @@ if (!defined('PHPMYADMIN')) {
  * @param string $sql       SQL query
  * @param array  $databases array with all databases
  *
- * @return strin $db new database name
+ * @return string $db new database name
  */
 function PMA_getNewDatabase($sql, $databases)
 {
diff --git a/tbl_row_action.php b/tbl_row_action.php
index 264ec36cb1..7ecae32694 100644
--- a/tbl_row_action.php
+++ b/tbl_row_action.php
@@ -1,7 +1,7 @@
 <?php
 /* vim: set expandtab sw=4 ts=4 sts=4: */
 /**
- * handle row specifc actions like edit, delete, export
+ * handle row specific actions like edit, delete, export
  *
  * @package PhpMyAdmin
  */

From 69b7c86f5059eced1957a8ac6890f70360250421 Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Tue, 23 Jul 2013 21:20:18 +0530
Subject: [PATCH 22/33] class redeclaration error corrected

---
 libraries/sql.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/sql.lib.php b/libraries/sql.lib.php
index bb50899c51..bbb7f90a8f 100644
--- a/libraries/sql.lib.php
+++ b/libraries/sql.lib.php
@@ -2253,7 +2253,7 @@ function PMA_executeQueryAndSendQueryResponse($analyzed_sql_results,
     $query_type, $sql_query, $selected, $complete_query
 ) {
     // Include PMA_Index class for use in PMA_DisplayResults class
-    include './libraries/Index.class.php';
+    include_once './libraries/Index.class.php';
 
     include 'libraries/DisplayResults.class.php';
 

From 5dc092ba249858120918759a027fe8c5ec350854 Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Tue, 23 Jul 2013 21:25:10 +0530
Subject: [PATCH 23/33] replaced include sql.php from tbl_structure.php

---
 tbl_structure.php | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tbl_structure.php b/tbl_structure.php
index c2f8bb1c9a..de4a4ffd2c 100644
--- a/tbl_structure.php
+++ b/tbl_structure.php
@@ -18,6 +18,8 @@ require_once 'libraries/mysql_charsets.inc.php';
  */
 require_once 'libraries/structure.lib.php';
 require_once 'libraries/index.lib.php';
+require_once 'libraries/sql.lib.php';
+require_once 'libraries/bookmark.lib.php';
 
 $response = PMA_Response::getInstance();
 $header   = $response->getHeader();
@@ -103,8 +105,15 @@ if (! empty($submit_mult)) {
             }
             $sql_query .= ' FROM ' . PMA_Util::backquote($db)
             . '.' . PMA_Util::backquote($table);
-            include 'sql.php';
-            exit;
+            
+            // Parse and analyze the query
+            require_once 'libraries/parse_analyze.inc.php';
+            
+            PMA_executeQueryAndSendQueryResponse(
+                $analyzed_sql_results, false, $db, $table, null, null, null, false, null,
+                null, null, null, $goto, $pmaThemeImage, null, null, null, $sql_query,
+                null, null
+            );
         } else {
             // handle multiple field commands
             // handle confirmation of deleting multiple fields/columns

From ea842c4f362ee1069b11952e9813b271df82cf42 Mon Sep 17 00:00:00 2001
From: Spun Nakandala <supun.nakandala@gmail.com>
Date: Tue, 23 Jul 2013 21:35:18 +0530
Subject: [PATCH 24/33] removed include sql.php from db_qbe.php

---
 db_qbe.php | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/db_qbe.php b/db_qbe.php
index 940758cccf..003b2fe033 100644
--- a/db_qbe.php
+++ b/db_qbe.php
@@ -11,6 +11,9 @@
  */
 require_once 'libraries/common.inc.php';
 require_once 'libraries/DBQbe.class.php';
+require_once 'libraries/bookmark.lib.php';
+require_once 'libraries/sql.lib.php';
+
 $response = PMA_Response::getInstance();
 
 // Gets the relation settings
@@ -25,8 +28,15 @@ if (isset($_REQUEST['submit_sql']) && ! empty($sql_query)) {
         $message_to_display = true;
     } else {
         $goto      = 'db_sql.php';
-        include 'sql.php';
-        exit;
+        
+        // Parse and analyze the query
+        require_once 'libraries/parse_analyze.inc.php';
+
+        PMA_executeQueryAndSendQueryResponse(
+            $analyzed_sql_results, false, $_REQUEST['db'], null, null, null, null,
+            false, null, null, null, null, $goto, $pmaThemeImage, null, null, null,
+            $sql_query, null, null
+        );
     }
 }
 

From 76c1df5ce8f06b99f04862e3ab6d9f66e04e1e7f Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Tue, 23 Jul 2013 15:31:48 -0400
Subject: [PATCH 25/33] Clarify comments

---
 tbl_structure.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tbl_structure.php b/tbl_structure.php
index de4a4ffd2c..1a210cf22d 100644
--- a/tbl_structure.php
+++ b/tbl_structure.php
@@ -1,8 +1,8 @@
 <?php
 /* vim: set expandtab sw=4 ts=4 sts=4: */
 /**
- * Displays table structure infos like fields/columns, indexes, size, rows
- * and allows manipulation of indexes and columns/fields
+ * Displays table structure infos like columns, indexes, size, rows
+ * and allows manipulation of indexes and columns
  *
  * @package PhpMyAdmin
  */
@@ -93,7 +93,7 @@ if (! empty($submit_mult)) {
     if (isset($_REQUEST['selected_fld'])) {
         $err_url = 'tbl_structure.php?' . PMA_generate_common_url($db, $table);
         if ($submit_mult == 'browse') {
-            // browsing the table displaying only selected fields/columns
+            // browsing the table displaying only selected columns
             $GLOBALS['active_page'] = 'sql.php';
             $sql_query = '';
             foreach ($_REQUEST['selected_fld'] as $idx => $sval) {
@@ -116,7 +116,7 @@ if (! empty($submit_mult)) {
             );
         } else {
             // handle multiple field commands
-            // handle confirmation of deleting multiple fields/columns
+            // handle confirmation of deleting multiple columns
             $action = 'tbl_structure.php';
             include 'libraries/mult_submits.inc.php';
             /**

From e32a429038eac2cabfe588cad68c613e061e483c Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Wed, 24 Jul 2013 07:40:04 -0400
Subject: [PATCH 26/33] Directly use the GET parameters

---
 import_status.php | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/import_status.php b/import_status.php
index 9b79f3fff6..f2e661ce24 100644
--- a/import_status.php
+++ b/import_status.php
@@ -63,24 +63,11 @@ if (defined('SESSIONUPLOAD')) {
     }
 }
 
-/**
- * Sets globals from $_GET
- */
-$get_params = array(
-    'message',
-    'id'
-);
-foreach ($get_params as $one_get_param) {
-    if (isset($_GET[$one_get_param])) {
-        $GLOBALS[$one_get_param] = $_GET[$one_get_param];
-    }
-}
-
 // AJAX requests can't be cached!
 PMA_noCacheHeader();
 
-// $GLOBALS["message"] is used for asking for an import message
-if (isset($GLOBALS["message"]) && $GLOBALS["message"]) {
+// $_GET["message"] is used for asking for an import message
+if (isset($_GET["message"]) && $_GET["message"]) {
 
     header('Content-type: text/html');
 
@@ -100,6 +87,6 @@ if (isset($GLOBALS["message"]) && $GLOBALS["message"]) {
     echo '</fieldset>'."\n";
 
 } else {
-    PMA_importAjaxStatus($GLOBALS["id"]);
+    PMA_importAjaxStatus($_GET["id"]);
 }
 ?>

From 93c5a23a727d6ca82b22842152e459aa9430fc69 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Wed, 24 Jul 2013 10:51:14 -0400
Subject: [PATCH 27/33] bug #4024 Editing field a record is selected by makes
 pma load forever

---
 ChangeLog | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index bd9c1decab..5f7320da3a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -25,7 +25,7 @@ phpMyAdmin - ChangeLog
 - [core] Dropped support for PHP 5.2.
 + rfe #487 and rfe #1405 Find and Replacing column wise
 + rfe #1373 Use same create view dialog for editing a view 
-+ rfe #316 Configurable menus; allow user groups with customized menus per group
++ rfe #316 Configurable menus; allow user groups with customized menus per group- bug #4024 Editing field a record is selected by makes pma load forever
 
 4.0.5.0 (not yet released)
 - bug #3977 Not detected configuration storage

From 04d815488d57fb40a9dc92dc46e1258d4a720c15 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C4=8Ciha=C5=99?= <mcihar@suse.cz>
Date: Thu, 25 Jul 2013 11:13:55 +0200
Subject: [PATCH 28/33] Use current DBI API

---
 libraries/operations.lib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/operations.lib.php b/libraries/operations.lib.php
index 46377f5106..7d85b369b3 100644
--- a/libraries/operations.lib.php
+++ b/libraries/operations.lib.php
@@ -380,7 +380,7 @@ function PMA_getSqlQueryAndCreateDbBeforeCopy()
     // Set the SQL mode to NO_AUTO_VALUE_ON_ZERO to prevent MySQL from creating
     // export statements it cannot import
     $sql_set_mode = "SET SQL_MODE='NO_AUTO_VALUE_ON_ZERO'";
-    PMA_DBI_query($sql_set_mode);
+    $GLOBALS['dbi']->query($sql_set_mode);
 
     // rebuild the database list because PMA_Table::moveCopy
     // checks in this list if the target db exists

From 539eeed0574c82d8074c2a08f4077e7379374769 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Thu, 25 Jul 2013 07:13:37 -0400
Subject: [PATCH 29/33] Globals generated from POST were not used

---
 tbl_select.php | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tbl_select.php b/tbl_select.php
index e0fd01f113..f91b0d1c6c 100644
--- a/tbl_select.php
+++ b/tbl_select.php
@@ -27,16 +27,6 @@ $scripts->addFile('tbl_change.js');
 $scripts->addFile('jquery/jquery-ui-timepicker-addon.js');
 $scripts->addFile('gis_data_editor.js');
 
-$post_params = array(
-    'ajax_request',
-    'session_max_rows'
-);
-foreach ($post_params as $one_post_param) {
-    if (isset($_POST[$one_post_param])) {
-        $GLOBALS[$one_post_param] = $_POST[$one_post_param];
-    }
-}
-
 $table_search = new PMA_TableSearch($db, $table, "normal");
 
 /**

From 5891c27e09f60aeb10795a50cd594cae7eddc89b Mon Sep 17 00:00:00 2001
From: saurabh chikate <chikate.saurabh@gmail.com>
Date: Thu, 25 Jul 2013 11:43:23 +0200
Subject: [PATCH 30/33] Translated using Weblate (West Flemish)

Currently translated at 0.1% (4 of 2680)
---
 po/vls.po | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/po/vls.po b/po/vls.po
index d81c6c08c1..1842e4442b 100644
--- a/po/vls.po
+++ b/po/vls.po
@@ -8,8 +8,8 @@ msgstr ""
 "Project-Id-Version: phpMyAdmin 4.1-dev\n"
 "Report-Msgid-Bugs-To: phpmyadmin-devel@lists.sourceforge.net\n"
 "POT-Creation-Date: 2013-07-12 16:06+0200\n"
-"PO-Revision-Date: 2013-07-22 11:57+0200\n"
-"Last-Translator: Michal Čihař <michal@cihar.com>\n"
+"PO-Revision-Date: 2013-07-25 11:43+0200\n"
+"Last-Translator: saurabh chikate <chikate.saurabh@gmail.com>\n"
 "Language-Team: West Flemish "
 "<http://l10n.cihar.com/projects/phpmyadmin/master/vls/>\n"
 "Language: vls\n"
@@ -2124,12 +2124,12 @@ msgstr ""
 #: libraries/Advisor.class.php:78
 #, php-format
 msgid "PHP threw following error: %s"
-msgstr ""
+msgstr "पी एच पी ने ये त्रुटी दिखाई है:%s"
 
 #: libraries/Advisor.class.php:107
 #, php-format
 msgid "Failed evaluating precondition for rule '%s'."
-msgstr ""
+msgstr "पूर्व शर्त कि वजाह से नियम सुलाझाने मे विफल'%s'"
 
 #: libraries/Advisor.class.php:124
 #, php-format

From 1c38c7cf19311dfc34ac1e2d9a7e601bb5e36391 Mon Sep 17 00:00:00 2001
From: Atul Pratap Singh <atulpratapsingh05@gmail.com>
Date: Thu, 25 Jul 2013 19:48:47 +0530
Subject: [PATCH 31/33] Format values in Questions/Connections chart

---
 js/server_status_monitor.js | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/js/server_status_monitor.js b/js/server_status_monitor.js
index c093fea83a..9da93e2e39 100644
--- a/js/server_status_monitor.js
+++ b/js/server_status_monitor.js
@@ -1201,6 +1201,19 @@ AJAX.registerOnload('server_status_monitor.js', function () {
             settings.axes.yaxis.tickOptions = {
                 formatter: $.jqplot.byteFormatter(1) // KiB
             };
+        } else if (settings.title === PMA_messages.strQuestions
+            || settings.title === PMA_messages.strConnections
+        ) {
+            settings.axes.yaxis.tickOptions = {
+                formatter: function(format, val) {
+                    if (Math.abs(val) >= 1000000)
+                        return $.jqplot.sprintf("%.3g M", val/1000000);
+                    else if (Math.abs(val) >= 1000)
+                        return $.jqplot.sprintf("%.3g k", val/1000);
+                    else
+                        return $.jqplot.sprintf("%d", val);
+                }
+            };
         }
 
         settings.series = chartObj.series;

From 84f6e72fa7c02623382e1b300474fa4164554a53 Mon Sep 17 00:00:00 2001
From: Atul Pratap Singh <atulpratapsingh05@gmail.com>
Date: Thu, 25 Jul 2013 19:54:05 +0530
Subject: [PATCH 32/33] Fix bug#4009, y-axis ticks invisible in Questions chart

---
 themes/pmahomme/css/common.css.php | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/themes/pmahomme/css/common.css.php b/themes/pmahomme/css/common.css.php
index 7c903aed0a..dfbd04f0aa 100644
--- a/themes/pmahomme/css/common.css.php
+++ b/themes/pmahomme/css/common.css.php
@@ -2811,3 +2811,9 @@ body .ui-widget {
     color: #235A81;
 }
 
+/* over-riding jqplot-yaxis class */
+.jqplot-yaxis {
+    left:0px !important;
+    min-width:25px;
+    width:auto;
+}

From 6bc8b9a22be9247acd2ed3d3e9c96c53d030501e Mon Sep 17 00:00:00 2001
From: saurabh chikate <chikate.saurabh@gmail.com>
Date: Thu, 25 Jul 2013 14:40:07 +0200
Subject: [PATCH 33/33] Translated using Weblate (West Flemish)

Currently translated at 0.1% (4 of 2680)
---
 po/vls.po | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/po/vls.po b/po/vls.po
index 1842e4442b..43f1a201e2 100644
--- a/po/vls.po
+++ b/po/vls.po
@@ -8,7 +8,7 @@ msgstr ""
 "Project-Id-Version: phpMyAdmin 4.1-dev\n"
 "Report-Msgid-Bugs-To: phpmyadmin-devel@lists.sourceforge.net\n"
 "POT-Creation-Date: 2013-07-12 16:06+0200\n"
-"PO-Revision-Date: 2013-07-25 11:43+0200\n"
+"PO-Revision-Date: 2013-07-25 14:40+0200\n"
 "Last-Translator: saurabh chikate <chikate.saurabh@gmail.com>\n"
 "Language-Team: West Flemish "
 "<http://l10n.cihar.com/projects/phpmyadmin/master/vls/>\n"
@@ -2129,7 +2129,7 @@ msgstr "पी एच पी ने ये त्रुटी दिखाई 
 #: libraries/Advisor.class.php:107
 #, php-format
 msgid "Failed evaluating precondition for rule '%s'."
-msgstr "पूर्व शर्त कि वजाह से नियम सुलाझाने मे विफल'%s'"
+msgstr "पूर्व शर्त कि वजाह से नियम सुलाझाने मे विफलता'%s'."
 
 #: libraries/Advisor.class.php:124
 #, php-format