From 81d1330ae583b2526d62338b3454cbfc91a0714e Mon Sep 17 00:00:00 2001 From: Sean Mollet Date: Thu, 30 Jan 2020 15:17:01 -0600 Subject: [PATCH] Fix crash when tablename or dbname is not set Drop statements don't give proper tablenames, resulting in a crash. Obviously, that issue needs fixed as well, but handling it cleanly seems preferable. Signed-off-by: Sean Mollet --- libraries/classes/Tracker.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/classes/Tracker.php b/libraries/classes/Tracker.php index e8e5cb0525..756232f184 100644 --- a/libraries/classes/Tracker.php +++ b/libraries/classes/Tracker.php @@ -917,10 +917,10 @@ class Tracker // we want to track $sql_query .= " WHERE FIND_IN_SET('" . $result['identifier'] . "',tracking) > 0" . - " AND `db_name` = '" . $GLOBALS['dbi']->escapeString($dbname) . "' " . + " AND `db_name` = '" . $GLOBALS['dbi']->escapeString($dbname ?? '') . "' " . " AND `table_name` = '" . $GLOBALS['dbi']->escapeString($result['tablename']) . "' " . - " AND `version` = '" . $GLOBALS['dbi']->escapeString($version) . "' "; + " AND `version` = '" . $GLOBALS['dbi']->escapeString($version ?? '') . "' "; $relation->queryAsControlUser($sql_query); }