Merge pull request #299 from xmujay/refactor_procedure1

Refactor getQueryStatisticsHtml function in server_status_queries.php
This commit is contained in:
J.M. 2013-05-01 08:17:31 -07:00
commit 378fd7bc63

View File

@ -89,13 +89,29 @@ function getQueryStatisticsHtml($ServerStatusData)
$retval .= '</span>';
$retval .= '</h3>';
$retval .= getServerStatusQueriesDetailsHtml($ServerStatusData);
return $retval;
}
/**
* Returns the html content for the query details
*
* @param object $ServerStatusData An instance of the PMA_ServerStatusData class
*
* @return string
*/
function getServerStatusQueriesDetailsHtml($ServerStatusData)
{
$used_queries = $ServerStatusData->used_queries;
$total_queries = array_sum($used_queries);
// reverse sort by value to show most used statements first
arsort($used_queries);
$odd_row = true;
$perc_factor = 100 / $total_queries; //(- $ServerStatusData->status['Connections']);
$retval .= '<table id="serverstatusqueriesdetails" class="data sortable noclick">';
$retval = '<table id="serverstatusqueriesdetails" class="data sortable noclick">';
$retval .= '<col class="namecol" />';
$retval .= '<col class="valuecol" span="3" />';
$retval .= '<thead>';
@ -155,7 +171,7 @@ function getQueryStatisticsHtml($ServerStatusData)
}
$retval .= htmlspecialchars(json_encode($chart_json));
$retval .= '</div>';
return $retval;
}