diff --git a/libraries/classes/Table/ColumnsDefinition.php b/libraries/classes/Table/ColumnsDefinition.php index 545956fc0c..b2926ca83d 100644 --- a/libraries/classes/Table/ColumnsDefinition.php +++ b/libraries/classes/Table/ColumnsDefinition.php @@ -126,7 +126,6 @@ final class ColumnsDefinition $available_mime = $transformations->getAvailableMimeTypes(); } - // this will be used on templates/columns_definitions/transformation.twig $mime_types = [ 'input_transformation', 'transformation', diff --git a/templates/columns_definitions/column_adjust_privileges.twig b/templates/columns_definitions/column_adjust_privileges.twig deleted file mode 100644 index d0d1e9156a..0000000000 --- a/templates/columns_definitions/column_adjust_privileges.twig +++ /dev/null @@ -1,16 +0,0 @@ -{% if privs_available %} - -{% else %} - -{% endif %} diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig index dc4717503b..c9f288df15 100644 --- a/templates/columns_definitions/column_attributes.twig +++ b/templates/columns_definitions/column_attributes.twig @@ -18,39 +18,41 @@ {% set ci = ci + 1 %} - {# column type #} - {% include 'columns_definitions/column_type.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'type_upper': type_upper - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# column length #} - {% include 'columns_definitions/column_length.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'length_values_input_size': length_values_input_size, - 'length_to_display': length - } only %} - {% set ci = ci + 1 %} + +

+ {% trans 'Edit ENUM/SET values' %} +

+ {% set ci = ci + 1 %} - {# column default #} - {% include 'columns_definitions/column_default.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'type_upper': type_upper, - 'default_value': default_value, - 'char_editing': char_editing - } only %} - {% set ci = ci + 1 %} + + {% if char_editing == 'textarea' %} + + {% else %} + + {% endif %} + {% set ci = ci + 1 %} {# column collation #} @@ -83,76 +85,77 @@ {% set ci = ci + 1 %} - {# column NULL #} - {% include 'columns_definitions/column_null.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta - } only %} + {% set ci = ci + 1 %} {% if change_column is defined and change_column is not empty %} {# column Adjust privileges, Only for 'Edit' Column(s) #} - {% include 'columns_definitions/column_adjust_privileges.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'privs_available': privs_available - } only %} - {% set ci = ci + 1 %} + + {%- else %} title="{% trans "You don't have sufficient privileges to perform this operation; Please refer to the documentation for more details" %}" disabled> + {%- endif %} + {% set ci = ci + 1 %} {% endif %} {% if not is_backup %} {# column indexes, See my other comment about this 'if'. #} - {% include 'columns_definitions/column_indexes.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} {% endif %} - {# column auto_increment #} - {% include 'columns_definitions/column_auto_increment.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# column comments #} - {% include 'columns_definitions/column_comment.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'max_length': max_length, - 'value': column_meta['Field'] is defined - and comments_map is iterable - and comments_map[column_meta['Field']] is defined - ? comments_map[column_meta['Field']]|e - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} {# column virtuality #} {% if is_virtual_columns_supported %} - {% include 'columns_definitions/column_virtuality.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'char_editing': char_editing, - 'expression': column_meta['Expression'] is defined ? column_meta['Expression'], - 'options': options - } only %} - {% set ci = ci + 1 %} + + + {% if char_editing == 'textarea' %} + + {% else %} + + {% endif %} + {% set ci = ci + 1 %} {% endif %} {# move column #} @@ -168,79 +171,78 @@ {% endfor %} - {% include 'columns_definitions/move_column.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'move_columns': move_columns, - 'current_index': current_index - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} {% endif %} {% if cfg_relation['mimework'] and browse_mime and cfg_relation['commwork'] %} - {# Column Mime-type #} - {% include 'columns_definitions/mime_type.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'available_mime': available_mime, - 'mime_map': mime_map - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# Column Browser transformation #} - {% include 'columns_definitions/transformation.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'available_mime': available_mime, - 'mime_map': mime_map, - 'type': 'transformation' - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# column Transformation options #} - {% include 'columns_definitions/transformation_option.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'mime_map': mime_map, - 'type_prefix': '' - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# Column Input transformation #} - {% include 'columns_definitions/transformation.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'available_mime': available_mime, - 'mime_map': mime_map, - 'type': 'input_transformation' - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} - {# column Input transformation options #} - {% include 'columns_definitions/transformation_option.twig' with { - 'column_number': column_number, - 'ci': ci, - 'ci_offset': ci_offset, - 'column_meta': column_meta, - 'mime_map': mime_map, - 'type_prefix': 'input_' - } only %} - {% set ci = ci + 1 %} + + {% set ci = ci + 1 %} {% endif %} diff --git a/templates/columns_definitions/column_auto_increment.twig b/templates/columns_definitions/column_auto_increment.twig deleted file mode 100644 index 46bfb42f6c..0000000000 --- a/templates/columns_definitions/column_auto_increment.twig +++ /dev/null @@ -1,7 +0,0 @@ - diff --git a/templates/columns_definitions/column_comment.twig b/templates/columns_definitions/column_comment.twig deleted file mode 100644 index 653441bf93..0000000000 --- a/templates/columns_definitions/column_comment.twig +++ /dev/null @@ -1,6 +0,0 @@ - diff --git a/templates/columns_definitions/column_default.twig b/templates/columns_definitions/column_default.twig deleted file mode 100644 index dcb66446bb..0000000000 --- a/templates/columns_definitions/column_default.twig +++ /dev/null @@ -1,35 +0,0 @@ -{# here we put 'NONE' as the default value of drop-down; otherwise users would -have problems if they forget to enter the default value (example, for an INT) #} -{% set translation %}{% trans %}None{% context %}for default{% endtrans %}{% endset %} -{% set default_options = { - 'NONE': translation, - 'USER_DEFINED': 'As defined:'|trans, - 'NULL': 'NULL', - 'CURRENT_TIMESTAMP': 'CURRENT_TIMESTAMP' -} %} - - -{% if char_editing == 'textarea' %} - -{% else %} - -{% endif %} diff --git a/templates/columns_definitions/column_extra.twig b/templates/columns_definitions/column_extra.twig deleted file mode 100644 index 7f61f5cb98..0000000000 --- a/templates/columns_definitions/column_extra.twig +++ /dev/null @@ -1,7 +0,0 @@ - diff --git a/templates/columns_definitions/column_indexes.twig b/templates/columns_definitions/column_indexes.twig deleted file mode 100644 index 398022997a..0000000000 --- a/templates/columns_definitions/column_indexes.twig +++ /dev/null @@ -1,24 +0,0 @@ - diff --git a/templates/columns_definitions/column_length.twig b/templates/columns_definitions/column_length.twig deleted file mode 100644 index ef7e5f0654..0000000000 --- a/templates/columns_definitions/column_length.twig +++ /dev/null @@ -1,11 +0,0 @@ - -

- - {% trans 'Edit ENUM/SET values' %} - -

diff --git a/templates/columns_definitions/column_null.twig b/templates/columns_definitions/column_null.twig deleted file mode 100644 index 5afd6497ef..0000000000 --- a/templates/columns_definitions/column_null.twig +++ /dev/null @@ -1,8 +0,0 @@ - diff --git a/templates/columns_definitions/column_type.twig b/templates/columns_definitions/column_type.twig deleted file mode 100644 index e74eb0e135..0000000000 --- a/templates/columns_definitions/column_type.twig +++ /dev/null @@ -1,8 +0,0 @@ - diff --git a/templates/columns_definitions/column_virtuality.twig b/templates/columns_definitions/column_virtuality.twig deleted file mode 100644 index d53f5d55e8..0000000000 --- a/templates/columns_definitions/column_virtuality.twig +++ /dev/null @@ -1,30 +0,0 @@ - - -{% if char_editing == 'textarea' %} - -{% else %} - -{% endif %} diff --git a/templates/columns_definitions/mime_type.twig b/templates/columns_definitions/mime_type.twig deleted file mode 100644 index ef395b65d8..0000000000 --- a/templates/columns_definitions/mime_type.twig +++ /dev/null @@ -1,17 +0,0 @@ - diff --git a/templates/columns_definitions/move_column.twig b/templates/columns_definitions/move_column.twig deleted file mode 100644 index 7c0b3f4bfc..0000000000 --- a/templates/columns_definitions/move_column.twig +++ /dev/null @@ -1,15 +0,0 @@ - diff --git a/templates/columns_definitions/transformation.twig b/templates/columns_definitions/transformation.twig deleted file mode 100644 index 9aec94a565..0000000000 --- a/templates/columns_definitions/transformation.twig +++ /dev/null @@ -1,26 +0,0 @@ - diff --git a/templates/columns_definitions/transformation_option.twig b/templates/columns_definitions/transformation_option.twig deleted file mode 100644 index f87ba7cba9..0000000000 --- a/templates/columns_definitions/transformation_option.twig +++ /dev/null @@ -1,9 +0,0 @@ -{% set options_key = type_prefix ~ 'transformation_options' %} - diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig index f63ef575e6..81e333cabe 100644 --- a/templates/database/central_columns/edit_table_row.twig +++ b/templates/database/central_columns/edit_table_row.twig @@ -12,35 +12,38 @@ - {% include 'columns_definitions/column_type.twig' with { - 'column_number': row_num, - 'ci': 1, - 'ci_offset': 0, - 'column_meta': [], - 'type_upper': row['col_type']|upper - } only %} + - {% include 'columns_definitions/column_length.twig' with { - 'column_number': row_num, - 'ci': 2, - 'ci_offset': 0, - 'length_values_input_size': 8, - 'length_to_display': row['col_length'] - } only %} + +

+ {% trans 'Edit ENUM/SET values' %} +

- {% include 'columns_definitions/column_default.twig' with { - 'column_number': row_num, - 'ci': 3, - 'ci_offset': 0, - 'column_meta': meta, - 'type_upper': row['col_default']|upper, - 'default_value': '', - 'char_editing': char_editing - } only %} + + {% if char_editing == 'textarea' %} + + {% else %} + + {% endif %} @@ -71,20 +74,12 @@ - {% include 'columns_definitions/column_null.twig' with { - 'column_number': row_num, - 'ci': 6, - 'ci_offset': 0, - 'column_meta': {'Null': row['col_isNull']} - } only %} + - {% include 'columns_definitions/column_extra.twig' with { - 'column_number': row_num, - 'ci': 7, - 'ci_offset': 0, - 'column_meta': {'Extra': row['col_extra']} - } only %} + diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig index a832727399..02fc512ab8 100644 --- a/templates/database/central_columns/main.twig +++ b/templates/database/central_columns/main.twig @@ -63,32 +63,28 @@ } only %} - {% include 'columns_definitions/column_type.twig' with { - 'column_number': 0, - 'ci': 1, - 'ci_offset': 0, - 'type_upper': '', - 'column_meta': {} - } only %} + - {% include 'columns_definitions/column_length.twig' with { - 'column_number': 0, - 'ci': 2, - 'ci_offset': 0, - 'length_values_input_size': 8, - 'length_to_display': '' - } only %} + +

+ {% trans 'Edit ENUM/SET values' %} +

- {% include 'columns_definitions/column_default.twig' with { - 'column_number': 0, - 'ci': 3, - 'ci_offset': 0, - 'type_upper': '', - 'column_meta': {}, - 'char_editing': char_editing, - } only %} + + {% if char_editing == 'textarea' %} + + {% else %} + + {% endif %} - {% include 'columns_definitions/column_extra.twig' with { - 'column_number': 0, - 'ci': 7, - 'ci_offset': 0, - 'column_meta': {} - } only %} + @@ -304,39 +290,43 @@ } only %} - {{ row['col_type'] }} - {% include 'columns_definitions/column_type.twig' with { - 'column_number': row_num, - 'ci': 1, - 'ci_offset': 0, - 'type_upper': types_upper[row_num], - 'column_meta': {} - } only %} + {{ row['col_type'] }} + - {{ (row['col_length']?(row['col_length']):'') }} - {% include 'columns_definitions/column_length.twig' with { - 'column_number': row_num, - 'ci': 2, - 'ci_offset': 0, - 'length_values_input_size': 8, - 'length_to_display': row['col_length'] - } only %} + {{ (row['col_length']?(row['col_length']):'') }} + +

+ {% trans 'Edit ENUM/SET values' %} +

- {% if row['col_default'] is defined %} - {{ row['col_default'] }} - {% else %} - None - {% endif %} - {% include 'columns_definitions/column_default.twig' with { - 'column_number': row_num, - 'ci': 3, - 'ci_offset': 0, - 'type_upper': types_upper[row_num], - 'column_meta': rows_meta[row_num], - 'char_editing': char_editing, - } only %} + {% if row['col_default'] is defined %} + {{ row['col_default'] }} + {% else %} + {% trans 'None' %} + {% endif %} + + {% if char_editing == 'textarea' %} + + {% else %} + + {% endif %} {{ row['col_collation'] }} @@ -368,25 +358,13 @@ {{ row['col_isNull'] ? 'Yes' | trans : 'No' | trans }} - {% include 'columns_definitions/column_null.twig' with { - 'column_number': row_num, - 'ci': 6, - 'ci_offset': 0, - 'column_meta': { - 'Null': row['col_isNull'] - } - } only %} + - {{ row['col_extra'] }} - {% include 'columns_definitions/column_extra.twig' with { - 'column_number': row_num, - 'ci': 7, - 'ci_offset': 0, - 'column_meta': { - 'Extra': row['col_extra'] - } - } only %} + {{ row['col_extra'] }} + {% set row_num = row_num + 1 %}