From 5ead3e5683db8e43a6ba2e18dd353c567ea62ccc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Sun, 13 Sep 2020 11:21:23 -0300
Subject: [PATCH 01/14] Remove columns_definitions/column_null template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../columns_definitions/column_attributes.twig  |  9 ++-------
 templates/columns_definitions/column_null.twig  |  8 --------
 .../central_columns/edit_table_row.twig         |  8 ++------
 templates/database/central_columns/main.twig    | 17 +++--------------
 4 files changed, 7 insertions(+), 35 deletions(-)
 delete mode 100644 templates/columns_definitions/column_null.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index dc4717503b..9a1393ea74 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -83,13 +83,8 @@
     {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
-    {# column NULL #}
-    {% include 'columns_definitions/column_null.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'column_meta': column_meta
-    } only %}
+    <input name="field_null[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" type="checkbox" value="YES" class="allow_null"
+      {{- column_meta['Null'] is not empty and column_meta['Null'] != 'NO' and column_meta['Null'] != 'NOT NULL' ? ' checked' }}>
     {% set ci = ci + 1 %}
 </td>
 {% if change_column is defined and change_column is not empty %}
diff --git a/templates/columns_definitions/column_null.twig b/templates/columns_definitions/column_null.twig
deleted file mode 100644
index 5afd6497ef..0000000000
--- a/templates/columns_definitions/column_null.twig
+++ /dev/null
@@ -1,8 +0,0 @@
-<input name="field_null[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    {% if column_meta['Null'] is not empty and column_meta['Null'] != 'NO' and column_meta['Null'] != 'NOT NULL' -%}
-        checked="checked"
-    {%- endif %}
-    type="checkbox"
-    value="YES"
-    class="allow_null">
diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig
index f63ef575e6..9dc337f8cf 100644
--- a/templates/database/central_columns/edit_table_row.twig
+++ b/templates/database/central_columns/edit_table_row.twig
@@ -71,12 +71,8 @@
   </td>
 
   <td class="nowrap" name="col_isNull">
-    {% include 'columns_definitions/column_null.twig' with {
-      'column_number': row_num,
-      'ci': 6,
-      'ci_offset': 0,
-      'column_meta': {'Null': row['col_isNull']}
-    } only %}
+    <input name="field_null[{{ row_num }}]" id="field_{{ row_num }}_6" type="checkbox" value="YES" class="allow_null"
+      {{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' ? ' checked' }}>
   </td>
 
   <td class="nowrap" name="col_extra">
diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig
index a832727399..e64fac8bc0 100644
--- a/templates/database/central_columns/main.twig
+++ b/templates/database/central_columns/main.twig
@@ -116,12 +116,7 @@
                             } only %}
                         </td>
                         <td class="nowrap" name="col_isNull">
-                            {% include 'columns_definitions/column_null.twig' with {
-                                'column_number': 0,
-                                'ci': 6,
-                                'ci_offset': 0,
-                                'column_meta': {}
-                            } only %}
+                          <input name="field_null[0]" id="field_0_6" type="checkbox" value="YES" class="allow_null">
                         </td>
                         <td class="nowrap" name="col_extra">
                             {% include 'columns_definitions/column_extra.twig' with {
@@ -368,14 +363,8 @@
                             </td>
                             <td class="nowrap" name="col_isNull">
                                 <span>{{ row['col_isNull'] ? 'Yes' | trans : 'No' | trans }}</span>
-                                {% include 'columns_definitions/column_null.twig' with {
-                                    'column_number': row_num,
-                                    'ci': 6,
-                                    'ci_offset': 0,
-                                    'column_meta': {
-                                        'Null': row['col_isNull']
-                                    }
-                                } only %}
+                                <input name="field_null[{{ row_num }}]" id="field_{{ row_num }}_6" type="checkbox" value="YES" class="allow_null"
+                                  {{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' ? ' checked' }}>
                             </td>
                             <td class="nowrap" name="col_extra">
                                 <span>{{ row['col_extra'] }}</span>

From c31f55b3f904579e85d3b5be76c89a891a595d29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Sun, 13 Sep 2020 11:56:04 -0300
Subject: [PATCH 02/14] Remove columns_definitions/column_comment template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../columns_definitions/column_attributes.twig   | 16 ++++------------
 .../columns_definitions/column_comment.twig      |  6 ------
 2 files changed, 4 insertions(+), 18 deletions(-)
 delete mode 100644 templates/columns_definitions/column_comment.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 9a1393ea74..3f70d3bcbc 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -122,18 +122,10 @@
     {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
-    {# column comments #}
-    {% include 'columns_definitions/column_comment.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'max_length': max_length,
-        'value': column_meta['Field'] is defined
-            and comments_map is iterable
-            and comments_map[column_meta['Field']] is defined
-            ? comments_map[column_meta['Field']]|e
-    } only %}
-    {% set ci = ci + 1 %}
+  <textarea id="field_{{ column_number }}_{{ ci - ci_offset }}" rows="1" name="field_comments[{{ column_number }}]" maxlength="{{ max_length }}">
+    {{- column_meta['Field'] is defined and comments_map is iterable and comments_map[column_meta['Field']] is defined ? comments_map[column_meta['Field']] -}}
+  </textarea>
+  {% set ci = ci + 1 %}
 </td>
  {# column virtuality #}
 {% if is_virtual_columns_supported %}
diff --git a/templates/columns_definitions/column_comment.twig b/templates/columns_definitions/column_comment.twig
deleted file mode 100644
index 653441bf93..0000000000
--- a/templates/columns_definitions/column_comment.twig
+++ /dev/null
@@ -1,6 +0,0 @@
-<textarea id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    rows="1"
-    name="field_comments[{{ column_number }}]"
-    maxlength="{{ max_length }}">
-  {{- value|raw -}}
-</textarea>

From 9d8e066e5c7fd4f224718c8f4c85dbf5fdcc0f9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Sun, 13 Sep 2020 12:25:16 -0300
Subject: [PATCH 03/14] Remove columns_definitions/column_type template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 14 +++++-------
 .../columns_definitions/column_type.twig      |  8 -------
 .../central_columns/edit_table_row.twig       | 10 +++------
 templates/database/central_columns/main.twig  | 22 ++++++-------------
 4 files changed, 15 insertions(+), 39 deletions(-)
 delete mode 100644 templates/columns_definitions/column_type.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 3f70d3bcbc..ae57f9e901 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -18,15 +18,11 @@
     {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
-    {# column type #}
-    {% include 'columns_definitions/column_type.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'column_meta': column_meta,
-        'type_upper': type_upper
-    } only %}
-    {% set ci = ci + 1 %}
+  <select class="column_type" name="field_type[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}"
+    {{- column_meta['column_status'] is defined and not column_meta['column_status']['isEditable'] ? ' disabled' }}>
+    {{ get_supported_datatypes(true, type_upper) }}
+  </select>
+  {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
     {# column length #}
diff --git a/templates/columns_definitions/column_type.twig b/templates/columns_definitions/column_type.twig
deleted file mode 100644
index e74eb0e135..0000000000
--- a/templates/columns_definitions/column_type.twig
+++ /dev/null
@@ -1,8 +0,0 @@
-<select class="column_type"
-    name="field_type[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    {%- if column_meta['column_status'] is defined and not column_meta['column_status']['isEditable'] -%}
-    disabled="disabled"
-    {%- endif %}>
-    {{ get_supported_datatypes(true, type_upper) }}
-</select>
diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig
index 9dc337f8cf..9a79281456 100644
--- a/templates/database/central_columns/edit_table_row.twig
+++ b/templates/database/central_columns/edit_table_row.twig
@@ -12,13 +12,9 @@
   </td>
 
   <td name="col_type" class="nowrap">
-    {% include 'columns_definitions/column_type.twig' with {
-      'column_number': row_num,
-      'ci': 1,
-      'ci_offset': 0,
-      'column_meta': [],
-      'type_upper': row['col_type']|upper
-    } only %}
+    <select class="column_type" name="field_type[{{ row_num }}]" id="field_{{ row_num }}_1">
+      {{ get_supported_datatypes(true, row['col_type']|upper) }}
+    </select>
   </td>
 
   <td class="nowrap" name="col_length">
diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig
index e64fac8bc0..2670eff8de 100644
--- a/templates/database/central_columns/main.twig
+++ b/templates/database/central_columns/main.twig
@@ -63,13 +63,9 @@
                             } only %}
                         </td>
                         <td name="col_type" class="nowrap">
-                            {% include 'columns_definitions/column_type.twig' with {
-                                'column_number': 0,
-                                'ci': 1,
-                                'ci_offset': 0,
-                                'type_upper': '',
-                                'column_meta': {}
-                            } only %}
+                          <select class="column_type" name="field_type[0]" id="field_0_1">
+                            {{ get_supported_datatypes(true) }}
+                          </select>
                         </td>
                         <td class="nowrap" name="col_length">
                             {% include 'columns_definitions/column_length.twig' with {
@@ -299,14 +295,10 @@
                                 } only %}
                             </td>
                             <td name = "col_type" class="nowrap">
-                                <span>{{ row['col_type'] }}</span>
-                                {% include 'columns_definitions/column_type.twig' with {
-                                    'column_number': row_num,
-                                    'ci': 1,
-                                    'ci_offset': 0,
-                                    'type_upper': types_upper[row_num],
-                                    'column_meta': {}
-                                } only %}
+                              <span>{{ row['col_type'] }}</span>
+                              <select class="column_type" name="field_type[{{ row_num }}]" id="field_{{ row_num }}_1">
+                                {{ get_supported_datatypes(true, types_upper[row_num]) }}
+                              </select>
                             </td>
                             <td class="nowrap" name="col_length">
                                 <span>{{ (row['col_length']?(row['col_length']):'') }}</span>

From 3fc0c6db3af60a56646d39bfa0cbb56b3bc36e94 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Mon, 14 Sep 2020 11:24:42 -0300
Subject: [PATCH 04/14] Remove columns_definitions/column_length template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 15 +++++-------
 .../columns_definitions/column_length.twig    | 11 ---------
 .../central_columns/edit_table_row.twig       | 11 ++++-----
 templates/database/central_columns/main.twig  | 24 +++++++------------
 4 files changed, 19 insertions(+), 42 deletions(-)
 delete mode 100644 templates/columns_definitions/column_length.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index ae57f9e901..71fd8c2f78 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -25,15 +25,12 @@
   {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
-    {# column length #}
-    {% include 'columns_definitions/column_length.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'length_values_input_size': length_values_input_size,
-        'length_to_display': length
-    } only %}
-    {% set ci = ci + 1 %}
+  <input id="field_{{ column_number }}_{{ ci - ci_offset }}" type="text" name="field_length[{{ column_number }}]" size="
+    {{- length_values_input_size }}" value="{{ length }}" class="textfield">
+  <p class="enum_notice" id="enum_notice_{{ column_number }}_{{ ci - ci_offset }}">
+    <a href="#" class="open_enum_editor">{% trans 'Edit ENUM/SET values' %}</a>
+  </p>
+  {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
     {# column default #}
diff --git a/templates/columns_definitions/column_length.twig b/templates/columns_definitions/column_length.twig
deleted file mode 100644
index ef7e5f0654..0000000000
--- a/templates/columns_definitions/column_length.twig
+++ /dev/null
@@ -1,11 +0,0 @@
-<input id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    type="text"
-    name="field_length[{{ column_number }}]"
-    size="{{ length_values_input_size }}"
-    value="{{ length_to_display }}"
-    class="textfield">
-<p class="enum_notice" id="enum_notice_{{ column_number }}_{{ ci - ci_offset }}">
-    <a href="#" class="open_enum_editor">
-        {% trans 'Edit ENUM/SET values' %}
-    </a>
-</p>
diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig
index 9a79281456..82731975d7 100644
--- a/templates/database/central_columns/edit_table_row.twig
+++ b/templates/database/central_columns/edit_table_row.twig
@@ -18,13 +18,10 @@
   </td>
 
   <td class="nowrap" name="col_length">
-    {% include 'columns_definitions/column_length.twig' with {
-      'column_number': row_num,
-      'ci': 2,
-      'ci_offset': 0,
-      'length_values_input_size': 8,
-      'length_to_display': row['col_length']
-    } only %}
+    <input id="field_{{ row_num }}_2" type="text" name="field_length[{{ row_num }}]" size="8" value="{{ row['col_length'] }}" class="textfield">
+    <p class="enum_notice" id="enum_notice_{{ row_num }}_2">
+      <a href="#" class="open_enum_editor">{% trans 'Edit ENUM/SET values' %}</a>
+    </p>
   </td>
 
   <td class="nowrap" name="col_default">
diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig
index 2670eff8de..f2495091e2 100644
--- a/templates/database/central_columns/main.twig
+++ b/templates/database/central_columns/main.twig
@@ -68,13 +68,10 @@
                           </select>
                         </td>
                         <td class="nowrap" name="col_length">
-                            {% include 'columns_definitions/column_length.twig' with {
-                                'column_number': 0,
-                                'ci': 2,
-                                'ci_offset': 0,
-                                'length_values_input_size': 8,
-                                'length_to_display': ''
-                            } only %}
+                          <input id="field_0_2" type="text" name="field_length[0]" size="8" value="" class="textfield">
+                          <p class="enum_notice" id="enum_notice_0_2">
+                            <a href="#" class="open_enum_editor">{% trans 'Edit ENUM/SET values' %}</a>
+                          </p>
                         </td>
                         <td class="nowrap" name="col_default">
                             {% include 'columns_definitions/column_default.twig' with {
@@ -301,14 +298,11 @@
                               </select>
                             </td>
                             <td class="nowrap" name="col_length">
-                                <span>{{ (row['col_length']?(row['col_length']):'') }}</span>
-                                {% include 'columns_definitions/column_length.twig' with {
-                                    'column_number': row_num,
-                                    'ci': 2,
-                                    'ci_offset': 0,
-                                    'length_values_input_size': 8,
-                                    'length_to_display': row['col_length']
-                                } only %}
+                              <span>{{ (row['col_length']?(row['col_length']):'') }}</span>
+                              <input id="field_{{ row_num }}_2" type="text" name="field_length[{{ row_num }}]" size="8" value="{{ row['col_length'] }}" class="textfield">
+                              <p class="enum_notice" id="enum_notice_{{ row_num }}_2">
+                                <a href="#" class="open_enum_editor">{% trans 'Edit ENUM/SET values' %}</a>
+                              </p>
                             </td>
                             <td class="nowrap" name="col_default">
                                 {% if row['col_default'] is defined %}

From a48283e67a72a04f7f2a3c6a099256caef4e3d3e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Mon, 14 Sep 2020 13:05:17 -0300
Subject: [PATCH 05/14] Remove columns_definitions/column_auto_increment
 template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 templates/columns_definitions/column_attributes.twig  | 11 +++--------
 .../columns_definitions/column_auto_increment.twig    |  7 -------
 2 files changed, 3 insertions(+), 15 deletions(-)
 delete mode 100644 templates/columns_definitions/column_auto_increment.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 71fd8c2f78..7e68d2de35 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -105,14 +105,9 @@
     </td>
 {% endif %}
 <td class="text-center">
-    {# column auto_increment #}
-    {% include 'columns_definitions/column_auto_increment.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'column_meta': column_meta
-    } only %}
-    {% set ci = ci + 1 %}
+  <input name="field_extra[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" type="checkbox" value="AUTO_INCREMENT"
+    {{- column_meta['Extra'] is defined and column_meta['Extra']|lower == 'auto_increment' ? ' checked' }}>
+  {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
   <textarea id="field_{{ column_number }}_{{ ci - ci_offset }}" rows="1" name="field_comments[{{ column_number }}]" maxlength="{{ max_length }}">
diff --git a/templates/columns_definitions/column_auto_increment.twig b/templates/columns_definitions/column_auto_increment.twig
deleted file mode 100644
index 46bfb42f6c..0000000000
--- a/templates/columns_definitions/column_auto_increment.twig
+++ /dev/null
@@ -1,7 +0,0 @@
-<input name="field_extra[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    {% if column_meta['Extra'] is defined and column_meta['Extra']|lower == 'auto_increment' -%}
-        checked="checked"
-    {%- endif %}
-    type="checkbox"
-    value="AUTO_INCREMENT">

From 2b9e333ed0bc69394648d8e918f3d62f14eac218 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Mon, 14 Sep 2020 16:37:13 -0300
Subject: [PATCH 06/14] Remove columns_definitions/column_default template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 31 ++++++----
 .../columns_definitions/column_default.twig   | 35 ------------
 .../central_columns/edit_table_row.twig       | 28 +++++++---
 templates/database/central_columns/main.twig  | 56 ++++++++++++-------
 4 files changed, 74 insertions(+), 76 deletions(-)
 delete mode 100644 templates/columns_definitions/column_default.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 7e68d2de35..152bceeac1 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -33,17 +33,26 @@
   {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
-    {# column default #}
-    {% include 'columns_definitions/column_default.twig' with {
-        'column_number': column_number,
-        'ci': ci,
-        'ci_offset': ci_offset,
-        'column_meta': column_meta,
-        'type_upper': type_upper,
-        'default_value': default_value,
-        'char_editing': char_editing
-    } only %}
-    {% set ci = ci + 1 %}
+  <select name="field_default_type[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" class="default_type">
+    <option value="NONE"{{ column_meta['DefaultType'] is defined and column_meta['DefaultType'] == 'NONE' ? ' selected' }}>
+      {% trans %}None{% context %}for default{% endtrans %}
+    </option>
+    <option value="USER_DEFINED"{{ column_meta['DefaultType'] is defined and column_meta['DefaultType'] == 'USER_DEFINED' ? ' selected' }}>
+      {% trans 'As defined:' %}
+    </option>
+    <option value="NULL"{{ column_meta['DefaultType'] is defined and column_meta['DefaultType'] == 'NULL' ? ' selected' }}>
+      NULL
+    </option>
+    <option value="CURRENT_TIMESTAMP"{{ column_meta['DefaultType'] is defined and column_meta['DefaultType'] == 'CURRENT_TIMESTAMP' ? ' selected' }}>
+      CURRENT_TIMESTAMP
+    </option>
+  </select>
+  {% if char_editing == 'textarea' %}
+    <textarea name="field_default_value[{{ column_number }}]" cols="15" class="textfield default_value">{{ default_value }}</textarea>
+  {% else %}
+    <input type="text" name="field_default_value[{{ column_number }}]" size="12" value="{{ default_value }}" class="textfield default_value">
+  {% endif %}
+  {% set ci = ci + 1 %}
 </td>
 <td class="text-center">
   {# column collation #}
diff --git a/templates/columns_definitions/column_default.twig b/templates/columns_definitions/column_default.twig
deleted file mode 100644
index dcb66446bb..0000000000
--- a/templates/columns_definitions/column_default.twig
+++ /dev/null
@@ -1,35 +0,0 @@
-{# here we put 'NONE' as the default value of drop-down; otherwise users would
-have problems if they forget to enter the default value (example, for an INT) #}
-{% set translation %}{% trans %}None{% context %}for default{% endtrans %}{% endset %}
-{% set default_options = {
-    'NONE': translation,
-    'USER_DEFINED': 'As defined:'|trans,
-    'NULL': 'NULL',
-    'CURRENT_TIMESTAMP': 'CURRENT_TIMESTAMP'
-} %}
-
-<select name="field_default_type[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    class="default_type">
-    {% for key, value in default_options %}
-        <option value="{{ key }}"
-            {%- if column_meta['DefaultType'] is defined
-                and column_meta['DefaultType'] == key %}
-                selected="selected"
-            {%- endif %}>
-            {{ value }}
-        </option>
-    {% endfor %}
-</select>
-{% if char_editing == 'textarea' %}
-    <textarea name="field_default_value[{{ column_number }}]"
-        cols="15"
-        class="textfield
-        default_value">{{ default_value }}</textarea>
-{% else %}
-    <input type="text"
-        name="field_default_value[{{ column_number }}]"
-        size="12"
-        value="{{ default_value }}"
-        class="textfield default_value">
-{% endif %}
diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig
index 82731975d7..fead63ada3 100644
--- a/templates/database/central_columns/edit_table_row.twig
+++ b/templates/database/central_columns/edit_table_row.twig
@@ -25,15 +25,25 @@
   </td>
 
   <td class="nowrap" name="col_default">
-    {% include 'columns_definitions/column_default.twig' with {
-      'column_number': row_num,
-      'ci': 3,
-      'ci_offset': 0,
-      'column_meta': meta,
-      'type_upper': row['col_default']|upper,
-      'default_value': '',
-      'char_editing': char_editing
-    } only %}
+    <select name="field_default_type[{{ row_num }}]" id="field_{{ row_num }}_3" class="default_type">
+      <option value="NONE"{{ meta['DefaultType'] is defined and meta['DefaultType'] == 'NONE' ? ' selected' }}>
+        {% trans %}None{% context %}for default{% endtrans %}
+      </option>
+      <option value="USER_DEFINED"{{ meta['DefaultType'] is defined and meta['DefaultType'] == 'USER_DEFINED' ? ' selected' }}>
+        {% trans 'As defined:' %}
+      </option>
+      <option value="NULL"{{ meta['DefaultType'] is defined and meta['DefaultType'] == 'NULL' ? ' selected' }}>
+        NULL
+      </option>
+      <option value="CURRENT_TIMESTAMP"{{ meta['DefaultType'] is defined and meta['DefaultType'] == 'CURRENT_TIMESTAMP' ? ' selected' }}>
+        CURRENT_TIMESTAMP
+      </option>
+    </select>
+    {% if char_editing == 'textarea' %}
+      <textarea name="field_default_value[{{ row_num }}]" cols="15" class="textfield default_value"></textarea>
+    {% else %}
+      <input type="text" name="field_default_value[{{ row_num }}]" size="12" value="" class="textfield default_value">
+    {% endif %}
   </td>
 
   <td name="collation" class="nowrap">
diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig
index f2495091e2..e72a636670 100644
--- a/templates/database/central_columns/main.twig
+++ b/templates/database/central_columns/main.twig
@@ -74,14 +74,17 @@
                           </p>
                         </td>
                         <td class="nowrap" name="col_default">
-                            {% include 'columns_definitions/column_default.twig' with {
-                                'column_number': 0,
-                                'ci': 3,
-                                'ci_offset': 0,
-                                'type_upper': '',
-                                'column_meta': {},
-                                'char_editing': char_editing,
-                            } only %}
+                          <select name="field_default_type[0]" id="field_0_3" class="default_type">
+                            <option value="NONE">{% trans %}None{% context %}for default{% endtrans %}</option>
+                            <option value="USER_DEFINED">{% trans 'As defined:' %}</option>
+                            <option value="NULL">NULL</option>
+                            <option value="CURRENT_TIMESTAMP">CURRENT_TIMESTAMP</option>
+                          </select>
+                          {% if char_editing == 'textarea' %}
+                            <textarea name="field_default_value[0]" cols="15" class="textfield default_value"></textarea>
+                          {% else %}
+                            <input type="text" name="field_default_value[0]" size="12" value="" class="textfield default_value">
+                          {% endif %}
                         </td>
                         <td name="collation" class="nowrap">
                           <select lang="en" dir="ltr" name="field_collation[0]" id="field_0_4">
@@ -305,19 +308,30 @@
                               </p>
                             </td>
                             <td class="nowrap" name="col_default">
-                                {% if row['col_default'] is defined %}
-                                    <span>{{ row['col_default'] }}</span>
-                                {% else %}
-                                    <span>None</span>
-                                {% endif %}
-                                {% include 'columns_definitions/column_default.twig' with {
-                                    'column_number': row_num,
-                                    'ci': 3,
-                                    'ci_offset': 0,
-                                    'type_upper': types_upper[row_num],
-                                    'column_meta': rows_meta[row_num],
-                                    'char_editing': char_editing,
-                                } only %}
+                              {% if row['col_default'] is defined %}
+                                <span>{{ row['col_default'] }}</span>
+                              {% else %}
+                                <span>{% trans 'None' %}</span>
+                              {% endif %}
+                              <select name="field_default_type[{{ row_num }}]" id="field_{{ row_num }}_3" class="default_type">
+                                <option value="NONE"{{ rows_meta[row_num]['DefaultType'] is defined and rows_meta[row_num]['DefaultType'] == 'NONE' ? ' selected' }}>
+                                  {% trans %}None{% context %}for default{% endtrans %}
+                                </option>
+                                <option value="USER_DEFINED"{{ rows_meta[row_num]['DefaultType'] is defined and rows_meta[row_num]['DefaultType'] == 'USER_DEFINED' ? ' selected' }}>
+                                  {% trans 'As defined:' %}
+                                </option>
+                                <option value="NULL"{{ rows_meta[row_num]['DefaultType'] is defined and rows_meta[row_num]['DefaultType'] == 'NULL' ? ' selected' }}>
+                                  NULL
+                                </option>
+                                <option value="CURRENT_TIMESTAMP"{{ rows_meta[row_num]['DefaultType'] is defined and rows_meta[row_num]['DefaultType'] == 'CURRENT_TIMESTAMP' ? ' selected' }}>
+                                  CURRENT_TIMESTAMP
+                                </option>
+                              </select>
+                              {% if char_editing == 'textarea' %}
+                                <textarea name="field_default_value[{{ row_num }}]" cols="15" class="textfield default_value"></textarea>
+                              {% else %}
+                                <input type="text" name="field_default_value[{{ row_num }}]" size="12" value="" class="textfield default_value">
+                              {% endif %}
                             </td>
                             <td name="collation" class="nowrap">
                                 <span>{{ row['col_collation'] }}</span>

From f3620054a6944f35031f8f3afc3fef495bba3ee4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Mon, 14 Sep 2020 18:02:54 -0300
Subject: [PATCH 07/14] Remove columns_definitions/column_extra template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../columns_definitions/column_extra.twig     |  7 -------
 .../central_columns/edit_table_row.twig       |  8 ++------
 templates/database/central_columns/main.twig  | 19 ++++---------------
 3 files changed, 6 insertions(+), 28 deletions(-)
 delete mode 100644 templates/columns_definitions/column_extra.twig

diff --git a/templates/columns_definitions/column_extra.twig b/templates/columns_definitions/column_extra.twig
deleted file mode 100644
index 7f61f5cb98..0000000000
--- a/templates/columns_definitions/column_extra.twig
+++ /dev/null
@@ -1,7 +0,0 @@
-<input name="col_extra[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    {% if column_meta['Extra'] is not empty and column_meta['Extra'] == 'auto_increment' -%}
-        checked="checked"
-    {%- endif %}
-    type="checkbox"
-    value="auto_increment">
diff --git a/templates/database/central_columns/edit_table_row.twig b/templates/database/central_columns/edit_table_row.twig
index fead63ada3..81e333cabe 100644
--- a/templates/database/central_columns/edit_table_row.twig
+++ b/templates/database/central_columns/edit_table_row.twig
@@ -79,11 +79,7 @@
   </td>
 
   <td class="nowrap" name="col_extra">
-    {% include 'columns_definitions/column_extra.twig' with {
-      'column_number': row_num,
-      'ci': 7,
-      'ci_offset': 0,
-      'column_meta': {'Extra': row['col_extra']}
-    } only %}
+    <input name="col_extra[{{ row_num }}]" id="field_{{ row_num }}_7" type="checkbox" value="auto_increment"
+      {{- row['col_extra'] is not empty and row['col_extra'] == 'auto_increment' }}>
   </td>
 </tr>
diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig
index e72a636670..02fc512ab8 100644
--- a/templates/database/central_columns/main.twig
+++ b/templates/database/central_columns/main.twig
@@ -115,12 +115,7 @@
                           <input name="field_null[0]" id="field_0_6" type="checkbox" value="YES" class="allow_null">
                         </td>
                         <td class="nowrap" name="col_extra">
-                            {% include 'columns_definitions/column_extra.twig' with {
-                                'column_number': 0,
-                                'ci': 7,
-                                'ci_offset': 0,
-                                'column_meta': {}
-                            } only %}
+                          <input name="col_extra[0]" id="field_0_7" type="checkbox" value="auto_increment">
                         </td>
                         <td>
                             <input id="add_column_save" class="btn btn-primary" type="submit" value="Save">
@@ -367,15 +362,9 @@
                                   {{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' ? ' checked' }}>
                             </td>
                             <td class="nowrap" name="col_extra">
-                                <span>{{ row['col_extra'] }}</span>
-                                {% include 'columns_definitions/column_extra.twig' with {
-                                    'column_number': row_num,
-                                    'ci': 7,
-                                    'ci_offset': 0,
-                                    'column_meta': {
-                                        'Extra': row['col_extra']
-                                    }
-                                } only %}
+                              <span>{{ row['col_extra'] }}</span>
+                              <input name="col_extra[{{ row_num }}]" id="field_{{ row_num }}_7" type="checkbox" value="auto_increment"
+                                {{- row['col_extra'] is not empty and row['col_extra'] == 'auto_increment' ? ' checked' }}>
                             </td>
                         </tr>
                         {% set row_num = row_num + 1 %}

From f097639eb43a2ea316365b08a065251434a7f1e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 14:23:16 -0300
Subject: [PATCH 08/14] Remove columns_definitions/column_adjust_privileges
 template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_adjust_privileges.twig                | 16 ----------------
 .../columns_definitions/column_attributes.twig   | 12 +++++-------
 2 files changed, 5 insertions(+), 23 deletions(-)
 delete mode 100644 templates/columns_definitions/column_adjust_privileges.twig

diff --git a/templates/columns_definitions/column_adjust_privileges.twig b/templates/columns_definitions/column_adjust_privileges.twig
deleted file mode 100644
index d0d1e9156a..0000000000
--- a/templates/columns_definitions/column_adjust_privileges.twig
+++ /dev/null
@@ -1,16 +0,0 @@
-{% if privs_available %}
-    <input name="field_adjust_privileges[{{ column_number }}]"
-        id="field_{{ column_number }}_{{ ci - ci_offset }}"
-        checked="checked"
-        type="checkbox"
-        value="NULL"
-        class="allow_null">
-{% else %}
-    <input name="field_adjust_privileges[{{ column_number }}]"
-        id="field_{{ column_number }}_{{ ci - ci_offset }}"
-        disabled
-        type="checkbox"
-        value="NULL"
-        class="allow_null"
-        title="{% trans "You don't have sufficient privileges to perform this operation; Please refer to the documentation for more details" %}">
-{% endif %}
diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 152bceeac1..29df37556a 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -92,13 +92,11 @@
 {% if change_column is defined and change_column is not empty %}
     {# column Adjust privileges, Only for 'Edit' Column(s) #}
     <td class="text-center">
-        {% include 'columns_definitions/column_adjust_privileges.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'privs_available': privs_available
-        } only %}
-        {% set ci = ci + 1 %}
+      <input name="field_adjust_privileges[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" type="checkbox" value="NULL" class="allow_null"
+        {%- if privs_available %} checked>
+        {%- else %} title="{% trans "You don't have sufficient privileges to perform this operation; Please refer to the documentation for more details" %}" disabled>
+        {%- endif %}
+      {% set ci = ci + 1 %}
     </td>
 {% endif %}
 {% if not is_backup %}

From 95f5d553b6a086bf269f4c6ab0d07b6465414ed7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 14:41:24 -0300
Subject: [PATCH 09/14] Remove columns_definitions/column_indexes template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 31 ++++++++++++++-----
 .../columns_definitions/column_indexes.twig   | 24 --------------
 2 files changed, 24 insertions(+), 31 deletions(-)
 delete mode 100644 templates/columns_definitions/column_indexes.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 29df37556a..e28af4c59a 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -102,13 +102,30 @@
 {% if not is_backup %}
     {# column indexes, See my other comment about  this 'if'. #}
     <td class="text-center">
-        {% include 'columns_definitions/column_indexes.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta
-        } only %}
-        {% set ci = ci + 1 %}
+      <select name="field_key[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" data-index="">
+        <option value="none_{{ column_number }}">---</option>
+        <option value="primary_{{ column_number }}" title="{% trans "Primary" %}"
+          {{- column_meta['Key'] is defined and column_meta['Key'] == 'PRI' ? ' selected' }}>
+          PRIMARY
+        </option>
+        <option value="unique_{{ column_number }}" title="{% trans "Unique" %}"
+          {{- column_meta['Key'] is defined and column_meta['Key'] == 'UNI' ? ' selected' }}>
+          UNIQUE
+        </option>
+        <option value="index_{{ column_number }}" title="{% trans "Index" %}"
+          {{- column_meta['Key'] is defined and column_meta['Key'] == 'MUL' ? ' selected' }}>
+          INDEX
+        </option>
+        <option value="fulltext_{{ column_number }}" title="{% trans "Fulltext" %}"
+          {{- column_meta['Key'] is defined and column_meta['Key'] == 'FULLTEXT' ? ' selected' }}>
+          FULLTEXT
+        </option>
+        <option value="spatial_{{ column_number }}" title="{% trans "Spatial" %}"
+          {{- column_meta['Key'] is defined and column_meta['Key'] == 'SPATIAL' ? ' selected' }}>
+          SPATIAL
+        </option>
+      </select>
+      {% set ci = ci + 1 %}
     </td>
 {% endif %}
 <td class="text-center">
diff --git a/templates/columns_definitions/column_indexes.twig b/templates/columns_definitions/column_indexes.twig
deleted file mode 100644
index 398022997a..0000000000
--- a/templates/columns_definitions/column_indexes.twig
+++ /dev/null
@@ -1,24 +0,0 @@
-<select name="field_key[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}" data-index="">
-    <option value="none_{{ column_number }}">---</option>
-    <option value="primary_{{ column_number }}" title="{% trans "Primary" %}"
-        {{- column_meta['Key'] is defined and column_meta['Key'] == 'PRI' ? ' selected="selected"' }}>
-        PRIMARY
-    </option>
-    <option value="unique_{{ column_number }}" title="{% trans "Unique" %}"
-        {{- column_meta['Key'] is defined and column_meta['Key'] == 'UNI' ? ' selected="selected"' }}>
-        UNIQUE
-    </option>
-    <option value="index_{{ column_number }}" title="{% trans "Index" %}"
-        {{- column_meta['Key'] is defined and column_meta['Key'] == 'MUL' ? ' selected="selected"' }}>
-        INDEX
-    </option>
-    <option value="fulltext_{{ column_number }}" title="{% trans "Fulltext" %}"
-        {{- column_meta['Key'] is defined and column_meta['Key'] == 'FULLTEXT' ? ' selected="selected"' }}>
-        FULLTEXT
-    </option>
-    <option value="spatial_{{ column_number }}" title="{% trans "Spatial" %}"
-        {{- column_meta['Key'] is defined and column_meta['Key'] == 'SPATIAL' ? ' selected="selected"' }}>
-        SPATIAL
-    </option>
-</select>

From c294e75017c3f9b2c1c4a997f820f114ef6ba428 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 17:12:34 -0300
Subject: [PATCH 10/14] Remove columns_definitions/column_virtuality template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 24 ++++++++-------
 .../column_virtuality.twig                    | 30 -------------------
 2 files changed, 14 insertions(+), 40 deletions(-)
 delete mode 100644 templates/columns_definitions/column_virtuality.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index e28af4c59a..80e604bf41 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -142,16 +142,20 @@
  {# column virtuality #}
 {% if is_virtual_columns_supported %}
     <td class="text-center">
-        {% include 'columns_definitions/column_virtuality.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'char_editing': char_editing,
-            'expression': column_meta['Expression'] is defined ? column_meta['Expression'],
-            'options': options
-        } only %}
-        {% set ci = ci + 1 %}
+      <select name="field_virtuality[{{ column_number }}]" id="field_{{ column_number }}_{{ ci - ci_offset }}" class="virtuality">
+        {% for key, value in options %}
+          <option value="{{ key }}"{{ column_meta['Extra'] is defined and key != '' and column_meta['Extra']|slice(0, key|length) is same as (key) ? ' selected' }}>
+            {{ value }}
+          </option>
+        {% endfor %}
+      </select>
+
+      {% if char_editing == 'textarea' %}
+        <textarea name="field_expression[{{ column_number }}]" cols="15" class="textfield expression">{{ column_meta['Expression'] is defined ? column_meta['Expression'] }}</textarea>
+      {% else %}
+        <input type="text" name="field_expression[{{ column_number }}]" size="12" value="{{ column_meta['Expression'] is defined ? column_meta['Expression'] }}" placeholder="{% trans 'Expression' %}" class="textfield expression">
+      {% endif %}
+      {% set ci = ci + 1 %}
     </td>
 {% endif %}
 {# move column #}
diff --git a/templates/columns_definitions/column_virtuality.twig b/templates/columns_definitions/column_virtuality.twig
deleted file mode 100644
index d53f5d55e8..0000000000
--- a/templates/columns_definitions/column_virtuality.twig
+++ /dev/null
@@ -1,30 +0,0 @@
-<select name="field_virtuality[{{ column_number }}]"
-    id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    class="virtuality">
-    {% for key, value in options %}
-        <option value="{{ key }}"
-            {% set key_length = key|length %}
-            {%- if column_meta['Extra'] is defined
-                and key != ''
-                and column_meta['Extra']|slice(0,key_length) is same as (key) %}
-                selected="selected"
-            {%- endif %}>
-            {{ value }}
-        </option>
-    {% endfor %}
-</select>
-
-{% if char_editing == 'textarea' %}
-    <textarea name="field_expression[{{ column_number }}]"
-        cols="15"
-        class="textfield expression">
-        {{- expression -}}
-    </textarea>
-{% else %}
-    <input type="text"
-        name="field_expression[{{ column_number }}]"
-        size="12"
-        value="{{ expression }}"
-        placeholder="{% trans 'Expression' %}"
-        class="textfield expression">
-{% endif %}

From fe725159207b7ac7f5920690ae4ac3befa991302 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 17:24:51 -0300
Subject: [PATCH 11/14] Remove columns_definitions/transformation_option
 template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 26 +++++--------------
 .../transformation_option.twig                |  9 -------
 2 files changed, 6 insertions(+), 29 deletions(-)
 delete mode 100644 templates/columns_definitions/transformation_option.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 80e604bf41..bd4a42c73b 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -210,16 +210,9 @@
         {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
-        {# column Transformation options #}
-        {% include 'columns_definitions/transformation_option.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'mime_map': mime_map,
-            'type_prefix': ''
-        } only %}
-        {% set ci = ci + 1 %}
+      <input id="field_{{ column_number }}_{{ ci - ci_offset }}" type="text" name="field_transformation_options[{{ column_number }}]" size="16" class="textfield" value="
+        {{- column_meta['Field'] is defined and mime_map[column_meta['Field']]['transformation_options'] is defined ? mime_map[column_meta['Field']]['transformation_options'] }}">
+      {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
         {# Column Input transformation #}
@@ -235,15 +228,8 @@
         {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
-        {# column Input transformation options #}
-        {% include 'columns_definitions/transformation_option.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'mime_map': mime_map,
-            'type_prefix': 'input_'
-        } only %}
-        {% set ci = ci + 1 %}
+      <input id="field_{{ column_number }}_{{ ci - ci_offset }}" type="text" name="field_input_transformation_options[{{ column_number }}]" size="16" class="textfield" value="
+        {{- column_meta['Field'] is defined and mime_map[column_meta['Field']]['input_transformation_options'] is defined ? mime_map[column_meta['Field']]['input_transformation_options'] }}">
+      {% set ci = ci + 1 %}
     </td>
 {% endif %}
diff --git a/templates/columns_definitions/transformation_option.twig b/templates/columns_definitions/transformation_option.twig
deleted file mode 100644
index f87ba7cba9..0000000000
--- a/templates/columns_definitions/transformation_option.twig
+++ /dev/null
@@ -1,9 +0,0 @@
-{% set options_key = type_prefix ~ 'transformation_options' %}
-<input id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    type="text"
-    name="field_{{ options_key }}[{{ column_number }}]"
-    size="16"
-    class="textfield"
-    value="{% if column_meta['Field'] is defined and mime_map[column_meta['Field']][options_key] is defined -%}
-        {{- mime_map[column_meta['Field']][options_key] -}}
-    {%- endif %}">

From 0e5d9535e60efd93d781d6164282e9dd6b175e23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 17:56:07 -0300
Subject: [PATCH 12/14] Remove columns_definitions/transformation template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 libraries/classes/Table/ColumnsDefinition.php |  1 -
 .../column_attributes.twig                    | 50 +++++++++++--------
 .../columns_definitions/transformation.twig   | 26 ----------
 3 files changed, 28 insertions(+), 49 deletions(-)
 delete mode 100644 templates/columns_definitions/transformation.twig

diff --git a/libraries/classes/Table/ColumnsDefinition.php b/libraries/classes/Table/ColumnsDefinition.php
index 545956fc0c..b2926ca83d 100644
--- a/libraries/classes/Table/ColumnsDefinition.php
+++ b/libraries/classes/Table/ColumnsDefinition.php
@@ -126,7 +126,6 @@ final class ColumnsDefinition
             $available_mime = $transformations->getAvailableMimeTypes();
         }
 
-        // this will be used on templates/columns_definitions/transformation.twig
         $mime_types = [
             'input_transformation',
             'transformation',
diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index bd4a42c73b..93ac281d29 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -197,17 +197,20 @@
         {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
-        {# Column Browser transformation #}
-        {% include 'columns_definitions/transformation.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'available_mime': available_mime,
-            'mime_map': mime_map,
-            'type': 'transformation'
-        } only %}
-        {% set ci = ci + 1 %}
+      <select id="field_{{ column_number }}_{{ ci - ci_offset }}" size="1" name="field_transformation[{{ column_number }}]">
+        <option value="" title="{% trans 'None' %}"></option>
+        {% if available_mime['transformation'] is defined and available_mime['transformation'] is iterable %}
+          {% for mimekey, transform in available_mime['transformation'] %}
+            {% set parts = transform|split(':') %}
+            <option value="{{ available_mime['transformation_file'][mimekey] }}" title="{{ get_description(available_mime['transformation_file'][mimekey]) }}"
+              {{- column_meta['Field'] is defined and mime_map[column_meta['Field']]['transformation'] is defined
+                and mime_map[column_meta['Field']]['transformation'] matches '@' ~ available_mime['transformation_file_quoted'][mimekey] ~ '3?@i' ? ' selected'}}>
+              {{ get_name(available_mime['transformation_file'][mimekey]) ~ ' (' ~ parts[0]|lower ~ ':' ~ parts[1] ~ ')' }}
+            </option>
+          {% endfor %}
+        {% endif %}
+      </select>
+      {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
       <input id="field_{{ column_number }}_{{ ci - ci_offset }}" type="text" name="field_transformation_options[{{ column_number }}]" size="16" class="textfield" value="
@@ -215,17 +218,20 @@
       {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
-        {# Column Input transformation #}
-        {% include 'columns_definitions/transformation.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'available_mime': available_mime,
-            'mime_map': mime_map,
-            'type': 'input_transformation'
-        } only %}
-        {% set ci = ci + 1 %}
+      <select id="field_{{ column_number }}_{{ ci - ci_offset }}" size="1" name="field_input_transformation[{{ column_number }}]">
+        <option value="" title="{% trans 'None' %}"></option>
+        {% if available_mime['input_transformation'] is defined and available_mime['input_transformation'] is iterable %}
+          {% for mimekey, transform in available_mime['input_transformation'] %}
+            {% set parts = transform|split(':') %}
+            <option value="{{ available_mime['input_transformation_file'][mimekey] }}" title="{{ get_description(available_mime['input_transformation_file'][mimekey]) }}"
+              {{- column_meta['Field'] is defined and mime_map[column_meta['Field']]['input_transformation'] is defined
+                and mime_map[column_meta['Field']]['input_transformation'] matches '@' ~ available_mime['input_transformation_file_quoted'][mimekey] ~ '3?@i' ? ' selected' }}>
+              {{ get_name(available_mime['input_transformation_file'][mimekey]) ~ ' (' ~ parts[0]|lower ~ ':' ~ parts[1] ~ ')' }}
+            </option>
+          {% endfor %}
+        {% endif %}
+      </select>
+      {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
       <input id="field_{{ column_number }}_{{ ci - ci_offset }}" type="text" name="field_input_transformation_options[{{ column_number }}]" size="16" class="textfield" value="
diff --git a/templates/columns_definitions/transformation.twig b/templates/columns_definitions/transformation.twig
deleted file mode 100644
index 9aec94a565..0000000000
--- a/templates/columns_definitions/transformation.twig
+++ /dev/null
@@ -1,26 +0,0 @@
-<select id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    size="1"
-    name="field_{{ type }}[{{ column_number }}]">
-    <option value="" title="{% trans 'None' %}"></option>
-    {% if available_mime[type] is defined and available_mime[type] is iterable %}
-        {% for mimekey, transform in available_mime[type] %}
-            {% set checked = column_meta['Field'] is defined
-                and mime_map[column_meta['Field']][type] is defined
-                and mime_map[column_meta['Field']][type] matches
-                    '@' ~ available_mime[type ~ '_file_quoted'][mimekey] ~ '3?@i'
-                ? 'selected ' %}
-            {% set tooltip = get_description(
-                available_mime[type ~ '_file'][mimekey]
-            ) %}
-            {% set parts = transform|split(':') %}
-            {% set name = get_name(
-                available_mime[type ~ '_file'][mimekey]
-            ) ~ ' (' ~ parts[0]|lower ~ ':' ~ parts[1] ~ ')' %}
-            <option value="{{ available_mime[type ~ '_file'][mimekey] }}"
-                {{ checked }}
-                title="{{ tooltip }}">
-                {{ name }}
-            </option>
-        {% endfor %}
-    {% endif %}
-</select>

From 8ca95dd31f2106f60b4041e5d35b30d7f5c64d77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 18:36:46 -0300
Subject: [PATCH 13/14] Remove columns_definitions/mime_type template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 23 +++++++++++--------
 templates/columns_definitions/mime_type.twig  | 17 --------------
 2 files changed, 13 insertions(+), 27 deletions(-)
 delete mode 100644 templates/columns_definitions/mime_type.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index 93ac281d29..f651569b1a 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -185,16 +185,19 @@
 
 {% if cfg_relation['mimework'] and browse_mime and cfg_relation['commwork'] %}
     <td class="text-center">
-        {# Column Mime-type #}
-        {% include 'columns_definitions/mime_type.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'available_mime': available_mime,
-            'mime_map': mime_map
-        } only %}
-        {% set ci = ci + 1 %}
+      <select id="field_{{ column_number }}_{{ ci - ci_offset }}" size="1" name="field_mimetype[{{ column_number }}]">
+        <option value="">&nbsp;</option>
+        {% if available_mime['mimetype'] is defined and available_mime['mimetype'] is iterable %}
+          {% for media_type in available_mime['mimetype'] %}
+            <option value="{{ media_type|replace({'/': '_'}) }}"
+              {{- column_meta['Field'] is defined and mime_map[column_meta['Field']]['mimetype'] is defined
+                and mime_map[column_meta['Field']]['mimetype'] == media_type|replace({'/': '_'}) ? ' selected' }}>
+              {{ media_type|lower }}
+            </option>
+          {% endfor %}
+        {% endif %}
+      </select>
+      {% set ci = ci + 1 %}
     </td>
     <td class="text-center">
       <select id="field_{{ column_number }}_{{ ci - ci_offset }}" size="1" name="field_transformation[{{ column_number }}]">
diff --git a/templates/columns_definitions/mime_type.twig b/templates/columns_definitions/mime_type.twig
deleted file mode 100644
index ef395b65d8..0000000000
--- a/templates/columns_definitions/mime_type.twig
+++ /dev/null
@@ -1,17 +0,0 @@
-<select id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    size="1"
-    name="field_mimetype[{{ column_number }}]">
-    <option value="">&nbsp;</option>
-    {% if available_mime['mimetype'] is defined
-        and available_mime['mimetype'] is iterable %}
-        {% for mimetype in available_mime['mimetype'] %}
-            {% set checked = column_meta['Field'] is defined
-                and mime_map[column_meta['Field']]['mimetype'] is defined
-                and mime_map[column_meta['Field']]['mimetype'] == mimetype|replace({'/': '_'})
-                ? ' selected' %}
-            <option value="{{ mimetype|replace({'/': '_'}) }}"{{ checked }}>
-                {{ mimetype|lower }}
-            </option>
-        {% endfor %}
-    {% endif %}
-</select>

From ca67584b63666bd6251650185b8b1961ac492a43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Thu, 17 Sep 2020 18:46:09 -0300
Subject: [PATCH 14/14] Remove columns_definitions/move_column template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 .../column_attributes.twig                    | 22 +++++++++++--------
 .../columns_definitions/move_column.twig      | 15 -------------
 2 files changed, 13 insertions(+), 24 deletions(-)
 delete mode 100644 templates/columns_definitions/move_column.twig

diff --git a/templates/columns_definitions/column_attributes.twig b/templates/columns_definitions/column_attributes.twig
index f651569b1a..c9f288df15 100644
--- a/templates/columns_definitions/column_attributes.twig
+++ b/templates/columns_definitions/column_attributes.twig
@@ -171,15 +171,19 @@
     {% endfor %}
 
     <td class="text-center">
-        {% include 'columns_definitions/move_column.twig' with {
-            'column_number': column_number,
-            'ci': ci,
-            'ci_offset': ci_offset,
-            'column_meta': column_meta,
-            'move_columns': move_columns,
-            'current_index': current_index
-        } only %}
-        {% set ci = ci + 1 %}
+      <select id="field_{{ column_number }}_{{ ci - ci_offset }}" name="field_move_to[{{ column_number }}]" size="1" width="5em">
+        <option value="" selected="selected">&nbsp;</option>
+        <option value="-first"{{ current_index == 0 ? ' disabled="disabled"' }}>
+          {% trans 'first' %}
+        </option>
+        {% for mi in 0..move_columns|length - 1 %}
+          <option value="{{ move_columns[mi].name }}"
+            {{- current_index == mi or current_index == mi + 1 ? ' disabled' }}>
+            {{ 'after %s'|trans|format(backquote(move_columns[mi].name|e)) }}
+          </option>
+        {% endfor %}
+      </select>
+      {% set ci = ci + 1 %}
     </td>
 {% endif %}
 
diff --git a/templates/columns_definitions/move_column.twig b/templates/columns_definitions/move_column.twig
deleted file mode 100644
index 7c0b3f4bfc..0000000000
--- a/templates/columns_definitions/move_column.twig
+++ /dev/null
@@ -1,15 +0,0 @@
-<select id="field_{{ column_number }}_{{ ci - ci_offset }}"
-    name="field_move_to[{{ column_number }}]"
-    size="1"
-    width="5em">
-    <option value="" selected="selected">&nbsp;</option>
-    <option value="-first"{{ current_index == 0 ? ' disabled="disabled"' }}>
-        {% trans 'first' %}
-    </option>
-    {% for mi in 0..move_columns|length - 1 %}
-        <option value="{{ move_columns[mi].name }}"
-            {{- current_index == mi or current_index == mi + 1 ? ' disabled="disabled"' }}>
-            {{ 'after %s'|trans|format(backquote(move_columns[mi].name|e)) }}
-        </option>
-    {% endfor %}
-</select>